84825 2012-04-24 21:52:29 -0700 New Notification constructor does not take security origin permissions into account 2012-04-24 22:51:55 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Mac OS X 10.7 RESOLVED FIXED InRadar P2 Normal --- 1 jonlee jonlee darin jianli webkit-bug-importer oldest_to_newest 609452 0 jonlee 2012-04-24 21:52:29 -0700 Running new Notification() show the notification regardless of whether the security origin has permission to do so. It should instead be calling the onerror() callback. 609453 1 webkit-bug-importer 2012-04-24 21:53:02 -0700 <rdar://problem/11315405> 609459 2 138738 jonlee 2012-04-24 22:23:39 -0700 Created attachment 138738 Patch 609461 3 138738 darin 2012-04-24 22:27:13 -0700 Comment on attachment 138738 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138738&action=review > Source/WebCore/ChangeLog:18 > + (WebCore::Notification::dispatchErrorEvent): The default constructor of ErrorEvent doesn't > + create the proper event object. Create it using Event::create(). Is there a test showing that this was wrong? 609471 4 jonlee 2012-04-24 22:49:19 -0700 (In reply to comment #3) > (From update of attachment 138738 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=138738&action=review > > > Source/WebCore/ChangeLog:18 > > + (WebCore::Notification::dispatchErrorEvent): The default constructor of ErrorEvent doesn't > > + create the proper event object. Create it using Event::create(). > > Is there a test showing that this was wrong? No. The only tests available are of the legacy API, which threw an exception when creating the notification, so there was no situation in which the error event got dispatched. The new behavior based on the latest draft of the spec utilizes this event. There are a series of tasks already in bugzilla for bringing the notifications tests up to date once support for notifications is available on the mac. 609472 5 jonlee 2012-04-24 22:51:55 -0700 Committed r115166: <http://trac.webkit.org/changeset/115166> 138738 2012-04-24 22:23:39 -0700 2012-04-24 22:27:13 -0700 Patch bug-84825-20120424222605.patch text/plain 3851 jonlee U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1MDc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTFhNGM1NjE3ZjU0NTAx YzdlZjM0NjJhZmMwNTlkYmNiNmVmNDNkZC4uN2RlZmI4MjM1MTJjZGFlMzE0YzkwOWM2NGQ1ZTg2 NjFlMjQyZWI3NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEyLTA0LTI0ICBKb24g TGVlICA8am9ubGVlQGFwcGxlLmNvbT4KKworICAgICAgICBOZXcgTm90aWZpY2F0aW9uIGNvbnN0 cnVjdG9yIGRvIG5vdCB0YWtlIGludG8gYWNjb3VudCBzZWN1cml0eSBvcmlnaW4gcGVybWlzc2lv bnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg0ODI1 CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xMTMxNTQwNT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0cyByZXF1aXJlcyBzdXBwb3J0IGZvciBu b3RpZmljYXRpb25zIG9uIE1hYyAoc2VlIDc5NDkyKS4KKworICAgICAgICBXaGVuIHRoZSB0YXNr IHRpbWVyIGZpcmVzLCB3ZSBzaG91bGQgY2hlY2sgdG8gc2VlIHRoYXQgdGhlIG5vdGlmaWNhdGlv biBoYXMgcGVybWlzc2lvbgorICAgICAgICB0byBzaG93LiBJZiBub3QsIHdlIGZpcmUgdGhlIG9u RXJyb3IgZXZlbnQuCisKKyAgICAgICAgKiBub3RpZmljYXRpb25zL05vdGlmaWNhdGlvbi5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpOb3RpZmljYXRpb246Ok5vdGlmaWNhdGlvbik6IFNpbmNlIHRo ZSB0aW1lciBtYXkgc2hvdywgb3IgY2FsbCB0aGUgb25lcnJvciBldmVudCwKKyAgICAgICAgd2Ug cmVuYW1lIGl0IGZyb20gbV9zaG93VGFza1RpbWVyLiB0byBtX3Rhc2tUaW1lci4KKyAgICAgICAg KFdlYkNvcmU6Ok5vdGlmaWNhdGlvbjo6ZGlzcGF0Y2hFcnJvckV2ZW50KTogVGhlIGRlZmF1bHQg Y29uc3RydWN0b3Igb2YgRXJyb3JFdmVudCBkb2Vzbid0CisgICAgICAgIGNyZWF0ZSB0aGUgcHJv cGVyIGV2ZW50IG9iamVjdC4gQ3JlYXRlIGl0IHVzaW5nIEV2ZW50OjpjcmVhdGUoKS4KKyAgICAg ICAgKFdlYkNvcmU6Ok5vdGlmaWNhdGlvbjo6dGFza1RpbWVyRmlyZWQpOiBDaGVjayB0byBzZWUg dGhhdCB3ZSBoYXZlIHBlcm1pc3Npb24gZmlyc3QuCisgICAgICAgICogbm90aWZpY2F0aW9ucy9O b3RpZmljYXRpb24uaDoKKyAgICAgICAgKE5vdGlmaWNhdGlvbik6CisKIDIwMTItMDQtMjQgIEFs ZXhhbmRydSBDaGljdWxpdGEgIDxhY2hpY3VAYWRvYmUuY29tPgogCiAgICAgICAgIFtDU1MgRmls dGVyc10gTW92ZSBtX2ZpbHRlciBhbmQgcmVsYXRlZCBmaWVsZHMgZnJvbSBSZW5kZXJMYXllciB0 byBhIGRpZmZlcmVudCBzdHJ1Y3R1cmUgYW5kIG9ubHkgYWxsb2NhdGUgaXQgd2hlbiBuZWVkZWQK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL25vdGlmaWNhdGlvbnMvTm90aWZpY2F0aW9uLmNw cCBiL1NvdXJjZS9XZWJDb3JlL25vdGlmaWNhdGlvbnMvTm90aWZpY2F0aW9uLmNwcAppbmRleCAx NGIwNzkyMTc5ZDNhMjdkYTNlMjRhMWY2OWFmZTgxNDMyMWYxZmE2Li5mNjZmMmIwYjBjMDQ5OTJl OGJmN2FmYzc4NzJkNzZjZDg1ZjMwY2M5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9ub3Rp ZmljYXRpb25zL05vdGlmaWNhdGlvbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbm90aWZpY2F0 aW9ucy9Ob3RpZmljYXRpb24uY3BwCkBAIC0xMDQsMTMgKzEwNCwxMyBAQCBOb3RpZmljYXRpb246 Ok5vdGlmaWNhdGlvbihTY3JpcHRFeGVjdXRpb25Db250ZXh0KiBjb250ZXh0LCBjb25zdCBTdHJp bmcmIHRpdGxlKQogICAgICwgbV9pc0hUTUwoZmFsc2UpCiAgICAgLCBtX3RpdGxlKHRpdGxlKQog ICAgICwgbV9zdGF0ZShJZGxlKQotICAgICwgbV9zaG93VGFza1RpbWVyKGFkb3B0UHRyKG5ldyBU aW1lcjxOb3RpZmljYXRpb24+KHRoaXMsICZOb3RpZmljYXRpb246OnNob3dUYXNrVGltZXJGaXJl ZCkpKQorICAgICwgbV90YXNrVGltZXIoYWRvcHRQdHIobmV3IFRpbWVyPE5vdGlmaWNhdGlvbj4o dGhpcywgJk5vdGlmaWNhdGlvbjo6dGFza1RpbWVyRmlyZWQpKSkKIHsKICAgICBBU1NFUlQoY29u dGV4dC0+aXNEb2N1bWVudCgpKTsKICAgICBtX25vdGlmaWNhdGlvbkNlbnRlciA9IERPTVdpbmRv d05vdGlmaWNhdGlvbnM6OndlYmtpdE5vdGlmaWNhdGlvbnMoc3RhdGljX2Nhc3Q8RG9jdW1lbnQq Pihjb250ZXh0KS0+ZG9tV2luZG93KCkpOwogICAgIAogICAgIEFTU0VSVChtX25vdGlmaWNhdGlv bkNlbnRlci0+Y2xpZW50KCkpOwotICAgIG1fc2hvd1Rhc2tUaW1lci0+c3RhcnRPbmVTaG90KDAp OworICAgIG1fdGFza1RpbWVyLT5zdGFydE9uZVNob3QoMCk7CiB9CiAjZW5kaWYKIApAQCAtMjMx LDEzICsyMzEsMTcgQEAgdm9pZCBOb3RpZmljYXRpb246OmRpc3BhdGNoQ2xvc2VFdmVudCgpCiAK IHZvaWQgTm90aWZpY2F0aW9uOjpkaXNwYXRjaEVycm9yRXZlbnQoKQogewotICAgIGRpc3BhdGNo RXZlbnQoRXJyb3JFdmVudDo6Y3JlYXRlKCkpOworICAgIGRpc3BhdGNoRXZlbnQoRXZlbnQ6OmNy ZWF0ZShldmVudE5hbWVzKCkuZXJyb3JFdmVudCwgZmFsc2UsIGZhbHNlKSk7CiB9CiAKICNpZiBF TkFCTEUoTk9USUZJQ0FUSU9OUykKLXZvaWQgTm90aWZpY2F0aW9uOjpzaG93VGFza1RpbWVyRmly ZWQoVGltZXI8Tm90aWZpY2F0aW9uPiogdGltZXIpCit2b2lkIE5vdGlmaWNhdGlvbjo6dGFza1Rp bWVyRmlyZWQoVGltZXI8Tm90aWZpY2F0aW9uPiogdGltZXIpCiB7Ci0gICAgQVNTRVJUX1VOVVNF RCh0aW1lciwgdGltZXIgPT0gbV9zaG93VGFza1RpbWVyLmdldCgpKTsKKyAgICBBU1NFUlRfVU5V U0VEKHRpbWVyLCB0aW1lciA9PSBtX3Rhc2tUaW1lci5nZXQoKSk7CisgICAgaWYgKG1fbm90aWZp Y2F0aW9uQ2VudGVyLT5jaGVja1Blcm1pc3Npb24oKSAhPSBOb3RpZmljYXRpb25DbGllbnQ6OlBl cm1pc3Npb25BbGxvd2VkKSB7CisgICAgICAgIGRpc3BhdGNoRXJyb3JFdmVudCgpOworICAgICAg ICByZXR1cm47CisgICAgfQogICAgIHNob3coKTsKIH0KICNlbmRpZgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvbm90aWZpY2F0aW9ucy9Ob3RpZmljYXRpb24uaCBiL1NvdXJjZS9XZWJDb3Jl L25vdGlmaWNhdGlvbnMvTm90aWZpY2F0aW9uLmgKaW5kZXggNWIwMzRjYzRjM2NhZTVjMjM5Mzc3 ZGFhZTA0Yjc5OTI1YThlOWYzMC4uNzJhZmU4NGU1Nzc3Zjc1ZTE4ZGRhNTZlMzZjNDY2MjE4Mjlm NDA5YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbm90aWZpY2F0aW9ucy9Ob3RpZmljYXRp b24uaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9ub3RpZmljYXRpb25zL05vdGlmaWNhdGlvbi5oCkBA IC0xNTYsNyArMTU2LDcgQEAgcHJpdmF0ZToKICAgICB2b2lkIGZpbmlzaExvYWRpbmdJY29uKCk7 CiAKICNpZiBFTkFCTEUoTk9USUZJQ0FUSU9OUykKLSAgICB2b2lkIHNob3dUYXNrVGltZXJGaXJl ZChUaW1lcjxOb3RpZmljYXRpb24+Kik7CisgICAgdm9pZCB0YXNrVGltZXJGaXJlZChUaW1lcjxO b3RpZmljYXRpb24+Kik7CiAjZW5kaWYKICAgICAKICAgICBib29sIG1faXNIVE1MOwpAQCAtMTg0 LDcgKzE4NCw3IEBAIHByaXZhdGU6CiAgICAgRXZlbnRUYXJnZXREYXRhIG1fZXZlbnRUYXJnZXRE YXRhOwogCiAjaWYgRU5BQkxFKE5PVElGSUNBVElPTlMpCi0gICAgT3duUHRyPFRpbWVyPE5vdGlm aWNhdGlvbj4gPiBtX3Nob3dUYXNrVGltZXI7CisgICAgT3duUHRyPFRpbWVyPE5vdGlmaWNhdGlv bj4gPiBtX3Rhc2tUaW1lcjsKICNlbmRpZgogfTsKIAo=