84821 2012-04-24 20:05:47 -0700 fast/js/random-array-gc-stress times out in debug mode 2012-04-30 12:23:39 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg webkit.review.bot oldest_to_newest 609410 0 mhahnenberg 2012-04-24 20:05:47 -0700 We should reduce the number of iterations so that it completes. 609411 1 138723 mhahnenberg 2012-04-24 20:07:06 -0700 Created attachment 138723 Patch 609413 2 138723 darin 2012-04-24 20:09:31 -0700 Comment on attachment 138723 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138723&action=review > LayoutTests/fast/js/script-tests/random-array-gc-stress.js:-12 > -function gc() > -{ > - if (this.GCController) > - GCController.collect(); > - else > - for (var i = 0; i < 10000; ++i) // Allocate a sufficient number of objects to force a GC. > - ({}); > -} Why are you removing this? Change log does not say. 609414 3 138724 mhahnenberg 2012-04-24 20:12:51 -0700 Created attachment 138724 Patch 609418 4 138724 ggaren 2012-04-24 20:19:38 -0700 Comment on attachment 138724 Patch Seems like this will fail to run due to no gc() function. 609426 5 138724 darin 2012-04-24 20:26:17 -0700 Comment on attachment 138724 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138724&action=review > LayoutTests/ChangeLog:10 > + * fast/js/script-tests/random-array-gc-stress.js: Reduce number of iterations so > + that the test can complete without timing out. Also remove the gc() function because > + a gc() function is already provided in resources/js-test-pre.js. Geoff, here’s the explanation of why it’s good to remove the gc function. 609762 6 138724 webkit.review.bot 2012-04-25 08:09:56 -0700 Comment on attachment 138724 Patch Clearing flags on attachment: 138724 Committed r115208: <http://trac.webkit.org/changeset/115208> 609763 7 webkit.review.bot 2012-04-25 08:10:02 -0700 All reviewed patches have been landed. Closing bug. 609918 8 mhahnenberg 2012-04-25 11:09:23 -0700 Apparently the bots are too slow even for the new version, which passes locally on my machine. Will try to reduce the number of iterations even further. 610151 9 138897 mhahnenberg 2012-04-25 16:39:34 -0700 Created attachment 138897 Patch 610274 10 138897 ggaren 2012-04-25 18:22:47 -0700 Comment on attachment 138897 Patch r=me 610348 11 138897 webkit.review.bot 2012-04-25 22:06:49 -0700 Comment on attachment 138897 Patch Clearing flags on attachment: 138897 Committed r115287: <http://trac.webkit.org/changeset/115287> 610349 12 webkit.review.bot 2012-04-25 22:06:54 -0700 All reviewed patches have been landed. Closing bug. 610981 13 mhahnenberg 2012-04-26 14:28:22 -0700 Still timing out on some bots. 611758 14 139243 mhahnenberg 2012-04-27 11:55:56 -0700 Created attachment 139243 Patch 612061 15 139243 darin 2012-04-27 18:21:07 -0700 Comment on attachment 139243 Patch OK. I am increasingly unhappy with this test if it takes so long to run. 612870 16 139243 webkit.review.bot 2012-04-30 12:23:18 -0700 Comment on attachment 139243 Patch Clearing flags on attachment: 139243 Committed r115658: <http://trac.webkit.org/changeset/115658> 612871 17 webkit.review.bot 2012-04-30 12:23:39 -0700 All reviewed patches have been landed. Closing bug. 138723 2012-04-24 20:07:06 -0700 2012-04-24 20:12:48 -0700 Patch bug-84821-20120424200704.patch text/plain 1750 mhahnenberg U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1MTU2CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggOTcxYzBkYjQwZTA5NDBlODQ2NDI0 ZDExYjVhY2YzZjRkNWFhMmQ2ZS4uOTRiNjlhNzkwNDNjODJmOWE4ODg5MGNmZDQ3ODY5YzU0MmRj ZTVlYSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTA0LTI0ICBNYXJrIEhhaG5lbmJlcmcg IDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisKKyAgICAgICAgZmFzdC9qcy9yYW5kb20tYXJyYXkt Z2Mtc3RyZXNzIHRpbWVzIG91dCBpbiBkZWJ1ZyBtb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NDgyMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmFzdC9qcy9zY3JpcHQtdGVzdHMvcmFuZG9tLWFy cmF5LWdjLXN0cmVzcy5qczogUmVkdWNlIG51bWJlciBvZiBpdGVyYXRpb25zIHNvIAorICAgICAg ICB0aGF0IHRoZSB0ZXN0IGNhbiBjb21wbGV0ZSB3aXRob3V0IHRpbWluZyBvdXQuCisKIDIwMTIt MDQtMjQgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIENhbGVu ZGFyIFBpY2tlcjogT3BlbiBhIGNhbGVuZGFyIHBpY2tlciBieSBrZXlib2FyZCBvcGVyYXRpb24K ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvanMvc2NyaXB0LXRlc3RzL3JhbmRvbS1hcnJh eS1nYy1zdHJlc3MuanMgYi9MYXlvdXRUZXN0cy9mYXN0L2pzL3NjcmlwdC10ZXN0cy9yYW5kb20t YXJyYXktZ2Mtc3RyZXNzLmpzCmluZGV4IDZlOGIyNzkyNzMxMjhhNmI3ZjQzZGEyODY2M2JiMzBl MzUwMGE5YzYuLmMyNTU0MWY2YmZlYjNmMjZlM2IxZDE4MWJmMDI3MDJjZjI5YzdlM2IgMTAwNjQ0 Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvanMvc2NyaXB0LXRlc3RzL3JhbmRvbS1hcnJheS1nYy1z dHJlc3MuanMKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9qcy9zY3JpcHQtdGVzdHMvcmFuZG9tLWFy cmF5LWdjLXN0cmVzcy5qcwpAQCAtMiwxNSArMiw2IEBAIGRlc2NyaXB0aW9uKAogJ1Rlc3RzIHRv IHJhbmRvbWx5IG1vZGlmeSBhbiBvYmplY3QgZ3JhcGggb2YgYXJyYXlzIHRvIG1ha2Ugc3VyZSB0 aGUgR0MgaGFuZGxlcyB0aGVtIHByb3Blcmx5IG5vdyB0aGF0IGl0IGFsbG9jYXRlcyBib3RoIHRo ZSBKU0FycmF5IGFuZCB0aGUgQXJyYXlTdG9yYWdlLiAgVG8gcGFzcyB3ZSBuZWVkIHRvIG5vdCBj cmFzaC4nCiApOwogCi1mdW5jdGlvbiBnYygpCi17Ci0gICAgaWYgKHRoaXMuR0NDb250cm9sbGVy KQotICAgICAgICBHQ0NvbnRyb2xsZXIuY29sbGVjdCgpOwotICAgIGVsc2UKLSAgICAgICAgZm9y ICh2YXIgaSA9IDA7IGkgPCAxMDAwMDsgKytpKSAvLyBBbGxvY2F0ZSBhIHN1ZmZpY2llbnQgbnVt YmVyIG9mIG9iamVjdHMgdG8gZm9yY2UgYSBHQy4KLSAgICAgICAgICAgICh7fSk7Ci19Ci0KIHZh ciBnbG9iYWwgPSBbXTsKIAogdmFyIGdldFJhbmRvbUluZGV4ID0gZnVuY3Rpb24obGVuZ3RoKSB7 CkBAIC00Nyw3ICszOCw3IEBAIHZhciB0ZXN0ID0gZnVuY3Rpb24oKSB7CiB9OwogCiB2YXIgcnVu cyA9IDA7IAotd2hpbGUgKHJ1bnMgPCA0MCkgeword2hpbGUgKHJ1bnMgPCAzMCkgewogICAgIHRl c3QoKTsKICAgICBydW5zICs9IDE7CiAgICAgZ2xvYmFsID0gW107Cg== 138724 2012-04-24 20:12:51 -0700 2012-04-25 16:39:28 -0700 Patch bug-84821-20120424201250.patch text/plain 1863 mhahnenberg U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1MTU2CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggOTcxYzBkYjQwZTA5NDBlODQ2NDI0 ZDExYjVhY2YzZjRkNWFhMmQ2ZS4uOGJhYTYxYTFjMzBjZGY1YmNhYTk0MTU1MDQzZjI5NzI0YzAz ZTQxNyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA0LTI0ICBNYXJrIEhhaG5lbmJlcmcg IDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisKKyAgICAgICAgZmFzdC9qcy9yYW5kb20tYXJyYXkt Z2Mtc3RyZXNzIHRpbWVzIG91dCBpbiBkZWJ1ZyBtb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NDgyMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmFzdC9qcy9zY3JpcHQtdGVzdHMvcmFuZG9tLWFy cmF5LWdjLXN0cmVzcy5qczogUmVkdWNlIG51bWJlciBvZiBpdGVyYXRpb25zIHNvIAorICAgICAg ICB0aGF0IHRoZSB0ZXN0IGNhbiBjb21wbGV0ZSB3aXRob3V0IHRpbWluZyBvdXQuIEFsc28gcmVt b3ZlIHRoZSBnYygpIGZ1bmN0aW9uIGJlY2F1c2UgCisgICAgICAgIGEgZ2MoKSBmdW5jdGlvbiBp cyBhbHJlYWR5IHByb3ZpZGVkIGluIHJlc291cmNlcy9qcy10ZXN0LXByZS5qcy4KKwogMjAxMi0w NC0yNCAgS2VudCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQ2FsZW5k YXIgUGlja2VyOiBPcGVuIGEgY2FsZW5kYXIgcGlja2VyIGJ5IGtleWJvYXJkIG9wZXJhdGlvbgpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9qcy9zY3JpcHQtdGVzdHMvcmFuZG9tLWFycmF5 LWdjLXN0cmVzcy5qcyBiL0xheW91dFRlc3RzL2Zhc3QvanMvc2NyaXB0LXRlc3RzL3JhbmRvbS1h cnJheS1nYy1zdHJlc3MuanMKaW5kZXggNmU4YjI3OTI3MzEyOGE2YjdmNDNkYTI4NjYzYmIzMGUz NTAwYTljNi4uYzI1NTQxZjZiZmViM2YyNmUzYjFkMTgxYmYwMjcwMmNmMjljN2UzYiAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9qcy9zY3JpcHQtdGVzdHMvcmFuZG9tLWFycmF5LWdjLXN0 cmVzcy5qcworKysgYi9MYXlvdXRUZXN0cy9mYXN0L2pzL3NjcmlwdC10ZXN0cy9yYW5kb20tYXJy YXktZ2Mtc3RyZXNzLmpzCkBAIC0yLDE1ICsyLDYgQEAgZGVzY3JpcHRpb24oCiAnVGVzdHMgdG8g cmFuZG9tbHkgbW9kaWZ5IGFuIG9iamVjdCBncmFwaCBvZiBhcnJheXMgdG8gbWFrZSBzdXJlIHRo ZSBHQyBoYW5kbGVzIHRoZW0gcHJvcGVybHkgbm93IHRoYXQgaXQgYWxsb2NhdGVzIGJvdGggdGhl IEpTQXJyYXkgYW5kIHRoZSBBcnJheVN0b3JhZ2UuICBUbyBwYXNzIHdlIG5lZWQgdG8gbm90IGNy YXNoLicKICk7CiAKLWZ1bmN0aW9uIGdjKCkKLXsKLSAgICBpZiAodGhpcy5HQ0NvbnRyb2xsZXIp Ci0gICAgICAgIEdDQ29udHJvbGxlci5jb2xsZWN0KCk7Ci0gICAgZWxzZQotICAgICAgICBmb3Ig KHZhciBpID0gMDsgaSA8IDEwMDAwOyArK2kpIC8vIEFsbG9jYXRlIGEgc3VmZmljaWVudCBudW1i ZXIgb2Ygb2JqZWN0cyB0byBmb3JjZSBhIEdDLgotICAgICAgICAgICAgKHt9KTsKLX0KLQogdmFy IGdsb2JhbCA9IFtdOwogCiB2YXIgZ2V0UmFuZG9tSW5kZXggPSBmdW5jdGlvbihsZW5ndGgpIHsK QEAgLTQ3LDcgKzM4LDcgQEAgdmFyIHRlc3QgPSBmdW5jdGlvbigpIHsKIH07CiAKIHZhciBydW5z ID0gMDsgCi13aGlsZSAocnVucyA8IDQwKSB7Cit3aGlsZSAocnVucyA8IDMwKSB7CiAgICAgdGVz dCgpOwogICAgIHJ1bnMgKz0gMTsKICAgICBnbG9iYWwgPSBbXTsK 138897 2012-04-25 16:39:34 -0700 2012-04-27 11:55:53 -0700 Patch bug-84821-20120425163933.patch text/plain 1234 mhahnenberg U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1MjIzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMjAwN2VmMzllYjE1OTAxNzRiODZj MjFjNzA2N2JlMzkzMjViMjlhMS4uYTY1ZDBiMGNiNzliZGY1NTAyOTE4NTAzZTU1ZmZjYzI1OTYw YzI3MSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTA0LTI1ICBNYXJrIEhhaG5lbmJlcmcg IDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisKKyAgICAgICAgZmFzdC9qcy9yYW5kb20tYXJyYXkt Z2Mtc3RyZXNzIHRpbWVzIG91dCBpbiBkZWJ1ZyBtb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NDgyMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmFzdC9qcy9zY3JpcHQtdGVzdHMvcmFuZG9tLWFy cmF5LWdjLXN0cmVzcy5qczogVHJ5aW5nIGEgbG93ZXIgbnVtYmVyIG9mIGl0ZXJhdGlvbnMKKyAg ICAgICAgdG8gbWFrZSB0aGUgc2xvdyBib3RzIGhhcHB5LgorCiAyMDEyLTA0LTI1ICBOYXRlIENo YXBpbiAgPGphcGhldEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVGVzdCBmb3IgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgzOTE4LgpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvZmFzdC9qcy9zY3JpcHQtdGVzdHMvcmFuZG9tLWFycmF5LWdjLXN0cmVzcy5qcyBiL0xh eW91dFRlc3RzL2Zhc3QvanMvc2NyaXB0LXRlc3RzL3JhbmRvbS1hcnJheS1nYy1zdHJlc3MuanMK aW5kZXggYzI1NTQxZjZiZmViM2YyNmUzYjFkMTgxYmYwMjcwMmNmMjljN2UzYi4uMjQzZjQxNTAz ZjEwOWFiYjA2MDk3YjVhZjQ5YTYwN2U4ZTljMjdlNCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv ZmFzdC9qcy9zY3JpcHQtdGVzdHMvcmFuZG9tLWFycmF5LWdjLXN0cmVzcy5qcworKysgYi9MYXlv dXRUZXN0cy9mYXN0L2pzL3NjcmlwdC10ZXN0cy9yYW5kb20tYXJyYXktZ2Mtc3RyZXNzLmpzCkBA IC0zOCw3ICszOCw3IEBAIHZhciB0ZXN0ID0gZnVuY3Rpb24oKSB7CiB9OwogCiB2YXIgcnVucyA9 IDA7IAotd2hpbGUgKHJ1bnMgPCAzMCkgeword2hpbGUgKHJ1bnMgPCAyMCkgewogICAgIHRlc3Qo KTsKICAgICBydW5zICs9IDE7CiAgICAgZ2xvYmFsID0gW107Cg== 139243 2012-04-27 11:55:56 -0700 2012-04-30 12:23:17 -0700 Patch bug-84821-20120427115555.patch text/plain 1237 mhahnenberg U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1MzI1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggODQwZDAyNjg5NmE1NGZkYjFiMmVi MWI4M2FhMmRjODRiZWU3MjYyNy4uZDFhMDc1NDM2NmE4Nzg5NzQ5YzkwMmE4ZWIxYjIwMjQxMWU4 OTlhNiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTA0LTI3ICBNYXJrIEhhaG5lbmJlcmcg IDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisKKyAgICAgICAgZmFzdC9qcy9yYW5kb20tYXJyYXkt Z2Mtc3RyZXNzIHRpbWVzIG91dCBpbiBkZWJ1ZyBtb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NDgyMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmFzdC9qcy9zY3JpcHQtdGVzdHMvcmFuZG9tLWFy cmF5LWdjLXN0cmVzcy5qczogTG93ZXJpbmcgdGhlIGl0ZXJhdGlvbnMgZXZlbiBtb3JlLgorCisK IDIwMTItMDQtMjYgIERpbWl0cmkgR2xhemtvdiAgPGRnbGF6a292QGNocm9taXVtLm9yZz4KIAog ICAgICAgICBbQ2hyb21pdW1dIHdlYmF1ZGlvL2F1ZGlvcGFyYW0tZXhwb25lbnRpYWxSYW1wVG9W YWx1ZUF0VGltZS5odG1sIGlzIG9jY2FzaW9uYWxseSBjcmFzaGluZwpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvZmFzdC9qcy9zY3JpcHQtdGVzdHMvcmFuZG9tLWFycmF5LWdjLXN0cmVzcy5qcyBi L0xheW91dFRlc3RzL2Zhc3QvanMvc2NyaXB0LXRlc3RzL3JhbmRvbS1hcnJheS1nYy1zdHJlc3Mu anMKaW5kZXggMjQzZjQxNTAzZjEwOWFiYjA2MDk3YjVhZjQ5YTYwN2U4ZTljMjdlNC4uYjVkMDYy NzgwNjQ5YjVjY2VjMDk1ODFiMWUwOTdhMzNlYmU5OWJjZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvZmFzdC9qcy9zY3JpcHQtdGVzdHMvcmFuZG9tLWFycmF5LWdjLXN0cmVzcy5qcworKysgYi9M YXlvdXRUZXN0cy9mYXN0L2pzL3NjcmlwdC10ZXN0cy9yYW5kb20tYXJyYXktZ2Mtc3RyZXNzLmpz CkBAIC0zOCw3ICszOCw3IEBAIHZhciB0ZXN0ID0gZnVuY3Rpb24oKSB7CiB9OwogCiB2YXIgcnVu cyA9IDA7IAotd2hpbGUgKHJ1bnMgPCAyMCkgeword2hpbGUgKHJ1bnMgPCAxMCkgewogICAgIHRl c3QoKTsKICAgICBydW5zICs9IDE7CiAgICAgZ2xvYmFsID0gW107Cg==