84820 2012-04-24 20:02:49 -0700 [BlackBerry] [DRT] Some HTTP tests can't access relative css and/or javascript 2013-05-21 20:04:16 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Other Other CLOSED FIXED P2 Normal --- 0 xiaobwang webkit-unassigned rwlbuis tonikitoo webkit.review.bot oldest_to_newest 609409 0 xiaobwang 2012-04-24 20:02:49 -0700 [Ported from RIM PR #128626] For example: LayoutTests/http/tests/local/blob/send-data-blob.html 1 <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN"> 2 <html> 3 <head> 4 <link rel="stylesheet" href="../../../../fast/js/resources/js-test-style.css"> 5 <script src="../../../../fast/js/resources/js-test-pre.js"></script> 6 </head> 7 <body> 8 <p id="description"></p> 9 <div id="console"></div> 10 <script src="resources/hybrid-blob-util.js"></script> 11 <script src="script-tests/send-data-blob.js"></script> 12 <script src="../../../../fast/js/resources/js-test-post.js"></script> 13 </body> 14 </html> When run this test, js-test-style.css, js-test-pre.js and js-test-post.js are not accessible because we hacked the root directory of apache server. We are configuring apache's root directory to LayoutTests/http/tests/local, which apparently make the resources not accessible. In WebKit ORWT and NRWT scripts, we run tests under folder "http/tests/local" with local path (like "/developer/LayoutTests/http/tests/local/absolute-url-strip-whitespace.html"). However in our porting we run all tests under folder "/http/tests/" as HTTP tests (http://...). We should fix this. 609542 1 138757 xiaobwang 2012-04-25 01:18:50 -0700 Created attachment 138757 Git patch for bug 84820 609543 2 138757 zimmermann 2012-04-25 01:29:53 -0700 Comment on attachment 138757 Git patch for bug 84820 View in context: https://bugs.webkit.org/attachment.cgi?id=138757&action=review > Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:345 > + return test.lower().substring(0, strlen(httpTestSyntax)) == httpTestSyntax > + && test.lower().substring(strlen(httpTestSyntax), strlen(localTestSyntax)) != localTestSyntax; You could cache test.lower(), and the results of the strlen() calls in local variables. Though as this is a DRT patch, I'll r+ it nevertheless, feel free to make the changes, and reupload a patch or set cq+ on this one. 609581 3 138767 xiaobwang 2012-04-25 02:31:50 -0700 Created attachment 138767 Git patch for bug 84820, updated 609591 4 xiaobwang 2012-04-25 02:34:54 -0700 (In reply to comment #2) > (From update of attachment 138757 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=138757&action=review > > > Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:345 > > + return test.lower().substring(0, strlen(httpTestSyntax)) == httpTestSyntax > > + && test.lower().substring(strlen(httpTestSyntax), strlen(localTestSyntax)) != localTestSyntax; > > You could cache test.lower(), and the results of the strlen() calls in local variables. Though as this is a DRT patch, I'll r+ it nevertheless, feel free to make the changes, and reupload a patch or set cq+ on this one. Thanks Nikolas, changes were made according to your comment and new patch was uploaded. 609603 5 138767 zimmermann 2012-04-25 03:09:47 -0700 Comment on attachment 138767 Git patch for bug 84820, updated Thanks, r=me! 609625 6 138767 webkit.review.bot 2012-04-25 04:00:58 -0700 Comment on attachment 138767 Git patch for bug 84820, updated Clearing flags on attachment: 138767 Committed r115182: <http://trac.webkit.org/changeset/115182> 800298 7 rwlbuis 2013-01-04 09:51:49 -0800 Landed in r115182, closing. 800299 8 rwlbuis 2013-01-04 09:52:06 -0800 Landed in r115182, closing. 892099 9 138757 xiaobwang 2013-05-21 20:03:16 -0700 Comment on attachment 138757 Git patch for bug 84820 Clear r and cq flags for the obsolete patch. 892100 10 xiaobwang 2013-05-21 20:04:16 -0700 close. 138757 2012-04-25 01:18:50 -0700 2013-05-21 20:03:15 -0700 Git patch for bug 84820 0001-2012-04-25-Xiaobo-Wang-xbwang-torchmobile.com.cn.patch text/plain 3152 xiaobwang RnJvbSBjYWY4MjI4NWRlMzlkYTRjM2Y0ODFlNGM4YjE1MDA3ZDAwN2IzODI5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYaWFvYm8gV2FuZyA8eGJ3YW5nQHRvcmNobW9iaWxlLmNvbS5j bj4KRGF0ZTogV2VkLCAyNSBBcHIgMjAxMiAxNToyOTo0MCArMDgwMApTdWJqZWN0OiBbUEFUQ0hd IDIwMTItMDQtMjUgIFhpYW9ibyBXYW5nICA8eGJ3YW5nQHRvcmNobW9iaWxlLmNvbS5jbj4KCiAg ICAgICAgW0JsYWNrQmVycnldIFJ1biB0ZXN0cyBpbiAnL2h0dHAvdGVzdHMvbG9jYWwnIHdpdGgg bG9jYWwgVVJJCiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTg0ODIwCgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAgICBDdXJy ZW50bHkgd2UgcnVuIGFsbCB0ZXN0cyB1bmRlciBmb2xkZXIgIi9odHRwL3Rlc3RzLyIgYXMgSFRU UAogICAgICAgIHRlc3RzIChodHRwOi8vLi4uKS4gSG93ZXZlciBpbiBXZWJLaXQgT1JXVCBhbmQg TlJXVCBzY3JpcHRzLCB0ZXN0cyBpbgogICAgICAgICdodHRwL3Rlc3RzL2xvY2FsJyBhcmUgcnVu IHdpdGggbG9jYWwgcGF0aCAobGlrZSAnL2RldmVsb3Blci9MYXlvdXRUZXN0cwogICAgICAgIC9o dHRwL3Rlc3RzL2xvY2FsL2Fic29sdXRlLXVybC1zdHJpcC13aGl0ZXNwYWNlLmh0bWwnKS4KICAg ICAgICBXaXRoIHRoaXMgcGF0Y2ggd2UgY2FuIGtlZXAgdGhlIHNhbWUgYmVoYXZpb3VyIGFzIG90 aGVyIHBvcnRpbmdzLgoKICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2JsYWNrYmVycnkvRHVtcFJl bmRlclRyZWUuY3BwOgogICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OkR1bXBSZW5kZXJUcmVl Ojppc0hUVFBUZXN0KToKLS0tCiBUb29scy9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICB8ICAgMTYgKysrKysrKysrKysrKysrKwogVG9vbHMvRHVtcFJlbmRlclRy ZWUvYmxhY2tiZXJyeS9EdW1wUmVuZGVyVHJlZS5jcHAgfCAgICA0ICsrKy0KIDIgZmlsZXMgY2hh bmdlZCwgMTkgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Ub29s cy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTRiNzUyMy4uODg4NzNkMCAxMDA2 NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE5IEBACisyMDEyLTA0LTI1ICBYaWFvYm8gV2FuZyAgPHhid2FuZ0B0b3JjaG1vYmlsZS5jb20u Y24+CisKKyAgICAgICAgW0JsYWNrQmVycnldIFJ1biB0ZXN0cyBpbiAnL2h0dHAvdGVzdHMvbG9j YWwnIHdpdGggbG9jYWwgVVJJCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD04NDgyMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEN1cnJlbnRseSB3ZSBydW4gYWxsIHRlc3RzIHVuZGVyIGZvbGRlciAiL2h0dHAv dGVzdHMvIiBhcyBIVFRQCisgICAgICAgIHRlc3RzIChodHRwOi8vLi4uKS4gSG93ZXZlciBpbiBX ZWJLaXQgT1JXVCBhbmQgTlJXVCBzY3JpcHRzLCB0ZXN0cyBpbiAKKyAgICAgICAgJ2h0dHAvdGVz dHMvbG9jYWwnIGFyZSBydW4gd2l0aCBsb2NhbCBwYXRoIChsaWtlICcvZGV2ZWxvcGVyL0xheW91 dFRlc3RzCisgICAgICAgIC9odHRwL3Rlc3RzL2xvY2FsL2Fic29sdXRlLXVybC1zdHJpcC13aGl0 ZXNwYWNlLmh0bWwnKS4gCisgICAgICAgIFdpdGggdGhpcyBwYXRjaCB3ZSBjYW4ga2VlcCB0aGUg c2FtZSBiZWhhdmlvdXIgYXMgb3RoZXIgcG9ydGluZ3MuCisKKyAgICAgICAgKiBEdW1wUmVuZGVy VHJlZS9ibGFja2JlcnJ5L0R1bXBSZW5kZXJUcmVlLmNwcDoKKyAgICAgICAgKEJsYWNrQmVycnk6 OldlYktpdDo6RHVtcFJlbmRlclRyZWU6OmlzSFRUUFRlc3QpOgorCiAyMDEyLTA0LTI0ICBEaXJr IFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIG5yd3Q6IGFkZCBBU0FO IGhhbmRsaW5nIHRvIGNocm9taXVtIGNyYXNoIGxvZ3MKZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBS ZW5kZXJUcmVlL2JsYWNrYmVycnkvRHVtcFJlbmRlclRyZWUuY3BwIGIvVG9vbHMvRHVtcFJlbmRl clRyZWUvYmxhY2tiZXJyeS9EdW1wUmVuZGVyVHJlZS5jcHAKaW5kZXggOTE5Mzc0ZC4uMWJjNGM4 OSAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvYmxhY2tiZXJyeS9EdW1wUmVuZGVy VHJlZS5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvYmxhY2tiZXJyeS9EdW1wUmVuZGVy VHJlZS5jcHAKQEAgLTc3LDYgKzc3LDcgQEAgYm9vbCB3YWl0Rm9yUG9saWN5ID0gZmFsc2U7CiAv LyBGSVhNRTogQXNzdW1pbmcgTGF5b3V0VGVzdHMgaGFzIGJlZW4gY29waWVkIHRvIC9kZXZlbG9w ZXIvTGF5b3V0VGVzdHMvCiBzdGF0aWMgY29uc3QgY2hhciogY29uc3Qga1NEQ0xheW91dFRlc3Rz VVJJID0gImZpbGU6Ly8vZGV2ZWxvcGVyL0xheW91dFRlc3RzLyI7CiBzdGF0aWMgY29uc3QgY2hh ciogaHR0cFRlc3RTeW50YXggPSAiaHR0cC90ZXN0cy8iOworc3RhdGljIGNvbnN0IGNoYXIqIGxv Y2FsVGVzdFN5bnRheCA9ICJsb2NhbC8iOwogc3RhdGljIGNvbnN0IGNoYXIqIGh0dHBQcmVmaXhV UkwgPSAiaHR0cDovLzEyNy4wLjAuMTo4MDAwLyI7CiAKIHVzaW5nIG5hbWVzcGFjZSBzdGQ7CkBA IC0zNDAsNyArMzQxLDggQEAgYm9vbCBEdW1wUmVuZGVyVHJlZTo6aXNIVFRQVGVzdChjb25zdCBX VEY6OlN0cmluZyYgdGVzdCkKIHsKICAgICBpZiAodGVzdC5sZW5ndGgoKSA8IHN0cmxlbihodHRw VGVzdFN5bnRheCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKLSAgICByZXR1cm4gdGVzdC5sb3dl cigpLnN1YnN0cmluZygwLCBzdHJsZW4oaHR0cFRlc3RTeW50YXgpKSA9PSBodHRwVGVzdFN5bnRh eDsKKyAgICByZXR1cm4gdGVzdC5sb3dlcigpLnN1YnN0cmluZygwLCBzdHJsZW4oaHR0cFRlc3RT eW50YXgpKSA9PSBodHRwVGVzdFN5bnRheAorICAgICAgICAgICAgJiYgdGVzdC5sb3dlcigpLnN1 YnN0cmluZyhzdHJsZW4oaHR0cFRlc3RTeW50YXgpLCBzdHJsZW4obG9jYWxUZXN0U3ludGF4KSkg IT0gbG9jYWxUZXN0U3ludGF4OwogfQogCiB2b2lkIER1bXBSZW5kZXJUcmVlOjpnZXRUZXN0c1Rv UnVuKCkKLS0gCjEuNy42Cgo= 138767 2012-04-25 02:31:50 -0700 2012-04-25 04:00:58 -0700 Git patch for bug 84820, updated 0001-2012-04-25-Xiaobo-Wang-xbwang-torchmobile.com.cn.patch text/plain 3286 xiaobwang RnJvbSAxMTE2OWIyOGQwZTYxZjczZjI1YjI4YjcxZGRmN2EyZGQ2ZDEzOWQzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYaWFvYm8gV2FuZyA8eGJ3YW5nQHRvcmNobW9iaWxlLmNvbS5j bj4KRGF0ZTogV2VkLCAyNSBBcHIgMjAxMiAxNToyOTo0MCArMDgwMApTdWJqZWN0OiBbUEFUQ0hd IDIwMTItMDQtMjUgIFhpYW9ibyBXYW5nICA8eGJ3YW5nQHRvcmNobW9iaWxlLmNvbS5jbj4KCiAg ICAgICAgW0JsYWNrQmVycnldIFJ1biB0ZXN0cyBpbiAnL2h0dHAvdGVzdHMvbG9jYWwnIHdpdGgg bG9jYWwgVVJJCiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTg0ODIwCgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAgICBDdXJy ZW50bHkgd2UgcnVuIGFsbCB0ZXN0cyB1bmRlciBmb2xkZXIgIi9odHRwL3Rlc3RzLyIgYXMgSFRU UAogICAgICAgIHRlc3RzIChodHRwOi8vLi4uKS4gSG93ZXZlciBpbiBXZWJLaXQgT1JXVCBhbmQg TlJXVCBzY3JpcHRzLCB0ZXN0cyBpbgogICAgICAgICdodHRwL3Rlc3RzL2xvY2FsJyBhcmUgcnVu IHdpdGggbG9jYWwgcGF0aCAobGlrZSAnL2RldmVsb3Blci9MYXlvdXRUZXN0cwogICAgICAgIC9o dHRwL3Rlc3RzL2xvY2FsL2Fic29sdXRlLXVybC1zdHJpcC13aGl0ZXNwYWNlLmh0bWwnKS4KICAg ICAgICBXaXRoIHRoaXMgcGF0Y2ggd2UgY2FuIGtlZXAgdGhlIHNhbWUgYmVoYXZpb3VyIGFzIG90 aGVyIHBvcnRpbmdzLgoKICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2JsYWNrYmVycnkvRHVtcFJl bmRlclRyZWUuY3BwOgogICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OkR1bXBSZW5kZXJUcmVl Ojppc0hUVFBUZXN0KToKLS0tCiBUb29scy9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICB8ICAgMTYgKysrKysrKysrKysrKysrKwogVG9vbHMvRHVtcFJlbmRlclRy ZWUvYmxhY2tiZXJyeS9EdW1wUmVuZGVyVHJlZS5jcHAgfCAgICA2ICsrKysrLQogMiBmaWxlcyBj aGFuZ2VkLCAyMSBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1Rv b2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA2MTdjMGM1Li41MWZjN2M2IDEw MDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTkgQEAKKzIwMTItMDQtMjUgIFhpYW9ibyBXYW5nICA8eGJ3YW5nQHRvcmNobW9iaWxlLmNv bS5jbj4KKworICAgICAgICBbQmxhY2tCZXJyeV0gUnVuIHRlc3RzIGluICcvaHR0cC90ZXN0cy9s b2NhbCcgd2l0aCBsb2NhbCBVUkkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTg0ODIwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQ3VycmVudGx5IHdlIHJ1biBhbGwgdGVzdHMgdW5kZXIgZm9sZGVyICIvaHR0 cC90ZXN0cy8iIGFzIEhUVFAKKyAgICAgICAgdGVzdHMgKGh0dHA6Ly8uLi4pLiBIb3dldmVyIGlu IFdlYktpdCBPUldUIGFuZCBOUldUIHNjcmlwdHMsIHRlc3RzIGluCisgICAgICAgICdodHRwL3Rl c3RzL2xvY2FsJyBhcmUgcnVuIHdpdGggbG9jYWwgcGF0aCAobGlrZSAnL2RldmVsb3Blci9MYXlv dXRUZXN0cworICAgICAgICAvaHR0cC90ZXN0cy9sb2NhbC9hYnNvbHV0ZS11cmwtc3RyaXAtd2hp dGVzcGFjZS5odG1sJykuCisgICAgICAgIFdpdGggdGhpcyBwYXRjaCB3ZSBjYW4ga2VlcCB0aGUg c2FtZSBiZWhhdmlvdXIgYXMgb3RoZXIgcG9ydGluZ3MuCisKKyAgICAgICAgKiBEdW1wUmVuZGVy VHJlZS9ibGFja2JlcnJ5L0R1bXBSZW5kZXJUcmVlLmNwcDoKKyAgICAgICAgKEJsYWNrQmVycnk6 OldlYktpdDo6RHVtcFJlbmRlclRyZWU6OmlzSFRUUFRlc3QpOgorCiAyMDEyLTA0LTI1ICBNaWto YWlsIFBvemRueWFrb3YgIDxtaWtoYWlsLnBvemRueWFrb3ZAaW50ZWwuY29tPgogCiAgICAgICAg IFtFRkxdW0RSVF0gUmVzZXQgRFJUIHNldHRpbmdzIHRvIHRoZWlyIGRlZmF1bHQgdmFsdWVzIGFm dGVyIGEgdGVzdGNhc2Ugd2FzIGV4ZWN1dGVkLgpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRl clRyZWUvYmxhY2tiZXJyeS9EdW1wUmVuZGVyVHJlZS5jcHAgYi9Ub29scy9EdW1wUmVuZGVyVHJl ZS9ibGFja2JlcnJ5L0R1bXBSZW5kZXJUcmVlLmNwcAppbmRleCA5MTkzNzRkLi5kZDM2NzZhIDEw MDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9ibGFja2JlcnJ5L0R1bXBSZW5kZXJUcmVl LmNwcAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9ibGFja2JlcnJ5L0R1bXBSZW5kZXJUcmVl LmNwcApAQCAtNzcsNiArNzcsNyBAQCBib29sIHdhaXRGb3JQb2xpY3kgPSBmYWxzZTsKIC8vIEZJ WE1FOiBBc3N1bWluZyBMYXlvdXRUZXN0cyBoYXMgYmVlbiBjb3BpZWQgdG8gL2RldmVsb3Blci9M YXlvdXRUZXN0cy8KIHN0YXRpYyBjb25zdCBjaGFyKiBjb25zdCBrU0RDTGF5b3V0VGVzdHNVUkkg PSAiZmlsZTovLy9kZXZlbG9wZXIvTGF5b3V0VGVzdHMvIjsKIHN0YXRpYyBjb25zdCBjaGFyKiBo dHRwVGVzdFN5bnRheCA9ICJodHRwL3Rlc3RzLyI7CitzdGF0aWMgY29uc3QgY2hhciogbG9jYWxU ZXN0U3ludGF4ID0gImxvY2FsLyI7CiBzdGF0aWMgY29uc3QgY2hhciogaHR0cFByZWZpeFVSTCA9 ICJodHRwOi8vMTI3LjAuMC4xOjgwMDAvIjsKIAogdXNpbmcgbmFtZXNwYWNlIHN0ZDsKQEAgLTM0 MCw3ICszNDEsMTAgQEAgYm9vbCBEdW1wUmVuZGVyVHJlZTo6aXNIVFRQVGVzdChjb25zdCBXVEY6 OlN0cmluZyYgdGVzdCkKIHsKICAgICBpZiAodGVzdC5sZW5ndGgoKSA8IHN0cmxlbihodHRwVGVz dFN5bnRheCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKLSAgICByZXR1cm4gdGVzdC5sb3dlcigp LnN1YnN0cmluZygwLCBzdHJsZW4oaHR0cFRlc3RTeW50YXgpKSA9PSBodHRwVGVzdFN5bnRheDsK KyAgICBXVEY6OlN0cmluZyB0ZXN0TG93ZXIgPSB0ZXN0Lmxvd2VyKCk7CisgICAgaW50IGxlbkh0 dHBUZXN0U3ludGF4ID0gc3RybGVuKGh0dHBUZXN0U3ludGF4KTsKKyAgICByZXR1cm4gdGVzdExv d2VyLnN1YnN0cmluZygwLCBsZW5IdHRwVGVzdFN5bnRheCkgPT0gaHR0cFRlc3RTeW50YXgKKyAg ICAgICAgICAgICYmIHRlc3RMb3dlci5zdWJzdHJpbmcobGVuSHR0cFRlc3RTeW50YXgsIHN0cmxl bihsb2NhbFRlc3RTeW50YXgpKSAhPSBsb2NhbFRlc3RTeW50YXg7CiB9CiAKIHZvaWQgRHVtcFJl bmRlclRyZWU6OmdldFRlc3RzVG9SdW4oKQotLSAKMS43LjYKCg==