84816 2012-04-24 18:43:50 -0700 ScrollingCoordinator::setScrollParameters should take a single struct 2012-04-24 19:07:06 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca jamesr tonikitoo webkit.review.bot oldest_to_newest 609362 0 andersca 2012-04-24 18:43:50 -0700 ScrollingCoordinator::setScrollParameters should take a single struct 609364 1 138714 andersca 2012-04-24 18:44:59 -0700 Created attachment 138714 Patch 609379 2 andersca 2012-04-24 19:07:06 -0700 Committed r115159: <http://trac.webkit.org/changeset/115159> 138714 2012-04-24 18:44:59 -0700 2012-04-24 18:53:55 -0700 Patch bug-84816-20120424184650.patch text/plain 7674 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1MTAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGNkOTA1ZGU0ZjNiMzE2 YmNhZWEyMWQwNTVmNjNmNThiZjViYzBhZC4uMmY4YWUzYzBkZjRmMmQzNzkxNTk0Y2Y5ZWY0MDk3 YjNmZmE0ODc0MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA0LTI0ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgU2Nyb2xsaW5nQ29v cmRpbmF0b3I6OnNldFNjcm9sbFBhcmFtZXRlcnMgc2hvdWxkIHRha2UgYSBzaW5nbGUgc3RydWN0 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NDgxNgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGFnZS9z Y3JvbGxpbmcvU2Nyb2xsaW5nQ29vcmRpbmF0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2Ny b2xsaW5nQ29vcmRpbmF0b3I6OmZyYW1lVmlld0xheW91dFVwZGF0ZWQpOgorICAgICAgICAoV2Vi Q29yZTo6U2Nyb2xsaW5nQ29vcmRpbmF0b3I6OnNldFNjcm9sbFBhcmFtZXRlcnMpOgorICAgICAg ICAqIHBhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ0Nvb3JkaW5hdG9yLmg6CisgICAgICAgIChTY3Jv bGxpbmdDb29yZGluYXRvcik6CisgICAgICAgIChTY3JvbGxQYXJhbWV0ZXJzKToKKyAgICAgICAg KiBwYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdDb29yZGluYXRvck5vbmUuY3BwOgorICAgICAgICAo V2ViQ29yZTo6U2Nyb2xsaW5nQ29vcmRpbmF0b3I6OnNldFNjcm9sbFBhcmFtZXRlcnMpOgorICAg ICAgICAqIHBhZ2Uvc2Nyb2xsaW5nL2Nocm9taXVtL1Njcm9sbGluZ0Nvb3JkaW5hdG9yQ2hyb21p dW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsaW5nQ29vcmRpbmF0b3I6OnNldFNjcm9s bFBhcmFtZXRlcnMpOgorCiAyMDEyLTA0LTI0ICBDYWlvIE1hcmNlbG8gZGUgT2xpdmVpcmEgRmls aG8gIDxjYWlvLm9saXZlaXJhQG9wZW5ib3NzYS5vcmc+CiAKICAgICAgICAgRml4IHdyb25nIEFT U0VSVCgpIGluIGZpbmRBdHRyaWJ1dGVJblZlY3RvcigpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdDb29yZGluYXRvci5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdDb29yZGluYXRvci5jcHAKaW5kZXggNjM3YmEy YWZmMWRjMzNiMWE2ZWYyNmY0ZjY0MzgzM2FjNTZlNzEwOC4uYzZkNGRmNzU3NjljMmVlNzdlOTYw MjI1ZGYzYTRlYTM0ZWFhZDJjMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9zY3Jv bGxpbmcvU2Nyb2xsaW5nQ29vcmRpbmF0b3IuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv c2Nyb2xsaW5nL1Njcm9sbGluZ0Nvb3JkaW5hdG9yLmNwcApAQCAtMTQxLDEzICsxNDEsMTYgQEAg dm9pZCBTY3JvbGxpbmdDb29yZGluYXRvcjo6ZnJhbWVWaWV3TGF5b3V0VXBkYXRlZChGcmFtZVZp ZXcqIGZyYW1lVmlldykKICAgICBpZiAoIWNvb3JkaW5hdGVzU2Nyb2xsaW5nRm9yRnJhbWVWaWV3 KGZyYW1lVmlldykpCiAgICAgICAgIHJldHVybjsKIAotICAgIHNldFNjcm9sbFBhcmFtZXRlcnMo ZnJhbWVWaWV3LT5ob3Jpem9udGFsU2Nyb2xsRWxhc3RpY2l0eSgpLAotICAgICAgICAgICAgICAg ICAgICAgICAgZnJhbWVWaWV3LT52ZXJ0aWNhbFNjcm9sbEVsYXN0aWNpdHkoKSwKLSAgICAgICAg ICAgICAgICAgICAgICAgIGZyYW1lVmlldy0+aG9yaXpvbnRhbFNjcm9sbGJhcigpICYmIGZyYW1l Vmlldy0+aG9yaXpvbnRhbFNjcm9sbGJhcigpLT5lbmFibGVkKCksCi0gICAgICAgICAgICAgICAg ICAgICAgICBmcmFtZVZpZXctPnZlcnRpY2FsU2Nyb2xsYmFyKCkgJiYgZnJhbWVWaWV3LT52ZXJ0 aWNhbFNjcm9sbGJhcigpLT5lbmFibGVkKCksCi0gICAgICAgICAgICAgICAgICAgICAgICBJbnRS ZWN0KEludFBvaW50KCksIGZyYW1lVmlldy0+dmlzaWJsZUNvbnRlbnRSZWN0KCkuc2l6ZSgpKSwK LSAgICAgICAgICAgICAgICAgICAgICAgIGZyYW1lVmlldy0+Y29udGVudHNTaXplKCkpOworICAg IFNjcm9sbFBhcmFtZXRlcnMgc2Nyb2xsUGFyYW1ldGVyczsKKyAgICBzY3JvbGxQYXJhbWV0ZXJz Lmhvcml6b250YWxTY3JvbGxFbGFzdGljaXR5ID0gZnJhbWVWaWV3LT5ob3Jpem9udGFsU2Nyb2xs RWxhc3RpY2l0eSgpOworICAgIHNjcm9sbFBhcmFtZXRlcnMudmVydGljYWxTY3JvbGxFbGFzdGlj aXR5ID0gZnJhbWVWaWV3LT52ZXJ0aWNhbFNjcm9sbEVsYXN0aWNpdHkoKTsKKyAgICBzY3JvbGxQ YXJhbWV0ZXJzLmhhc0VuYWJsZWRIb3Jpem9udGFsU2Nyb2xsYmFyID0gZnJhbWVWaWV3LT5ob3Jp em9udGFsU2Nyb2xsYmFyKCkgJiYgZnJhbWVWaWV3LT5ob3Jpem9udGFsU2Nyb2xsYmFyKCktPmVu YWJsZWQoKTsKKyAgICBzY3JvbGxQYXJhbWV0ZXJzLmhhc0VuYWJsZWRWZXJ0aWNhbFNjcm9sbGJh ciA9IGZyYW1lVmlldy0+dmVydGljYWxTY3JvbGxiYXIoKSAmJiBmcmFtZVZpZXctPnZlcnRpY2Fs U2Nyb2xsYmFyKCktPmVuYWJsZWQoKTsKIAorICAgIHNjcm9sbFBhcmFtZXRlcnMudmlld3BvcnRS ZWN0ID0gSW50UmVjdChJbnRQb2ludCgpLCBmcmFtZVZpZXctPnZpc2libGVDb250ZW50UmVjdCgp LnNpemUoKSk7CisgICAgc2Nyb2xsUGFyYW1ldGVycy5jb250ZW50c1NpemUgPSBmcmFtZVZpZXct PmNvbnRlbnRzU2l6ZSgpOworCisgICAgc2V0U2Nyb2xsUGFyYW1ldGVycyhzY3JvbGxQYXJhbWV0 ZXJzKTsKIH0KIAogdm9pZCBTY3JvbGxpbmdDb29yZGluYXRvcjo6ZnJhbWVWaWV3V2hlZWxFdmVu dEhhbmRsZXJDb3VudENoYW5nZWQoRnJhbWVWaWV3KikKQEAgLTM1MiwyMCArMzU1LDE1IEBAIHZv aWQgU2Nyb2xsaW5nQ29vcmRpbmF0b3I6OnNldE5vbkZhc3RTY3JvbGxhYmxlUmVnaW9uKGNvbnN0 IFJlZ2lvbiYgcmVnaW9uKQogICAgIHNjaGVkdWxlVHJlZVN0YXRlQ29tbWl0KCk7CiB9CiAKLXZv aWQgU2Nyb2xsaW5nQ29vcmRpbmF0b3I6OnNldFNjcm9sbFBhcmFtZXRlcnMoU2Nyb2xsRWxhc3Rp Y2l0eSBob3Jpem9udGFsU2Nyb2xsRWxhc3RpY2l0eSwKLSAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgU2Nyb2xsRWxhc3RpY2l0eSB2ZXJ0aWNhbFNjcm9sbEVs YXN0aWNpdHksCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGJvb2wgaGFzRW5hYmxlZEhvcml6b250YWxTY3JvbGxiYXIsCi0gICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJvb2wgaGFzRW5hYmxlZFZlcnRpY2FsU2Nyb2xs YmFyLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25z dCBJbnRSZWN0JiB2aWV3cG9ydFJlY3QsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGNvbnN0IEludFNpemUmIGNvbnRlbnRzU2l6ZSkKK3ZvaWQgU2Nyb2xs aW5nQ29vcmRpbmF0b3I6OnNldFNjcm9sbFBhcmFtZXRlcnMoY29uc3QgU2Nyb2xsUGFyYW1ldGVy cyYgc2Nyb2xsUGFyYW1ldGVycykKIHsKLSAgICBtX3Njcm9sbGluZ1RyZWVTdGF0ZS0+c2V0SG9y aXpvbnRhbFNjcm9sbEVsYXN0aWNpdHkoaG9yaXpvbnRhbFNjcm9sbEVsYXN0aWNpdHkpOwotICAg IG1fc2Nyb2xsaW5nVHJlZVN0YXRlLT5zZXRWZXJ0aWNhbFNjcm9sbEVsYXN0aWNpdHkodmVydGlj YWxTY3JvbGxFbGFzdGljaXR5KTsKLSAgICBtX3Njcm9sbGluZ1RyZWVTdGF0ZS0+c2V0SGFzRW5h YmxlZEhvcml6b250YWxTY3JvbGxiYXIoaGFzRW5hYmxlZEhvcml6b250YWxTY3JvbGxiYXIpOwot ICAgIG1fc2Nyb2xsaW5nVHJlZVN0YXRlLT5zZXRIYXNFbmFibGVkVmVydGljYWxTY3JvbGxiYXIo aGFzRW5hYmxlZFZlcnRpY2FsU2Nyb2xsYmFyKTsKKyAgICBtX3Njcm9sbGluZ1RyZWVTdGF0ZS0+ c2V0SG9yaXpvbnRhbFNjcm9sbEVsYXN0aWNpdHkoc2Nyb2xsUGFyYW1ldGVycy5ob3Jpem9udGFs U2Nyb2xsRWxhc3RpY2l0eSk7CisgICAgbV9zY3JvbGxpbmdUcmVlU3RhdGUtPnNldFZlcnRpY2Fs U2Nyb2xsRWxhc3RpY2l0eShzY3JvbGxQYXJhbWV0ZXJzLnZlcnRpY2FsU2Nyb2xsRWxhc3RpY2l0 eSk7CisgICAgbV9zY3JvbGxpbmdUcmVlU3RhdGUtPnNldEhhc0VuYWJsZWRIb3Jpem9udGFsU2Ny b2xsYmFyKHNjcm9sbFBhcmFtZXRlcnMuaGFzRW5hYmxlZEhvcml6b250YWxTY3JvbGxiYXIpOwor ICAgIG1fc2Nyb2xsaW5nVHJlZVN0YXRlLT5zZXRIYXNFbmFibGVkVmVydGljYWxTY3JvbGxiYXIo c2Nyb2xsUGFyYW1ldGVycy5oYXNFbmFibGVkVmVydGljYWxTY3JvbGxiYXIpOwogCi0gICAgbV9z Y3JvbGxpbmdUcmVlU3RhdGUtPnNldFZpZXdwb3J0UmVjdCh2aWV3cG9ydFJlY3QpOwotICAgIG1f c2Nyb2xsaW5nVHJlZVN0YXRlLT5zZXRDb250ZW50c1NpemUoY29udGVudHNTaXplKTsKKyAgICBt X3Njcm9sbGluZ1RyZWVTdGF0ZS0+c2V0Vmlld3BvcnRSZWN0KHNjcm9sbFBhcmFtZXRlcnMudmll d3BvcnRSZWN0KTsKKyAgICBtX3Njcm9sbGluZ1RyZWVTdGF0ZS0+c2V0Q29udGVudHNTaXplKHNj cm9sbFBhcmFtZXRlcnMuY29udGVudHNTaXplKTsKICAgICBzY2hlZHVsZVRyZWVTdGF0ZUNvbW1p dCgpOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9TY3Jv bGxpbmdDb29yZGluYXRvci5oIGIvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xs aW5nQ29vcmRpbmF0b3IuaAppbmRleCA0YTIyMzJkMjRkY2ZhMzE4MDNiNDMzZDc0YTAyZTQyZGRh NThjOGYxLi44ZTU0YzM5YWQ1Y2FiY2RhYzU2NzFmZjZiMjNiNGJjZWVhOGE3MmE2IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdDb29yZGluYXRvci5o CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ0Nvb3JkaW5hdG9y LmgKQEAgLTEyMyw5ICsxMjMsMTkgQEAgcHJpdmF0ZToKIAogICAgIHZvaWQgc2V0U2Nyb2xsTGF5 ZXIoR3JhcGhpY3NMYXllciopOwogICAgIHZvaWQgc2V0Tm9uRmFzdFNjcm9sbGFibGVSZWdpb24o Y29uc3QgUmVnaW9uJik7Ci0gICAgdm9pZCBzZXRTY3JvbGxQYXJhbWV0ZXJzKFNjcm9sbEVsYXN0 aWNpdHkgaG9yaXpvbnRhbFNjcm9sbEVsYXN0aWNpdHksIFNjcm9sbEVsYXN0aWNpdHkgdmVydGlj YWxTY3JvbGxFbGFzdGljaXR5LAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICBib29sIGhh c0VuYWJsZWRIb3Jpem9udGFsU2Nyb2xsYmFyLCBib29sIGhhc0VuYWJsZWRWZXJ0aWNhbFNjcm9s bGJhciwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3QgSW50UmVjdCYgdmlld3Bv cnRSZWN0LCBjb25zdCBJbnRTaXplJiBjb250ZW50c1NpemUpOworCisgICAgc3RydWN0IFNjcm9s bFBhcmFtZXRlcnMgeworICAgICAgICBTY3JvbGxFbGFzdGljaXR5IGhvcml6b250YWxTY3JvbGxF bGFzdGljaXR5OworICAgICAgICBTY3JvbGxFbGFzdGljaXR5IHZlcnRpY2FsU2Nyb2xsRWxhc3Rp Y2l0eTsKKworICAgICAgICBib29sIGhhc0VuYWJsZWRIb3Jpem9udGFsU2Nyb2xsYmFyOworICAg ICAgICBib29sIGhhc0VuYWJsZWRWZXJ0aWNhbFNjcm9sbGJhcjsKKworICAgICAgICBJbnRSZWN0 IHZpZXdwb3J0UmVjdDsKKyAgICAgICAgSW50U2l6ZSBjb250ZW50c1NpemU7CisgICAgfTsKKwor ICAgIHZvaWQgc2V0U2Nyb2xsUGFyYW1ldGVycyhjb25zdCBTY3JvbGxQYXJhbWV0ZXJzJik7CiAg ICAgdm9pZCBzZXRXaGVlbEV2ZW50SGFuZGxlckNvdW50KHVuc2lnbmVkKTsKICAgICB2b2lkIHNl dFNob3VsZFVwZGF0ZVNjcm9sbExheWVyUG9zaXRpb25Pbk1haW5UaHJlYWQoYm9vbCk7CiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ0Nvb3JkaW5h dG9yTm9uZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdDb29y ZGluYXRvck5vbmUuY3BwCmluZGV4IGQwNmQ2YmIzNDVmNTA2Y2NmMGQyMTkxNDk4MWZhZGY4ZWJl NmRjMmIuLmNmMTQ1ZGQyMzM3YjgwODdjNDhmNzVhNjI0ZDEwMTE3YzllNDQyMzQgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ0Nvb3JkaW5hdG9yTm9u ZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nQ29vcmRp bmF0b3JOb25lLmNwcApAQCAtNTksNyArNTksNyBAQCB2b2lkIFNjcm9sbGluZ0Nvb3JkaW5hdG9y OjpzZXROb25GYXN0U2Nyb2xsYWJsZVJlZ2lvbihjb25zdCBSZWdpb24mKQogewogfQogCi12b2lk IFNjcm9sbGluZ0Nvb3JkaW5hdG9yOjpzZXRTY3JvbGxQYXJhbWV0ZXJzKFNjcm9sbEVsYXN0aWNp dHksIFNjcm9sbEVsYXN0aWNpdHksIGJvb2wsIGJvb2wsIGNvbnN0IEludFJlY3QmLCBjb25zdCBJ bnRTaXplJikKK3ZvaWQgU2Nyb2xsaW5nQ29vcmRpbmF0b3I6OnNldFNjcm9sbFBhcmFtZXRlcnMo Y29uc3QgU2Nyb2xsUGFyYW1ldGVycyYpCiB7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BhZ2Uvc2Nyb2xsaW5nL2Nocm9taXVtL1Njcm9sbGluZ0Nvb3JkaW5hdG9yQ2hyb21pdW0u Y3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvY2hyb21pdW0vU2Nyb2xsaW5nQ29v cmRpbmF0b3JDaHJvbWl1bS5jcHAKaW5kZXggZDU2Y2Y0OTMzMTNkNjkzZTIyZmEzNDM5NGE1MzI2 M2E0OTQ2MjRlNS4uYzE4ZTdlMzk3NjYwNDhhZWQwZTg1YzNhNzBkOTIyMmI4NTRjOGQ3YiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvY2hyb21pdW0vU2Nyb2xsaW5n Q29vcmRpbmF0b3JDaHJvbWl1bS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxp bmcvY2hyb21pdW0vU2Nyb2xsaW5nQ29vcmRpbmF0b3JDaHJvbWl1bS5jcHAKQEAgLTE0NCw5ICsx NDQsNyBAQCB2b2lkIFNjcm9sbGluZ0Nvb3JkaW5hdG9yOjpzZXROb25GYXN0U2Nyb2xsYWJsZVJl Z2lvbihjb25zdCBSZWdpb24mIHJlZ2lvbikKICAgICAgICAgbGF5ZXItPnNldE5vbkZhc3RTY3Jv bGxhYmxlUmVnaW9uKHJlZ2lvbik7CiB9CiAKLXZvaWQgU2Nyb2xsaW5nQ29vcmRpbmF0b3I6OnNl dFNjcm9sbFBhcmFtZXRlcnMoU2Nyb2xsRWxhc3RpY2l0eSBob3Jpem9udGFsU2Nyb2xsRWxhc3Rp Y2l0eSwgU2Nyb2xsRWxhc3RpY2l0eSB2ZXJ0aWNhbFNjcm9sbEVsYXN0aWNpdHksCi0gICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJvb2wgaGFzRW5hYmxlZEhv cml6b250YWxTY3JvbGxiYXIsIGJvb2wgaGFzRW5hYmxlZFZlcnRpY2FsU2Nyb2xsYmFyLAotICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBJbnRSZWN0 JiB2aWV3cG9ydFJlY3QsIGNvbnN0IEludFNpemUmIGNvbnRlbnRzU2l6ZSkKK3ZvaWQgU2Nyb2xs aW5nQ29vcmRpbmF0b3I6OnNldFNjcm9sbFBhcmFtZXRlcnMoY29uc3QgU2Nyb2xsUGFyYW1ldGVy cyYpCiB7CiAgICAgLy8gRklYTUU6IEltcGxlbWVudCEKIH0K