84807 2012-04-24 17:10:52 -0700 [chromium] Don't call calculateRenderPasses in CCLayerTreeHostImpl::scrollBegin() 2012-04-24 20:00:14 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 84805 1 enne enne cc-bugs enne jamesr webkit.review.bot oldest_to_newest 609278 0 enne 2012-04-24 17:10:52 -0700 calculateRenderPasses calls willDraw() on every layer and unless drawLayers is then called, there's a missing didDraw() pair. This causes problems for video layers that want to lock and release resources during these two function calls. 609284 1 138696 enne 2012-04-24 17:15:31 -0700 Created attachment 138696 Patch 609288 2 138696 jamesr 2012-04-24 17:17:40 -0700 Comment on attachment 138696 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138696&action=review Much better R=me > Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:266 > + ASSERT(passes.isEmpty()); can we make passes a local variable again and just have the renderSurfaceLayerList be a member variable, or is that teh crazy? 609292 3 enne 2012-04-24 17:19:41 -0700 (In reply to comment #2) > (From update of attachment 138696 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=138696&action=review > > Much better R=me > > > Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:266 > > + ASSERT(passes.isEmpty()); > > can we make passes a local variable again and just have the renderSurfaceLayerList be a member variable, or is that teh crazy? Sadly, I think that'd be a larger refactoring, although it might be worthwhile to investigate it. 609406 4 138696 webkit.review.bot 2012-04-24 20:00:09 -0700 Comment on attachment 138696 Patch Clearing flags on attachment: 138696 Committed r115162: <http://trac.webkit.org/changeset/115162> 609407 5 webkit.review.bot 2012-04-24 20:00:14 -0700 All reviewed patches have been landed. Closing bug. 138696 2012-04-24 17:15:31 -0700 2012-04-24 20:00:09 -0700 Patch bug-84807-20120424171529.patch text/plain 4727 enne U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1MTAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGNkOTA1ZGU0ZjNiMzE2 YmNhZWEyMWQwNTVmNjNmNThiZjViYzBhZC4uNjQ3OWVlY2M3NTk4MWI1Yzg0OTg0ZjA1MGFhZWIy OWI5NDc3NGIwMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA0LTI0ICBBZHJp ZW5uZSBXYWxrZXIgIDxlbm5lQGdvb2dsZS5jb20+CisKKyAgICAgICAgW2Nocm9taXVtXSBEb24n dCBjYWxsIGNhbGN1bGF0ZVJlbmRlclBhc3NlcyBpbiBDQ0xheWVyVHJlZUhvc3RJbXBsOjpzY3Jv bGxCZWdpbigpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD04NDgwNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEluc3RlYWQgb2YgY2FsY3VsYXRlIHJlbmRlciBwYXNzZXMgYW5kIHF1YWRzIGFuZCB0cmFja2lu ZyBkYW1hZ2UsCisgICAgICAgIHNpbXBseSBjYWxjdWxhdGUgdGhlIHVwZGF0ZWQgcmVuZGVyIGxh eWVyIGxpc3QsIHdoaWNoIGlzIHdoYXQgaXMKKyAgICAgICAgbmVlZGVkIGZvciBzY3JvbGxpbmcu ICBUaGlzIHByZXZlbnRzIGEgd2lsbERyYXcvZGlkRHJhdyBtaXNtYXRjaCBvbgorICAgICAgICBs YXllcnMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVy VHJlZUhvc3RJbXBsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNDTGF5ZXJUcmVlSG9zdEltcGw6 OmNhbGN1bGF0ZVJlbmRlclN1cmZhY2VMYXllckxpc3QpOgorICAgICAgICAoV2ViQ29yZSk6Cisg ICAgICAgIChXZWJDb3JlOjpDQ0xheWVyVHJlZUhvc3RJbXBsOjpjYWxjdWxhdGVSZW5kZXJQYXNz ZXMpOgorICAgICAgICAoV2ViQ29yZTo6Q0NMYXllclRyZWVIb3N0SW1wbDo6ZW5zdXJlTW9zdFJl Y2VudFJlbmRlclN1cmZhY2VMYXllckxpc3QpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNz L2Nocm9taXVtL2NjL0NDTGF5ZXJUcmVlSG9zdEltcGwuaDoKKyAgICAgICAgKENDTGF5ZXJUcmVl SG9zdEltcGwpOgorCiAyMDEyLTA0LTI0ICBDYWlvIE1hcmNlbG8gZGUgT2xpdmVpcmEgRmlsaG8g IDxjYWlvLm9saXZlaXJhQG9wZW5ib3NzYS5vcmc+CiAKICAgICAgICAgRml4IHdyb25nIEFTU0VS VCgpIGluIGZpbmRBdHRyaWJ1dGVJblZlY3RvcigpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVyVHJlZUhvc3RJbXBsLmNwcCBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJUcmVl SG9zdEltcGwuY3BwCmluZGV4IDk1OGZiMDg4NjVkNDZlNjg2MDZmYmUzMzc1Y2QxYTc5N2JjM2E4 MWIuLmI2ZjlkYjk5NTYyZjc5YzQ0MTc1NTE1NzY2NjdlN2EyZmY2YzA4MzkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJUcmVl SG9zdEltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9t aXVtL2NjL0NDTGF5ZXJUcmVlSG9zdEltcGwuY3BwCkBAIC0yNDAsOSArMjQwLDggQEAgc3RhdGlj IEZsb2F0UmVjdCBkYW1hZ2VJblN1cmZhY2VTcGFjZShDQ0xheWVySW1wbCogcmVuZGVyU3VyZmFj ZUxheWVyLCBjb25zdCBGbG8KICAgICByZXR1cm4gc3VyZmFjZURhbWFnZVJlY3Q7CiB9CiAKLWJv b2wgQ0NMYXllclRyZWVIb3N0SW1wbDo6Y2FsY3VsYXRlUmVuZGVyUGFzc2VzKENDUmVuZGVyUGFz c0xpc3QmIHBhc3NlcywgQ0NMYXllckxpc3QmIHJlbmRlclN1cmZhY2VMYXllckxpc3QpCit2b2lk IENDTGF5ZXJUcmVlSG9zdEltcGw6OmNhbGN1bGF0ZVJlbmRlclN1cmZhY2VMYXllckxpc3QoQ0NM YXllckxpc3QmIHJlbmRlclN1cmZhY2VMYXllckxpc3QpCiB7Ci0gICAgQVNTRVJUKHBhc3Nlcy5p c0VtcHR5KCkpOwogICAgIEFTU0VSVChyZW5kZXJTdXJmYWNlTGF5ZXJMaXN0LmlzRW1wdHkoKSk7 CiAgICAgQVNTRVJUKG1fcm9vdExheWVySW1wbCk7CiAKQEAgLTI2MCw2ICsyNTksMTMgQEAgYm9v bCBDQ0xheWVyVHJlZUhvc3RJbXBsOjpjYWxjdWxhdGVSZW5kZXJQYXNzZXMoQ0NSZW5kZXJQYXNz TGlzdCYgcGFzc2VzLCBDQ0xheWUKICAgICAgICAgVFJBQ0VfRVZFTlQoIkNDTGF5ZXJUcmVlSG9z dEltcGw6OmNhbGNEcmF3RXRjIiwgdGhpcywgMCk7CiAgICAgICAgIENDTGF5ZXJUcmVlSG9zdENv bW1vbjo6Y2FsY3VsYXRlRHJhd1RyYW5zZm9ybXNBbmRWaXNpYmlsaXR5KG1fcm9vdExheWVySW1w bC5nZXQoKSwgbV9yb290TGF5ZXJJbXBsLmdldCgpLCBpZGVudGl0eU1hdHJpeCwgaWRlbnRpdHlN YXRyaXgsIHJlbmRlclN1cmZhY2VMYXllckxpc3QsIG1fcm9vdExheWVySW1wbC0+cmVuZGVyU3Vy ZmFjZSgpLT5sYXllckxpc3QoKSwgJm1fbGF5ZXJTb3J0ZXIsIGxheWVyUmVuZGVyZXJDYXBhYmls aXRpZXMoKS5tYXhUZXh0dXJlU2l6ZSk7CiAgICAgfQorfQorCitib29sIENDTGF5ZXJUcmVlSG9z dEltcGw6OmNhbGN1bGF0ZVJlbmRlclBhc3NlcyhDQ1JlbmRlclBhc3NMaXN0JiBwYXNzZXMsIEND TGF5ZXJMaXN0JiByZW5kZXJTdXJmYWNlTGF5ZXJMaXN0KQoreworICAgIEFTU0VSVChwYXNzZXMu aXNFbXB0eSgpKTsKKworICAgIGNhbGN1bGF0ZVJlbmRlclN1cmZhY2VMYXllckxpc3QocmVuZGVy U3VyZmFjZUxheWVyTGlzdCk7CiAKICAgICBUUkFDRV9FVkVOVDEoIndlYmtpdCIsICJDQ0xheWVy VHJlZUhvc3RJbXBsOjpjYWxjdWxhdGVSZW5kZXJQYXNzZXMiLCAicmVuZGVyU3VyZmFjZUxheWVy TGlzdC5zaXplKCkiLCBzdGF0aWNfY2FzdDxsb25nIGxvbmcgdW5zaWduZWQ+KHJlbmRlclN1cmZh Y2VMYXllckxpc3Quc2l6ZSgpKSk7CiAKQEAgLTY4MiwxMCArNjg4LDEwIEBAIGJvb2wgQ0NMYXll clRyZWVIb3N0SW1wbDo6ZW5zdXJlTW9zdFJlY2VudFJlbmRlclN1cmZhY2VMYXllckxpc3QoKQog ICAgIGlmICghbV9yb290TGF5ZXJJbXBsKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKLSAgICAv LyBJZiB3ZSBhcmUgY2FsbGVkIGFmdGVyIHNldFJvb3RMYXllcigpIGJ1dCBiZWZvcmUgcHJlcGFy ZVRvRHJhdygpLCB3ZSBuZWVkIHRvIHJlY2FsY3VsYXRlCi0gICAgLy8gdGhlIHZpc2libGUgbGF5 ZXJzLiBUaGUgcmV0dXJuIHZhbHVlIGlzIGlnbm9yZWQgYmVjYXVzZSB3ZSBkb24ndCBjYXJlIGFi b3V0IGNoZWNrZXJib2FyZGluZy4KLSAgICBDQ1JlbmRlclBhc3NMaXN0IHBhc3NlczsKLSAgICBj YWxjdWxhdGVSZW5kZXJQYXNzZXMocGFzc2VzLCBtX21vc3RSZWNlbnRSZW5kZXJTdXJmYWNlTGF5 ZXJMaXN0KTsKKyAgICAvLyBJZiB3ZSBhcmUgY2FsbGVkIGFmdGVyIHNldFJvb3RMYXllcigpIGJ1 dCBiZWZvcmUgcHJlcGFyZVRvRHJhdygpLCB3ZSBuZWVkCisgICAgLy8gdG8gcmVjYWxjdWxhdGUg dGhlIHZpc2libGUgbGF5ZXJzLiBUaGlzIHByZXZlbnRzIGJlaW5nIHVuYWJsZSB0byBzY3JvbGwK KyAgICAvLyBkdXJpbmcgcGFydCBvZiBhIGNvbW1pdC4KKyAgICBjYWxjdWxhdGVSZW5kZXJTdXJm YWNlTGF5ZXJMaXN0KG1fbW9zdFJlY2VudFJlbmRlclN1cmZhY2VMYXllckxpc3QpOwogCiAgICAg cmV0dXJuIG1fbW9zdFJlY2VudFJlbmRlclN1cmZhY2VMYXllckxpc3Quc2l6ZSgpOwogfQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NM YXllclRyZWVIb3N0SW1wbC5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hy b21pdW0vY2MvQ0NMYXllclRyZWVIb3N0SW1wbC5oCmluZGV4IDY1NTg5ZTgyMjgyODQ0ZDQ1Yzlm NDczOGNmN2E4ZWFmNDY4MTI1ZWIuLjE3N2I0YjU2ZmY4NzYyZjIwNzNlZjMzNjlhMjI2ODFiMGI1 YzE5ZGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9t aXVtL2NjL0NDTGF5ZXJUcmVlSG9zdEltcGwuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVyVHJlZUhvc3RJbXBsLmgKQEAgLTE3Niw2ICsx NzYsNyBAQCBwcml2YXRlOgogICAgIHZvaWQgc2V0UGFnZVNjYWxlRGVsdGEoZmxvYXQpOwogICAg IHZvaWQgdXBkYXRlTWF4U2Nyb2xsUG9zaXRpb24oKTsKICAgICB2b2lkIHRyYWNrRGFtYWdlRm9y QWxsU3VyZmFjZXMoQ0NMYXllckltcGwqIHJvb3REcmF3TGF5ZXIsIGNvbnN0IENDTGF5ZXJMaXN0 JiByZW5kZXJTdXJmYWNlTGF5ZXJMaXN0KTsKKyAgICB2b2lkIGNhbGN1bGF0ZVJlbmRlclN1cmZh Y2VMYXllckxpc3QoQ0NMYXllckxpc3QmKTsKICAgICAvLyBSZXR1cm5zIGZhbHNlIGlmIHRoZSBm cmFtZSBzaG91bGQgbm90IGJlIGRpc3BsYXllZC4KICAgICBib29sIGNhbGN1bGF0ZVJlbmRlclBh c3NlcyhDQ1JlbmRlclBhc3NMaXN0JiwgQ0NMYXllckxpc3QmIHJlbmRlclN1cmZhY2VMYXllckxp c3QpOwogICAgIHZvaWQgYW5pbWF0ZUxheWVyc1JlY3Vyc2l2ZShDQ0xheWVySW1wbCosIGRvdWJs ZSBtb25vdG9uaWNUaW1lLCBkb3VibGUgd2FsbENsb2NrVGltZSwgQ0NBbmltYXRpb25FdmVudHNW ZWN0b3IqLCBib29sJiBkaWRBbmltYXRlLCBib29sJiBuZWVkc0FuaW1hdGVMYXllcnMpOwo=