84749 2012-04-24 12:22:50 -0700 [Coverity] Uninitialized fields in RenderSVGShape constructors 2012-04-25 06:44:37 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P4 Normal --- 1 fmalita fmalita webkit.review.bot zimmermann oldest_to_newest 608931 0 fmalita 2012-04-24 12:22:50 -0700 RenderSVGShape::RenderSVGShape(SVGStyledTransformableElement* node): * m_strokeContainsFallBack RenderSVGShape::RenderSVGShape(SVGStyledTransformableElement* node, Path* path, bool isFillFallback): * m_needsTransformUpdate * m_needsShapeUpdate * m_strokeContainsFallBack * m_needsBoundariesUpdate Looks like neither m_strokeContainsFallBack nor the second constructor is being used, so we can simply get rid of them. 608949 1 138622 fmalita 2012-04-24 12:40:26 -0700 Created attachment 138622 Patch 608952 2 138622 darin 2012-04-24 12:42:05 -0700 Comment on attachment 138622 Patch Looks fine. Great to remove unused code! 609706 3 138622 webkit.review.bot 2012-04-25 06:44:32 -0700 Comment on attachment 138622 Patch Clearing flags on attachment: 138622 Committed r115196: <http://trac.webkit.org/changeset/115196> 609707 4 webkit.review.bot 2012-04-25 06:44:37 -0700 All reviewed patches have been landed. Closing bug. 138622 2012-04-24 12:40:26 -0700 2012-04-25 06:44:31 -0700 Patch bug-84749-20120424154024.patch text/plain 2091 fmalita U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1MDU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjdmNzc3MDMzMzQ5NzIw ZGU3NWUzZjZhYTNkZDhkNWRlNzY4YjRmYy4uODliOWM1ZjAxY2VlNDBhN2ZmMTBjNGQ1NmQwNmE2 N2I1MDIwYTQ1MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDEyLTA0LTI0ICBGbG9y aW4gTWFsaXRhICA8Zm1hbGl0YUBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgW0NvdmVyaXR5XSBV bmluaXRpYWxpemVkIGZpZWxkcyBpbiBSZW5kZXJTVkdTaGFwZSBjb25zdHJ1Y3RvcnMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg0NzQ5CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZpbmcgdW51c2Vk IFJlbmRlclNWR1NoYXBlIGNvbnN0cnVjdG9yIGFuZCBmaWVsZC4KKworICAgICAgICBObyBuZXcg dGVzdHMgLSBubyBiZWhhdmlvciBjaGFuZ2UuCisKKyAgICAgICAgKiByZW5kZXJpbmcvc3ZnL1Jl bmRlclNWR1NoYXBlLmNwcDoKKyAgICAgICAgKiByZW5kZXJpbmcvc3ZnL1JlbmRlclNWR1NoYXBl Lmg6CisgICAgICAgIChSZW5kZXJTVkdTaGFwZSk6CisKKzIwMTItMDQtMjQgIEZsb3JpbiBNYWxp dGEgIDxmbWFsaXRhQGNocm9taXVtLm9yZz4KKwogICAgICAgICBXZWJDb3JlOjpFdmVudFRhcmdl dDo6YWRkRXZlbnRMaXN0ZW5lciBjcmFzaAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9ODQxNzEKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL3N2Zy9SZW5kZXJTVkdTaGFwZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv c3ZnL1JlbmRlclNWR1NoYXBlLmNwcAppbmRleCAyYjQ3ZWM5ZTFhY2QyNzU3NjlhMGUxZWJmYjg2 OTRkNTJmNTI3NDczLi5mYTdhZjVmNjAwNTNkNDEwMGU1ZDk2YTI5MmFlM2I2NWNiYmM2ODU5IDEw MDc1NQotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1JlbmRlclNWR1NoYXBlLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1JlbmRlclNWR1NoYXBlLmNwcApA QCAtNjIsMTMgKzYyLDYgQEAgUmVuZGVyU1ZHU2hhcGU6OlJlbmRlclNWR1NoYXBlKFNWR1N0eWxl ZFRyYW5zZm9ybWFibGVFbGVtZW50KiBub2RlKQogewogfQogCi1SZW5kZXJTVkdTaGFwZTo6UmVu ZGVyU1ZHU2hhcGUoU1ZHU3R5bGVkVHJhbnNmb3JtYWJsZUVsZW1lbnQqIG5vZGUsIFBhdGgqIHBh dGgsIGJvb2wgaXNGaWxsRmFsbGJhY2spCi0gICAgOiBSZW5kZXJTVkdNb2RlbE9iamVjdChub2Rl KQotICAgICwgbV9wYXRoKGFkb3B0UHRyKHBhdGgpKQotICAgICwgbV9maWxsRmFsbGJhY2soaXNG aWxsRmFsbGJhY2spCi17Ci19Ci0KIFJlbmRlclNWR1NoYXBlOjp+UmVuZGVyU1ZHU2hhcGUoKQog ewogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9SZW5kZXJTVkdT aGFwZS5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9SZW5kZXJTVkdTaGFwZS5oCmlu ZGV4IDkzNGEwNWQzOTUzMmE0ZWNiYWQyZTE4Y2NiNWU5MWZjNTY1OTYxZjEuLmFiOWIxY2I1YWFj NDI2MGVmYTlmZjM0NTdhZDYzMzNlYmVhMWYyZTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9zdmcvUmVuZGVyU1ZHU2hhcGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvc3ZnL1JlbmRlclNWR1NoYXBlLmgKQEAgLTE0NCw3ICsxNDQsNiBAQCBwcml2YXRlOgog ICAgIGJvb2wgbV9uZWVkc1NoYXBlVXBkYXRlIDogMTsKICAgICBib29sIG1fbmVlZHNUcmFuc2Zv cm1VcGRhdGUgOiAxOwogICAgIGJvb2wgbV9maWxsRmFsbGJhY2sgOiAxOwotICAgIGJvb2wgbV9z dHJva2VDb250YWluc0ZhbGxCYWNrIDogMTsKIH07CiAKIGlubGluZSBSZW5kZXJTVkdTaGFwZSog dG9SZW5kZXJTVkdTaGFwZShSZW5kZXJPYmplY3QqIG9iamVjdCkK