84744 2012-04-24 11:33:51 -0700 [BlackBerry] Perform spellcheck before handling TouchRelease event 2012-04-24 18:02:07 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 nima.ghanavatian nima.ghanavatian tonikitoo webkit.review.bot oldest_to_newest 608882 0 nima.ghanavatian 2012-04-24 11:33:51 -0700 After rebasing to master_35, it appears as though some code has been moved around. Here, we were handling the TouchReleased event before calling spellcheck. This meant that when we finally got the call to spellcheck, the fatFinger result had been reset and the spelling markers had been removed. In addition, based on https://bugs.webkit.org/show_bug.cgi?id=66330 I am also updating the BlackBerry specific documentMarkerContainingPoint to use LayoutPoint instead of IntPoint. 608895 1 138613 nima.ghanavatian 2012-04-24 11:41:49 -0700 Created attachment 138613 Patch 609330 2 138613 webkit.review.bot 2012-04-24 18:02:03 -0700 Comment on attachment 138613 Patch Clearing flags on attachment: 138613 Committed r115152: <http://trac.webkit.org/changeset/115152> 609331 3 webkit.review.bot 2012-04-24 18:02:07 -0700 All reviewed patches have been landed. Closing bug. 138613 2012-04-24 11:41:49 -0700 2012-04-24 18:02:03 -0700 Patch bug-84744-20120424143830.patch text/plain 4115 nima.ghanavatian U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0OTAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCBjNzJlZGEyNTE5ZWEwYmNjMzllNDIwNWE4MGFlODUyZGFiZWFmNGYyLi4xYzcwNTJmZTMz ZWQ3YzI3MDlhZTRhNzdjMDk0NGZjOGVkYzYzMDQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyOCBAQAorMjAxMi0wNC0yNCAgTmltYSBHaGFuYXZhdGlhbiAgPG5n aGFuYXZhdGlhbkByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBQZXJmb3JtIHNwZWxs Y2hlY2sgYmVmb3JlIGhhbmRsaW5nIFRvdWNoUmVsZWFzZSBldmVudAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODQ3NDQKKworICAgICAgICBBZnRlciBy ZWJhc2luZyB0byBtYXN0ZXJfMzUsIGl0IGFwcGVhcnMgYXMgdGhvdWdoIHNvbWUgY29kZSBoYWQg YmVlbiBtb3ZlZCBhcm91bmQuCisgICAgICAgIEhlcmUsIHdlIHdlcmUgaGFuZGxpbmcgdGhlIFRv dWNoUmVsZWFzZWQgZXZlbnQgYmVmb3JlIGNhbGxpbmcgc3BlbGxjaGVjay4gIFRoaXMKKyAgICAg ICAgbWVhbnQgdGhhdCB3aGVuIHdlIGZpbmFsbHkgZ290IHRoZSBjYWxsIHRvIHNwZWxsY2hlY2ss IHRoZSBmYXRGaW5nZXIgcmVzdWx0IGhhZCBiZWVuCisgICAgICAgIHJlc2V0IGFuZCB0aGUgc3Bl bGxpbmcgbWFya2VycyBoYWQgYmVlbiByZW1vdmVkLgorCisgICAgICAgIEluIGFkZGl0aW9uLCBi YXNlZCBvbiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjYzMzAKKyAg ICAgICAgSSBhbSBhbHNvIHVwZGF0aW5nIHRoZSBCbGFja0JlcnJ5IHNwZWNpZmljIGRvY3VtZW50 TWFya2VyQ29udGFpbmluZ1BvaW50IHRvIHVzZQorICAgICAgICBMYXlvdXRQb2ludCBpbnN0ZWFk IG9mIEludFBvaW50LgorCisgICAgICAgIEludGVybmFsbHkgcmV2aWV3ZWQgYnkgTWlrZSBGZW50 b24uCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBX ZWJLaXRTdXBwb3J0L1RvdWNoRXZlbnRIYW5kbGVyLmNwcDoKKyAgICAgICAgKEJsYWNrQmVycnk6 OldlYktpdDo6VG91Y2hFdmVudEhhbmRsZXI6OmhhbmRsZVRvdWNoUG9pbnQpOgorICAgICAgICAo QmxhY2tCZXJyeTo6V2ViS2l0OjpUb3VjaEV2ZW50SGFuZGxlcjo6c3BlbGxDaGVjayk6CisgICAg ICAgICogZG9tL0RvY3VtZW50TWFya2VyQ29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpEb2N1bWVudE1hcmtlckNvbnRyb2xsZXI6Om1hcmtlckNvbnRhaW5pbmdQb2ludCk6CisgICAg ICAgICogZG9tL0RvY3VtZW50TWFya2VyQ29udHJvbGxlci5oOgorCiAyMDEyLTA0LTIxICBCZW5q YW1pbiBDIE1leWVyICA8Ym1leWVyQHJpbS5jb20+CiAKICAgICAgICAgRG9uJ3QgaGFyZCBjb2Rl IHRoZSBwbHVnaW5zIHRoYXQgYmxhY2tiZXJyeSBzdXBwb3J0cy4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L1RvdWNoRXZlbnRIYW5kbGVyLmNwcCBi L1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L1RvdWNoRXZlbnRIYW5kbGVy LmNwcAppbmRleCBlMzZlYWY3NjhjY2Q1NzgzNzFmNDk4M2U4ZGI5MmM3NzU1ZmM0NTAxLi41MjVl M2I4YzgwMjBhMDJmYjNmZjcwODAyMGUzMmFjOTE0YmIzMTIwIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9Ub3VjaEV2ZW50SGFuZGxlci5jcHAKKysr IGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvVG91Y2hFdmVudEhhbmRs ZXIuY3BwCkBAIC0yMTUsNiArMjE1LDcgQEAgYm9vbCBUb3VjaEV2ZW50SGFuZGxlcjo6aGFuZGxl VG91Y2hQb2ludChQbGF0Zm9ybTo6VG91Y2hQb2ludCYgcG9pbnQpCiAgICAgICAgIH0KICAgICBj YXNlIFBsYXRmb3JtOjpUb3VjaFBvaW50OjpUb3VjaFJlbGVhc2VkOgogICAgICAgICB7CisgICAg ICAgICAgICB1bnNpZ25lZCBzcGVsbExlbmd0aCA9IHNwZWxsQ2hlY2socG9pbnQpOwogICAgICAg ICAgICAgLy8gQXBwbHkgYW55IHN1cHByZXNzZWQgY2hhbmdlcy4gVGhpcyBkb2VzIG5vdCBlbGlt aW5hdGUgdGhlIG5lZWQKICAgICAgICAgICAgIC8vIGZvciB0aGUgc2hvdyBhZnRlciB0aGUgaGFu ZGxpbmcgb2YgZmF0IGZpbmdlciBwcmVzc2VkIGFzIGl0IG1heQogICAgICAgICAgICAgLy8gaGF2 ZSB0cmlnZ2VyZWQgYSBzdGF0ZSBjaGFuZ2UuCkBAIC0yNDAsOCArMjQxLDYgQEAgYm9vbCBUb3Vj aEV2ZW50SGFuZGxlcjo6aGFuZGxlVG91Y2hQb2ludChQbGF0Zm9ybTo6VG91Y2hQb2ludCYgcG9p bnQpCiAgICAgICAgICAgICBQbGF0Zm9ybU1vdXNlRXZlbnQgbW91c2VFdmVudChhZGp1c3RlZFBv aW50LCBtX2xhc3RTY3JlZW5Qb2ludCwgUGxhdGZvcm1FdmVudDo6TW91c2VSZWxlYXNlZCwgMSwg TGVmdEJ1dHRvbiwgVG91Y2hTY3JlZW4pOwogICAgICAgICAgICAgbV93ZWJQYWdlLT5oYW5kbGVN b3VzZUV2ZW50KG1vdXNlRXZlbnQpOwogICAgICAgICAgICAgbV9sYXN0RmF0RmluZ2Vyc1Jlc3Vs dC5yZXNldCgpOyAvLyBSZXNldCB0aGUgZmF0IGZpbmdlciByZXN1bHQgYXMgaXRzIG5vIGxvbmdl ciB2YWxpZCB3aGVuIGEgdXNlcidzIGZpbmdlciBpcyBub3Qgb24gdGhlIHNjcmVlbi4KLQotICAg ICAgICAgICAgdW5zaWduZWQgc3BlbGxMZW5ndGggPSBzcGVsbENoZWNrKHBvaW50KTsKICAgICAg ICAgICAgIGlmIChzcGVsbExlbmd0aCkgewogICAgICAgICAgICAgICAgIHVuc2lnbmVkIGVuZCA9 IG1fd2ViUGFnZS0+bV9pbnB1dEhhbmRsZXItPmNhcmV0UG9zaXRpb24oKTsKICAgICAgICAgICAg ICAgICB1bnNpZ25lZCBzdGFydCA9IGVuZCAtIHNwZWxsTGVuZ3RoOwpAQCAtMjcyLDcgKzI3MSw3 IEBAIHVuc2lnbmVkIFRvdWNoRXZlbnRIYW5kbGVyOjpzcGVsbENoZWNrKFBsYXRmb3JtOjpUb3Vj aFBvaW50JiB0b3VjaFBvaW50KQogICAgIGlmICghbV9sYXN0RmF0RmluZ2Vyc1Jlc3VsdC5pc1Rl eHRJbnB1dCgpIHx8ICFlbGVtZW50VW5kZXJGYXRGaW5nZXIpCiAgICAgICAgIHJldHVybiAwOwog Ci0gICAgSW50UG9pbnQgY29udGVudFBvcyhtX3dlYlBhZ2UtPm1hcEZyb21WaWV3cG9ydFRvQ29u dGVudHModG91Y2hQb2ludC5tX3BvcykpOworICAgIExheW91dFBvaW50IGNvbnRlbnRQb3MobV93 ZWJQYWdlLT5tYXBGcm9tVmlld3BvcnRUb0NvbnRlbnRzKHRvdWNoUG9pbnQubV9wb3MpKTsKICAg ICBjb250ZW50UG9zID0gRE9NU3VwcG9ydDo6Y29udmVydFBvaW50VG9GcmFtZShtX3dlYlBhZ2Ut Pm1haW5GcmFtZSgpLCBtX3dlYlBhZ2UtPmZvY3VzZWRPck1haW5GcmFtZSgpLCBjb250ZW50UG9z KTsKIAogICAgIERvY3VtZW50KiBkb2N1bWVudCA9IGVsZW1lbnRVbmRlckZhdEZpbmdlci0+ZG9j dW1lbnQoKTsKQEAgLTI4Miw3ICsyODEsNyBAQCB1bnNpZ25lZCBUb3VjaEV2ZW50SGFuZGxlcjo6 c3BlbGxDaGVjayhQbGF0Zm9ybTo6VG91Y2hQb2ludCYgdG91Y2hQb2ludCkKICAgICAgICAgcmV0 dXJuIDA7CiAKICAgICBJbnRSZWN0IHJlY3QgPSBtYXJrZXItPnJlbmRlcmVkUmVjdCgpOwotICAg IEludFBvaW50IG5ld0NvbnRlbnRQb3MgPSBJbnRQb2ludChyZWN0LngoKSArIHJlY3Qud2lkdGgo KSwgcmVjdC55KCkgKyByZWN0LmhlaWdodCgpIC8gMik7CisgICAgTGF5b3V0UG9pbnQgbmV3Q29u dGVudFBvcyA9IExheW91dFBvaW50KHJlY3QueCgpICsgcmVjdC53aWR0aCgpLCByZWN0LnkoKSAr IHJlY3QuaGVpZ2h0KCkgLyAyKTsKICAgICBGcmFtZSogZnJhbWUgPSBtX3dlYlBhZ2UtPmZvY3Vz ZWRPck1haW5GcmFtZSgpOwogICAgIGlmIChmcmFtZSAhPSBtX3dlYlBhZ2UtPm1haW5GcmFtZSgp KQogICAgICAgICBuZXdDb250ZW50UG9zID0gbV93ZWJQYWdlLT5tYWluRnJhbWUoKS0+dmlldygp LT53aW5kb3dUb0NvbnRlbnRzKGZyYW1lLT52aWV3KCktPmNvbnRlbnRzVG9XaW5kb3cobmV3Q29u dGVudFBvcykpOwo=