84728 2012-04-24 07:55:54 -0700 [BlackBerry] Add additional details including the bounds of the box for caretPositionChanged. 2012-04-24 09:06:01 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mifenton mifenton tonikitoo webkit.review.bot oldest_to_newest 608663 0 mifenton 2012-04-24 07:55:54 -0700 SSIA. 608701 1 138568 mifenton 2012-04-24 08:33:26 -0700 Created attachment 138568 Patch 608734 2 138568 webkit.review.bot 2012-04-24 09:05:47 -0700 Comment on attachment 138568 Patch Clearing flags on attachment: 138568 Committed r115066: <http://trac.webkit.org/changeset/115066> 608737 3 webkit.review.bot 2012-04-24 09:06:01 -0700 All reviewed patches have been landed. Closing bug. 138568 2012-04-24 08:33:26 -0700 2012-04-24 09:05:46 -0700 Patch 0001-2012-04-23-Mike-Fenton-mifenton-rim.com.patch text/plain 7283 mifenton RnJvbSAzYmQwYmU1YmZjZjk3MmNkYjM5ZmY0NmE5ZWI5YWFmZDlhZTA5YWZhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWtlIEZlbnRvbiA8bWlmZW50b25AcmltLmNvbT4KRGF0ZTog TW9uLCAyMyBBcHIgMjAxMiAxMzoyODoxMyAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIDIwMTItMDQt MjMgIE1pa2UgRmVudG9uICA8bWlmZW50b25AcmltLmNvbT4KCiAgICAgICAgUFIgMTM4OTg4LgoK ICAgICAgICBVcGRhdGUgY2FyZXRQb3NpdGlvbkNoYW5nZWQgdG8gaW5jbHVkZSB0aGUgbGltaXQg b2YgdGhlIGlucHV0IGZpZWxkCiAgICAgICAgZm9yIHNpbmdsZSBsaW5lIGlucHV0cy4KCiAgICAg ICAgUmV2aWV3ZWQgSW50ZXJuYWxseSBieSBHZW4gTWFrLgoKICAgICAgICAqIEFwaS9XZWJQYWdl Q2xpZW50Lmg6CiAgICAgICAgKiBXZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxlci5jcHA6CiAgICAg ICAgKEJsYWNrQmVycnk6OldlYktpdDo6SW5wdXRIYW5kbGVyOjpib3VuZGluZ0JveEZvcklucHV0 RmllbGQpOgogICAgICAgIChXZWJLaXQpOgogICAgICAgICogV2ViS2l0U3VwcG9ydC9JbnB1dEhh bmRsZXIuaDoKICAgICAgICAoSW5wdXRIYW5kbGVyKToKICAgICAgICAqIFdlYktpdFN1cHBvcnQv U2VsZWN0aW9uSGFuZGxlci5jcHA6CiAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6U2VsZWN0 aW9uSGFuZGxlcjo6Y2xpcHBpbmdSZWN0Rm9yVmlzaWJsZUNvbnRlbnQpOgogICAgICAgIChCbGFj a0JlcnJ5OjpXZWJLaXQ6OlNlbGVjdGlvbkhhbmRsZXI6OmNhcmV0UG9zaXRpb25DaGFuZ2VkKToK LS0tCiBTb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2VDbGllbnQuaCAgICAgICB8 ICAgIDIgKy0KIFNvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgICAgICAgICAgICAg ICAgIHwgICAyNCArKysrKysrKysrKysrKysrKysrKwogLi4uL2JsYWNrYmVycnkvV2ViS2l0U3Vw cG9ydC9JbnB1dEhhbmRsZXIuY3BwICAgICAgfCAgIDExICsrKysrKysrKwogLi4uL1dlYktpdC9i bGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvSW5wdXRIYW5kbGVyLmggfCAgICAyICsKIC4uLi9ibGFj a2JlcnJ5L1dlYktpdFN1cHBvcnQvU2VsZWN0aW9uSGFuZGxlci5jcHAgIHwgICAxNyArKysrKysr LS0tLS0tCiA1IGZpbGVzIGNoYW5nZWQsIDQ3IGluc2VydGlvbnMoKyksIDkgZGVsZXRpb25zKC0p CgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlQ2xpZW50 LmggYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2VDbGllbnQuaAppbmRleCA5 YzMzYWYwLi5kNzlmNGUyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBp L1dlYlBhZ2VDbGllbnQuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBh Z2VDbGllbnQuaApAQCAtMTQ5LDcgKzE0OSw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQg bm90aWZ5U2VsZWN0aW9uRGV0YWlsc0NoYW5nZWQoY29uc3QgUGxhdGZvcm06OkludFJlY3QmIHN0 YXJ0LCBjb25zdCBQbGF0Zm9ybTo6SW50UmVjdCYgZW5kLCBjb25zdCBQbGF0Zm9ybTo6SW50UmVj dFJlZ2lvbiYpID0gMDsKICAgICB2aXJ0dWFsIHZvaWQgY2FuY2VsU2VsZWN0aW9uVmlzdWFscygp ID0gMDsKICAgICB2aXJ0dWFsIHZvaWQgbm90aWZ5U2VsZWN0aW9uSGFuZGxlc1JldmVyc2VkKCkg PSAwOwotICAgIHZpcnR1YWwgdm9pZCBub3RpZnlDYXJldENoYW5nZWQoY29uc3QgUGxhdGZvcm06 OkludFJlY3QmIGNhcmV0LCBib29sIHVzZXJUb3VjaFRyaWdnZXJlZCkgPSAwOworICAgIHZpcnR1 YWwgdm9pZCBub3RpZnlDYXJldENoYW5nZWQoY29uc3QgUGxhdGZvcm06OkludFJlY3QmIGNhcmV0 LCBib29sIHVzZXJUb3VjaFRyaWdnZXJlZCwgYm9vbCBzaW5nbGVMaW5lSW5wdXQgPSBmYWxzZSwg Y29uc3QgUGxhdGZvcm06OkludFJlY3QmIHNpbmdsZUxpbmVCb3VuZGluZ0JveCA9IFBsYXRmb3Jt OjpJbnRSZWN0KCkpID0gMDsKIAogICAgIHZpcnR1YWwgdm9pZCBjdXJzb3JDaGFuZ2VkKFBsYXRm b3JtOjpDdXJzb3JUeXBlLCBjb25zdCBjaGFyKiB1cmwsIGludCB4LCBpbnQgeSkgPSAwOwogCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwppbmRleCBkOTM4NDk5Li5jNTI2MDMyIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJL aXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNyBAQAorMjAxMi0wNC0yNCAgTWlr ZSBGZW50b24gIDxtaWZlbnRvbkByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBBZGQg YWRkaXRpb25hbCBkZXRhaWxzIGluY2x1ZGluZyB0aGUgYm91bmRzIG9mIHRoZSBib3ggZm9yIGNh cmV0UG9zaXRpb25DaGFuZ2VkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9ODQ3MjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBQUiAxMzg5ODguCisKKyAgICAgICAgVXBkYXRlIGNhcmV0UG9zaXRpb25DaGFu Z2VkIHRvIGluY2x1ZGUgdGhlIGxpbWl0IG9mIHRoZSBpbnB1dCBmaWVsZAorICAgICAgICBmb3Ig c2luZ2xlIGxpbmUgaW5wdXRzLgorCisgICAgICAgIFJldmlld2VkIEludGVybmFsbHkgYnkgR2Vu IE1hay4KKworICAgICAgICAqIEFwaS9XZWJQYWdlQ2xpZW50Lmg6CisgICAgICAgICogV2ViS2l0 U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpJ bnB1dEhhbmRsZXI6OmJvdW5kaW5nQm94Rm9ySW5wdXRGaWVsZCk6CisgICAgICAgIChXZWJLaXQp OgorICAgICAgICAqIFdlYktpdFN1cHBvcnQvSW5wdXRIYW5kbGVyLmg6CisgICAgICAgIChJbnB1 dEhhbmRsZXIpOgorICAgICAgICAqIFdlYktpdFN1cHBvcnQvU2VsZWN0aW9uSGFuZGxlci5jcHA6 CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OlNlbGVjdGlvbkhhbmRsZXI6OmNsaXBwaW5n UmVjdEZvclZpc2libGVDb250ZW50KToKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6U2Vs ZWN0aW9uSGFuZGxlcjo6Y2FyZXRQb3NpdGlvbkNoYW5nZWQpOgorCiAyMDEyLTA0LTIzICBDaGFy bGVzIFdlaSAgPGNoYXJsZXMud2VpQHRvcmNobW9iaWxlLmNvbS5jbj4KIAogICAgICAgICBbQmxh Y2tCZXJyeV0gQnVpbGQgZmFpbHVyZSB3aGVuIERFQlVHX0ZBVF9GSU5HRVIgaXMgZW5hYmxlZApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvSW5wdXRI YW5kbGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0lucHV0 SGFuZGxlci5jcHAKaW5kZXggMDkxNWNkOS4uYWNiYTdmMCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvSW5wdXRIYW5kbGVyLmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3BwCkBAIC01 MzcsNiArNTM3LDE3IEBAIHZvaWQgSW5wdXRIYW5kbGVyOjpub2RlVGV4dENoYW5nZWQoY29uc3Qg Tm9kZSogbm9kZSkKICAgICByZW1vdmVBdHRyaWJ1dGVkVGV4dE1hcmtlcigpOwogfQogCitXZWJD b3JlOjpJbnRSZWN0IElucHV0SGFuZGxlcjo6Ym91bmRpbmdCb3hGb3JJbnB1dEZpZWxkKCkKK3sK KyAgICBpZiAoIWlzQWN0aXZlVGV4dEVkaXQoKSkKKyAgICAgICAgcmV0dXJuIFdlYkNvcmU6Oklu dFJlY3QoKTsKKworICAgIGlmICghbV9jdXJyZW50Rm9jdXNFbGVtZW50LT5yZW5kZXJlcigpKQor ICAgICAgICByZXR1cm4gV2ViQ29yZTo6SW50UmVjdCgpOworCisgICAgcmV0dXJuIG1fY3VycmVu dEZvY3VzRWxlbWVudC0+cmVuZGVyZXIoKS0+YWJzb2x1dGVCb3VuZGluZ0JveFJlY3QoKTsKK30K Kwogdm9pZCBJbnB1dEhhbmRsZXI6OmVuc3VyZUZvY3VzVGV4dEVsZW1lbnRWaXNpYmxlKENhcmV0 U2Nyb2xsVHlwZSBzY3JvbGxUeXBlKQogewogICAgIGlmICghbV9pbnB1dE1vZGVFbmFibGVkIHx8 ICFtX2N1cnJlbnRGb2N1c0VsZW1lbnQgfHwgIW1fY3VycmVudEZvY3VzRWxlbWVudC0+ZG9jdW1l bnQoKSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0 L0lucHV0SGFuZGxlci5oIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQv SW5wdXRIYW5kbGVyLmgKaW5kZXggZDM0NTQwYS4uNzlhYzU2NyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvSW5wdXRIYW5kbGVyLmgKKysrIGIvU291 cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvSW5wdXRIYW5kbGVyLmgKQEAgLTEw Miw2ICsxMDIsOCBAQCBwdWJsaWM6CiAKICAgICBXVEY6OlN0cmluZyBlbGVtZW50VGV4dCgpOwog CisgICAgV2ViQ29yZTo6SW50UmVjdCBib3VuZGluZ0JveEZvcklucHV0RmllbGQoKTsKKwogICAg IC8vIElNRiBkcml2ZW4gY2FsbHMuCiAgICAgYm9vbCBzZXRCYXRjaEVkaXRpbmdBY3RpdmUoYm9v bCk7CiAgICAgYm9vbCBzZXRTZWxlY3Rpb24oaW50IHN0YXJ0LCBpbnQgZW5kLCBib29sIGNoYW5n ZUlzUGFydE9mQ29tcG9zaXRpb24gPSBmYWxzZSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9TZWxlY3Rpb25IYW5kbGVyLmNwcCBiL1NvdXJjZS9X ZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L1NlbGVjdGlvbkhhbmRsZXIuY3BwCmluZGV4 IGVhYWRlNDQuLmIxMTRhYmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9X ZWJLaXRTdXBwb3J0L1NlbGVjdGlvbkhhbmRsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxh Y2tiZXJyeS9XZWJLaXRTdXBwb3J0L1NlbGVjdGlvbkhhbmRsZXIuY3BwCkBAIC05OCwyMCArOTgs MTggQEAgV2ViQ29yZTo6SW50UmVjdCBTZWxlY3Rpb25IYW5kbGVyOjpjbGlwcGluZ1JlY3RGb3JW aXNpYmxlQ29udGVudCgpIGNvbnN0CiB7CiAgICAgLy8gR2V0IHRoZSBjb250YWluaW5nIGNvbnRl bnQgcmVjdCBmb3IgdGhlIGZyYW1lLgogICAgIEZyYW1lKiBmcmFtZSA9IG1fd2ViUGFnZS0+Zm9j dXNlZE9yTWFpbkZyYW1lKCk7Ci0gICAgV2ViQ29yZTo6SW50UmVjdCBjbGlwUmVjdCA9IFdlYkNv cmU6OkludFJlY3QoLTEsIC0xLCAwLCAwKTsKKyAgICBXZWJDb3JlOjpJbnRSZWN0IGNsaXBSZWN0 ID0gV2ViQ29yZTo6SW50UmVjdChXZWJDb3JlOjpJbnRQb2ludCgwLCAwKSwgbV93ZWJQYWdlLT5j b250ZW50c1NpemUoKSk7CiAgICAgaWYgKGZyYW1lICE9IG1fd2ViUGFnZS0+bWFpbkZyYW1lKCkp IHsKICAgICAgICAgY2xpcFJlY3QgPSBtX3dlYlBhZ2UtPmdldFJlY3Vyc2l2ZVZpc2libGVXaW5k b3dSZWN0KGZyYW1lLT52aWV3KCksIHRydWUgLyogbm8gY2xpcCB0byBtYWluIGZyYW1lIHdpbmRv dyAqLyk7CiAgICAgICAgIGNsaXBSZWN0ID0gbV93ZWJQYWdlLT5tX21haW5GcmFtZS0+dmlldygp LT53aW5kb3dUb0NvbnRlbnRzKGNsaXBSZWN0KTsKICAgICB9CiAKICAgICAvLyBHZXQgdGhlIGlu cHV0IGZpZWxkIGNvbnRhaW5pbmcgYm94LgotICAgIGlmIChtX3dlYlBhZ2UtPm1faW5wdXRIYW5k bGVyLT5pc0lucHV0TW9kZSgpCi0gICAgICAgICYmIGZyYW1lLT5kb2N1bWVudCgpLT5mb2N1c2Vk Tm9kZSgpCi0gICAgICAgICYmIGZyYW1lLT5kb2N1bWVudCgpLT5mb2N1c2VkTm9kZSgpLT5yZW5k ZXJlcigpKSB7Ci0KKyAgICBXZWJDb3JlOjpJbnRSZWN0IGlucHV0Qm91bmRpbmdCb3ggPSBtX3dl YlBhZ2UtPm1faW5wdXRIYW5kbGVyLT5ib3VuZGluZ0JveEZvcklucHV0RmllbGQoKTsKKyAgICBp ZiAoIWlucHV0Qm91bmRpbmdCb3guaXNFbXB0eSgpKSB7CiAgICAgICAgIC8vIEFkanVzdCB0aGUg Ym91bmRpbmcgYm94IHRvIHRoZSBmcmFtZSBvZmZzZXQuCi0gICAgICAgIGNsaXBSZWN0ID0gZnJh bWUtPmRvY3VtZW50KCktPmZvY3VzZWROb2RlKCktPnJlbmRlcmVyKCktPmFic29sdXRlQm91bmRp bmdCb3hSZWN0KCk7Ci0gICAgICAgIGNsaXBSZWN0ID0gbV93ZWJQYWdlLT5tYWluRnJhbWUoKS0+ dmlldygpLT53aW5kb3dUb0NvbnRlbnRzKGZyYW1lLT52aWV3KCktPmNvbnRlbnRzVG9XaW5kb3co Y2xpcFJlY3QpKTsKKyAgICAgICAgaW5wdXRCb3VuZGluZ0JveCA9IG1fd2ViUGFnZS0+bWFpbkZy YW1lKCktPnZpZXcoKS0+d2luZG93VG9Db250ZW50cyhmcmFtZS0+dmlldygpLT5jb250ZW50c1Rv V2luZG93KGlucHV0Qm91bmRpbmdCb3gpKTsKKyAgICAgICAgY2xpcFJlY3QuaW50ZXJzZWN0KGlu cHV0Qm91bmRpbmdCb3gpOwogICAgIH0KICAgICByZXR1cm4gY2xpcFJlY3Q7CiB9CkBAIC05NjAs NyArOTU4LDEwIEBAIHZvaWQgU2VsZWN0aW9uSGFuZGxlcjo6Y2FyZXRQb3NpdGlvbkNoYW5nZWQo KQogICAgIGNhcmV0TG9jYXRpb24gPSBtX3dlYlBhZ2UtPm1hcFRvVHJhbnNmb3JtZWQoY2FyZXRM b2NhdGlvbik7CiAgICAgbV93ZWJQYWdlLT5jbGlwVG9UcmFuc2Zvcm1lZENvbnRlbnRzUmVjdChj YXJldExvY2F0aW9uKTsKIAotICAgIG1fd2ViUGFnZS0+bV9jbGllbnQtPm5vdGlmeUNhcmV0Q2hh bmdlZChjYXJldExvY2F0aW9uLCBtX3dlYlBhZ2UtPm1fdG91Y2hFdmVudEhhbmRsZXItPmxhc3RG YXRGaW5nZXJzUmVzdWx0KCkuaXNUZXh0SW5wdXQoKSAvKiB1c2VyVG91Y2hUcmlnZ2VyZWQgKi8p OworICAgIGJvb2wgc2luZ2xlTGluZUlucHV0ID0gIW1fd2ViUGFnZS0+bV9pbnB1dEhhbmRsZXIt PmlzTXVsdGlsaW5lSW5wdXRNb2RlKCk7CisgICAgV2ViQ29yZTo6SW50UmVjdCBub2RlQm91bmRp bmdCb3ggPSBzaW5nbGVMaW5lSW5wdXQgPyBtX3dlYlBhZ2UtPm1faW5wdXRIYW5kbGVyLT5ib3Vu ZGluZ0JveEZvcklucHV0RmllbGQoKSA6IFdlYkNvcmU6OkludFJlY3QoKTsKKworICAgIG1fd2Vi UGFnZS0+bV9jbGllbnQtPm5vdGlmeUNhcmV0Q2hhbmdlZChjYXJldExvY2F0aW9uLCBtX3dlYlBh Z2UtPm1fdG91Y2hFdmVudEhhbmRsZXItPmxhc3RGYXRGaW5nZXJzUmVzdWx0KCkuaXNUZXh0SW5w dXQoKSAvKiB1c2VyVG91Y2hUcmlnZ2VyZWQgKi8sIHNpbmdsZUxpbmVJbnB1dCwgbm9kZUJvdW5k aW5nQm94KTsKIH0KIAogYm9vbCBTZWxlY3Rpb25IYW5kbGVyOjpzZWxlY3Rpb25Db250YWlucyhj b25zdCBXZWJDb3JlOjpJbnRQb2ludCYgcG9pbnQpCi0tIAoxLjcuNS40Cgo=