84713 2012-04-24 05:40:46 -0700 [TestResultsServer] Add a unit test for changes in r114868 2012-04-24 12:28:34 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan ojan webkit.review.bot oldest_to_newest 608578 0 zan 2012-04-24 05:40:46 -0700 A unit test is required for changes in r114868, covered by bug #84544. 608585 1 138545 zan 2012-04-24 05:54:17 -0700 Created attachment 138545 Patch 608860 2 138545 ojan 2012-04-24 11:11:23 -0700 Comment on attachment 138545 Patch Thanks! As part of trying to get better test coverage, I've started requiring tests for all changes. :) 608937 3 138545 webkit.review.bot 2012-04-24 12:28:25 -0700 Comment on attachment 138545 Patch Clearing flags on attachment: 138545 Committed r115094: <http://trac.webkit.org/changeset/115094> 608938 4 webkit.review.bot 2012-04-24 12:28:34 -0700 All reviewed patches have been landed. Closing bug. 138545 2012-04-24 05:54:17 -0700 2012-04-24 12:28:25 -0700 Patch bug-84713-20120424145415.patch text/plain 2704 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1MDMyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzk5MzVjNTUxYzg4NThhODhjOWM4N2I5ZjE3Yjc3MTk5 ZmM3ZmRhNy4uNjU3OTViOWE3YTBjMmE0ZjBlZjU0NTdkM2FjOWZiNzFmYjQ3ZjgyMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDEyLTA0LTI0ICBaYW4gRG9iZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CisK KyAgICAgICAgW1Rlc3RSZXN1bHRzU2VydmVyXSBBZGQgYSB1bml0IHRlc3QgZm9yIGNoYW5nZXMg aW4gcjExNDg2OAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9ODQ3MTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBZGQgYSBuZXcgdW5pdCB0ZXN0IHRvIHRlc3QgdGhlIGlzVG9UV2ViS2l0IGF0dHJpYnV0ZSBv ZiBhIEJ1aWxkZXJHcm91cCBvYmplY3QKKyAgICAgICAgdGhhdCBpcyBjcmVhdGVkIGZvciBlaXRo ZXIgREVQUyBvciBUb1QgYnVpbGRlciBncm91cHMuIFRoZSB1bml0IHRlc3QgY292ZXJzIGNoYW5n ZXMKKyAgICAgICAgbWFkZSBpbiByMTE0ODY4LgorCisgICAgICAgICogVGVzdFJlc3VsdFNlcnZl ci9zdGF0aWMtZGFzaGJvYXJkcy9mbGFraW5lc3NfZGFzaGJvYXJkX3VuaXR0ZXN0cy5qczoKKyAg ICAgICAgKHRlc3RCdWlsZGVyR3JvdXBJc1RvVFdlYktpdEF0dHJpYnV0ZS5nX2hhbmRsZUJ1aWxk ZXJzTGlzdExvYWRlZCk6CisgICAgICAgICh0ZXN0QnVpbGRlckdyb3VwSXNUb1RXZWJLaXRBdHRy aWJ1dGUuYXNzZXJ0RXF1YWxzKToKKwogMjAxMi0wNC0yMyAgRXJpcSBBdWd1c3RpbmUgIDxlYXVn dXN0aUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV0dXJuIHZhbHVlIGZyb20gZXhlY3V0ZWQg c2NyaXB0IGluIENocm9taXVtLgpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFJlc3VsdFNlcnZlci9z dGF0aWMtZGFzaGJvYXJkcy9mbGFraW5lc3NfZGFzaGJvYXJkX3VuaXR0ZXN0cy5qcyBiL1Rvb2xz L1Rlc3RSZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvZmxha2luZXNzX2Rhc2hib2FyZF91 bml0dGVzdHMuanMKaW5kZXggMzAyNjUyNTY5ODE1ZTUzMzE4ZjA5NzA5ZjE0Nzk1OGZlNWNhZGYw ZC4uZDMyZDE2YzQyODdiNjZmNzFiZjdjMjUyOGI3MDgzZmNjZGIwY2E4OSAxMDA2NDQKLS0tIGEv VG9vbHMvVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9mbGFraW5lc3NfZGFzaGJv YXJkX3VuaXR0ZXN0cy5qcworKysgYi9Ub29scy9UZXN0UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNo Ym9hcmRzL2ZsYWtpbmVzc19kYXNoYm9hcmRfdW5pdHRlc3RzLmpzCkBAIC02NDUsNiArNjQ1LDI2 IEBAIGZ1bmN0aW9uIHRlc3RBZGRCdWlsZGVyTG9hZEVycm9ycygpCiAgICAgYXNzZXJ0RXF1YWxz KGdfZXJyb3JNZXNzYWdlcywgJ0VSUk9SOiBGYWlsZWQgdG8gZ2V0IGRhdGEgZnJvbSBidWlsZGVy MSxidWlsZGVyMi48YnI+RVJST1I6IERhdGEgZnJvbSBzdGFsZUJ1aWxkZXIxIGlzIG1vcmUgdGhh biAxIGRheSBzdGFsZS48YnI+Jyk7CiB9CiAKK2Z1bmN0aW9uIHRlc3RCdWlsZGVyR3JvdXBJc1Rv VFdlYktpdEF0dHJpYnV0ZSgpCit7CisgICAgdmFyIGR1bW15TWFzdGVyID0gbmV3IEJ1aWxkZXJN YXN0ZXIoJ2R1bW15Lm9yZycsICdodHRwOi8vYnVpbGQuZHVtbXkub3JnJyk7CisgICAgdmFyIHRl c3RCdWlsZGVyR3JvdXBzID0geworICAgICAgICAnQFRvVCAtIGR1bW15Lm9yZyc6IG51bGwsCisg ICAgICAgICdAREVQUyAtIGR1bW15Lm9yZyc6IG51bGwsCisgICAgfQorICAgIHZhciB0ZXN0SlNP TkRhdGEgPSAieyBcIkR1bW15IEJ1aWxkZXIgMVwiOiBudWxsLCBcIkR1bW15IEJ1aWxkZXIgMlwi OiBudWxsIH0iOworCisgICAgLy8gT3ZlcnJpZGUgZ19oYW5kbGVCdWlsZGVyc0xpc3RMb2FkZWQg dG8gYXZvaWQgZW50ZXJpbmcgYW4gaW5maW5pdGUgcmVjdXJzaW9uCisgICAgLy8gYXMgdGhlIGJ1 aWxkZXIgbGlzdHMgYXJlIGJlaW5nIGxvYWRlZCB3aXRoIGR1bW15IGRhdGEuCisgICAgZ19oYW5k bGVCdWlsZGVyc0xpc3RMb2FkZWQgPSBmdW5jdGlvbigpIHsgfQorCisgICAgb25CdWlsZGVyTGlz dExvYWQodGVzdEJ1aWxkZXJHcm91cHMsICBmdW5jdGlvbigpIHsgcmV0dXJuIHRydWU7IH0sIGR1 bW15TWFzdGVyLCAnQFRvVCAtIGR1bW15Lm9yZycsIEJ1aWxkZXJHcm91cC5UT1RfV0VCS0lULCBK U09OLnBhcnNlKHRlc3RKU09ORGF0YSkpOworICAgIGFzc2VydEVxdWFscyh0ZXN0QnVpbGRlckdy b3Vwc1snQFRvVCAtIGR1bW15Lm9yZyddLmlzVG9UV2ViS2l0LCB0cnVlKTsKKworICAgIG9uQnVp bGRlckxpc3RMb2FkKHRlc3RCdWlsZGVyR3JvdXBzLCAgZnVuY3Rpb24oKSB7IHJldHVybiB0cnVl OyB9LCBkdW1teU1hc3RlciwgJ0BERVBTIC0gZHVtbXkub3JnJywgQnVpbGRlckdyb3VwLkRFUFNf V0VCS0lULCBKU09OLnBhcnNlKHRlc3RKU09ORGF0YSkpOworICAgIGFzc2VydEVxdWFscyh0ZXN0 QnVpbGRlckdyb3Vwc1snQERFUFMgLSBkdW1teS5vcmcnXS5pc1RvVFdlYktpdCwgZmFsc2UpOwor fQorCiBmdW5jdGlvbiBodG1sRXNjYXBlKHN0cmluZykKIHsKICAgICB2YXIgZGl2ID0gZG9jdW1l bnQuY3JlYXRlRWxlbWVudCgnZGl2Jyk7Cg==