84711 2012-04-24 05:18:36 -0700 Rename CSSStyleApplyProperty class to StyleBuilder. 2012-04-24 06:28:19 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 menard menard kling koivisto macpherson webkit.review.bot oldest_to_newest 608566 0 menard 2012-04-24 05:18:36 -0700 Rename CSSStyleApplyProperty class to StyleBuilder. 608567 1 138539 menard 2012-04-24 05:20:48 -0700 Created attachment 138539 Patch 608600 2 138539 menard 2012-04-24 06:28:13 -0700 Comment on attachment 138539 Patch Clearing flags on attachment: 138539 Committed r115043: <http://trac.webkit.org/changeset/115043> 608601 3 menard 2012-04-24 06:28:19 -0700 All reviewed patches have been landed. Closing bug. 138539 2012-04-24 05:20:48 -0700 2012-04-24 06:28:12 -0700 Patch bug-84711-20120424092031.patch text/plain 7125 menard U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1MDMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmQ5ODQwMGIyYTc3MmI0 MGNlYWNmZjc3ZTk1OWQ5NjczNzc4YWQ5ZS4uMzg0ZDlkMzdmZDIwMWJkMGMyNDI0ZTNlZmE5NDI4 YjRjODRhMmQzMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMyIEBACisyMDEyLTA0LTI0ICBBbGV4 aXMgTWVuYXJkICA8YWxleGlzLm1lbmFyZEBvcGVuYm9zc2Eub3JnPgorCisgICAgICAgIFJlbmFt ZSBDU1NTdHlsZUFwcGx5UHJvcGVydHkgY2xhc3MgdG8gU3R5bGVCdWlsZGVyLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODQ3MTEKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBcyBwZXIgZGlzY3Vzc2lvbiBv biBidWcgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQyNzY0CisgICAg ICAgIHRoZSBuYW1lIGlzIGEgYml0IGNvbmZ1c2luZy4gVGhpcyBmaXJzdCBwYXRjaCByZW5hbWUg dGhlIGNsYXNzIGFuZCBhCisgICAgICAgIGZvbGxvd2luZyBvbmUgd2lsbCByZW5hbWUgdGhlIGZp bGVzLiBXZSBhbHNvIGRyb3AgdGhlIENTUyBwcmVmaXggb2YgdGhlCisgICAgICAgIGNsYXNzIHRv IGtlZXAgQ1NTIHByZWZpeGVkIGNsYXNzZXMgZm9yIENTU09NIHR5cGVzLgorCisgICAgICAgIE5v IG5ldyB0ZXN0cyA6IHJlbmFtaW5nLCBubyBiZWhhdmlvciBjaGFuZ2VzIHNob3VsZCBhcHBlYXIu CisKKyAgICAgICAgKiBjc3MvQ1NTU3R5bGVBcHBseVByb3BlcnR5LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkFwcGx5UHJvcGVydHlFeHBhbmRpbmc6OmFwcGx5SW5oZXJpdFZhbHVlKToKKyAgICAg ICAgKFdlYkNvcmU6OkFwcGx5UHJvcGVydHlFeHBhbmRpbmc6OmFwcGx5SW5pdGlhbFZhbHVlKToK KyAgICAgICAgKFdlYkNvcmU6OkFwcGx5UHJvcGVydHlFeHBhbmRpbmc6OmFwcGx5VmFsdWUpOgor ICAgICAgICAoV2ViQ29yZTo6U3R5bGVCdWlsZGVyOjpzaGFyZWRTdHlsZUJ1aWxkZXIpOgorICAg ICAgICAoV2ViQ29yZTo6U3R5bGVCdWlsZGVyOjpTdHlsZUJ1aWxkZXIpOgorICAgICAgICAqIGNz cy9DU1NTdHlsZUFwcGx5UHJvcGVydHkuaDoKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAo U3R5bGVCdWlsZGVyKToKKyAgICAgICAgKiBjc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpDU1NTdHlsZVNlbGVjdG9yOjpDU1NTdHlsZVNlbGVjdG9yKToKKyAgICAg ICAgKFdlYkNvcmU6OkNTU1N0eWxlU2VsZWN0b3I6OmNvbGxlY3RNYXRjaGluZ1J1bGVzRm9yTGlz dCk6CisgICAgICAgICogY3NzL0NTU1N0eWxlU2VsZWN0b3IuaDoKKyAgICAgICAgKENTU1N0eWxl U2VsZWN0b3IpOgorCiAyMDEyLTA0LTI0ICBQYXZlbCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IHJlbW92ZSBwdXJlIGRlbGVnYXRpb24g Y29kZSBmcm9tIERlYnVnZ2VyUHJlc2VudGF0aW9uTW9kZWwKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2Nzcy9DU1NTdHlsZUFwcGx5UHJvcGVydHkuY3BwIGIvU291cmNlL1dlYkNvcmUvY3Nz L0NTU1N0eWxlQXBwbHlQcm9wZXJ0eS5jcHAKaW5kZXggZmU4NTAzODk0N2Q4YzcxY2NlNzU2ZDgy MmI1NGQyZGQxMTgzNWMyNi4uMDMwZTlkZjM3MWM0YzcxNjNlMGY1YmJlNTYzOGVlMjgyZWM0ZTll ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1N0eWxlQXBwbHlQcm9wZXJ0eS5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1N0eWxlQXBwbHlQcm9wZXJ0eS5jcHAKQEAg LTU4LDcgKzU4LDcgQEAgcHVibGljOgogICAgICAgICBpZiAoaWQgPT0gQ1NTUHJvcGVydHlJbnZh bGlkKQogICAgICAgICAgICAgcmV0dXJuOwogCi0gICAgICAgIGNvbnN0IENTU1N0eWxlQXBwbHlQ cm9wZXJ0eSYgdGFibGUgPSBDU1NTdHlsZUFwcGx5UHJvcGVydHk6OnNoYXJlZENTU1N0eWxlQXBw bHlQcm9wZXJ0eSgpOworICAgICAgICBjb25zdCBTdHlsZUJ1aWxkZXImIHRhYmxlID0gU3R5bGVC dWlsZGVyOjpzaGFyZWRTdHlsZUJ1aWxkZXIoKTsKICAgICAgICAgY29uc3QgUHJvcGVydHlIYW5k bGVyJiBoYW5kbGVyID0gdGFibGUucHJvcGVydHlIYW5kbGVyKGlkKTsKICAgICAgICAgaWYgKGhh bmRsZXIuaXNWYWxpZCgpKQogICAgICAgICAgICAgaGFuZGxlci5hcHBseUluaGVyaXRWYWx1ZShz ZWxlY3Rvcik7CkBAIC03OSw3ICs3OSw3IEBAIHB1YmxpYzoKICAgICAgICAgaWYgKGlkID09IENT U1Byb3BlcnR5SW52YWxpZCkKICAgICAgICAgICAgIHJldHVybjsKIAotICAgICAgICBjb25zdCBD U1NTdHlsZUFwcGx5UHJvcGVydHkmIHRhYmxlID0gQ1NTU3R5bGVBcHBseVByb3BlcnR5OjpzaGFy ZWRDU1NTdHlsZUFwcGx5UHJvcGVydHkoKTsKKyAgICAgICAgY29uc3QgU3R5bGVCdWlsZGVyJiB0 YWJsZSA9IFN0eWxlQnVpbGRlcjo6c2hhcmVkU3R5bGVCdWlsZGVyKCk7CiAgICAgICAgIGNvbnN0 IFByb3BlcnR5SGFuZGxlciYgaGFuZGxlciA9IHRhYmxlLnByb3BlcnR5SGFuZGxlcihpZCk7CiAg ICAgICAgIGlmIChoYW5kbGVyLmlzVmFsaWQoKSkKICAgICAgICAgICAgIGhhbmRsZXIuYXBwbHlJ bml0aWFsVmFsdWUoc2VsZWN0b3IpOwpAQCAtMTAwLDcgKzEwMCw3IEBAIHB1YmxpYzoKICAgICAg ICAgaWYgKGlkID09IENTU1Byb3BlcnR5SW52YWxpZCkKICAgICAgICAgICAgIHJldHVybjsKIAot ICAgICAgICBjb25zdCBDU1NTdHlsZUFwcGx5UHJvcGVydHkmIHRhYmxlID0gQ1NTU3R5bGVBcHBs eVByb3BlcnR5OjpzaGFyZWRDU1NTdHlsZUFwcGx5UHJvcGVydHkoKTsKKyAgICAgICAgY29uc3Qg U3R5bGVCdWlsZGVyJiB0YWJsZSA9IFN0eWxlQnVpbGRlcjo6c2hhcmVkU3R5bGVCdWlsZGVyKCk7 CiAgICAgICAgIGNvbnN0IFByb3BlcnR5SGFuZGxlciYgaGFuZGxlciA9IHRhYmxlLnByb3BlcnR5 SGFuZGxlcihpZCk7CiAgICAgICAgIGlmIChoYW5kbGVyLmlzVmFsaWQoKSkKICAgICAgICAgICAg IGhhbmRsZXIuYXBwbHlWYWx1ZShzZWxlY3RvciwgdmFsdWUpOwpAQCAtMTc2NCwxMyArMTc2NCwx MyBAQCBwcml2YXRlOgogCiB9OwogCi1jb25zdCBDU1NTdHlsZUFwcGx5UHJvcGVydHkmIENTU1N0 eWxlQXBwbHlQcm9wZXJ0eTo6c2hhcmVkQ1NTU3R5bGVBcHBseVByb3BlcnR5KCkKK2NvbnN0IFN0 eWxlQnVpbGRlciYgU3R5bGVCdWlsZGVyOjpzaGFyZWRTdHlsZUJ1aWxkZXIoKQogewotICAgIERF RklORV9TVEFUSUNfTE9DQUwoQ1NTU3R5bGVBcHBseVByb3BlcnR5LCBjc3NTdHlsZUFwcGx5UHJv cGVydHlJbnN0YW5jZSwgKCkpOwotICAgIHJldHVybiBjc3NTdHlsZUFwcGx5UHJvcGVydHlJbnN0 YW5jZTsKKyAgICBERUZJTkVfU1RBVElDX0xPQ0FMKFN0eWxlQnVpbGRlciwgc3R5bGVCdWlsZGVy SW5zdGFuY2UsICgpKTsKKyAgICByZXR1cm4gc3R5bGVCdWlsZGVySW5zdGFuY2U7CiB9CiAKLUNT U1N0eWxlQXBwbHlQcm9wZXJ0eTo6Q1NTU3R5bGVBcHBseVByb3BlcnR5KCkKK1N0eWxlQnVpbGRl cjo6U3R5bGVCdWlsZGVyKCkKIHsKICAgICBmb3IgKGludCBpID0gMDsgaSA8IG51bUNTU1Byb3Bl cnRpZXM7ICsraSkKICAgICAgICAgbV9wcm9wZXJ0eU1hcFtpXSA9IFByb3BlcnR5SGFuZGxlcigp OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1N0eWxlQXBwbHlQcm9wZXJ0eS5o IGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1N0eWxlQXBwbHlQcm9wZXJ0eS5oCmluZGV4IDMzNTVk MjUyOWJjNjMxOTQ2YmQ5MTZlNDhkYTAxOTk0MGQ1YWFjOTQuLjUyNTVmNWQyZTlkZGE3NzdiYTI4 ZjZiMzFhMDk5NmI0NjNlYTk5ZWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NT dHlsZUFwcGx5UHJvcGVydHkuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTU3R5bGVBcHBs eVByb3BlcnR5LmgKQEAgLTMzLDcgKzMzLDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiBjbGFz cyBDU1NTdHlsZVNlbGVjdG9yOwogY2xhc3MgQ1NTVmFsdWU7Ci1jbGFzcyBDU1NTdHlsZUFwcGx5 UHJvcGVydHk7CitjbGFzcyBTdHlsZUJ1aWxkZXI7CiAKIGNsYXNzIFByb3BlcnR5SGFuZGxlciB7 CiBwdWJsaWM6CkBAIC01NSwxMCArNTUsMTAgQEAgcHJpdmF0ZToKICAgICBBcHBseUZ1bmN0aW9u IG1fYXBwbHk7CiB9OwogCi1jbGFzcyBDU1NTdHlsZUFwcGx5UHJvcGVydHkgewotICAgIFdURl9N QUtFX05PTkNPUFlBQkxFKENTU1N0eWxlQXBwbHlQcm9wZXJ0eSk7CitjbGFzcyBTdHlsZUJ1aWxk ZXIgeworICAgIFdURl9NQUtFX05PTkNPUFlBQkxFKFN0eWxlQnVpbGRlcik7CiBwdWJsaWM6Ci0g ICAgc3RhdGljIGNvbnN0IENTU1N0eWxlQXBwbHlQcm9wZXJ0eSYgc2hhcmVkQ1NTU3R5bGVBcHBs eVByb3BlcnR5KCk7CisgICAgc3RhdGljIGNvbnN0IFN0eWxlQnVpbGRlciYgc2hhcmVkU3R5bGVC dWlsZGVyKCk7CiAKICAgICBjb25zdCBQcm9wZXJ0eUhhbmRsZXImIHByb3BlcnR5SGFuZGxlcihD U1NQcm9wZXJ0eUlEIHByb3BlcnR5KSBjb25zdAogICAgIHsKQEAgLTY2LDcgKzY2LDcgQEAgcHVi bGljOgogICAgICAgICByZXR1cm4gbV9wcm9wZXJ0eU1hcFtpbmRleChwcm9wZXJ0eSldOwogICAg IH0KIHByaXZhdGU6Ci0gICAgQ1NTU3R5bGVBcHBseVByb3BlcnR5KCk7CisgICAgU3R5bGVCdWls ZGVyKCk7CiAgICAgc3RhdGljIGludCBpbmRleChDU1NQcm9wZXJ0eUlEIHByb3BlcnR5KQogICAg IHsKICAgICAgICAgcmV0dXJuIHByb3BlcnR5IC0gZmlyc3RDU1NQcm9wZXJ0eTsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcCBiL1NvdXJjZS9XZWJD b3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcAppbmRleCA1M2ExNDMwMWJmNzdjYzhmNDg2YmNk YWQyMmNhNzVmMTRhYTBkYzJkLi4yOGQxYWY2OTlhMzZkYTVlYzM3ZWI1NGQwNzk1MzMzYmY1MDdk YjY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwCkBAIC0zNTUsNyAr MzU1LDcgQEAgQ1NTU3R5bGVTZWxlY3Rvcjo6Q1NTU3R5bGVTZWxlY3RvcihEb2N1bWVudCogZG9j dW1lbnQsIGJvb2wgbWF0Y2hBdXRob3JBbmRVc2VyU3QKICAgICAsIG1fZm9udFNlbGVjdG9yKENT U0ZvbnRTZWxlY3Rvcjo6Y3JlYXRlKGRvY3VtZW50KSkKICAgICAsIG1fYXBwbHlQcm9wZXJ0eVRv UmVndWxhclN0eWxlKHRydWUpCiAgICAgLCBtX2FwcGx5UHJvcGVydHlUb1Zpc2l0ZWRMaW5rU3R5 bGUoZmFsc2UpCi0gICAgLCBtX2FwcGx5UHJvcGVydHkoQ1NTU3R5bGVBcHBseVByb3BlcnR5Ojpz aGFyZWRDU1NTdHlsZUFwcGx5UHJvcGVydHkoKSkKKyAgICAsIG1fc3R5bGVCdWlsZGVyKFN0eWxl QnVpbGRlcjo6c2hhcmVkU3R5bGVCdWlsZGVyKCkpCiAjaWYgRU5BQkxFKENTU19TSEFERVJTKQog ICAgICwgbV9oYXNQZW5kaW5nU2hhZGVycyhmYWxzZSkKICNlbmRpZgpAQCAtMzEwMSw3ICszMTAx LDcgQEAgdm9pZCBDU1NTdHlsZVNlbGVjdG9yOjphcHBseVByb3BlcnR5KENTU1Byb3BlcnR5SUQg aWQsIENTU1ZhbHVlICp2YWx1ZSkKICAgICAgICAgbV9wYXJlbnRTdHlsZS0+c2V0SGFzRXhwbGlj aXRseUluaGVyaXRlZFByb3BlcnRpZXMoKTsKIAogICAgIC8vIGNoZWNrIGxvb2t1cCB0YWJsZSBm b3IgaW1wbGVtZW50YXRpb25zIGFuZCB1c2Ugd2hlbiBhdmFpbGFibGUKLSAgICBjb25zdCBQcm9w ZXJ0eUhhbmRsZXImIGhhbmRsZXIgPSBtX2FwcGx5UHJvcGVydHkucHJvcGVydHlIYW5kbGVyKGlk KTsKKyAgICBjb25zdCBQcm9wZXJ0eUhhbmRsZXImIGhhbmRsZXIgPSBtX3N0eWxlQnVpbGRlci5w cm9wZXJ0eUhhbmRsZXIoaWQpOwogICAgIGlmIChoYW5kbGVyLmlzVmFsaWQoKSkgewogICAgICAg ICBpZiAoaXNJbmhlcml0KQogICAgICAgICAgICAgaGFuZGxlci5hcHBseUluaGVyaXRWYWx1ZSh0 aGlzKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmgg Yi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5oCmluZGV4IGI0N2EyNGY3M2Y1 ODUyNTkwMTQ3ZDZiMjY5N2I3OTkxMmUyNmE0MGMuLmJhNjFhMjk4ZjkwYmJkNjIxZWNhYWE0ODc2 MWQ1OGQ2NTk0MDBlMTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNl bGVjdG9yLmgKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0b3IuaApAQCAt NDksNyArNDksNiBAQCBjbGFzcyBDU1NJbWFnZUdlbmVyYXRvclZhbHVlOwogY2xhc3MgQ1NTSW1h Z2VTZXRWYWx1ZTsKIGNsYXNzIENTU0ltYWdlVmFsdWU7CiBjbGFzcyBDU1NTZWxlY3RvcjsKLWNs YXNzIENTU1N0eWxlQXBwbHlQcm9wZXJ0eTsKIGNsYXNzIENTU1N0eWxlUnVsZTsKIGNsYXNzIENT U1N0eWxlU2hlZXQ7CiBjbGFzcyBDU1NWYWx1ZTsKQEAgLTcwLDYgKzY5LDcgQEAgY2xhc3MgUnVs ZURhdGE7CiBjbGFzcyBSdWxlU2V0OwogY2xhc3MgU2V0dGluZ3M7CiBjbGFzcyBTdGF0aWNDU1NS dWxlTGlzdDsKK2NsYXNzIFN0eWxlQnVpbGRlcjsKIGNsYXNzIFN0eWxlSW1hZ2U7CiBjbGFzcyBT dHlsZUtleWZyYW1lOwogY2xhc3MgU3R5bGVQZW5kaW5nSW1hZ2U7CkBAIC00OTQsNyArNDk0LDcg QEAgcHJpdmF0ZToKIAogICAgIGJvb2wgbV9hcHBseVByb3BlcnR5VG9SZWd1bGFyU3R5bGU7CiAg ICAgYm9vbCBtX2FwcGx5UHJvcGVydHlUb1Zpc2l0ZWRMaW5rU3R5bGU7Ci0gICAgY29uc3QgQ1NT U3R5bGVBcHBseVByb3BlcnR5JiBtX2FwcGx5UHJvcGVydHk7CisgICAgY29uc3QgU3R5bGVCdWls ZGVyJiBtX3N0eWxlQnVpbGRlcjsKICAgICAKICAgICBIYXNoTWFwPFN0eWxlUnVsZSosIFJlZlB0 cjxDU1NTdHlsZVJ1bGU+ID4gbV9zdHlsZVJ1bGVUb0NTU09NV3JhcHBlck1hcDsKICAgICBIYXNo U2V0PFJlZlB0cjxDU1NTdHlsZVNoZWV0PiA+IG1fc3R5bGVTaGVldENTU09NV3JhcHBlclNldDsK