84709 2012-04-24 05:11:52 -0700 [EFL][DRT] Reset DRT settings to their default values after a testcase was executed. 2012-05-22 11:11:58 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 mikhail.pozdnyakov mikhail.pozdnyakov d-r eric gustavo gyuyoung.kim lucas.de.marchi mrobinson pnormand rakuco tonikitoo webkit.review.bot oldest_to_newest 608561 0 mikhail.pozdnyakov 2012-04-24 05:11:52 -0700 Not all the settings affected by layout testcases are reset in DumpRenderTreeChrome::resetDefaultsToConsistentValues(). ones corresponding to the setters below are missed: ewk_view_setting_user_stylesheet_set ewk_view_setting_enable_xss_auditor_set ewk_view_setting_enable_developer_extras_set ewk_view_setting_minimum_timer_interval_set DumpRenderTreeSupportEfl::setSmartInsertDeleteEnabled DumpRenderTreeSupportEfl::setSelectTrailingWhitespaceEnabled DumpRenderTreeSupportEfl::setDefersLoading DumpRenderTreeSupportEfl::setEditingBehavior It may cause flakiness of the test results. 608570 1 138541 mikhail.pozdnyakov 2012-04-24 05:26:36 -0700 Created attachment 138541 reset some missed DRT settings 608576 2 138541 d-r 2012-04-24 05:37:11 -0700 Comment on attachment 138541 reset some missed DRT settings View in context: https://bugs.webkit.org/attachment.cgi?id=138541&action=review Otherwise LGTM. > Tools/ChangeLog:7 > + I think it makes sense to put the explanation from the bug report here, e.g.: "Not all the settings that can be changed by layout testcases through a JS API were reset in DumpRenderTreeChrome::resetDefaultsToConsistentValues()." 608581 3 138544 mikhail.pozdnyakov 2012-04-24 05:46:01 -0700 Created attachment 138544 reset some missed DRT settings 609193 4 138544 rakuco 2012-04-24 16:00:57 -0700 Comment on attachment 138544 reset some missed DRT settings Makes sense. 609401 5 138544 gyuyoung.kim 2012-04-24 19:54:34 -0700 Comment on attachment 138544 reset some missed DRT settings Looks fine. 609515 6 138544 eric 2012-04-25 00:31:07 -0700 Comment on attachment 138544 reset some missed DRT settings OK. 609518 7 138544 webkit.review.bot 2012-04-25 00:38:35 -0700 Comment on attachment 138544 reset some missed DRT settings Clearing flags on attachment: 138544 Committed r115173: <http://trac.webkit.org/changeset/115173> 609519 8 webkit.review.bot 2012-04-25 00:38:40 -0700 All reviewed patches have been landed. Closing bug. 138541 2012-04-24 05:26:36 -0700 2012-04-24 05:46:01 -0700 reset some missed DRT settings bug84709 text/plain 3024 mikhail.pozdnyakov Y29tbWl0IDQ5ZGZhZTNiYjVjZDlkMGFhMjg3MjRjNmRlMDQxY2VlYTIwODRmYjkKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPHBvemRueWFrb3YubWlraGFpbEBnbWFpbC5jb20+CkRhdGU6ICAg VHVlIEFwciAyNCAxNToyMjoyMSAyMDEyICswMzAwCgogICAgYnVnODQ3MDkKCmRpZmYgLS1naXQg YS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZDI0NmJmOS4uYjdkNjg0 ZCAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE0IEBACisyMDEyLTA0LTI0ICBNaWtoYWlsIFBvemRueWFrb3YgIDxtaWtoYWlsLnBv emRueWFrb3ZAaW50ZWwuY29tPgorCisgICAgICAgIFtFRkxdW0RSVF0gUmVzZXQgRFJUIHNldHRp bmdzIHRvIHRoZWlyIGRlZmF1bHQgdmFsdWVzIGFmdGVyIGEgdGVzdGNhc2Ugd2FzIGV4ZWN1dGVk LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODQ3MDkK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIER1bXBS ZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVyVHJlZUNocm9tZS5jcHA6CisgICAgICAgIChkZWZhdWx0 RWRpdGluZ0JlaGF2aW9yKTogcmV0dXJucyBlZGl0aW5nIGJlaGF2aW9yIGRlcGVuZGluZyBvbiBj dXJyZW50IHBsYXRmb3JtLgorICAgICAgICAoRHVtcFJlbmRlclRyZWVDaHJvbWU6OnJlc2V0RGVm YXVsdHNUb0NvbnNpc3RlbnRWYWx1ZXMpOiByZXNldCBzb21lIG1pc3NlZCBEUlQgc2V0dGluZ3MK KwogMjAxMi0wNC0yMyAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgogCiAg ICAgICAgIFVucmV2aWV3ZWQgcm9sbGluZyBvdXQgcjExNDg4MSwgYmVjYXVzZSBpdCBicm9rZSB1 cGxvYWQgYnVpbGRzdGVwLgpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvZWZsL0R1 bXBSZW5kZXJUcmVlQ2hyb21lLmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVu ZGVyVHJlZUNocm9tZS5jcHAKaW5kZXggMTk3MDIxMS4uYTE0OGE2NiAxMDA2NDQKLS0tIGEvVG9v bHMvRHVtcFJlbmRlclRyZWUvZWZsL0R1bXBSZW5kZXJUcmVlQ2hyb21lLmNwcAorKysgYi9Ub29s cy9EdW1wUmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRyZWVDaHJvbWUuY3BwCkBAIC0xNjgsNiAr MTY4LDIxIEBAIEV2YXNfT2JqZWN0KiBEdW1wUmVuZGVyVHJlZUNocm9tZTo6bWFpblZpZXcoKSBj b25zdAogICAgIHJldHVybiBtX21haW5WaWV3OwogfQogCitzdGF0aWMgaW5saW5lIGNvbnN0IGNo YXIqIGRlZmF1bHRFZGl0aW5nQmVoYXZpb3IoKQoreworICAgIHJldHVybgorI2lmIE9TKERBUldJ TikKKyAgICAibWFjIjsKKyNlbGlmIE9TKFdJTkRPV1MpCisgICAgIndpbiI7CisjZWxpZiBPUyhV TklYKQorICAgICJ1bml4IjsKKyNlbHNlCisgICAgLy8gRmFsbGJhY2sKKyAgICAibWFjIjsKKyNl bmRpZgorfQorCiB2b2lkIER1bXBSZW5kZXJUcmVlQ2hyb21lOjpyZXNldERlZmF1bHRzVG9Db25z aXN0ZW50VmFsdWVzKCkKIHsKICAgICBWZWN0b3I8RXZhc19PYmplY3QqPjo6aXRlcmF0b3IgaXQg PSBtX2V4dHJhVmlld3MuYmVnaW4oKTsKQEAgLTIwMiw2ICsyMTcsMTAgQEAgdm9pZCBEdW1wUmVu ZGVyVHJlZUNocm9tZTo6cmVzZXREZWZhdWx0c1RvQ29uc2lzdGVudFZhbHVlcygpCiAgICAgZXdr X3ZpZXdfc2V0dGluZ19zY3JpcHRzX2Nhbl9vcGVuX3dpbmRvd3Nfc2V0KG1haW5WaWV3KCksIEVJ TkFfVFJVRSk7CiAgICAgZXdrX3ZpZXdfc2V0dGluZ19zY3JpcHRzX2Nhbl9jbG9zZV93aW5kb3dz X3NldChtYWluVmlldygpLCBFSU5BX1RSVUUpOwogICAgIGV3a192aWV3X3NldHRpbmdfYXV0b19s b2FkX2ltYWdlc19zZXQobWFpblZpZXcoKSwgRUlOQV9UUlVFKTsKKyAgICBld2tfdmlld19zZXR0 aW5nX3VzZXJfc3R5bGVzaGVldF9zZXQobWFpblZpZXcoKSwgMCk7CisgICAgZXdrX3ZpZXdfc2V0 dGluZ19lbmFibGVfeHNzX2F1ZGl0b3Jfc2V0KGJyb3dzZXItPm1haW5WaWV3KCksIEVJTkFfVFJV RSk7CisgICAgZXdrX3ZpZXdfc2V0dGluZ19lbmFibGVfZGV2ZWxvcGVyX2V4dHJhc19zZXQoYnJv d3Nlci0+bWFpblZpZXcoKSwgRUlOQV9GQUxTRSk7CisgICAgZXdrX3ZpZXdfc2V0dGluZ19taW5p bXVtX3RpbWVyX2ludGVydmFsX3NldChicm93c2VyLT5tYWluVmlldygpLCAwLjAxMCk7IC8vIDEw IG1pbGxpc2Vjb25kcyAoRE9NVGltZXI6OnNfbWluRGVmYXVsdFRpbWVySW50ZXJ2YWwpCiAKICAg ICBld2tfdmlld196b29tX3NldChtYWluVmlldygpLCAxLjAsIDAsIDApOwogICAgIGV3a192aWV3 X3NjYWxlX3NldChtYWluVmlldygpLCAxLjAsIDAsIDApOwpAQCAtMjE1LDYgKzIzNCwxMCBAQCB2 b2lkIER1bXBSZW5kZXJUcmVlQ2hyb21lOjpyZXNldERlZmF1bHRzVG9Db25zaXN0ZW50VmFsdWVz KCkKICAgICBEdW1wUmVuZGVyVHJlZVN1cHBvcnRFZmw6OmNsZWFyT3BlbmVyKG1haW5GcmFtZSgp KTsKICAgICBEdW1wUmVuZGVyVHJlZVN1cHBvcnRFZmw6OnNldEludGVyYWN0aXZlRm9ybVZhbGlk YXRpb25FbmFibGVkKG1haW5WaWV3KCksIHRydWUpOwogICAgIER1bXBSZW5kZXJUcmVlU3VwcG9y dEVmbDo6c2V0QXV0aG9yQW5kVXNlclN0eWxlc0VuYWJsZWQobWFpblZpZXcoKSwgdHJ1ZSk7Cisg ICAgRHVtcFJlbmRlclRyZWVTdXBwb3J0RWZsOjpzZXRTbWFydEluc2VydERlbGV0ZUVuYWJsZWQo bWFpblZpZXcoKSwgZmFsc2UpOworICAgIER1bXBSZW5kZXJUcmVlU3VwcG9ydEVmbDo6c2V0U2Vs ZWN0VHJhaWxpbmdXaGl0ZXNwYWNlRW5hYmxlZChtYWluVmlldygpLCBmYWxzZSk7CisgICAgRHVt cFJlbmRlclRyZWVTdXBwb3J0RWZsOjpzZXREZWZlcnNMb2FkaW5nKG1haW5WaWV3KCksIGZhbHNl KTsKKyAgICBEdW1wUmVuZGVyVHJlZVN1cHBvcnRFZmw6OnNldEVkaXRpbmdCZWhhdmlvcihtYWlu VmlldygpLCBkZWZhdWx0RWRpdGluZ0JlaGF2aW9yKCkpOwogfQogCiAvLyBTbWFydCBDYWxsYmFj a3MK 138544 2012-04-24 05:46:01 -0700 2012-04-25 00:38:35 -0700 reset some missed DRT settings bug84709_v2 text/plain 3194 mikhail.pozdnyakov Y29tbWl0IDNmMzE4OTFiMDY5ODE2NGQyZDhkZTE2YjJhOTc2YWVjNzZjYTk3MGMKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPHBvemRueWFrb3YubWlraGFpbEBnbWFpbC5jb20+CkRhdGU6ICAg VHVlIEFwciAyNCAxNToyMjoyMSAyMDEyICswMzAwCgogICAgYnVnODQ3MDkKCmRpZmYgLS1naXQg YS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZDI0NmJmOS4uYTQ1OWI1 YSAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE3IEBACisyMDEyLTA0LTI0ICBNaWtoYWlsIFBvemRueWFrb3YgIDxtaWtoYWlsLnBv emRueWFrb3ZAaW50ZWwuY29tPgorCisgICAgICAgIFtFRkxdW0RSVF0gUmVzZXQgRFJUIHNldHRp bmdzIHRvIHRoZWlyIGRlZmF1bHQgdmFsdWVzIGFmdGVyIGEgdGVzdGNhc2Ugd2FzIGV4ZWN1dGVk LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODQ3MDkK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBOb3QgYWxs IHRoZSBzZXR0aW5ncyB0aGF0IGNhbiBiZSBjaGFuZ2VkIGJ5IGxheW91dCB0ZXN0Y2FzZXMgdGhy b3VnaCBhIEpTIEFQSSB3ZXJlIAorICAgICAgICByZXNldCBpbiBEdW1wUmVuZGVyVHJlZUNocm9t ZTo6cmVzZXREZWZhdWx0c1RvQ29uc2lzdGVudFZhbHVlcygpLgorCisgICAgICAgICogRHVtcFJl bmRlclRyZWUvZWZsL0R1bXBSZW5kZXJUcmVlQ2hyb21lLmNwcDoKKyAgICAgICAgKGRlZmF1bHRF ZGl0aW5nQmVoYXZpb3IpOiByZXR1cm5zIGVkaXRpbmcgYmVoYXZpb3IgZGVwZW5kaW5nIG9uIGN1 cnJlbnQgcGxhdGZvcm0uCisgICAgICAgIChEdW1wUmVuZGVyVHJlZUNocm9tZTo6cmVzZXREZWZh dWx0c1RvQ29uc2lzdGVudFZhbHVlcyk6IHJlc2V0IHNvbWUgbWlzc2VkIERSVCBzZXR0aW5ncwor CiAyMDEyLTA0LTIzICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAKICAg ICAgICAgVW5yZXZpZXdlZCByb2xsaW5nIG91dCByMTE0ODgxLCBiZWNhdXNlIGl0IGJyb2tlIHVw bG9hZCBidWlsZHN0ZXAuCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9lZmwvRHVt cFJlbmRlclRyZWVDaHJvbWUuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvZWZsL0R1bXBSZW5k ZXJUcmVlQ2hyb21lLmNwcAppbmRleCAxOTcwMjExLi5hMTQ4YTY2IDEwMDY0NAotLS0gYS9Ub29s cy9EdW1wUmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRyZWVDaHJvbWUuY3BwCisrKyBiL1Rvb2xz L0R1bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVyVHJlZUNocm9tZS5jcHAKQEAgLTE2OCw2ICsx NjgsMjEgQEAgRXZhc19PYmplY3QqIER1bXBSZW5kZXJUcmVlQ2hyb21lOjptYWluVmlldygpIGNv bnN0CiAgICAgcmV0dXJuIG1fbWFpblZpZXc7CiB9CiAKK3N0YXRpYyBpbmxpbmUgY29uc3QgY2hh ciogZGVmYXVsdEVkaXRpbmdCZWhhdmlvcigpCit7CisgICAgcmV0dXJuCisjaWYgT1MoREFSV0lO KQorICAgICJtYWMiOworI2VsaWYgT1MoV0lORE9XUykKKyAgICAid2luIjsKKyNlbGlmIE9TKFVO SVgpCisgICAgInVuaXgiOworI2Vsc2UKKyAgICAvLyBGYWxsYmFjaworICAgICJtYWMiOworI2Vu ZGlmCit9CisKIHZvaWQgRHVtcFJlbmRlclRyZWVDaHJvbWU6OnJlc2V0RGVmYXVsdHNUb0NvbnNp c3RlbnRWYWx1ZXMoKQogewogICAgIFZlY3RvcjxFdmFzX09iamVjdCo+OjppdGVyYXRvciBpdCA9 IG1fZXh0cmFWaWV3cy5iZWdpbigpOwpAQCAtMjAyLDYgKzIxNywxMCBAQCB2b2lkIER1bXBSZW5k ZXJUcmVlQ2hyb21lOjpyZXNldERlZmF1bHRzVG9Db25zaXN0ZW50VmFsdWVzKCkKICAgICBld2tf dmlld19zZXR0aW5nX3NjcmlwdHNfY2FuX29wZW5fd2luZG93c19zZXQobWFpblZpZXcoKSwgRUlO QV9UUlVFKTsKICAgICBld2tfdmlld19zZXR0aW5nX3NjcmlwdHNfY2FuX2Nsb3NlX3dpbmRvd3Nf c2V0KG1haW5WaWV3KCksIEVJTkFfVFJVRSk7CiAgICAgZXdrX3ZpZXdfc2V0dGluZ19hdXRvX2xv YWRfaW1hZ2VzX3NldChtYWluVmlldygpLCBFSU5BX1RSVUUpOworICAgIGV3a192aWV3X3NldHRp bmdfdXNlcl9zdHlsZXNoZWV0X3NldChtYWluVmlldygpLCAwKTsKKyAgICBld2tfdmlld19zZXR0 aW5nX2VuYWJsZV94c3NfYXVkaXRvcl9zZXQoYnJvd3Nlci0+bWFpblZpZXcoKSwgRUlOQV9UUlVF KTsKKyAgICBld2tfdmlld19zZXR0aW5nX2VuYWJsZV9kZXZlbG9wZXJfZXh0cmFzX3NldChicm93 c2VyLT5tYWluVmlldygpLCBFSU5BX0ZBTFNFKTsKKyAgICBld2tfdmlld19zZXR0aW5nX21pbmlt dW1fdGltZXJfaW50ZXJ2YWxfc2V0KGJyb3dzZXItPm1haW5WaWV3KCksIDAuMDEwKTsgLy8gMTAg bWlsbGlzZWNvbmRzIChET01UaW1lcjo6c19taW5EZWZhdWx0VGltZXJJbnRlcnZhbCkKIAogICAg IGV3a192aWV3X3pvb21fc2V0KG1haW5WaWV3KCksIDEuMCwgMCwgMCk7CiAgICAgZXdrX3ZpZXdf c2NhbGVfc2V0KG1haW5WaWV3KCksIDEuMCwgMCwgMCk7CkBAIC0yMTUsNiArMjM0LDEwIEBAIHZv aWQgRHVtcFJlbmRlclRyZWVDaHJvbWU6OnJlc2V0RGVmYXVsdHNUb0NvbnNpc3RlbnRWYWx1ZXMo KQogICAgIER1bXBSZW5kZXJUcmVlU3VwcG9ydEVmbDo6Y2xlYXJPcGVuZXIobWFpbkZyYW1lKCkp OwogICAgIER1bXBSZW5kZXJUcmVlU3VwcG9ydEVmbDo6c2V0SW50ZXJhY3RpdmVGb3JtVmFsaWRh dGlvbkVuYWJsZWQobWFpblZpZXcoKSwgdHJ1ZSk7CiAgICAgRHVtcFJlbmRlclRyZWVTdXBwb3J0 RWZsOjpzZXRBdXRob3JBbmRVc2VyU3R5bGVzRW5hYmxlZChtYWluVmlldygpLCB0cnVlKTsKKyAg ICBEdW1wUmVuZGVyVHJlZVN1cHBvcnRFZmw6OnNldFNtYXJ0SW5zZXJ0RGVsZXRlRW5hYmxlZCht YWluVmlldygpLCBmYWxzZSk7CisgICAgRHVtcFJlbmRlclRyZWVTdXBwb3J0RWZsOjpzZXRTZWxl Y3RUcmFpbGluZ1doaXRlc3BhY2VFbmFibGVkKG1haW5WaWV3KCksIGZhbHNlKTsKKyAgICBEdW1w UmVuZGVyVHJlZVN1cHBvcnRFZmw6OnNldERlZmVyc0xvYWRpbmcobWFpblZpZXcoKSwgZmFsc2Up OworICAgIER1bXBSZW5kZXJUcmVlU3VwcG9ydEVmbDo6c2V0RWRpdGluZ0JlaGF2aW9yKG1haW5W aWV3KCksIGRlZmF1bHRFZGl0aW5nQmVoYXZpb3IoKSk7CiB9CiAKIC8vIFNtYXJ0IENhbGxiYWNr cwo=