84706 2012-04-24 04:28:00 -0700 add numberOfInputChannels support in JavaScriptAudioNode 2012-04-24 18:48:38 -0700 1 1 1 Unclassified WebKit Web Audio 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 84687 P2 Normal --- 1 james.wei james.wei crogers eric.carlson feature-media-reviews webkit.review.bot oldest_to_newest 608541 0 james.wei 2012-04-24 04:28:00 -0700 add numberOfInputChannels support in JavaScriptAudioNode 608544 1 138535 james.wei 2012-04-24 04:32:41 -0700 Created attachment 138535 Patch 609062 2 crogers 2012-04-24 14:24:41 -0700 Hi James, this looks almost the same as Xingnan's patch which also just appeared: https://bugs.webkit.org/show_bug.cgi?id=84687 609195 3 james.wei 2012-04-24 16:02:38 -0700 (In reply to comment #2) > Hi James, this looks almost the same as Xingnan's patch which also just appeared: > https://bugs.webkit.org/show_bug.cgi?id=84687 yes, you can just review his patch and ignore this one. thanks 609367 4 crogers 2012-04-24 18:48:38 -0700 thanks, I'll look at Xingnan's patch instead *** This bug has been marked as a duplicate of bug 84687 *** 138535 2012-04-24 04:32:41 -0700 2012-04-24 16:03:16 -0700 Patch bug-84706-20120424193242.patch text/plain 5534 james.wei U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0OTczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTg3ZGM2MTlhNWEwNWRm ZWFiMjc0ZTZiNThjZjAzZGMwNDcyZmNiYy4uMTI1ZWQ5YmJiMmE5ZmE5Njc5ODE3OGM1YzU0Zjk1 NjBjMjU2ZGQyZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA0LTI0ICBXZWkg SmFtZXMgIDxqYW1lcy53ZWlAaW50ZWwuY29tPgorCisgICAgICAgIGFkZCBudW1iZXJPZklucHV0 Q2hhbm5lbHMgc3VwcG9ydCBpbiBKYXZhU2NyaXB0QXVkaW9Ob2RlCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NDcwNgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTW9kdWxlcy93ZWJhdWRpby9KYXZhU2Ny aXB0QXVkaW9Ob2RlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkphdmFTY3JpcHRBdWRpb05vZGU6 OkphdmFTY3JpcHRBdWRpb05vZGUpOgorICAgICAgICAoV2ViQ29yZTo6SmF2YVNjcmlwdEF1ZGlv Tm9kZTo6aW5pdGlhbGl6ZSk6CisgICAgICAgIChXZWJDb3JlOjpKYXZhU2NyaXB0QXVkaW9Ob2Rl Ojpwcm9jZXNzKToKKyAgICAgICAgKiBNb2R1bGVzL3dlYmF1ZGlvL0phdmFTY3JpcHRBdWRpb05v ZGUuaDoKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAoSmF2YVNjcmlwdEF1ZGlvTm9kZSk6 CisKIDIwMTItMDQtMjMgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIFJlbmRlckRldGFpbHNNYXJrZXIgc2hvdWxkIGRyYXcgdGhlIHRyaWFuZ2xlIGluc2lkZSB0 aGUgY29udGVudCBib3gKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVk aW8vSmF2YVNjcmlwdEF1ZGlvTm9kZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1 ZGlvL0phdmFTY3JpcHRBdWRpb05vZGUuY3BwCmluZGV4IDgxYzFkYzc2YmQxNWI5ODU1YWY4YmRh NjI5MGE0ZTdiMzk0ZTc4M2IuLjliMGE0OWEzYTZhZTczY2IwMWE3NzY3ZTUzY2QxOTJiMDU0ODlh NWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vSmF2YVNjcmlw dEF1ZGlvTm9kZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9KYXZh U2NyaXB0QXVkaW9Ob2RlLmNwcApAQCAtNzksMTIgKzc5LDExIEBAIEphdmFTY3JpcHRBdWRpb05v ZGU6OkphdmFTY3JpcHRBdWRpb05vZGUoQXVkaW9Db250ZXh0KiBjb250ZXh0LCBmbG9hdCBzYW1w bGVSYXRlCiAgICAgaWYgKG1fYnVmZmVyU2l6ZSA8IEF1ZGlvTm9kZTo6UHJvY2Vzc2luZ1NpemVJ bkZyYW1lcykKICAgICAgICAgbV9idWZmZXJTaXplID0gQXVkaW9Ob2RlOjpQcm9jZXNzaW5nU2l6 ZUluRnJhbWVzOwogCi0gICAgLy8gRklYTUU6IFdlIHN0aWxsIG5lZWQgdG8gaW1wbGVtZW50IG51 bWJlck9mSW5wdXRDaGFubmVscy4KLSAgICBBU1NFUlRfVU5VU0VEKG51bWJlck9mSW5wdXRDaGFu bmVscywgbnVtYmVyT2ZJbnB1dENoYW5uZWxzID4gMCk7Ci0KICAgICBhZGRJbnB1dChhZG9wdFB0 cihuZXcgQXVkaW9Ob2RlSW5wdXQodGhpcykpKTsKICAgICBhZGRPdXRwdXQoYWRvcHRQdHIobmV3 IEF1ZGlvTm9kZU91dHB1dCh0aGlzLCBudW1iZXJPZk91dHB1dENoYW5uZWxzKSkpOwogCisgICAg bV9pbnRlcm5hbEJ1cyA9IGFkb3B0UHRyKG5ldyBBdWRpb0J1cyhudW1iZXJPZklucHV0Q2hhbm5l bHMsIEF1ZGlvTm9kZTo6UHJvY2Vzc2luZ1NpemVJbkZyYW1lcywgZmFsc2UpKTsKKwogICAgIHNl dE5vZGVUeXBlKE5vZGVUeXBlSmF2YVNjcmlwdCk7CiAKICAgICBpbml0aWFsaXplKCk7CkBAIC0x MDUsNyArMTA0LDcgQEAgdm9pZCBKYXZhU2NyaXB0QXVkaW9Ob2RlOjppbml0aWFsaXplKCkKICAg ICAvLyBDcmVhdGUgZG91YmxlIGJ1ZmZlcnMgb24gYm90aCB0aGUgaW5wdXQgYW5kIG91dHB1dCBz aWRlcy4KICAgICAvLyBUaGVzZSBBdWRpb0J1ZmZlcnMgd2lsbCBiZSBkaXJlY3RseSBhY2Nlc3Nl ZCBpbiB0aGUgbWFpbiB0aHJlYWQgYnkgSmF2YVNjcmlwdC4KICAgICBmb3IgKHVuc2lnbmVkIGkg PSAwOyBpIDwgMjsgKytpKSB7Ci0gICAgICAgIG1faW5wdXRCdWZmZXJzLmFwcGVuZChBdWRpb0J1 ZmZlcjo6Y3JlYXRlKDIsIGJ1ZmZlclNpemUoKSwgc2FtcGxlUmF0ZSkpOworICAgICAgICBtX2lu cHV0QnVmZmVycy5hcHBlbmQoQXVkaW9CdWZmZXI6OmNyZWF0ZShtX2ludGVybmFsQnVzLT5udW1i ZXJPZkNoYW5uZWxzKCksIGJ1ZmZlclNpemUoKSwgc2FtcGxlUmF0ZSkpOwogICAgICAgICBtX291 dHB1dEJ1ZmZlcnMuYXBwZW5kKEF1ZGlvQnVmZmVyOjpjcmVhdGUodGhpcy0+b3V0cHV0KDApLT5u dW1iZXJPZkNoYW5uZWxzKCksIGJ1ZmZlclNpemUoKSwgc2FtcGxlUmF0ZSkpOwogICAgIH0KIApA QCAtMTU4LDMwICsxNTcsMjIgQEAgdm9pZCBKYXZhU2NyaXB0QXVkaW9Ob2RlOjpwcm9jZXNzKHNp emVfdCBmcmFtZXNUb1Byb2Nlc3MpCiAgICAgaWYgKCFpc0ZyYW1lc1RvUHJvY2Vzc0dvb2QpCiAg ICAgICAgIHJldHVybjsKICAgICAgICAgCi0gICAgdW5zaWduZWQgbnVtYmVyT2ZJbnB1dENoYW5u ZWxzID0gaW5wdXRCdXMtPm51bWJlck9mQ2hhbm5lbHMoKTsKKyAgICB1bnNpZ25lZCBudW1iZXJP ZklucHV0Q2hhbm5lbHMgPSBtX2ludGVybmFsQnVzLT5udW1iZXJPZkNoYW5uZWxzKCk7CiAgICAg dW5zaWduZWQgbnVtYmVyT2ZPdXRwdXRDaGFubmVscyA9IG91dHB1dEJ1cy0+bnVtYmVyT2ZDaGFu bmVscygpOwogICAgIAotICAgIGJvb2wgY2hhbm5lbHNBcmVHb29kID0gKG51bWJlck9mSW5wdXRD aGFubmVscyA9PSAxIHx8IG51bWJlck9mSW5wdXRDaGFubmVscyA9PSAyKTsKKyAgICBib29sIGNo YW5uZWxzQXJlR29vZCA9IChudW1iZXJPZklucHV0Q2hhbm5lbHMgfHwgbnVtYmVyT2ZPdXRwdXRD aGFubmVscyk7CiAgICAgQVNTRVJUKGNoYW5uZWxzQXJlR29vZCk7CiAgICAgaWYgKCFjaGFubmVs c0FyZUdvb2QpCiAgICAgICAgIHJldHVybjsKIAotICAgIGNvbnN0IGZsb2F0KiBzb3VyY2VMID0g aW5wdXRCdXMtPmNoYW5uZWwoMCktPmRhdGEoKTsKLSAgICBjb25zdCBmbG9hdCogc291cmNlUiA9 IG51bWJlck9mSW5wdXRDaGFubmVscyA+IDEgPyBpbnB1dEJ1cy0+Y2hhbm5lbCgxKS0+ZGF0YSgp IDogMDsKKyAgICAvLyBTZXQgdGhlIGlucHV0IGJ1ZmZlciBhcyB0aGUgbWVtb3J5IG9mIGludGVy bmFsIGJ1cyBjaGFubmVscy4KKyAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgbnVtYmVyT2ZJ bnB1dENoYW5uZWxzOyArK2kpCisgICAgICAgIG1faW50ZXJuYWxCdXMtPnNldENoYW5uZWxNZW1v cnkoaSwgaW5wdXRCdWZmZXItPmdldENoYW5uZWxEYXRhKGkpLT5kYXRhKCkgKyBtX2J1ZmZlclJl YWRXcml0ZUluZGV4LCBBdWRpb05vZGU6OlByb2Nlc3NpbmdTaXplSW5GcmFtZXMpOworICAgIC8v IENvcHkgZnJvbSB0aGUgaW5wdXQgdG8gdGhlIGlucHV0IGJ1ZmZlci4KKyAgICBtX2ludGVybmFs QnVzLT5jb3B5RnJvbSgqaW5wdXRCdXMpOwogCi0gICAgLy8gQ29weSBmcm9tIHRoZSBpbnB1dCB0 byB0aGUgaW5wdXQgYnVmZmVyLiAgU2VlICJidWZmZXJzQXJlR29vZCIgY2hlY2sgYWJvdmUgZm9y IHNhZmV0eS4KLSAgICBzaXplX3QgYnl0ZXNUb0NvcHkgPSBzaXplb2YoZmxvYXQpICogZnJhbWVz VG9Qcm9jZXNzOwotICAgIG1lbWNweShpbnB1dEJ1ZmZlci0+Z2V0Q2hhbm5lbERhdGEoMCktPmRh dGEoKSArIG1fYnVmZmVyUmVhZFdyaXRlSW5kZXgsIHNvdXJjZUwsIGJ5dGVzVG9Db3B5KTsKLSAg ICAKLSAgICBpZiAobnVtYmVyT2ZJbnB1dENoYW5uZWxzID09IDIpCi0gICAgICAgIG1lbWNweShp bnB1dEJ1ZmZlci0+Z2V0Q2hhbm5lbERhdGEoMSktPmRhdGEoKSArIG1fYnVmZmVyUmVhZFdyaXRl SW5kZXgsIHNvdXJjZVIsIGJ5dGVzVG9Db3B5KTsKLSAgICBlbHNlIGlmIChudW1iZXJPZklucHV0 Q2hhbm5lbHMgPT0gMSkgewotICAgICAgICAvLyBJZiB0aGUgaW5wdXQgaXMgbW9ubywgdGhlbiBh bHNvIGNvcHkgdGhlIG1vbm8gaW5wdXQgdG8gdGhlIHJpZ2h0IGNoYW5uZWwgb2YgdGhlIEF1ZGlv QnVmZmVyIHdoaWNoIHRoZSBBdWRpb1Byb2Nlc3NpbmdFdmVudCB1c2VzLgotICAgICAgICAvLyBG SVhNRTogaXQgaXMgbGlrZWx5IHRoZSBhdWRpbyBBUEkgd2lsbCBldm9sdmUgdG8gcHJlc2VudCBh biBBdWRpb0J1ZmZlciB3aXRoIHRoZSBzYW1lIG51bWJlciBvZiBjaGFubmVscyBhcyBvdXIgaW5w dXQuCi0gICAgICAgIG1lbWNweShpbnB1dEJ1ZmZlci0+Z2V0Q2hhbm5lbERhdGEoMSktPmRhdGEo KSArIG1fYnVmZmVyUmVhZFdyaXRlSW5kZXgsIHNvdXJjZUwsIGJ5dGVzVG9Db3B5KTsKLSAgICB9 Ci0gICAgCiAgICAgLy8gQ29weSBmcm9tIHRoZSBvdXRwdXQgYnVmZmVyIHRvIHRoZSBvdXRwdXQu IAorICAgIHNpemVfdCBieXRlc1RvQ29weSA9IHNpemVvZihmbG9hdCkgKiBmcmFtZXNUb1Byb2Nl c3M7CiAgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IG51bWJlck9mT3V0cHV0Q2hhbm5lbHM7 ICsraSkKICAgICAgICAgbWVtY3B5KG91dHB1dEJ1cy0+Y2hhbm5lbChpKS0+bXV0YWJsZURhdGEo KSwgb3V0cHV0QnVmZmVyLT5nZXRDaGFubmVsRGF0YShpKS0+ZGF0YSgpICsgbV9idWZmZXJSZWFk V3JpdGVJbmRleCwgYnl0ZXNUb0NvcHkpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL3dlYmF1ZGlvL0phdmFTY3JpcHRBdWRpb05vZGUuaCBiL1NvdXJjZS9XZWJDb3JlL01v ZHVsZXMvd2ViYXVkaW8vSmF2YVNjcmlwdEF1ZGlvTm9kZS5oCmluZGV4IGI5NDBlMWE4ZDVkNmJj NTQyNjlkZGRlNDRkZjYyZGQ5MTIzZGQ2ODguLjkxNmY5NzY5NzEyOTExYzdiZTNiMjI4MDAxMjRk MjNhM2U0OGFlMDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8v SmF2YVNjcmlwdEF1ZGlvTm9kZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVk aW8vSmF2YVNjcmlwdEF1ZGlvTm9kZS5oCkBAIC0zNyw2ICszNyw3IEBACiBuYW1lc3BhY2UgV2Vi Q29yZSB7CiAKIGNsYXNzIEF1ZGlvQnVmZmVyOworY2xhc3MgQXVkaW9CdXM7CiBjbGFzcyBBdWRp b0NvbnRleHQ7CiBjbGFzcyBBdWRpb1Byb2Nlc3NpbmdFdmVudDsKIApAQCAtOTMsNiArOTQsNyBA QCBwcml2YXRlOgogICAgIHVuc2lnbmVkIG1fZG91YmxlQnVmZmVySW5kZXhGb3JFdmVudDsKICAg ICBWZWN0b3I8UmVmUHRyPEF1ZGlvQnVmZmVyPiA+IG1faW5wdXRCdWZmZXJzOwogICAgIFZlY3Rv cjxSZWZQdHI8QXVkaW9CdWZmZXI+ID4gbV9vdXRwdXRCdWZmZXJzOworICAgIE93blB0cjxBdWRp b0J1cz4gbV9pbnRlcm5hbEJ1czsKIAogICAgIHZpcnR1YWwgdm9pZCByZWZFdmVudFRhcmdldCgp IHsgcmVmKCk7IH0KICAgICB2aXJ0dWFsIHZvaWQgZGVyZWZFdmVudFRhcmdldCgpIHsgZGVyZWYo KTsgfQo=