84705 2012-04-24 04:05:15 -0700 [EFL] Enable Web Timing 2012-05-06 22:53:11 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 30685 0 cdumez cdumez gyuyoung.kim lucas.de.marchi rakuco tonyg webkit.review.bot oldest_to_newest 608527 0 cdumez 2012-04-24 04:05:15 -0700 Web Timing should be enabled for the EFL port. 608530 1 138533 cdumez 2012-04-24 04:15:30 -0700 Created attachment 138533 Patch 608549 2 138533 tonyg 2012-04-24 04:34:27 -0700 Comment on attachment 138533 Patch In order for navigation timing to completely work, each port needs to provide some detailed network times via the platform/network/ResourceLoadTiming.h API. Without it, some parts of the API won't be correct. I'm happy to give an r+ either way, but just wanted to make sure that was already hooked up or else it is understood that some information won't be correct. 608552 3 cdumez 2012-04-24 04:39:17 -0700 I believe that work was already done in Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp as part of enabling Web Timing for GTK port. The EFL port is using libsoup as well. Am I missing something? 608553 4 cdumez 2012-04-24 04:40:26 -0700 I'm referring to this patch: https://bugs.webkit.org/attachment.cgi?id=134524&action=prettypatch 608560 5 138533 tonyg 2012-04-24 05:11:19 -0700 Comment on attachment 138533 Patch Thanks for confirming. I just wasn't aware that libsoup was used by EFL. Excited to see this turned on. 608614 6 138533 webkit.review.bot 2012-04-24 06:48:43 -0700 Comment on attachment 138533 Patch Clearing flags on attachment: 138533 Committed r115046: <http://trac.webkit.org/changeset/115046> 608615 7 webkit.review.bot 2012-04-24 06:48:48 -0700 All reviewed patches have been landed. Closing bug. 138533 2012-04-24 04:15:30 -0700 2012-04-24 06:48:43 -0700 Patch 84705_webtiming.patch text/plain 3904 cdumez ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA3N2JiOTJkLi45NWZhYzY3 IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTItMDQtMjQgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNv bT4KKworICAgICAgICBbRUZMXSBFbmFibGUgV2ViIFRpbWluZworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODQ3MDUKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFbmFibGUgV2ViIFRpbWluZyBpbiBFRkwgcG9y dCBmb3IgZm9yIHBlcmZvcm1hbmNlIHByb2ZpbGluZyBhbmQKKyAgICAgICAgaW1wcm92ZW1lbnQu CisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvT3B0aW9uc0VmbC5jbWFrZToKKwogMjAxMi0wNC0y MyAgS2VudCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQWRkIHRlc3Qg ZnVuY3Rpb24gdG8gZ2V0IHBsYWNlaG9sZGVyIHN0cmluZwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDEzMTA3NTQuLjJiZWNh YjkgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0wNC0yNCAgQ2hyaXN0b3BoZSBEdW1leiAg PGNocmlzdG9waGUuZHVtZXpAaW50ZWwuY29tPgorCisgICAgICAgIFtFRkxdIEVuYWJsZSBXZWIg VGltaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04 NDcwNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVu c2tpcCB0aGUgdGVzdCBjYXNlcyB0aGF0IHJlcXVpcmUgV2ViIFRpbWluZyBub3cgdGhhdCBpdCBp cyBlbmFibGVkCisgICAgICAgIGJ5IGRlZmF1bHQgaW4gRUZMIHBvcnQuCisKKyAgICAgICAgKiBw bGF0Zm9ybS9lZmwvU2tpcHBlZDoKKwogMjAxMi0wNC0yNCAgU3ppbGFyZCBMZWRhbiAgPHN6bGVk YW5AaW5mLnUtc3plZ2VkLmh1PgogCiAgICAgICAgIFtRdF0gR2FyZGVuaW5nCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvU2tpcHBlZCBiL0xheW91dFRlc3RzL3BsYXRmb3Jt L2VmbC9Ta2lwcGVkCmluZGV4IDc2ZmFkMjEuLjBkZWU3NTUgMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL3BsYXRmb3JtL2VmbC9Ta2lwcGVkCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9T a2lwcGVkCkBAIC03OTksMjAgKzc5OSw2IEBAIHN2Zy93ZWJhcmNoaXZlCiBzdmcvY3VzdG9tL2lt YWdlLXdpdGgtcHJlZml4LWluLXdlYmFyY2hpdmUuc3ZnCiB3ZWJhcmNoaXZlCiAKLSMgVGhlIEVG TCBwb3J0IGhhcyBubyBzdXBwb3J0IGZvciB3ZWJ0aW1pbmcKLWZhc3QvZG9tL1dpbmRvdy93aW5k b3ctcHJvcGVydGllcy1wZXJmb3JtYW5jZS5odG1sCi1mYXN0L2RvbS9uYXZpZ2F0aW9uLXR5cGUt YmFjay1mb3J3YXJkLmh0bWwKLWZhc3QvZG9tL25hdmlnYXRpb24tdHlwZS1uYXZpZ2F0ZS5odG1s Ci1mYXN0L2RvbS9uYXZpZ2F0aW9uLXR5cGUtcmVsb2FkLmh0bWwKLWZhc3QvZG9tL3dlYnRpbWlu Zy5odG1sCi1mYXN0L2RvbS93ZWJ0aW1pbmctbmF2aWdhdGUtd2l0aGluLWRvY3VtZW50Lmh0bWwK LWZhc3QvZG9tL3dlYnRpbWluZy1kb2N1bWVudC1vcGVuLmh0bWwKLWh0dHAvdGVzdHMvbWlzYy93 ZWJ0aW1pbmctb3JpZ2lucy5odG1sCi1odHRwL3Rlc3RzL21pc2Mvd2VidGltaW5nLW9uZS1yZWRp cmVjdC5waHAKLWh0dHAvdGVzdHMvbWlzYy93ZWJ0aW1pbmctc2xvdy1sb2FkLnBocAotaHR0cC90 ZXN0cy9taXNjL3dlYnRpbWluZy1zc2wucGhwCi1odHRwL3Rlc3RzL21pc2Mvd2VidGltaW5nLXR3 by1yZWRpcmVjdHMucGhwCi0KICMgVGhlIEVGTCBwb3J0IGhhcyBubyBzdXBwb3J0IGZvciB3ZWJh dWRpbwogd2ViYXVkaW8KIApkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL09wdGlvbnNFZmwuY21h a2UgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0VmbC5jbWFrZQppbmRleCAxMDM2MmFhLi40NDcwMTNj IDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvT3B0aW9uc0VmbC5jbWFrZQorKysgYi9Tb3VyY2Uv Y21ha2UvT3B0aW9uc0VmbC5jbWFrZQpAQCAtNzcsNiArNzcsNyBAQCBXRUJLSVRfT1BUSU9OX0RF RkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfUkVRVUVTVF9BTklNQVRJT05fRlJBTUUgT04pCiBXRUJL SVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfU0hBUkVEX1dPUktFUlMgT04pCiBX RUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfVklCUkFUSU9OIE9OKQogV0VC S0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX1ZJREVPIE9OKQorV0VCS0lUX09Q VElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX1dFQl9USU1JTkcgT04pCiBXRUJLSVRfT1BU SU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfV09SS0VSUyBPTikKIFdFQktJVF9PUFRJT05f RU5EKCkKIApkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmlu ZGV4IDc5OTM1YzUuLjI1Yjk2MzUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMi0wNC0yNCAgQ2hyaXN0b3BoZSBE dW1leiAgPGNocmlzdG9waGUuZHVtZXpAaW50ZWwuY29tPgorCisgICAgICAgIFtFRkxdIEVuYWJs ZSBXZWIgVGltaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD04NDcwNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEVuYWJsZSB3ZWIgdGltaW5nIGJ5IGRlZmF1bHQgd2hlbmV2ZXIgYnVpbGQtd2Via2l0IGlz IHVzZWQuCisKKyAgICAgICAgKiBTY3JpcHRzL2J1aWxkLXdlYmtpdDoKKwogMjAxMi0wNC0yMyAg RXJpcSBBdWd1c3RpbmUgIDxlYXVndXN0aUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV0dXJu IHZhbHVlIGZyb20gZXhlY3V0ZWQgc2NyaXB0IGluIENocm9taXVtLgpkaWZmIC0tZ2l0IGEvVG9v bHMvU2NyaXB0cy9idWlsZC13ZWJraXQgYi9Ub29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdAppbmRl eCA2YjgzNmVjLi5mNmNlYmUxIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL2J1aWxkLXdlYmtp dAorKysgYi9Ub29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdApAQCAtMzYyLDcgKzM2Miw3IEBAIG15 IEBmZWF0dXJlcyA9ICgKICAgICAgIGRlZmluZSA9PiAiRU5BQkxFX1dFQl9TT0NLRVRTIiwgZGVm YXVsdCA9PiAxLCB2YWx1ZT0+IFwkd2ViU29ja2V0c1N1cHBvcnQgfSwKIAogICAgIHsgb3B0aW9u ID0+ICJ3ZWItdGltaW5nIiwgZGVzYyA9PiAiVG9nZ2xlIFdlYiBUaW1pbmcgc3VwcG9ydCIsCi0g ICAgICBkZWZpbmUgPT4gIkVOQUJMRV9XRUJfVElNSU5HIiwgZGVmYXVsdCA9PiAoaXNCbGFja0Jl cnJ5KCkgfHwgaXNHdGsoKSksIHZhbHVlPT4gXCR3ZWJUaW1pbmdTdXBwb3J0IH0sCisgICAgICBk ZWZpbmUgPT4gIkVOQUJMRV9XRUJfVElNSU5HIiwgZGVmYXVsdCA9PiAoaXNCbGFja0JlcnJ5KCkg fHwgaXNHdGsoKSB8fCBpc0VmbCgpKSwgdmFsdWU9PiBcJHdlYlRpbWluZ1N1cHBvcnQgfSwKIAog ICAgIHsgb3B0aW9uID0+ICJ3b3JrZXJzIiwgZGVzYyA9PiAiVG9nZ2xlIFdlYiBXb3JrZXJzIHN1 cHBvcnQiLAogICAgICAgZGVmaW5lID0+ICJFTkFCTEVfV09SS0VSUyIsIGRlZmF1bHQgPT4gKGlz QXBwbGVXZWJLaXQoKSB8fCBpc0d0aygpIHx8IGlzQmxhY2tCZXJyeSgpIHx8IGlzRWZsKCkpLCB2 YWx1ZSA9PiBcJHdvcmtlcnNTdXBwb3J0IH0sCg==