8469 2006-04-18 19:27:58 -0700 CRASH: WebCore::CSSParser::parseDashboardRegions when attr() is passed 2006-04-19 09:41:30 -0700 1 1 1 Unclassified WebKit CSS 420+ Mac OS X 10.4 RESOLVED FIXED http://toadstool.se/software/iexploder/testcases/safari/5763_181-Safari-Nightly-420+-2006-r13911-2006-04-18.html P1 Major --- 1 thomas+opendarwin webkit-unassigned ap oldest_to_newest 39748 0 thomas+opendarwin 2006-04-18 19:27:58 -0700 Using iExploder 1.3.0 I found the following crash in the Nightly-420+ r13911-2006-04-18 build: Safari.crash.log - 2006-04-18 22:25:04.670 -0400 =================================================== Thread 0 Crashed: 0 com.apple.WebCore 0x01179810 WebCore::CSSParser::parseDashboardRegions(int, bool) + 496 1 com.apple.WebCore 0x0117d69c WebCore::CSSParser::parseValue(int, bool) + 1388 2 com.apple.WebCore 0x01289d94 cssyyparse(void*) + 7476 3 com.apple.WebCore 0x0117a560 WebCore::CSSParser::parseDeclaration(WebCore::CSSMutableStyleDeclaration*, WebCore::String const&) + 96 4 com.apple.WebCore 0x0116fbac WebCore::CSSMutableStyleDeclaration::parseDeclaration(WebCore::String const&) + 60 5 com.apple.WebCore 0x012965fc WebCore::StyledElement::parseMappedAttribute(WebCore::MappedAttribute*) + 700 39749 1 7814 thomas+opendarwin 2006-04-18 19:29:07 -0700 Created attachment 7814 Testcase: table style="-webkit-dashboard-region: attr("a");" 39763 2 ap 2006-04-18 21:59:57 -0700 Reproducible crash = P1. 39781 3 7821 mitz 2006-04-19 03:43:30 -0700 Created attachment 7821 Add missing null check I looked for other places missing this check and found none. 39782 4 7821 eric 2006-04-19 03:45:22 -0700 Comment on attachment 7821 Add missing null check Looks fine. r=me. 39783 5 7821 eric 2006-04-19 03:45:23 -0700 Comment on attachment 7821 Add missing null check Looks fine. r=me. 7814 2006-04-18 19:29:07 -0700 2006-04-18 19:29:07 -0700 Testcase: table style="-webkit-dashboard-region: attr("a");" 5763_181-Safari-Nightly-420+-2006-r13911-2006-04-18.html text/html 143 thomas+opendarwin PGh0bWw+CjxoZWFkPgo8L2hlYWQ+Cjxib2R5PgkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJ CQkJCQkJCQkJCQkJCQkJCQkKPHRhYmxlIHN0eWxlPSItd2Via2l0LWRhc2hib2FyZC1yZWdpb246 IGF0dHIoImEiKTsiPgo8L2JvZHk+CjwvaHRtbD4= 7821 2006-04-19 03:43:30 -0700 2006-04-19 03:45:22 -0700 Add missing null check 8469_r1.patch text/plain 4087 mitz SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDEzOTY2KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDYtIyMtIyMgIE1pdHogUGV0dGVsICA8b3Bl bmRhcndpbi5vcmdAbWl0enBldHRlbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgLSB0ZXN0IGZvciBodHRwOi8vYnVnemlsbGEub3BlbmRhcndp bi5vcmcvc2hvd19idWcuY2dpP2lkPTg0NjkKKyAgICAgICAgICBDUkFTSDogV2ViQ29yZTo6Q1NT UGFyc2VyOjpwYXJzZURhc2hib2FyZFJlZ2lvbnMgd2hlbiBhdHRyKCkgaXMgcGFzc2VkCisKKyAg ICAgICAgKiBmYXN0L2Nzcy9kYXNoYm9hcmQtcmVnaW9ucy1hdHRyLWNyYXNoLWV4cGVjdGVkLnR4 dDogQWRkZWQuCisgICAgICAgICogZmFzdC9jc3MvZGFzaGJvYXJkLXJlZ2lvbnMtYXR0ci1jcmFz aC5odG1sOiBBZGRlZC4KKwogMjAwNi0wNC0xOCAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5j b20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQmV0aC4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3Qv Y3NzL2Rhc2hib2FyZC1yZWdpb25zLWF0dHItY3Jhc2gtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL2Zhc3QvY3NzL2Rhc2hib2FyZC1yZWdpb25zLWF0dHItY3Jhc2gtZXhw ZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9jc3MvZGFzaGJvYXJk LXJlZ2lvbnMtYXR0ci1jcmFzaC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEs NiBAQAorVGVzdCBmb3IgaHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNn aT9pZD04NDY5IENSQVNIOiBXZWJDb3JlOjpDU1NQYXJzZXI6OnBhcnNlRGFzaGJvYXJkUmVnaW9u cyB3aGVuIGF0dHIoKSBpcyBwYXNzZWQuCisKK0lmIHRoZSB0ZXN0IHBhc3NlcyBpdCB3b24ndCBj cmFzaAorCisKKwpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9jc3MvZGFzaGJvYXJkLXJlZ2lvbnMt YXR0ci1jcmFzaC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvY3NzL2Rhc2hi b2FyZC1yZWdpb25zLWF0dHItY3Jhc2guaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3Rz L2Zhc3QvY3NzL2Rhc2hib2FyZC1yZWdpb25zLWF0dHItY3Jhc2guaHRtbAkocmV2aXNpb24gMCkK QEAgLTAsMCArMSwxNCBAQAorPGh0bWw+Cis8aGVhZD4KKzxzY3JpcHQ+CisgICAgaWYgKHdpbmRv dy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVt cEFzVGV4dCgpOworPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxwPlRlc3QgZm9yIDxpPjxh IGhyZWY9Imh0dHA6Ly9idWd6aWxsYS5vcGVuZGFyd2luLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODQ2 OSI+aHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNnaT9pZD04NDY5PC9h PiBDUkFTSDogV2ViQ29yZTo6Q1NTUGFyc2VyOjpwYXJzZURhc2hib2FyZFJlZ2lvbnMgd2hlbiBh dHRyKCkgaXMgcGFzc2VkPC9pPi48L3A+Cis8cD5JZiB0aGUgdGVzdCBwYXNzZXMgaXQgd29uJ3Qg Y3Jhc2g8L3A+IAorPGJyIHN0eWxlPSItd2Via2l0LWRhc2hib2FyZC1yZWdpb246IGRhc2hib2Fy ZC1yZWdpb24oImEiKTsiPgorPHRhYmxlIHN0eWxlPSItd2Via2l0LWRhc2hib2FyZC1yZWdpb246 IGF0dHIoImEiKTsiPgorPC9ib2R5PgorPC9odG1sPgpJbmRleDogV2ViQ29yZS9DaGFuZ2VMb2cK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViQ29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzOTY2KQorKysgV2Vi Q29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAwNi0jIy0j IyAgTWl0eiBQZXR0ZWwgIDxvcGVuZGFyd2luLm9yZ0BtaXR6cGV0dGVsLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAtIGZpeCBodHRwOi8vYnVn emlsbGEub3BlbmRhcndpbi5vcmcvc2hvd19idWcuY2dpP2lkPTg0NjkKKyAgICAgICAgICBDUkFT SDogV2ViQ29yZTo6Q1NTUGFyc2VyOjpwYXJzZURhc2hib2FyZFJlZ2lvbnMgd2hlbiBhdHRyKCkg aXMgcGFzc2VkCisKKyAgICAgICAgVGVzdDogZmFzdC9jc3MvZGFzaGJvYXJkLXJlZ2lvbnMtYXR0 ci1jcmFzaC5odG1sCisKKyAgICAgICAgKiBjc3MvY3NzcGFyc2VyLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkNTU1BhcnNlcjo6cGFyc2VEYXNoYm9hcmRSZWdpb25zKTogQWRkZWQgbnVsbCBjaGVj ayBmb3IgYXJncy4KKwogMjAwNi0wNC0xOCAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+ CiAKICAgICAgICAgKiByZW5kZXJpbmcvcmVuZGVyX2Zvcm0uY3BwOiAoV2ViQ29yZTo6UmVuZGVy U2VsZWN0Ojp1cGRhdGVGcm9tRWxlbWVudCk6CkluZGV4OiBXZWJDb3JlL2Nzcy9jc3NwYXJzZXIu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvY3NzL2Nzc3BhcnNlci5jcHAJKHJldmlzaW9uIDEz OTY2KQorKysgV2ViQ29yZS9jc3MvY3NzcGFyc2VyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTc5 NiwxNSArMTc5NiwxNSBAQCBib29sIENTU1BhcnNlcjo6cGFyc2VEYXNoYm9hcmRSZWdpb25zKGlu CiAgICAgICAgIC8vIGRhc2hib2FyZC1yZWdpb24obGFiZWwsIHR5cGUpIG9yIGRhc2hib2FyZC1y ZWdpb24obGFiZWwgdHlwZSkKICAgICAgICAgLy8gZGFzaGJvYXJkLXJlZ2lvbihsYWJlbCwgdHlw ZSkgb3IgZGFzaGJvYXJkLXJlZ2lvbihsYWJlbCB0eXBlKQogICAgICAgICBWYWx1ZUxpc3QqIGFy Z3MgPSB2YWx1ZS0+ZnVuY3Rpb24tPmFyZ3M7Ci0gICAgICAgIGludCBudW1BcmdzID0gdmFsdWUt PmZ1bmN0aW9uLT5hcmdzLT5zaXplKCk7Ci0gICAgICAgIGlmICgobnVtQXJncyAhPSBEQVNIQk9B UkRfUkVHSU9OX05VTV9QQVJBTUVURVJTICYmIG51bUFyZ3MgIT0gKERBU0hCT0FSRF9SRUdJT05f TlVNX1BBUkFNRVRFUlMqMi0xKSkgJiYKLSAgICAgICAgICAgIChudW1BcmdzICE9IERBU0hCT0FS RF9SRUdJT05fU0hPUlRfTlVNX1BBUkFNRVRFUlMgJiYgbnVtQXJncyAhPSAoREFTSEJPQVJEX1JF R0lPTl9TSE9SVF9OVU1fUEFSQU1FVEVSUyoyLTEpKSl7CisgICAgICAgIFN0cmluZyBmbmFtZSA9 IGRvbVN0cmluZyh2YWx1ZS0+ZnVuY3Rpb24tPm5hbWUpLmxvd2VyKCk7CisgICAgICAgIGlmIChm bmFtZSAhPSAiZGFzaGJvYXJkLXJlZ2lvbigiIHx8ICFhcmdzKSB7CiAgICAgICAgICAgICB2YWxp ZCA9IGZhbHNlOwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0KICAgICAgICAgCi0gICAg ICAgIFN0cmluZyBmbmFtZSA9IGRvbVN0cmluZyh2YWx1ZS0+ZnVuY3Rpb24tPm5hbWUpLmxvd2Vy KCk7Ci0gICAgICAgIGlmIChmbmFtZSAhPSAiZGFzaGJvYXJkLXJlZ2lvbigiKSB7CisgICAgICAg IGludCBudW1BcmdzID0gYXJncy0+c2l6ZSgpOworICAgICAgICBpZiAoKG51bUFyZ3MgIT0gREFT SEJPQVJEX1JFR0lPTl9OVU1fUEFSQU1FVEVSUyAmJiBudW1BcmdzICE9IChEQVNIQk9BUkRfUkVH SU9OX05VTV9QQVJBTUVURVJTKjItMSkpICYmCisgICAgICAgICAgICAobnVtQXJncyAhPSBEQVNI Qk9BUkRfUkVHSU9OX1NIT1JUX05VTV9QQVJBTUVURVJTICYmIG51bUFyZ3MgIT0gKERBU0hCT0FS RF9SRUdJT05fU0hPUlRfTlVNX1BBUkFNRVRFUlMqMi0xKSkpewogICAgICAgICAgICAgdmFsaWQg PSBmYWxzZTsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICB9Cg==