84675 2012-04-24 00:50:12 -0700 [GTK] drag&drop related failures 2012-05-02 08:57:02 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand zan abarth dpranke hnandor mrobinson ojan webkit.review.bot zan oldest_to_newest 608423 0 pnormand 2012-04-24 00:50:12 -0700 I haven't yet figured out this regression. But we need green bots so I'll flag the following tests. Unexpected flakiness: text diff mismatch editing/pasteboard/4947130.html = TEXT PASS editing/pasteboard/dataTransfer-setData-getData.html = TEXT PASS editing/pasteboard/drag-and-drop-image-contenteditable.html = TEXT PASS editing/pasteboard/drag-and-drop-inputimage-contenteditable.html = TEXT PASS editing/pasteboard/drag-and-drop-objectimage-contenteditable.html = TEXT PASS editing/pasteboard/drag-drop-input-textarea.html = TEXT PASS editing/pasteboard/drag-drop-modifies-page.html = TEXT PASS editing/pasteboard/drag-drop-url-text.html = TEXT PASS editing/pasteboard/drag-image-in-about-blank-frame.html = TEXT PASS editing/pasteboard/drag-selected-image-to-contenteditable.html = TEXT PASS editing/pasteboard/drop-inputtext-acquires-style.html = TEXT PASS editing/pasteboard/drop-link.html = TEXT PASS editing/pasteboard/drop-text-events.html = TEXT PASS editing/pasteboard/drop-text-without-selection.html = TEXT PASS editing/pasteboard/file-drag-to-editable.html = TEXT PASS editing/pasteboard/file-input-files-access.html = TEXT PASS editing/pasteboard/get-data-text-plain-drop.html = TEXT PASS editing/pasteboard/subframe-dragndrop-1.html = TEXT PASS Regressions: Unexpected text diff mismatch : fast/forms/drag-into-textarea.html = TEXT fast/forms/drag-out-of-textarea.html = TEXT fast/forms/file/get-file-upload.html = TEXT fast/forms/file/input-file-re-render.html = TEXT fast/forms/file/recover-file-input-in-unposted-form.html = TEXT 608930 1 zan 2012-04-24 12:19:09 -0700 After bisecting the offending commit seems to be r114788. http://trac.webkit.org/changeset/114788 609503 2 pnormand 2012-04-25 00:01:12 -0700 (In reply to comment #1) > After bisecting the offending commit seems to be r114788. > http://trac.webkit.org/changeset/114788 Really? That seems a bit odd :( I'll have a look at this issue. 609526 3 pnormand 2012-04-25 00:50:44 -0700 Indeed, spot-on, Zan! I'll try to figure this one out. 609527 4 zan 2012-04-25 00:51:52 -0700 (In reply to comment #3) > Indeed, spot-on, Zan! I'll try to figure this one out. Great, thanks! 613417 5 pnormand 2012-05-01 08:28:35 -0700 It seems that using this new option --skip-pixel-test-if-no-baseline somehow fixes the issue... Can you confirm Zan? Not sure about using this on the bots though. 613423 6 pnormand 2012-05-01 08:32:19 -0700 CCing Dirk and Nandor on this issue. Do we need to use this new --skip-pixel-test-if-no-baseline option? Any feedback would be appreciated! 613426 7 pnormand 2012-05-01 08:45:28 -0700 Please also note that GTK bots don't run the pixel tests. 613560 8 dpranke 2012-05-01 11:37:44 -0700 I don't know why --skip-pixel-test-if-no-baseline would be causing TEXT regressions; that doesn't make a lot of sense. If you don't run pixel tests, you shouldn't need to use this option at all. 613573 9 pnormand 2012-05-01 11:56:02 -0700 (In reply to comment #8) > I don't know why --skip-pixel-test-if-no-baseline would be causing TEXT regressions; that doesn't make a lot of sense. > > If you don't run pixel tests, you shouldn't need to use this option at all. Yeah that's what I thought. I'll double-check this tomorrow, maybe a little bug sneaked in the patch introducing that new option, for ports not running pixel tests. 614243 10 139800 zan 2012-05-02 06:40:18 -0700 Created attachment 139800 Patch 614258 11 139800 pnormand 2012-05-02 06:54:45 -0700 Comment on attachment 139800 Patch Alright the change and its explanation make sense to me. Thanks! 614267 12 139800 zan 2012-05-02 07:07:34 -0700 Comment on attachment 139800 Patch Clearing flags on attachment: 139800 Committed r115825: <http://trac.webkit.org/changeset/115825> 614268 13 zan 2012-05-02 07:07:43 -0700 All reviewed patches have been landed. Closing bug. 614333 14 139800 mrobinson 2012-05-02 08:57:02 -0700 Comment on attachment 139800 Patch Awesome fix! 139800 2012-05-02 06:40:18 -0700 2012-05-02 08:57:02 -0700 Patch bug-84675-20120502154017.patch text/plain 5416 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1ODE4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzRhZTM3MTU1ODMzN2YzZTE0NTFiMjRkNDNkYjQwOWEy MjE1NjE2Mi4uMmQ2NDZlZTdhYzQ2ZTI2YmQ3OTUxNzUzOGRjMWI3YzNlMGNjMDhkYiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIw IEBACisyMDEyLTA1LTAyICBaYW4gRG9iZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CisK KyAgICAgICAgW0dUS10gZHJhZyZkcm9wIHJlbGF0ZWQgZmFpbHVyZXMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg0Njc1CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmF0aGVyIHRoYW4gY2hlY2tpbmcgb3B0 aW9ucyB0byBzZWUgd2hldGhlciB3ZSdyZSBydW5uaW5nIHBpeGVsIHRlc3RzCisgICAgICAgIHRo ZSBwaXhlbF90ZXN0cyBhcmd1bWVudCBwYXNzZWQgdG8gR3RrRHJpdmVyLl9zdGFydCBzaG91bGQg YmUgdXNlZCBhcworICAgICAgICBpdCBhbHNvIGNvdmVycyBjYXNlcyB3aGVuIHBpeGVsIHRlc3Rz IHNob3VsZCBiZSBydW4gYmVjYXVzZSBvZiB0ZXN0aW5nCisgICAgICAgIHJlZnRlc3RzLiBUaGlz IGFnYWluIGNyZWF0ZXMgZGlmZmVyZW50IFh2ZmIgcHJvY2Vzc2VzIHdpdGggcHJvcGVyCisgICAg ICAgIGRpc3BsYXkgSURzIGZvciBhIHdvcmtlciB0aGF0J3MgcGVyZm9ybWluZyBib3RoIG9yZGlu YXJ5IGFuZCBwaXhlbAorICAgICAgICB0ZXN0cywgYXMgd2FzIHRoZSBjYXNlIGJlZm9yZSBjaGFu Z2VzIG1hZGUgaW4gcjExNDc4OC4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0 X3Rlc3RzL3BvcnQvZ3RrLnB5OgorICAgICAgICAoR3RrRHJpdmVyLl9zdGFydCk6CisKIDIwMTIt MDUtMDEgIFJhcGhhZWwgS3VibyBkYSBDb3N0YSAgPHJha3Vjb0B3ZWJraXQub3JnPgogCiAgICAg ICAgIHdlYmtpdHB5OiBSZW1vdmUgdW51c2VkIHBsYXRmb3JtIGltcG9ydHMuCmRpZmYgLS1naXQg YS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2d0ay5weSBiL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvZ3RrLnB5CmluZGV4IDEwNGZmNDFj ZTBlNmY4NGRmZTc5MDNlYzNjNmQ0MGNkZDE1ZjQwNzAuLjk4NTFhOGIyNmU4ZTdlZWZhZDQ5NzVi YWMwNzNjZTE0M2Y1MzEyY2QgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5 b3V0X3Rlc3RzL3BvcnQvZ3RrLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0 X3Rlc3RzL3BvcnQvZ3RrLnB5CkBAIC01Miw3ICs1Miw3IEBAIGNsYXNzIEd0a0RyaXZlcihXZWJL aXREcml2ZXIpOgogICAgICAgICAjIERyaXZlclByb3h5IGNyZWF0ZXMgdHdvIGRyaXZlcnMsIG9u ZSBmb3Igbm9ybWFsIGFuZCB0aGUgb3RoZXIgZm9yIHJlZiB0ZXN0cy4gQm90aCBoYXZlCiAgICAg ICAgICMgdGhlIHNhbWUgd29ya2VyIG51bWJlciwgc28gdGhpcyBwcmV2ZW50cyB0aGVtIGZyb20g dXNpbmcgdGhlIHNhbWUgWHZmYiBpbnN0YW5jZS4KICAgICAgICAgZGlzcGxheV9pZCA9IHNlbGYu X3dvcmtlcl9udW1iZXIgKiAyICsgcnVubmluZ19kaXNwbGF5cwotICAgICAgICBpZiBzZWxmLl9w b3J0LmdldF9vcHRpb24oJ3BpeGVsX3Rlc3RzJyk6CisgICAgICAgIGlmIHBpeGVsX3Rlc3RzOgog ICAgICAgICAgICAgZGlzcGxheV9pZCArPSAxCiAgICAgICAgIHJ1bl94dmZiID0gWyJYdmZiIiwg IjolZCIgJSAoZGlzcGxheV9pZCksICItc2NyZWVuIiwgICIwIiwgIjgwMHg2MDB4MjQiLCAiLW5v bGlzdGVuIiwgInRjcCJdCiAgICAgICAgIHdpdGggb3Blbihvcy5kZXZudWxsLCAndycpIGFzIGRl dm51bGw6CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKaW5kZXggNjNhNTk5ZGM0YzY0YjA1YzMwYjQ5ZWU3MTJiNDI2Nzc1OWMwNWZhNi4u MWZmMTQ3MWQyMzIyOWIxYjVjY2U2OGJjMWM3NGVmNmVhODkwMzI4OSAxMDA2NDQKLS0tIGEvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE0IEBACisyMDEyLTA1LTAyICBaYW4gRG9iZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5jb20+ CisKKyAgICAgICAgW0dUS10gZHJhZyZkcm9wIHJlbGF0ZWQgZmFpbHVyZXMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg0Njc1CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIHRlc3QgY2FzZXMgZnJv bSBleHBlY3RhdGlvbnMgdGhhdCBhcmUgbm93IHBhc3NpbmcuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9ndGsvdGVzdF9leHBlY3RhdGlvbnMudHh0OgorCiAyMDEyLTA1LTAyICBDc2FiYSBPc3p0cm9n b27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAKICAgICAgICAgW1F0XVtNYWNdIFNraXAgbmV3IGZh aWxpbmcgdGVzdHMgYW5kIG9uZSBjcmFzaGluZyB0ZXN0IHRvIHBhaW50IHRoZSBib3QgZ3JlZW4u CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvdGVzdF9leHBlY3RhdGlvbnMu dHh0IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAppbmRl eCAzOTNmNDM4YmNjYmYxN2Y5MjM1OTlkZTgyOGM3ZGVkODZjM2I1YWFlLi4yMTNmYjYwODUwMmJl MzY2NmZjOGQxZGQ1YTQ5Y2QxZjNkMmU4MzQ2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9ndGsvdGVzdF9leHBlY3RhdGlvbnMudHh0CisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3Jt L2d0ay90ZXN0X2V4cGVjdGF0aW9ucy50eHQKQEAgLTQ4NCwyNSArNDg0LDYgQEAgQlVHV0s4Mzcw NCA6IG1lZGlhL2V2ZW50LWF0dHJpYnV0ZXMuaHRtbCA9IFBBU1MgVEVYVAogCiBCVUdXSzg0MDM3 IDogZmFzdC90ZXh0L2ludGVybmF0aW9uYWwvc3BhY2VzLWNvbWJpbmVkLWluLXZlcnRpY2FsLXRl eHQuaHRtbCA9IFBBU1MgVEVYVAogCi1CVUdXSzg0Njc1IDogZWRpdGluZy9wYXN0ZWJvYXJkLzQ5 NDcxMzAuaHRtbCA9IFRFWFQgUEFTUwotQlVHV0s4NDY3NSA6IGVkaXRpbmcvcGFzdGVib2FyZC9k YXRhVHJhbnNmZXItc2V0RGF0YS1nZXREYXRhLmh0bWwgPSBURVhUIFBBU1MKLUJVR1dLODQ2NzUg OiBlZGl0aW5nL3Bhc3RlYm9hcmQvZHJhZy1hbmQtZHJvcC1pbWFnZS1jb250ZW50ZWRpdGFibGUu aHRtbCA9IFRFWFQgUEFTUwotQlVHV0s4NDY3NSA6IGVkaXRpbmcvcGFzdGVib2FyZC9kcmFnLWFu ZC1kcm9wLWlucHV0aW1hZ2UtY29udGVudGVkaXRhYmxlLmh0bWwgPSBURVhUIFBBU1MKLUJVR1dL ODQ2NzUgOiBlZGl0aW5nL3Bhc3RlYm9hcmQvZHJhZy1hbmQtZHJvcC1vYmplY3RpbWFnZS1jb250 ZW50ZWRpdGFibGUuaHRtbCA9IFRFWFQgUEFTUwotQlVHV0s4NDY3NSA6IGVkaXRpbmcvcGFzdGVi b2FyZC9kcmFnLWRyb3AtaW5wdXQtdGV4dGFyZWEuaHRtbCA9IFRFWFQgUEFTUwotQlVHV0s4NDY3 NSA6IGVkaXRpbmcvcGFzdGVib2FyZC9kcmFnLWRyb3AtbW9kaWZpZXMtcGFnZS5odG1sID0gVEVY VCBQQVNTCi1CVUdXSzg0Njc1IDogZWRpdGluZy9wYXN0ZWJvYXJkL2RyYWctZHJvcC11cmwtdGV4 dC5odG1sID0gVEVYVCBQQVNTCi1CVUdXSzg0Njc1IDogZWRpdGluZy9wYXN0ZWJvYXJkL2RyYWct aW1hZ2UtaW4tYWJvdXQtYmxhbmstZnJhbWUuaHRtbCA9IFRFWFQgUEFTUwotQlVHV0s4NDY3NSA6 IGVkaXRpbmcvcGFzdGVib2FyZC9kcmFnLXNlbGVjdGVkLWltYWdlLXRvLWNvbnRlbnRlZGl0YWJs ZS5odG1sID0gVEVYVCBQQVNTCi1CVUdXSzg0Njc1IDogZWRpdGluZy9wYXN0ZWJvYXJkL2Ryb3At aW5wdXR0ZXh0LWFjcXVpcmVzLXN0eWxlLmh0bWwgPSBURVhUIFBBU1MKLUJVR1dLODQ2NzUgOiBl ZGl0aW5nL3Bhc3RlYm9hcmQvZHJvcC1saW5rLmh0bWwgPSBURVhUIFBBU1MKLUJVR1dLODQ2NzUg OiBlZGl0aW5nL3Bhc3RlYm9hcmQvZHJvcC10ZXh0LWV2ZW50cy5odG1sID0gVEVYVCBQQVNTCi1C VUdXSzg0Njc1IDogZWRpdGluZy9wYXN0ZWJvYXJkL2Ryb3AtdGV4dC13aXRob3V0LXNlbGVjdGlv bi5odG1sID0gVEVYVCBQQVNTCi1CVUdXSzg0Njc1IDogZWRpdGluZy9wYXN0ZWJvYXJkL2ZpbGUt ZHJhZy10by1lZGl0YWJsZS5odG1sID0gVEVYVCBQQVNTCi1CVUdXSzg0Njc1IDogZWRpdGluZy9w YXN0ZWJvYXJkL2ZpbGUtaW5wdXQtZmlsZXMtYWNjZXNzLmh0bWwgPSBURVhUIFBBU1MKLUJVR1dL ODQ2NzUgOiBlZGl0aW5nL3Bhc3RlYm9hcmQvZ2V0LWRhdGEtdGV4dC1wbGFpbi1kcm9wLmh0bWwg PSBURVhUIFBBU1MKLUJVR1dLODQ2NzUgOiBlZGl0aW5nL3Bhc3RlYm9hcmQvc3ViZnJhbWUtZHJh Z25kcm9wLTEuaHRtbCA9IFRFWFQgUEFTUwotCiBCVUdXSzg0NzAwIDogZmFzdC9kb20vV2luZG93 L3dpbmRvdy1wb3N0bWVzc2FnZS1jbG9uZS5odG1sID0gUEFTUyBURVhUCiBCVUdXSzg0NzAwIDog ZmFzdC9kb20vV2luZG93L3dpbmRvdy1wb3N0bWVzc2FnZS1jbG9uZS1mcmFtZXMuaHRtbCA9IFBB U1MgVEVYVAogCkBAIC0xNTI4LDEzICsxNTA5LDYgQEAgQlVHV0s3Mzc0NCA6IGZhc3QvdGFibGUv dGQtd2lkdGgtZmlmdHktcGVyY2VudC1yZWdyZXNzaW9uLmh0bWwgPSBGQUlMCiAKIEJVR1dLODQz NzggOiBtZWRpYS90cmFjay90cmFjay1jdWUtcmVuZGVyaW5nLXNuYXAtdG8tbGluZXMtbm90LXNl dC5odG1sID0gRkFJTAogCi1CVUdXSzg0Njc1IDogZmFzdC9mb3Jtcy9kcmFnLWludG8tdGV4dGFy ZWEuaHRtbCA9IFRFWFQKLUJVR1dLODQ2NzUgOiBmYXN0L2Zvcm1zL2RyYWctb3V0LW9mLXRleHRh cmVhLmh0bWwgPSBURVhUCi1CVUdXSzg0Njc1IDogZmFzdC9mb3Jtcy9maWxlL2dldC1maWxlLXVw bG9hZC5odG1sID0gVEVYVAotQlVHV0s4NDY3NSA6IGZhc3QvZm9ybXMvZmlsZS9pbnB1dC1maWxl LXJlLXJlbmRlci5odG1sID0gVEVYVAotQlVHV0s4NDY3NSA6IGZhc3QvZm9ybXMvZmlsZS9yZWNv dmVyLWZpbGUtaW5wdXQtaW4tdW5wb3N0ZWQtZm9ybS5odG1sID0gVEVYVAotQlVHV0s4NDY3NSA6 IGZhc3QvbGlzdHMvZHJhZy1pbnRvLW1hcmtlci5odG1sID0gVEVYVAotCiBCVUdXSzg0Njc4IDog ZmFzdC9zcGF0aWFsLW5hdmlnYXRpb24vc25hdi1jb250YWluZXItd2hpdGUtc3BhY2UuaHRtbCA9 IFRFWFQKIEJVR1dLODQ2NzggOiBmYXN0L3NwYXRpYWwtbmF2aWdhdGlvbi9zbmF2LWZ1bGx5LWFs aWduZWQtaG9yaXpvbnRhbGx5Lmh0bWwgPSBURVhUCiBCVUdXSzg0Njc4IDogZmFzdC9zcGF0aWFs LW5hdmlnYXRpb24vc25hdi1pZnJhbWUtbm8tc2Nyb2xsYWJsZS1jb250ZW50Lmh0bWwgPSBURVhU Cg==