84647 2012-04-23 15:59:49 -0700 Oscillator::setWaveTable() should not reset oscillator phase 2012-04-23 20:19:59 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 crogers crogers eric.carlson feature-media-reviews kbr webkit.review.bot oldest_to_newest 608137 0 crogers 2012-04-23 15:59:49 -0700 Oscillator::setWaveTable() should not reset oscillator phase 608139 1 138448 crogers 2012-04-23 16:01:28 -0700 Created attachment 138448 Patch 608145 2 138448 kbr 2012-04-23 16:05:01 -0700 Comment on attachment 138448 Patch Looks straightforward. Layout test? 608149 3 138448 crogers 2012-04-23 16:08:33 -0700 Comment on attachment 138448 Patch Thanks Ken. Unfortunately, this is quite difficult to test since it involves the main thread calling setWaveTable() while the audio thread is rendering, and this is racy as far as layout tests go. 608332 4 138448 webkit.review.bot 2012-04-23 20:19:55 -0700 Comment on attachment 138448 Patch Clearing flags on attachment: 138448 Committed r114988: <http://trac.webkit.org/changeset/114988> 608333 5 webkit.review.bot 2012-04-23 20:19:59 -0700 All reviewed patches have been landed. Closing bug. 138448 2012-04-23 16:01:28 -0700 2012-04-23 20:19:55 -0700 Patch bug-84647-20120423160126.patch text/plain 1226 crogers U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0OTIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTkwYjAyODAyYjZkNWY0 MTg0M2JjNzJhYTRmMmQ5OTc4NjE2NDc3Yy4uNjA4MzhmZjJhZTU5NDU3NGIxZDNhNjlmOWIzZDc3 NzA0Yjk3YTY2OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTA0LTIzICBDaHJp cyBSb2dlcnMgIDxjcm9nZXJzQGdvb2dsZS5jb20+CisKKyAgICAgICAgT3NjaWxsYXRvcjo6c2V0 V2F2ZVRhYmxlKCkgc2hvdWxkIG5vdCByZXNldCBvc2NpbGxhdG9yIHBoYXNlCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NDY0NworICAgICAgICAKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBNb2R1bGVzL3dl YmF1ZGlvL09zY2lsbGF0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6T3NjaWxsYXRvcjo6c2V0 V2F2ZVRhYmxlKToKKwogMjAxMi0wNC0yMyAgS2VudGFybyBIYXJhICA8aGFyYWtlbkBjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgW1Y4XVtSZWZhY3RvcmluZ10gUmVtb3ZlIFY4UHJveHk6OnRvVjgo KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9Pc2NpbGxhdG9y LmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vT3NjaWxsYXRvci5jcHAKaW5k ZXggMzk4ZDM1OTNkNmJhZmU2MjZiMGZjMmUyZjEyNzJjY2Q4MTY1NGRkNy4uYzU1NDNiYzU4YmQ3 MjgzN2UyYWZiYmIwNGM0ZGQ0ZjM3MzU5ZTdmYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv TW9kdWxlcy93ZWJhdWRpby9Pc2NpbGxhdG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1 bGVzL3dlYmF1ZGlvL09zY2lsbGF0b3IuY3BwCkBAIC0yNzUsNyArMjc1LDYgQEAgdm9pZCBPc2Np bGxhdG9yOjpzZXRXYXZlVGFibGUoV2F2ZVRhYmxlKiB3YXZlVGFibGUpCiAgICAgTXV0ZXhMb2Nr ZXIgcHJvY2Vzc0xvY2tlcihtX3Byb2Nlc3NMb2NrKTsKICAgICBtX3dhdmVUYWJsZSA9IHdhdmVU YWJsZTsKICAgICBtX3R5cGUgPSBDVVNUT007Ci0gICAgbV92aXJ0dWFsUmVhZEluZGV4ID0gMDsK IH0KIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQo=