84644 2012-04-23 15:39:02 -0700 WaveTable should normalize to 0dbFS instead of -6dbFS 2012-04-24 14:20:29 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 crogers crogers eric.carlson feature-media-reviews kbr webkit.review.bot oldest_to_newest 608102 0 crogers 2012-04-23 15:39:02 -0700 WaveTable should normalize to 0dbFS instead of -6dbFS 608108 1 138441 crogers 2012-04-23 15:42:46 -0700 Created attachment 138441 Patch 608111 2 crogers 2012-04-23 15:43:53 -0700 The Web Audio API spec: https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#dfn-createWaveTable says that createWaveTable() normalizes to 0dbFS 608147 3 138441 kbr 2012-04-23 16:07:25 -0700 Comment on attachment 138441 Patch OK. Would it make sense to rebaseline the tests in this patch? 608151 4 crogers 2012-04-23 16:10:13 -0700 I was planning to land the patch manually, and then use "garden-o-matic" to re-baseline all platforms once the new baselines become available. 609058 5 crogers 2012-04-24 14:20:29 -0700 Committed r115111: <http://trac.webkit.org/changeset/115111> 138441 2012-04-23 15:42:46 -0700 2012-04-23 16:07:25 -0700 Patch bug-84644-20120423154245.patch text/plain 1412 crogers U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0OTIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTkwYjAyODAyYjZkNWY0 MTg0M2JjNzJhYTRmMmQ5OTc4NjE2NDc3Yy4uMjcyMWFmM2ExMGYzYTdiYjFjZDM3MjRiYmUyYTMy NzMwZTUxNjUwNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA0LTIzICBDaHJp cyBSb2dlcnMgIDxjcm9nZXJzQGdvb2dsZS5jb20+CisKKyAgICAgICAgV2F2ZVRhYmxlIHNob3Vs ZCBub3JtYWxpemUgdG8gMGRiRlMgaW5zdGVhZCBvZiAtNmRiRlMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg0NjQ0CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiAgRXhpc3RpbmcgT3Nj aWxsYXRvciB0ZXN0cyBtdXN0IGJlIHJlLWJhc2VsaW5lZC4KKworICAgICAgICAqIE1vZHVsZXMv d2ViYXVkaW8vV2F2ZVRhYmxlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OldhdmVUYWJsZTo6Y3Jl YXRlQmFuZExpbWl0ZWRUYWJsZXMpOgorCiAyMDEyLTA0LTIzICBLZW50YXJvIEhhcmEgIDxoYXJh a2VuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbVjhdW1JlZmFjdG9yaW5nXSBSZW1vdmUgVjhQ cm94eTo6dG9WOCgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlv L1dhdmVUYWJsZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL1dhdmVUYWJs ZS5jcHAKaW5kZXggOTYwY2E2ZmJjMzlmYTVkNGUzYzgzODFhNTBmMTYzODM1MTU4ZGM2Ni4uOTJl OTQ0YmY1MDhiNGM3MDk3MDMyNzI3YTE0Nzc5ZjkxNTU0Mjc3OSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9XYXZlVGFibGUuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL01vZHVsZXMvd2ViYXVkaW8vV2F2ZVRhYmxlLmNwcApAQCAtMjExLDcgKzIxMSw3IEBAIHZv aWQgV2F2ZVRhYmxlOjpjcmVhdGVCYW5kTGltaXRlZFRhYmxlcyhjb25zdCBmbG9hdCogcmVhbERh dGEsIGNvbnN0IGZsb2F0KiBpbWFnCiAgICAgICAgICAgICB2bWF4bWd2KGRhdGEsIDEsICZtYXhW YWx1ZSwgbV93YXZlVGFibGVTaXplKTsKIAogICAgICAgICAgICAgaWYgKG1heFZhbHVlKQotICAg ICAgICAgICAgICAgIG5vcm1hbGl6YXRpb25TY2FsZSA9IDAuNWYgLyBtYXhWYWx1ZTsKKyAgICAg ICAgICAgICAgICBub3JtYWxpemF0aW9uU2NhbGUgPSAxLjBmIC8gbWF4VmFsdWU7CiAgICAgICAg IH0KIAogICAgICAgICAvLyBBcHBseSBub3JtYWxpemF0aW9uIHNjYWxlLgo=