84640 2012-04-23 15:17:24 -0700 [V8] Fix issue with trying to access a constructor in a frame that has been removed 2012-04-23 20:22:11 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 arv arv abarth adamk haraken japhet webkit.review.bot oldest_to_newest 608066 0 arv 2012-04-23 15:17:24 -0700 [V8] Fix issue with trying to access a constructor in a frame that has been removed 608074 1 138436 arv 2012-04-23 15:20:39 -0700 Created attachment 138436 Patch 608080 2 arv 2012-04-23 15:23:35 -0700 http://code.google.com/p/chromium/issues/detail?id=124165 608087 3 138436 haraken 2012-04-23 15:29:25 -0700 Comment on attachment 138436 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138436&action=review > LayoutTests/fast/dom/constructor-in-removed-frame.html:17 > + frame.Window; Shall we check the value of frame.Window? 608105 4 arv 2012-04-23 15:41:24 -0700 (In reply to comment #3) > (From update of attachment 138436 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=138436&action=review > > > LayoutTests/fast/dom/constructor-in-removed-frame.html:17 > > + frame.Window; > > Shall we check the value of frame.Window? We could but V8 and JSC report different values. V8 returns undefined. JSC returns the Window constructor. V8 matches Firefox and Opera. IE throws access denied. Based on that I don't think we should check the actual value. 608109 5 138436 haraken 2012-04-23 15:43:07 -0700 Comment on attachment 138436 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138436&action=review >>> LayoutTests/fast/dom/constructor-in-removed-frame.html:17 >>> + frame.Window; >> >> Shall we check the value of frame.Window? > > We could but V8 and JSC report different values. > > V8 returns undefined. JSC returns the Window constructor. V8 matches Firefox and Opera. IE throws access denied. > > Based on that I don't think we should check the actual value. Sounds reasonable. 608334 6 138436 webkit.review.bot 2012-04-23 20:22:06 -0700 Comment on attachment 138436 Patch Clearing flags on attachment: 138436 Committed r114989: <http://trac.webkit.org/changeset/114989> 608335 7 webkit.review.bot 2012-04-23 20:22:11 -0700 All reviewed patches have been landed. Closing bug. 138436 2012-04-23 15:20:39 -0700 2012-04-23 20:22:06 -0700 Patch bug-84640-20120423152038.patch text/plain 3903 arv U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0OTM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDRhZDllZTY3MmVjNjRj MTMzYzJlOGQ2Mzk2M2M0NzE2YTU5NTUzNy4uMWNiMTkwMTU3YjFmMjVhOTJmNDgxNzZhZjFkNDRi YTI0YjAzMWQ0ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA0LTIzICBFcmlr IEFydmlkc3NvbiAgPGFydkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW1Y4XSBGaXggaXNzdWUg d2l0aCB0cnlpbmcgdG8gYWNjZXNzIGEgY29uc3RydWN0b3IgaW4gYSBmcmFtZSB0aGF0IGhhcyBi ZWVuIHJlbW92ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTg0NjQwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgVGhpcyByZWdyZXNzZWQgaW4gcjExMzI1MC4gTm93IHdlIGRvIHdoYXQgd2UgZGlkIGJlZm9y ZSBhbmQgcmV0dXJuIHVuZGVmaW5lZCBpZiB0aGUgZnJhbWUKKyAgICAgICAgZG9lcyBub3QgaGF2 ZSBhIGNvbnRleHQuCisKKyAgICAgICAgVGVzdDogZmFzdC9kb20vY29uc3RydWN0b3ItaW4tcmVt b3ZlZC1mcmFtZS5odG1sCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOERPTVdyYXBwZXIuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6VjhET01XcmFwcGVyOjpjb25zdHJ1Y3RvckZvclR5cGUpOgor CiAyMDEyLTA0LTIzICBFbWlsIEEgRWtsdW5kICA8ZWFlQGNocm9taXVtLm9yZz4KIAogICAgICAg ICBDcmFzaCBpbiBSZW5kZXJJbmxpbmU6OmNsaXBwZWRPdmVyZmxvd1JlY3RGb3JSZXBhaW50IGZv ciBQcmludFByZXZpZXcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4 RE9NV3JhcHBlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdyYXBwZXIu Y3BwCmluZGV4IDg0MmEwYjRlNGEzNDRlNzY3OTExNzhkODNmYWVmMjZiNjdkNGNlZTYuLjIzN2Fj MWMwMjFmMmY2OTViZmEwZWFlNWE4NmZmOTIxZmRkY2Y3YmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv YmluZGluZ3MvdjgvVjhET01XcmFwcGVyLmNwcApAQCAtODcsNyArODcsMTEgQEAgdjg6OkxvY2Fs PHY4OjpGdW5jdGlvbj4gVjhET01XcmFwcGVyOjpjb25zdHJ1Y3RvckZvclR5cGUoV3JhcHBlclR5 cGVJbmZvKiB0eXBlLAogICAgIEZyYW1lKiBmcmFtZSA9IHdpbmRvdy0+ZnJhbWUoKTsKICAgICBp ZiAoIWZyYW1lKQogICAgICAgICByZXR1cm4gdjg6OkxvY2FsPHY4OjpGdW5jdGlvbj4oKTsKLSAg ICByZXR1cm4gVjhQcm94eTo6cmV0cmlldmVQZXJDb250ZXh0RGF0YShmcmFtZSktPmNvbnN0cnVj dG9yRm9yVHlwZSh0eXBlKTsKKworICAgIGlmIChWOEJpbmRpbmdQZXJDb250ZXh0RGF0YSogY29u dGV4dERhdGEgPSBWOFByb3h5OjpyZXRyaWV2ZVBlckNvbnRleHREYXRhKGZyYW1lKSkKKyAgICAg ICAgcmV0dXJuIGNvbnRleHREYXRhLT5jb25zdHJ1Y3RvckZvclR5cGUodHlwZSk7CisKKyAgICBy ZXR1cm4gdjg6OkxvY2FsPHY4OjpGdW5jdGlvbj4oKTsKIH0KIAogI2lmIEVOQUJMRShXT1JLRVJT KQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCmluZGV4IDU1NTQ1ZjViMjVkZjA1NTNlYTUwNDc1NmUyOTUwMDI0M2U1OWYzNmIuLjA0OTQx ODdkZGEyMGJmMGFhNzJiNzM1ZTAxZjg2ODNmZDQwOWRiNjkgMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBA QAorMjAxMi0wNC0yMyAgRXJpayBBcnZpZHNzb24gIDxhcnZAY2hyb21pdW0ub3JnPgorCisgICAg ICAgIFtWOF0gRml4IGlzc3VlIHdpdGggdHJ5aW5nIHRvIGFjY2VzcyBhIGNvbnN0cnVjdG9yIGlu IGEgZnJhbWUgdGhhdCBoYXMgYmVlbiByZW1vdmVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NDY0MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogZmFzdC9kb20vY29uc3RydWN0b3ItaW4tcmVtb3ZlZC1m cmFtZS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZG9tL2NvbnN0cnVjdG9y LWluLXJlbW92ZWQtZnJhbWUuaHRtbDogQWRkZWQuCisKIDIwMTItMDQtMjMgIFNoZXJpZmYgQm90 ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJv bGxpbmcgb3V0IHIxMTQ5MjkuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9jb25z dHJ1Y3Rvci1pbi1yZW1vdmVkLWZyYW1lLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3Qv ZG9tL2NvbnN0cnVjdG9yLWluLXJlbW92ZWQtZnJhbWUtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1v ZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAu LjdlZjIyZTlhNDMxYWQwMjcyNzEzYjcxZmRjODc5NDAxNmM4ZWYxMmYKLS0tIC9kZXYvbnVsbAor KysgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9jb25zdHJ1Y3Rvci1pbi1yZW1vdmVkLWZyYW1lLWV4 cGVjdGVkLnR4dApAQCAtMCwwICsxIEBACitQQVNTCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9m YXN0L2RvbS9jb25zdHJ1Y3Rvci1pbi1yZW1vdmVkLWZyYW1lLmh0bWwgYi9MYXlvdXRUZXN0cy9m YXN0L2RvbS9jb25zdHJ1Y3Rvci1pbi1yZW1vdmVkLWZyYW1lLmh0bWwKbmV3IGZpbGUgbW9kZSAx MDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uYWI2 NzcxNDkyZWVjM2MzMDA1Njg0NzBiNzM0YjI4OWQ4MjQyYjRjZAotLS0gL2Rldi9udWxsCisrKyBi L0xheW91dFRlc3RzL2Zhc3QvZG9tL2NvbnN0cnVjdG9yLWluLXJlbW92ZWQtZnJhbWUuaHRtbApA QCAtMCwwICsxLDI4IEBACis8IURPQ1RZUEUgaHRtbD4KKzxwPkZBSUw8L3A+Cis8aWZyYW1lIHNy Yz0iZGF0YTp0ZXh0L2h0bWwsRkFJTCI+PC9pZnJhbWU+Cis8c2NyaXB0PgorCit3aW5kb3cub25s b2FkID0gZnVuY3Rpb24oKSB7CisgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikg eworICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7CisgICAgICAg IGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKworICAgICAgICB2YXIgaWZyYW1l RWxlbWVudCA9IGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoJ2lmcmFtZScpOworICAgICAgICBpZnJh bWVFbGVtZW50Lm9ubG9hZCA9IGZ1bmN0aW9uKCkgeworICAgICAgICAgICAgdmFyIGZyYW1lID0g d2luZG93LmZyYW1lc1swXTsKKyAgICAgICAgICAgIGlmcmFtZUVsZW1lbnQucGFyZW50Tm9kZS5y ZW1vdmVDaGlsZChpZnJhbWVFbGVtZW50KTsKKworICAgICAgICAgICAgLy8gVGhlIFY4IGJpbmRp bmdzIGRvZXMgbm90IGtlZXAgdGhlIGZyYW1lIGNvbnN0cnVjdG9yIGFsaXZlIGJ1dCBhdCBsZWFz dCBpdCBzaG91bGQgbm90IGNyYXNoIQorICAgICAgICAgICAgZnJhbWUuV2luZG93OworCisgICAg ICAgICAgICBkb2N1bWVudC5ib2R5LnRleHRDb250ZW50ID0gJ1BBU1MnOworICAgICAgICAgICAg bGF5b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9uZSgpOworICAgICAgICB9OworICAgICAgICBp ZnJhbWVFbGVtZW50LnNyYyA9ICdkYXRhOnRleHQvaHRtbCxQQVNTJzsKKyAgICB9Cit9OworCis8 L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K