84630 2012-04-23 13:48:31 -0700 REGRESSION(r109981): Broke Twitter map buddy icon (see https://bugs.webkit.org/show_bug.cgi?id=84558) (Requested by thorton on #webkit). 2012-04-23 14:59:05 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 63499 1 webkit.review.bot webkit.review.bot enne simon.fraser oldest_to_newest 607988 0 webkit.review.bot 2012-04-23 13:48:31 -0700 http://trac.webkit.org/changeset/109981 broke the build: Broke Twitter map buddy icon (see https://bugs.webkit.org/show_bug.cgi?id=84558) (Requested by thorton on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 607990 1 138417 webkit.review.bot 2012-04-23 13:49:07 -0700 Created attachment 138417 ROLLOUT of r109981 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 608043 2 138417 webkit.review.bot 2012-04-23 14:59:00 -0700 Comment on attachment 138417 ROLLOUT of r109981 Clearing flags on attachment: 138417 Committed r114950: <http://trac.webkit.org/changeset/114950> 608044 3 webkit.review.bot 2012-04-23 14:59:05 -0700 All reviewed patches have been landed. Closing bug. 138417 2012-04-23 13:49:07 -0700 2012-04-23 14:59:00 -0700 ROLLOUT of r109981 bug-84630-20120423205238.patch text/plain 6040 webkit.review.bot U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0OTM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDRhZDllZTY3MmVjNjRj MTMzYzJlOGQ2Mzk2M2M0NzE2YTU5NTUzNy4uZTliZTQ2Y2M5Y2ZhNWY0MzhiZGU4ZjA2YjczNDgy ODY1N2ViOTljZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA0LTIzICBTaGVy aWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KKworICAgICAgICBVbnJldmll d2VkLCByb2xsaW5nIG91dCByMTA5OTgxLgorICAgICAgICBodHRwOi8vdHJhYy53ZWJraXQub3Jn L2NoYW5nZXNldC8xMDk5ODEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTg0NjMwCisKKyAgICAgICAgQnJva2UgVHdpdHRlciBtYXAgYnVkZHkgaWNvbiAo c2VlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NDU1 OCkgKFJlcXVlc3RlZCBieQorICAgICAgICB0aG9ydG9uIG9uICN3ZWJraXQpLgorCisgICAgICAg ICogcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpSZW5kZXJMYXllckNvbXBvc2l0b3I6OmFkZFRvT3ZlcmxhcE1hcCk6CisgICAgICAgIChXZWJD b3JlOjpSZW5kZXJMYXllckNvbXBvc2l0b3I6OmNvbXB1dGVDb21wb3NpdGluZ1JlcXVpcmVtZW50 cyk6CisKIDIwMTItMDQtMjMgIEVtaWwgQSBFa2x1bmQgIDxlYWVAY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIENyYXNoIGluIFJlbmRlcklubGluZTo6Y2xpcHBlZE92ZXJmbG93UmVjdEZvclJlcGFp bnQgZm9yIFByaW50UHJldmlldwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyTGF5ZXJDb21wb3NpdG9yLmNwcAppbmRleCBiMzAyNWFiMDYwYzJmY2YzYjAyODQ5ODZiNDMw YjkyZTUxOWZhNWNhLi4zN2I1ZmY3YmUwNmZiZDFkNjRiZDQzODdlOGE2YTBlYzVjMzBhOGU4IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9y LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9y LmNwcApAQCAtNTY1LDEyICs1NjUsMTIgQEAgdm9pZCBSZW5kZXJMYXllckNvbXBvc2l0b3I6OmFk ZFRvT3ZlcmxhcE1hcChPdmVybGFwTWFwJiBvdmVybGFwTWFwLCBSZW5kZXJMYXllcioKIAogICAg IGlmICghYm91bmRzQ29tcHV0ZWQpIHsKICAgICAgICAgbGF5ZXJCb3VuZHMgPSBsYXllci0+cmVu ZGVyZXIoKS0+bG9jYWxUb0Fic29sdXRlUXVhZChGbG9hdFJlY3QobGF5ZXItPmxvY2FsQm91bmRp bmdCb3goKSkpLmVuY2xvc2luZ0JvdW5kaW5nQm94KCk7CisgICAgICAgIC8vIEVtcHR5IHJlY3Rz IG5ldmVyIGludGVyc2VjdCwgYnV0IHdlIG5lZWQgdGhlbSB0byBmb3IgdGhlIHB1cnBvc2VzIG9m IG92ZXJsYXAgdGVzdGluZy4KKyAgICAgICAgaWYgKGxheWVyQm91bmRzLmlzRW1wdHkoKSkKKyAg ICAgICAgICAgIGxheWVyQm91bmRzLnNldFNpemUoSW50U2l6ZSgxLCAxKSk7CiAgICAgICAgIGJv dW5kc0NvbXB1dGVkID0gdHJ1ZTsKICAgICB9CiAKLSAgICBpZiAobGF5ZXJCb3VuZHMuaXNFbXB0 eSgpKQotICAgICAgICByZXR1cm47Ci0KICAgICBJbnRSZWN0IGNsaXBSZWN0ID0gcGl4ZWxTbmFw cGVkSW50UmVjdChsYXllci0+YmFja2dyb3VuZENsaXBSZWN0KHJvb3RSZW5kZXJMYXllcigpLCAw LCB0cnVlKS5yZWN0KCkpOyAvLyBGSVhNRTogSW5jb3JyZWN0IGZvciBDU1MgcmVnaW9ucy4KICAg ICBjbGlwUmVjdC5zY2FsZShwYWdlU2NhbGVGYWN0b3IoKSk7CiAgICAgY2xpcFJlY3QuaW50ZXJz ZWN0KGxheWVyQm91bmRzKTsKQEAgLTY0Niw2ICs2NDYsOCBAQCB2b2lkIFJlbmRlckxheWVyQ29t cG9zaXRvcjo6Y29tcHV0ZUNvbXBvc2l0aW5nUmVxdWlyZW1lbnRzKFJlbmRlckxheWVyKiBsYXll ciwgTwogICAgICAgICAvLyBJZiB3ZSdyZSB0ZXN0aW5nIGZvciBvdmVybGFwLCB3ZSBvbmx5IG5l ZWQgdG8gY29tcG9zaXRlIGlmIHdlIG92ZXJsYXAgc29tZXRoaW5nIHRoYXQgaXMgYWxyZWFkeSBj b21wb3NpdGVkLgogICAgICAgICBhYnNCb3VuZHMgPSBsYXllci0+cmVuZGVyZXIoKS0+bG9jYWxU b0Fic29sdXRlUXVhZChGbG9hdFJlY3QobGF5ZXItPmxvY2FsQm91bmRpbmdCb3goKSkpLmVuY2xv c2luZ0JvdW5kaW5nQm94KCk7CiAgICAgICAgIC8vIEVtcHR5IHJlY3RzIG5ldmVyIGludGVyc2Vj dCwgYnV0IHdlIG5lZWQgdGhlbSB0byBmb3IgdGhlIHB1cnBvc2VzIG9mIG92ZXJsYXAgdGVzdGlu Zy4KKyAgICAgICAgaWYgKGFic0JvdW5kcy5pc0VtcHR5KCkpCisgICAgICAgICAgICBhYnNCb3Vu ZHMuc2V0U2l6ZShJbnRTaXplKDEsIDEpKTsKICAgICAgICAgaGF2ZUNvbXB1dGVkQm91bmRzID0g dHJ1ZTsKICAgICAgICAgbXVzdE92ZXJsYXBDb21wb3NpdGVkTGF5ZXJzID0gb3ZlcmxhcE1hcC0+ b3ZlcmxhcHNMYXllcnMoYWJzQm91bmRzKTsKICAgICB9CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNTU1NDVmNWIyNWRmMDU1 M2VhNTA0NzU2ZTI5NTAwMjQzZTU5ZjM2Yi4uNDUwNTMwODM4YjY3OTc1NmFiNTQ2ZDlkZWEwYThl NjM4MDUxNTQwZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91 dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDEyLTA0LTIzICBTaGVyaWZmIEJv dCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAorICAgICAgICBVbnJldmlld2VkLCBy b2xsaW5nIG91dCByMTA5OTgxLgorICAgICAgICBodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5n ZXNldC8xMDk5ODEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTg0NjMwCisKKyAgICAgICAgQnJva2UgVHdpdHRlciBtYXAgYnVkZHkgaWNvbiAoc2VlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NDU1OCkgKFJl cXVlc3RlZCBieQorICAgICAgICB0aG9ydG9uIG9uICN3ZWJraXQpLgorCisgICAgICAgICogY29t cG9zaXRpbmcvbGF5ZXItY3JlYXRpb24vb3ZlcmxhcC1lbXB0eS1sYXllci1leHBlY3RlZC50eHQ6 IFJlbW92ZWQuCisgICAgICAgICogY29tcG9zaXRpbmcvbGF5ZXItY3JlYXRpb24vb3ZlcmxhcC1l bXB0eS1sYXllci5odG1sOiBSZW1vdmVkLgorCisyMDEyLTA0LTIzICBTaGVyaWZmIEJvdCAgPHdl YmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KKwogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5n IG91dCByMTE0OTI5LgogICAgICAgICBodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC8x MTQ5MjkKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg0 NjIzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9jb21wb3NpdGluZy9sYXllci1jcmVhdGlvbi9v dmVybGFwLWVtcHR5LWxheWVyLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2NvbXBvc2l0aW5n L2xheWVyLWNyZWF0aW9uL292ZXJsYXAtZW1wdHktbGF5ZXItZXhwZWN0ZWQudHh0CmRlbGV0ZWQg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCA5YjU0OGMyYTc1NDIwYjRhZDQ5NmRjZmIzODk1Y2UwZmUz OWE3NjRhLi4wMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwCi0tLSBhL0xh eW91dFRlc3RzL2NvbXBvc2l0aW5nL2xheWVyLWNyZWF0aW9uL292ZXJsYXAtZW1wdHktbGF5ZXIt ZXhwZWN0ZWQudHh0CisrKyAvZGV2L251bGwKQEAgLTEsMjMgKzAsMCBAQAotKEdyYXBoaWNzTGF5 ZXIKLSAgKGJvdW5kcyA4NDIuMDAgNjAwLjAwKQotICAoY2hpbGRyZW4gMQotICAgIChHcmFwaGlj c0xheWVyCi0gICAgICAoYm91bmRzIDg0Mi4wMCA2MDAuMDApCi0gICAgICAoY2hpbGRyZW4gMQot ICAgICAgICAoR3JhcGhpY3NMYXllcgotICAgICAgICAgIChwb3NpdGlvbiA4LjAwIDguMDApCi0g ICAgICAgICAgKGJvdW5kcyA3ODQuMDAgMC4wMCkKLSAgICAgICAgICAodHJhbnNmb3JtIFsxLjAw IDAuMDAgMC4wMCAwLjAwXSBbMC4wMCAxLjAwIDAuMDAgMC4wMF0gWzAuMDAgMC4wMCAxLjAwIDAu MDBdIFs1MC4wMCA1MC4wMCAwLjAwIDEuMDBdKQotICAgICAgICAgIChjaGlsZHJlbiAxCi0gICAg ICAgICAgICAoR3JhcGhpY3NMYXllcgotICAgICAgICAgICAgICAocG9zaXRpb24gMjAwLjAwIDIw MC4wMCkKLSAgICAgICAgICAgICAgKGJvdW5kcyA4MC4wMCA4MC4wMCkKLSAgICAgICAgICAgICAg KGRyYXdzQ29udGVudCAxKQotICAgICAgICAgICAgKQotICAgICAgICAgICkKLSAgICAgICAgKQot ICAgICAgKQotICAgICkKLSAgKQotKQotCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9jb21wb3Np dGluZy9sYXllci1jcmVhdGlvbi9vdmVybGFwLWVtcHR5LWxheWVyLmh0bWwgYi9MYXlvdXRUZXN0 cy9jb21wb3NpdGluZy9sYXllci1jcmVhdGlvbi9vdmVybGFwLWVtcHR5LWxheWVyLmh0bWwKZGVs ZXRlZCBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDBmZTIwNDJlMWM4MzdhZDI5YjkyMDUyZDU5NWI0 MjEzNzZlODk2YTcuLjAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAKLS0t IGEvTGF5b3V0VGVzdHMvY29tcG9zaXRpbmcvbGF5ZXItY3JlYXRpb24vb3ZlcmxhcC1lbXB0eS1s YXllci5odG1sCisrKyAvZGV2L251bGwKQEAgLTEsNTEgKzAsMCBAQAotPGh0bWw+Ci08aGVhZD4K LTxzdHlsZT4KLSAgICBib2R5IHsKLSAgICAgICAgb3ZlcmZsb3c6IGhpZGRlbjsKLSAgICB9Ci0K LSAgICAjY29udGFpbmVyIHsKLSAgICAgICAgLXdlYmtpdC10cmFuc2Zvcm06IHRyYW5zbGF0ZSg1 MHB4LCA1MHB4KTsKLSAgICB9Ci0KLSAgICAjY29tcG9zaXRlZCB7Ci0gICAgICAgIC13ZWJraXQt dHJhbnNmb3JtOnRyYW5zbGF0ZVooMCk7Ci0gICAgICAgIHBvc2l0aW9uOmFic29sdXRlOwotICAg ICAgICB0b3A6IDIwMHB4OwotICAgICAgICBsZWZ0OiAyMDBweDsKLSAgICAgICAgd2lkdGg6IDgw cHg7Ci0gICAgICAgIGhlaWdodDogODBweDsKLSAgICAgICAgYmFja2dyb3VuZC1jb2xvcjogYmx1 ZTsKLSAgICB9Ci0KLSAgICAjb3ZlcmxhcCB7Ci0gICAgICAgIHBvc2l0aW9uOiBhYnNvbHV0ZTsK LSAgICAgICAgdG9wOiAwcHg7Ci0gICAgICAgIGxlZnQ6IDBweDsKLSAgICAgICAgd2lkdGg6IDEw MHB4OwotICAgICAgICBoZWlnaHQ6IDEwMHB4OwotICAgICAgICBiYWNrZ3JvdW5kLWNvbG9yOiBi bHVlOwotICAgIH0KLTwvc3R5bGU+Ci08c2NyaXB0PgotICAgIGlmICh3aW5kb3cubGF5b3V0VGVz dENvbnRyb2xsZXIpIHsKLSAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dChm YWxzZSk7Ci0gICAgICAgIHdpbmRvdy5hZGRFdmVudExpc3RlbmVyKCdsb2FkJywgZnVuY3Rpb24o KSB7Ci0gICAgICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgibGF5ZXJ0cmVlIikuaW5u ZXJUZXh0ID0gbGF5b3V0VGVzdENvbnRyb2xsZXIubGF5ZXJUcmVlQXNUZXh0KCk7Ci0gICAgICAg IH0sIGZhbHNlKTsKLSAgICB9Ci08L3NjcmlwdD4KLTwvaGVhZD4KLTxib2R5PgotICAgIDxkaXYg aWQ9ImNvbnRhaW5lciI+Ci0gICAgICAgIDxkaXYgaWQ9ImNvbXBvc2l0ZWQiPjwvZGl2PgotICAg IDwvZGl2PgotCi0gICAgPCEtLSBUaGlzIG92ZXJsYXBzIGFsbCBvZiBjb250YWluZXIsIGJ1dCBu b3QgdGhlIGNvbXBvc2l0ZWQgY2hpbGQuIC0tPgotICAgIDwhLS0gSXQgc2hvdWxkIG5vdCBnZXQg aXRzIG93biBjb21wb3NpdGVkIGxheWVyLiAtLT4KLSAgICA8ZGl2IGlkPSJvdmVybGFwIj48L2Rp dj4KLQotICAgIDxwcmUgaWQ9ImxheWVydHJlZSI+PC9wcmU+Ci08L2JvZHk+Ci08L2h0bWw+Cg==