84617 2012-04-23 12:10:15 -0700 test-webkitpy is failing 2012-04-23 12:50:00 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 eric dpranke abarth dpranke ojan webkit.review.bot oldest_to_newest 607910 0 eric 2012-04-23 12:10:15 -0700 File "./Tools/Scripts/test-webkitpy", line 64, in <module> sys.exit(not tester.run()) File "/mnt/git/webkit-sheriff-bot/Tools/Scripts/webkitpy/test/main.py", line 138, in run return self._run_tests(names) File "/mnt/git/webkit-sheriff-bot/Tools/Scripts/webkitpy/test/main.py", line 169, in _run_tests suites.append(loader.loadTestsFromName(name, None)) File "/usr/lib/python2.6/unittest.py", line 587, in loadTestsFromName return self.loadTestsFromModule(obj) File "/usr/lib/python2.6/unittest.py", line 559, in loadTestsFromModule tests.append(self.loadTestsFromTestCase(obj)) File "/usr/lib/python2.6/unittest.py", line 550, in loadTestsFromTestCase return self.suiteClass(map(testCaseClass, testCaseNames)) File "/mnt/git/webkit-sheriff-bot/Tools/Scripts/webkitpy/layout_tests/port/http_lock_unittest.py", line 44, in __init__ self.clean_all_lockfile() File "/mnt/git/webkit-sheriff-bot/Tools/Scripts/webkitpy/layout_tests/port/http_lock_unittest.py", line 52, in clean_all_lockfile self.filesystem.unlink(file_name) AttributeError: 'FileSystem' object has no attribute 'unlink' Unclear when it started. 607932 1 138400 dpranke 2012-04-23 12:42:21 -0700 Created attachment 138400 Patch 607933 2 dpranke 2012-04-23 12:43:24 -0700 Looks like that code triggers only in error cases; it's probably been broken for a long time. This is a quick fix, but all of this test code should probably be rewritten to use a MockFileSystem (there's already a FIXME for that in the code; I'll file a separate bug). 607935 3 138400 eric 2012-04-23 12:44:36 -0700 Comment on attachment 138400 Patch LGTM. Thanks. 607937 4 dpranke 2012-04-23 12:49:12 -0700 Committed r114933: <http://trac.webkit.org/changeset/114933> 607939 5 dpranke 2012-04-23 12:50:00 -0700 bug 84617 filed for that. 138400 2012-04-23 12:42:21 -0700 2012-04-23 12:44:36 -0700 Patch bug-84617-20120423124220.patch text/plain 1598 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0OTI3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDIzODIxOTA1N2M2ZWQyNGVhM2NkNmVlNjhhY2E0YTFm YjdkMjRiNS4uMDUzY2IzZDIyNDE5NzU4NjRhMmRjZTBhZjMxYjgwYmE4MTg1NmFjYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDEyLTA0LTIzICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgorCisg ICAgICAgIHRlc3Qtd2Via2l0cHkgaXMgZmFpbGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODQ2MTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3Bv cnQvaHR0cF9sb2NrX3VuaXR0ZXN0LnB5OgorICAgICAgICAoSHR0cExvY2tUZXN0V2l0aFJlYWxG aWxlU3lzdGVtLmNsZWFuX2FsbF9sb2NrZmlsZSk6CisKIDIwMTItMDQtMjMgIEFsbGFuIFNhbmRm ZWxkIEplbnNlbiAgPGFsbGFuLmplbnNlbkBub2tpYS5jb20+CiAKICAgICAgICAgW1F0XVtXSzJd IENvbnZlcnQgdG91Y2gtcG9pbnQgYXJlYS4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvaHR0cF9sb2NrX3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9odHRwX2xvY2tfdW5pdHRlc3QucHkKaW5k ZXggYmZmNWE2NmQ4Njk1ZDJmOWRhNDZiYjYxNDIyMDRhMTA4MDUxY2FlOC4uZmJmMmQ5ZGYzNDg3 MzBjODg5NzE4ZTk1ODdjNmI0ODM4NzM5NzZmYyAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9odHRwX2xvY2tfdW5pdHRlc3QucHkKKysrIGIvVG9v bHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9odHRwX2xvY2tfdW5pdHRlc3Qu cHkKQEAgLTQ2LDEwICs0NiwxMCBAQCBjbGFzcyBIdHRwTG9ja1Rlc3RXaXRoUmVhbEZpbGVTeXN0 ZW0odW5pdHRlc3QuVGVzdENhc2UpOgogCiAgICAgZGVmIGNsZWFuX2FsbF9sb2NrZmlsZShzZWxm KToKICAgICAgICAgaWYgc2VsZi5maWxlc3lzdGVtLmV4aXN0cyhzZWxmLmd1YXJkX2xvY2tfZmls ZSk6Ci0gICAgICAgICAgICBzZWxmLmZpbGVzeXN0ZW0udW5saW5rKHNlbGYuZ3VhcmRfbG9ja19m aWxlKQorICAgICAgICAgICAgc2VsZi5maWxlc3lzdGVtLnJlbW92ZShzZWxmLmd1YXJkX2xvY2tf ZmlsZSkKICAgICAgICAgbG9ja19saXN0ID0gc2VsZi5maWxlc3lzdGVtLmdsb2Ioc2VsZi5sb2Nr X2ZpbGVfcGF0aF9wcmVmaXggKyAnKicpCiAgICAgICAgIGZvciBmaWxlX25hbWUgaW4gbG9ja19s aXN0OgotICAgICAgICAgICAgc2VsZi5maWxlc3lzdGVtLnVubGluayhmaWxlX25hbWUpCisgICAg ICAgICAgICBzZWxmLmZpbGVzeXN0ZW0ucmVtb3ZlKGZpbGVfbmFtZSkKIAogICAgIGRlZiBhc3Nl cnRFcXVhbChzZWxmLCBmaXJzdCwgc2Vjb25kKToKICAgICAgICAgaWYgZmlyc3QgIT0gc2Vjb25k Ogo=