84608 2012-04-23 10:16:02 -0700 [Chromium] Added a chromium webkit public header file to support different web print scaling options. 2012-04-27 12:01:59 -0700 1 1 1 Unclassified WebKit Printing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kmadhusu kmadhusu abarth dglazkov fishd jamesr tkent+wkapi webkit.review.bot oldest_to_newest 607784 0 kmadhusu 2012-04-23 10:16:02 -0700 To fix crbug.com/85132, I need a webkit public header file to provide different types of print scaling options. Actual fix for the bug(crbug.com/85132) include ppapi changes, chromium changes and webkit changes. In order to prevent any build breakage while committing the individual CL's, I would like to commit this header file first followed by the patch in https://bugs.webkit.org/show_bug.cgi?id=84312. 607787 1 138374 kmadhusu 2012-04-23 10:18:00 -0700 Created attachment 138374 Patch 607791 2 138375 kmadhusu 2012-04-23 10:20:22 -0700 Created attachment 138375 Patch 607792 3 webkit.review.bot 2012-04-23 10:21:09 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 607870 4 138375 fishd 2012-04-23 11:26:46 -0700 Comment on attachment 138375 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138375&action=review How do you plan to use this enum? It is often easier to review API changes when it is clear how the parts will fit together. This looks like an unused enum :-) > Source/WebKit/chromium/public/WebPrintScalingOption.h:36 > +enum WebPrintScalingOption { please fix naming: http://trac.webkit.org/wiki/ChromiumWebKitAPI#Enums 607890 5 138395 kmadhusu 2012-04-23 11:46:42 -0700 Created attachment 138395 Patch 607891 6 138375 kmadhusu 2012-04-23 11:47:37 -0700 Comment on attachment 138375 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138375&action=review >> Source/WebKit/chromium/public/WebPrintScalingOption.h:36 >> +enum WebPrintScalingOption { > > please fix naming: > http://trac.webkit.org/wiki/ChromiumWebKitAPI#Enums I assume you meant to change the enum value names. Done. 607894 7 kmadhusu 2012-04-23 11:48:28 -0700 Sorry I didn't state it clearly in my description. You can see the usage of this enum in the latest patch uploaded in https://bugs.webkit.org/show_bug.cgi?id=84312. And you can also find the usage of this enum in the following chromium side CL's. http://codereview.chromium.org/10083059/ http://codereview.chromium.org/10168013/ Thanks. 607897 8 kmadhusu 2012-04-23 11:50:44 -0700 Patch in bug 84312 uses WebPrintFitToPrintableArea enum value. After addressing all the review comments in this header file, I will update the patch in bug 84312 accordingly. 610281 9 kmadhusu 2012-04-25 18:39:07 -0700 ping 611690 10 138395 fishd 2012-04-27 11:07:03 -0700 Comment on attachment 138395 Patch OK, R=me Normally, it is better to include a change like this with the patch that actually requires it. 611709 11 kmadhusu 2012-04-27 11:18:20 -0700 Thanks for reviewing the patch. I understand your concern. I am just trying to avoid chrome canary build breakages. By landing this header file first, it easier for me to land the individual patches. Will it help if I add more information in the ChangeLog file? Can you also please review the other webkit patch (https://bugs.webkit.org/show_bug.cgi?id=84312) which actually uses this enum to make sure you are fine with the workflow? 611764 12 138395 webkit.review.bot 2012-04-27 12:01:54 -0700 Comment on attachment 138395 Patch Clearing flags on attachment: 138395 Committed r115464: <http://trac.webkit.org/changeset/115464> 611765 13 webkit.review.bot 2012-04-27 12:01:59 -0700 All reviewed patches have been landed. Closing bug. 138374 2012-04-23 10:18:00 -0700 2012-04-23 10:20:19 -0700 Patch bug-84608-20120423101759.patch text/plain 6055 kmadhusu SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMTQ5MTMpCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0 IEBACisyMDEyLTA0LTIzICBLYXVzYWx5YSBNYWRodXN1ZGhhbmFuICA8a21hZGh1c3VAY2hyb21p dW0ub3JnPgorCisgICAgICAgIEFkZGVkIGEgY2hyb21pdW0gd2Via2l0IHB1YmxpYyBoZWFkZXIg ZmlsZSB0byBzdXBwb3J0IGRpZmZlcmVudCB3ZWIgcHJpbnQgc2NhbGluZyBvcHRpb25zLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODQ2MDgKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYktpdC5neXA6 CisgICAgICAgICogcHVibGljL1dlYlByaW50U2NhbGluZ09wdGlvbi5oOiBBZGRlZC4KKyAgICAg ICAgKFdlYktpdCk6CisKIDIwMTItMDQtMjMgIElhbiBWb2xsaWNrICA8dm9sbGlja0BjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBXaGVuIHByZXBhcmVUb0RyYXcgZmFpbHMgZHVl IHRvIGFuaW1hdGlvbiBjaGVja2VyYm9hcmQsIHdlIG5lZWQgdG8gY2FsbCBzZXROZWVkc0NvbW1p dApJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9XZWJLaXQuZ3lwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vV2ViS2l0Lmd5cAkocmV2aXNpb24gMTE0ODU4KQorKysg U291cmNlL1dlYktpdC9jaHJvbWl1bS9XZWJLaXQuZ3lwCSh3b3JraW5nIGNvcHkpCkBAIC0yMjQs NiArMjI0LDcgQEAKICAgICAgICAgICAgICAgICAncHVibGljL1dlYlBsdWdpbkNvbnRhaW5lci5o JywKICAgICAgICAgICAgICAgICAncHVibGljL1dlYlBsdWdpbkRvY3VtZW50LmgnLAogICAgICAg ICAgICAgICAgICdwdWJsaWMvV2ViUGx1Z2luTGlzdEJ1aWxkZXIuaCcsCisgICAgICAgICAgICAg ICAgJ3B1YmxpYy9XZWJQcmludFNjYWxpbmdPcHRpb24uaCcsCiAgICAgICAgICAgICAgICAgJ3B1 YmxpYy9XZWJQb3B1cE1lbnUuaCcsCiAgICAgICAgICAgICAgICAgJ3B1YmxpYy9XZWJQb3B1cE1l bnVJbmZvLmgnLAogICAgICAgICAgICAgICAgICdwdWJsaWMvV2ViUG9wdXBUeXBlLmgnLApJbmRl eDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViUHJpbnRTY2FsaW5nT3B0aW9uLmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViUHJpbnRTY2Fs aW5nT3B0aW9uLmgJKHJldmlzaW9uIDApCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1Ymxp Yy9XZWJQcmludFNjYWxpbmdPcHRpb24uaAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw4OCBAQAor LyoKKyAqIENvcHlyaWdodCAoQykgMjAxMiBHb29nbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVk LgorICoKKyAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9y bXMsIHdpdGggb3Igd2l0aG91dAorICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3Zp ZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zIGFyZQorICogbWV0OgorICoKKyAqICAg ICAqIFJlZGlzdHJpYnV0aW9ucyBvZiBzb3VyY2UgY29kZSBtdXN0IHJldGFpbiB0aGUgYWJvdmUg Y29weXJpZ2h0CisgKiBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9s bG93aW5nIGRpc2NsYWltZXIuCisgKiAgICAgKiBSZWRpc3RyaWJ1dGlvbnMgaW4gYmluYXJ5IGZv cm0gbXVzdCByZXByb2R1Y2UgdGhlIGFib3ZlCisgKiBjb3B5cmlnaHQgbm90aWNlLCB0aGlzIGxp c3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyCisgKiBpbiB0aGUg ZG9jdW1lbnRhdGlvbiBhbmQvb3Igb3RoZXIgbWF0ZXJpYWxzIHByb3ZpZGVkIHdpdGggdGhlCisg KiBkaXN0cmlidXRpb24uCisgKiAgICAgKiBOZWl0aGVyIHRoZSBuYW1lIG9mIEdvb2dsZSBJbmMu IG5vciB0aGUgbmFtZXMgb2YgaXRzCisgKiBjb250cmlidXRvcnMgbWF5IGJlIHVzZWQgdG8gZW5k b3JzZSBvciBwcm9tb3RlIHByb2R1Y3RzIGRlcml2ZWQgZnJvbQorICogdGhpcyBzb2Z0d2FyZSB3 aXRob3V0IHNwZWNpZmljIHByaW9yIHdyaXR0ZW4gcGVybWlzc2lvbi4KKyAqCisgKiBUSElTIFNP RlRXQVJFIElTIFBST1ZJREVEIEJZIFRIRSBDT1BZUklHSFQgSE9MREVSUyBBTkQgQ09OVFJJQlVU T1JTCisgKiAiQVMgSVMiIEFORCBBTlkgRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMsIElO Q0xVRElORywgQlVUIE5PVAorICogTElNSVRFRCBUTywgVEhFIElNUExJRUQgV0FSUkFOVElFUyBP RiBNRVJDSEFOVEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SCisgKiBBIFBBUlRJQ1VMQVIgUFVSUE9T RSBBUkUgRElTQ0xBSU1FRC4gSU4gTk8gRVZFTlQgU0hBTEwgVEhFIENPUFlSSUdIVAorICogT1dO RVIgT1IgQ09OVFJJQlVUT1JTIEJFIExJQUJMRSBGT1IgQU5ZIERJUkVDVCwgSU5ESVJFQ1QsIElO Q0lERU5UQUwsCisgKiBTUEVDSUFMLCBFWEVNUExBUlksIE9SIENPTlNFUVVFTlRJQUwgREFNQUdF UyAoSU5DTFVESU5HLCBCVVQgTk9UCisgKiBMSU1JVEVEIFRPLCBQUk9DVVJFTUVOVCBPRiBTVUJT VElUVVRFIEdPT0RTIE9SIFNFUlZJQ0VTOyBMT1NTIE9GIFVTRSwKKyAqIERBVEEsIE9SIFBST0ZJ VFM7IE9SIEJVU0lORVNTIElOVEVSUlVQVElPTikgSE9XRVZFUiBDQVVTRUQgQU5EIE9OIEFOWQor ICogVEhFT1JZIE9GIExJQUJJTElUWSwgV0hFVEhFUiBJTiBDT05UUkFDVCwgU1RSSUNUIExJQUJJ TElUWSwgT1IgVE9SVAorICogKElOQ0xVRElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJ U0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFCisgKiBPRiBUSElTIFNPRlRXQVJFLCBFVkVO IElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgorICovCisKKyNp Zm5kZWYgV2ViUHJpbnRTY2FsaW5nT3B0aW9uX2gKKyNkZWZpbmUgV2ViUHJpbnRTY2FsaW5nT3B0 aW9uX2gKKworbmFtZXNwYWNlIFdlYktpdCB7CisKK2VudW0gV2ViUHJpbnRTY2FsaW5nT3B0aW9u IHsKKyAgICBXZWJQcmludFNjYWxlTm9uZSwgLy8gUHJpbnRzIHRoZSB1cHBlciBsZWZ0IG9mIGEg cGFnZSB3aXRob3V0IHNjYWxpbmcuIENyb3AgdGhlIHBhZ2UgY29udGVudHMgdGhhdCBkb24ndCBm aXQgb24gdGhlIHBhcGVyLgorICAgIFdlYlByaW50Rml0VG9QcmludGFibGVBcmVhLCAvLyBSZWR1 Y2VzIG9yIGVubGFyZ2VzIGVhY2ggcGFnZSB0byBmaXQgdGhlIHByaW50YWJsZSBhcmVhIG9mIHRo ZSBzZWxlY3RlZCBwcmludGVyIHBhcGVyIHNpemUuCisgICAgV2ViUHJpbnRTb3VyY2VTaXplLCAv LyBQcmludCBvdXRwdXQgcGFnZSBzaXplIGlzIHNhbWUgYXMgdGhlIGFjdHVhbCBzb3VyY2UgcGFn ZSBzaXplLiBEbyBub3Qgc2NhbGUvY2VudGVyL2ZpdCB0byBwcmludGFibGUgYXJlYS4KK307CisK K30gLy8gbmFtZXNwYWNlIFdlYktpdAorCisjZW5kaWYKKy8qCisgKiBDb3B5cmlnaHQgKEMpIDIw MTIgR29vZ2xlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqCisgKiBSZWRpc3RyaWJ1dGlv biBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKKyAq IG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcg Y29uZGl0aW9ucyBhcmUKKyAqIG1ldDoKKyAqCisgKiAgICAgKiBSZWRpc3RyaWJ1dGlvbnMgb2Yg c291cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdodAorICogbm90aWNlLCB0 aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgorICog ICAgICogUmVkaXN0cmlidXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBh Ym92ZQorICogY29weXJpZ2h0IG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRo ZSBmb2xsb3dpbmcgZGlzY2xhaW1lcgorICogaW4gdGhlIGRvY3VtZW50YXRpb24gYW5kL29yIG90 aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3aXRoIHRoZQorICogZGlzdHJpYnV0aW9uLgorICogICAg ICogTmVpdGhlciB0aGUgbmFtZSBvZiBHb29nbGUgSW5jLiBub3IgdGhlIG5hbWVzIG9mIGl0cwor ICogY29udHJpYnV0b3JzIG1heSBiZSB1c2VkIHRvIGVuZG9yc2Ugb3IgcHJvbW90ZSBwcm9kdWN0 cyBkZXJpdmVkIGZyb20KKyAqIHRoaXMgc29mdHdhcmUgd2l0aG91dCBzcGVjaWZpYyBwcmlvciB3 cml0dGVuIHBlcm1pc3Npb24uCisgKgorICogVEhJUyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBU SEUgQ09QWVJJR0hUIEhPTERFUlMgQU5EIENPTlRSSUJVVE9SUworICogIkFTIElTIiBBTkQgQU5Z IEVYUFJFU1MgT1IgSU1QTElFRCBXQVJSQU5USUVTLCBJTkNMVURJTkcsIEJVVCBOT1QKKyAqIExJ TUlURUQgVE8sIFRIRSBJTVBMSUVEIFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFORCBG SVRORVNTIEZPUgorICogQSBQQVJUSUNVTEFSIFBVUlBPU0UgQVJFIERJU0NMQUlNRUQuIElOIE5P IEVWRU5UIFNIQUxMIFRIRSBDT1BZUklHSFQKKyAqIE9XTkVSIE9SIENPTlRSSUJVVE9SUyBCRSBM SUFCTEUgRk9SIEFOWSBESVJFQ1QsIElORElSRUNULCBJTkNJREVOVEFMLAorICogU1BFQ0lBTCwg RVhFTVBMQVJZLCBPUiBDT05TRVFVRU5USUFMIERBTUFHRVMgKElOQ0xVRElORywgQlVUIE5PVAor ICogTElNSVRFRCBUTywgUFJPQ1VSRU1FTlQgT0YgU1VCU1RJVFVURSBHT09EUyBPUiBTRVJWSUNF UzsgTE9TUyBPRiBVU0UsCisgKiBEQVRBLCBPUiBQUk9GSVRTOyBPUiBCVVNJTkVTUyBJTlRFUlJV UFRJT04pIEhPV0VWRVIgQ0FVU0VEIEFORCBPTiBBTlkKKyAqIFRIRU9SWSBPRiBMSUFCSUxJVFks IFdIRVRIRVIgSU4gQ09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJVFksIE9SIFRPUlQKKyAqIChJTkNM VURJTkcgTkVHTElHRU5DRSBPUiBPVEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0Yg VEhFIFVTRQorICogT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NT SUJJTElUWSBPRiBTVUNIIERBTUFHRS4KKyAqLworCisjaWZuZGVmIFdlYlByaW50U2NhbGluZ09w dGlvbl9oCisjZGVmaW5lIFdlYlByaW50U2NhbGluZ09wdGlvbl9oCisKK25hbWVzcGFjZSBXZWJL aXQgeworCitlbnVtIFdlYlByaW50U2NhbGluZ09wdGlvbiB7CisgICAgV2ViUHJpbnRTY2FsZU5v bmUsIC8vIFByaW50cyB0aGUgdXBwZXIgbGVmdCBvZiBhIHBhZ2Ugd2l0aG91dCBzY2FsaW5nLiBD cm9wIHRoZSBwYWdlIGNvbnRlbnRzIHRoYXQgZG9uJ3QgZml0IG9uIHRoZSBwYXBlci4KKyAgICBX ZWJQcmludEZpdFRvUHJpbnRhYmxlQXJlYSwgLy8gUmVkdWNlcyBvciBlbmxhcmdlcyBlYWNoIHBh Z2UgdG8gZml0IHRoZSBwcmludGFibGUgYXJlYSBvZiB0aGUgc2VsZWN0ZWQgcHJpbnRlciBwYXBl ciBzaXplLgorICAgIFdlYlByaW50U291cmNlU2l6ZSwgLy8gUHJpbnQgb3V0cHV0IHBhZ2Ugc2l6 ZSBpcyBzYW1lIGFzIHRoZSBhY3R1YWwgc291cmNlIHBhZ2Ugc2l6ZS4gRG8gbm90IHNjYWxlL2Nl bnRlci9maXQgdG8gcHJpbnRhYmxlIGFyZWEuCit9OworCit9IC8vIG5hbWVzcGFjZSBXZWJLaXQK KworI2VuZGlmCgpQcm9wZXJ0eSBjaGFuZ2VzIG9uOiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1 YmxpYy9XZWJQcmludFNjYWxpbmdPcHRpb24uaApfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkFkZGVkOiBzdm46ZW9sLXN0 eWxlCiAgICsgTEYKCg== 138375 2012-04-23 10:20:22 -0700 2012-04-23 11:47:37 -0700 Patch bug-84608-20120423102021.patch text/plain 3912 kmadhusu SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMTQ5MTMpCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0 IEBACisyMDEyLTA0LTIzICBLYXVzYWx5YSBNYWRodXN1ZGhhbmFuICA8a21hZGh1c3VAY2hyb21p dW0ub3JnPgorCisgICAgICAgIEFkZGVkIGEgY2hyb21pdW0gd2Via2l0IHB1YmxpYyBoZWFkZXIg ZmlsZSB0byBzdXBwb3J0IGRpZmZlcmVudCB3ZWIgcHJpbnQgc2NhbGluZyBvcHRpb25zLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODQ2MDgKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYktpdC5neXA6 CisgICAgICAgICogcHVibGljL1dlYlByaW50U2NhbGluZ09wdGlvbi5oOiBBZGRlZC4KKyAgICAg ICAgKFdlYktpdCk6CisKIDIwMTItMDQtMjMgIElhbiBWb2xsaWNrICA8dm9sbGlja0BjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBXaGVuIHByZXBhcmVUb0RyYXcgZmFpbHMgZHVl IHRvIGFuaW1hdGlvbiBjaGVja2VyYm9hcmQsIHdlIG5lZWQgdG8gY2FsbCBzZXROZWVkc0NvbW1p dApJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9XZWJLaXQuZ3lwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vV2ViS2l0Lmd5cAkocmV2aXNpb24gMTE0ODU4KQorKysg U291cmNlL1dlYktpdC9jaHJvbWl1bS9XZWJLaXQuZ3lwCSh3b3JraW5nIGNvcHkpCkBAIC0yMjQs NiArMjI0LDcgQEAKICAgICAgICAgICAgICAgICAncHVibGljL1dlYlBsdWdpbkNvbnRhaW5lci5o JywKICAgICAgICAgICAgICAgICAncHVibGljL1dlYlBsdWdpbkRvY3VtZW50LmgnLAogICAgICAg ICAgICAgICAgICdwdWJsaWMvV2ViUGx1Z2luTGlzdEJ1aWxkZXIuaCcsCisgICAgICAgICAgICAg ICAgJ3B1YmxpYy9XZWJQcmludFNjYWxpbmdPcHRpb24uaCcsCiAgICAgICAgICAgICAgICAgJ3B1 YmxpYy9XZWJQb3B1cE1lbnUuaCcsCiAgICAgICAgICAgICAgICAgJ3B1YmxpYy9XZWJQb3B1cE1l bnVJbmZvLmgnLAogICAgICAgICAgICAgICAgICdwdWJsaWMvV2ViUG9wdXBUeXBlLmgnLApJbmRl eDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViUHJpbnRTY2FsaW5nT3B0aW9uLmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViUHJpbnRTY2Fs aW5nT3B0aW9uLmgJKHJldmlzaW9uIDApCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1Ymxp Yy9XZWJQcmludFNjYWxpbmdPcHRpb24uaAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw0NCBAQAor LyoKKyAqIENvcHlyaWdodCAoQykgMjAxMiBHb29nbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVk LgorICoKKyAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9y bXMsIHdpdGggb3Igd2l0aG91dAorICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3Zp ZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zIGFyZQorICogbWV0OgorICoKKyAqICAg ICAqIFJlZGlzdHJpYnV0aW9ucyBvZiBzb3VyY2UgY29kZSBtdXN0IHJldGFpbiB0aGUgYWJvdmUg Y29weXJpZ2h0CisgKiBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9s bG93aW5nIGRpc2NsYWltZXIuCisgKiAgICAgKiBSZWRpc3RyaWJ1dGlvbnMgaW4gYmluYXJ5IGZv cm0gbXVzdCByZXByb2R1Y2UgdGhlIGFib3ZlCisgKiBjb3B5cmlnaHQgbm90aWNlLCB0aGlzIGxp c3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyCisgKiBpbiB0aGUg ZG9jdW1lbnRhdGlvbiBhbmQvb3Igb3RoZXIgbWF0ZXJpYWxzIHByb3ZpZGVkIHdpdGggdGhlCisg KiBkaXN0cmlidXRpb24uCisgKiAgICAgKiBOZWl0aGVyIHRoZSBuYW1lIG9mIEdvb2dsZSBJbmMu IG5vciB0aGUgbmFtZXMgb2YgaXRzCisgKiBjb250cmlidXRvcnMgbWF5IGJlIHVzZWQgdG8gZW5k b3JzZSBvciBwcm9tb3RlIHByb2R1Y3RzIGRlcml2ZWQgZnJvbQorICogdGhpcyBzb2Z0d2FyZSB3 aXRob3V0IHNwZWNpZmljIHByaW9yIHdyaXR0ZW4gcGVybWlzc2lvbi4KKyAqCisgKiBUSElTIFNP RlRXQVJFIElTIFBST1ZJREVEIEJZIFRIRSBDT1BZUklHSFQgSE9MREVSUyBBTkQgQ09OVFJJQlVU T1JTCisgKiAiQVMgSVMiIEFORCBBTlkgRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMsIElO Q0xVRElORywgQlVUIE5PVAorICogTElNSVRFRCBUTywgVEhFIElNUExJRUQgV0FSUkFOVElFUyBP RiBNRVJDSEFOVEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SCisgKiBBIFBBUlRJQ1VMQVIgUFVSUE9T RSBBUkUgRElTQ0xBSU1FRC4gSU4gTk8gRVZFTlQgU0hBTEwgVEhFIENPUFlSSUdIVAorICogT1dO RVIgT1IgQ09OVFJJQlVUT1JTIEJFIExJQUJMRSBGT1IgQU5ZIERJUkVDVCwgSU5ESVJFQ1QsIElO Q0lERU5UQUwsCisgKiBTUEVDSUFMLCBFWEVNUExBUlksIE9SIENPTlNFUVVFTlRJQUwgREFNQUdF UyAoSU5DTFVESU5HLCBCVVQgTk9UCisgKiBMSU1JVEVEIFRPLCBQUk9DVVJFTUVOVCBPRiBTVUJT VElUVVRFIEdPT0RTIE9SIFNFUlZJQ0VTOyBMT1NTIE9GIFVTRSwKKyAqIERBVEEsIE9SIFBST0ZJ VFM7IE9SIEJVU0lORVNTIElOVEVSUlVQVElPTikgSE9XRVZFUiBDQVVTRUQgQU5EIE9OIEFOWQor ICogVEhFT1JZIE9GIExJQUJJTElUWSwgV0hFVEhFUiBJTiBDT05UUkFDVCwgU1RSSUNUIExJQUJJ TElUWSwgT1IgVE9SVAorICogKElOQ0xVRElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJ U0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFCisgKiBPRiBUSElTIFNPRlRXQVJFLCBFVkVO IElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgorICovCisKKyNp Zm5kZWYgV2ViUHJpbnRTY2FsaW5nT3B0aW9uX2gKKyNkZWZpbmUgV2ViUHJpbnRTY2FsaW5nT3B0 aW9uX2gKKworbmFtZXNwYWNlIFdlYktpdCB7CisKK2VudW0gV2ViUHJpbnRTY2FsaW5nT3B0aW9u IHsKKyAgICBXZWJQcmludFNjYWxlTm9uZSwgLy8gUHJpbnRzIHRoZSB1cHBlciBsZWZ0IG9mIGEg cGFnZSB3aXRob3V0IHNjYWxpbmcuIENyb3AgdGhlIHBhZ2UgY29udGVudHMgdGhhdCBkb24ndCBm aXQgb24gdGhlIHBhcGVyLgorICAgIFdlYlByaW50Rml0VG9QcmludGFibGVBcmVhLCAvLyBSZWR1 Y2VzIG9yIGVubGFyZ2VzIGVhY2ggcGFnZSB0byBmaXQgdGhlIHByaW50YWJsZSBhcmVhIG9mIHRo ZSBzZWxlY3RlZCBwcmludGVyIHBhcGVyIHNpemUuCisgICAgV2ViUHJpbnRTb3VyY2VTaXplLCAv LyBQcmludCBvdXRwdXQgcGFnZSBzaXplIGlzIHNhbWUgYXMgdGhlIGFjdHVhbCBzb3VyY2UgcGFn ZSBzaXplLiBEbyBub3Qgc2NhbGUvY2VudGVyL2ZpdCB0byBwcmludGFibGUgYXJlYS4KK307CisK K30gLy8gbmFtZXNwYWNlIFdlYktpdAorCisjZW5kaWYKClByb3BlcnR5IGNoYW5nZXMgb246IFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlByaW50U2NhbGluZ09wdGlvbi5oCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KQWRkZWQ6IHN2bjplb2wtc3R5bGUKICAgKyBMRgoK 138395 2012-04-23 11:46:42 -0700 2012-04-27 12:01:54 -0700 Patch bug-84608-20120423114641.patch text/plain 3909 kmadhusu SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMTQ5MjQpCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0 IEBACisyMDEyLTA0LTIzICBLYXVzYWx5YSBNYWRodXN1ZGhhbmFuICA8a21hZGh1c3VAY2hyb21p dW0ub3JnPgorCisgICAgICAgIEFkZGVkIGEgY2hyb21pdW0gd2Via2l0IHB1YmxpYyBoZWFkZXIg ZmlsZSB0byBzdXBwb3J0IGRpZmZlcmVudCB3ZWIgcHJpbnQgc2NhbGluZyBvcHRpb25zLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODQ2MDgKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYktpdC5neXA6 CisgICAgICAgICogcHVibGljL1dlYlByaW50U2NhbGluZ09wdGlvbi5oOiBBZGRlZC4KKyAgICAg ICAgKFdlYktpdCk6CisKIDIwMTItMDQtMjMgIElhbiBWb2xsaWNrICA8dm9sbGlja0BjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBQcm9wZXJseSBpZ25vcmUgdW5zdXBwb3J0ZWQg YW5pbWF0aW9uIGRpcmVjdGlvbnMuCkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL1dlYktp dC5neXAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9jaHJvbWl1bS9XZWJLaXQuZ3lwCShy ZXZpc2lvbiAxMTQ4NTgpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL1dlYktpdC5neXAJKHdv cmtpbmcgY29weSkKQEAgLTIyNCw2ICsyMjQsNyBAQAogICAgICAgICAgICAgICAgICdwdWJsaWMv V2ViUGx1Z2luQ29udGFpbmVyLmgnLAogICAgICAgICAgICAgICAgICdwdWJsaWMvV2ViUGx1Z2lu RG9jdW1lbnQuaCcsCiAgICAgICAgICAgICAgICAgJ3B1YmxpYy9XZWJQbHVnaW5MaXN0QnVpbGRl ci5oJywKKyAgICAgICAgICAgICAgICAncHVibGljL1dlYlByaW50U2NhbGluZ09wdGlvbi5oJywK ICAgICAgICAgICAgICAgICAncHVibGljL1dlYlBvcHVwTWVudS5oJywKICAgICAgICAgICAgICAg ICAncHVibGljL1dlYlBvcHVwTWVudUluZm8uaCcsCiAgICAgICAgICAgICAgICAgJ3B1YmxpYy9X ZWJQb3B1cFR5cGUuaCcsCkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJQ cmludFNjYWxpbmdPcHRpb24uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVt L3B1YmxpYy9XZWJQcmludFNjYWxpbmdPcHRpb24uaAkocmV2aXNpb24gMCkKKysrIFNvdXJjZS9X ZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlByaW50U2NhbGluZ09wdGlvbi5oCShyZXZpc2lvbiAw KQpAQCAtMCwwICsxLDQ0IEBACisvKgorICogQ29weXJpZ2h0IChDKSAyMDEyIEdvb2dsZSBJbmMu IEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKgorICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBz b3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CisgKiBtb2RpZmljYXRpb24s IGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMgYXJl CisgKiBtZXQ6CisgKgorICogICAgICogUmVkaXN0cmlidXRpb25zIG9mIHNvdXJjZSBjb2RlIG11 c3QgcmV0YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyAqIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNv bmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lci4KKyAqICAgICAqIFJlZGlzdHJp YnV0aW9ucyBpbiBiaW5hcnkgZm9ybSBtdXN0IHJlcHJvZHVjZSB0aGUgYWJvdmUKKyAqIGNvcHly aWdodCBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRp c2NsYWltZXIKKyAqIGluIHRoZSBkb2N1bWVudGF0aW9uIGFuZC9vciBvdGhlciBtYXRlcmlhbHMg cHJvdmlkZWQgd2l0aCB0aGUKKyAqIGRpc3RyaWJ1dGlvbi4KKyAqICAgICAqIE5laXRoZXIgdGhl IG5hbWUgb2YgR29vZ2xlIEluYy4gbm9yIHRoZSBuYW1lcyBvZiBpdHMKKyAqIGNvbnRyaWJ1dG9y cyBtYXkgYmUgdXNlZCB0byBlbmRvcnNlIG9yIHByb21vdGUgcHJvZHVjdHMgZGVyaXZlZCBmcm9t CisgKiB0aGlzIHNvZnR3YXJlIHdpdGhvdXQgc3BlY2lmaWMgcHJpb3Igd3JpdHRlbiBwZXJtaXNz aW9uLgorICoKKyAqIFRISVMgU09GVFdBUkUgSVMgUFJPVklERUQgQlkgVEhFIENPUFlSSUdIVCBI T0xERVJTIEFORCBDT05UUklCVVRPUlMKKyAqICJBUyBJUyIgQU5EIEFOWSBFWFBSRVNTIE9SIElN UExJRUQgV0FSUkFOVElFUywgSU5DTFVESU5HLCBCVVQgTk9UCisgKiBMSU1JVEVEIFRPLCBUSEUg SU1QTElFRCBXQVJSQU5USUVTIE9GIE1FUkNIQU5UQUJJTElUWSBBTkQgRklUTkVTUyBGT1IKKyAq IEEgUEFSVElDVUxBUiBQVVJQT1NFIEFSRSBESVNDTEFJTUVELiBJTiBOTyBFVkVOVCBTSEFMTCBU SEUgQ09QWVJJR0hUCisgKiBPV05FUiBPUiBDT05UUklCVVRPUlMgQkUgTElBQkxFIEZPUiBBTlkg RElSRUNULCBJTkRJUkVDVCwgSU5DSURFTlRBTCwKKyAqIFNQRUNJQUwsIEVYRU1QTEFSWSwgT1Ig Q09OU0VRVUVOVElBTCBEQU1BR0VTIChJTkNMVURJTkcsIEJVVCBOT1QKKyAqIExJTUlURUQgVE8s IFBST0NVUkVNRU5UIE9GIFNVQlNUSVRVVEUgR09PRFMgT1IgU0VSVklDRVM7IExPU1MgT0YgVVNF LAorICogREFUQSwgT1IgUFJPRklUUzsgT1IgQlVTSU5FU1MgSU5URVJSVVBUSU9OKSBIT1dFVkVS IENBVVNFRCBBTkQgT04gQU5ZCisgKiBUSEVPUlkgT0YgTElBQklMSVRZLCBXSEVUSEVSIElOIENP TlRSQUNULCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JUCisgKiAoSU5DTFVESU5HIE5FR0xJR0VO Q0UgT1IgT1RIRVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UKKyAqIE9G IFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VD SCBEQU1BR0UuCisgKi8KKworI2lmbmRlZiBXZWJQcmludFNjYWxpbmdPcHRpb25faAorI2RlZmlu ZSBXZWJQcmludFNjYWxpbmdPcHRpb25faAorCituYW1lc3BhY2UgV2ViS2l0IHsKKworZW51bSBX ZWJQcmludFNjYWxpbmdPcHRpb24geworICAgIFdlYlByaW50U2NhbGluZ09wdGlvbk5vbmUsIC8v IFByaW50cyB0aGUgdXBwZXIgbGVmdCBvZiBhIHBhZ2Ugd2l0aG91dCBzY2FsaW5nLiBDcm9wIHRo ZSBwYWdlIGNvbnRlbnRzIHRoYXQgZG9uJ3QgZml0IG9uIHRoZSBwYXBlci4KKyAgICBXZWJQcmlu dFNjYWxpbmdPcHRpb25GaXRUb1ByaW50YWJsZUFyZWEsIC8vIFJlZHVjZXMgb3IgZW5sYXJnZXMg ZWFjaCBwYWdlIHRvIGZpdCB0aGUgcHJpbnRhYmxlIGFyZWEgb2YgdGhlIHNlbGVjdGVkIHByaW50 ZXIgcGFwZXIgc2l6ZS4KKyAgICBXZWJQcmludFNjYWxpbmdPcHRpb25Tb3VyY2VTaXplLCAvLyBQ cmludCBvdXRwdXQgcGFnZSBzaXplIGlzIHNhbWUgYXMgdGhlIGFjdHVhbCBzb3VyY2UgcGFnZSBz aXplLiBEbyBub3Qgc2NhbGUvY2VudGVyL2ZpdCB0byBwcmludGFibGUgYXJlYS4KK307CisKK30g Ly8gbmFtZXNwYWNlIFdlYktpdAorCisjZW5kaWYKClByb3BlcnR5IGNoYW5nZXMgb246IFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlByaW50U2NhbGluZ09wdGlvbi5oCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KQWRkZWQ6IHN2bjplb2wtc3R5bGUKICAgKyBMRgoK