84602 2012-04-23 09:00:45 -0700 [Qt] Tap-to zoom should navigate when appropiate 2012-04-24 08:27:27 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 84591 1 allan.jensen allan.jensen menard webkit.review.bot zoltan oldest_to_newest 607726 0 allan.jensen 2012-04-23 09:00:45 -0700 Tap-to-zoom should distinguish between taps in a zoomed area that should zoom back out and taps that should navigate to unexposed areas of the target area. To support this we should detect if the newly adjusted zoomed area would expose more of the zoom-target, and if it does navigate to the area instead of zooming back. 607727 1 138358 allan.jensen 2012-04-23 09:04:22 -0700 Created attachment 138358 Patch 608556 2 138537 allan.jensen 2012-04-24 04:53:40 -0700 Created attachment 138537 Patch 608691 3 138537 webkit.review.bot 2012-04-24 08:27:22 -0700 Comment on attachment 138537 Patch Clearing flags on attachment: 138537 Committed r115059: <http://trac.webkit.org/changeset/115059> 608692 4 webkit.review.bot 2012-04-24 08:27:27 -0700 All reviewed patches have been landed. Closing bug. 138358 2012-04-23 09:04:22 -0700 2012-04-24 04:53:34 -0700 Patch bug-84602-20120423180429.patch text/plain 3217 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0ODk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMjZjODRmYTNmMjEyNTAz OWQ2ZmYxMmViZDJiYjNhNWIxOTIzNGZkNy4uN2FjYmRlMTkwMDhjZDQzMGU4MmZjZmFmZmJlMTQx ODNjZDk2NzMxOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDEyLTA0LTIzICBBbGxh biBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5Abm9raWEuY29tPgogCisgICAgICAgIFtR dF0gVGFwLXRvIHpvb20gc2hvdWxkIG5hdmlnYXRlIHdoZW4gYXBwcm9waWF0ZQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODQ2MDIKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIFdoZW4gYSB6b29t YWJsZSBhcmVhIGlzIHJldHVybmVkIGFuZCBoYXMgdGhlIHNhbWUgem9vbS1sZXZlbCBhcyB0aGUg Y3VycmVudCwgCisgICAgICAgIGV4YW1pbmUgaWYgdGhlIHVzaW5nIHRoaXMgdGFyZ2V0IHdvdWxk IGV4cG9zZSBjdXJyZW50bHkgdW5leHBvc2VkIHBhcnRzIG9mCisgICAgICAgIHRoZSB6b29tLXRh cmdldC4gSWYgaXQgZG9lcywgcGFuIHRvIHRoYXQgYXJlYSBpbnN0ZWFkIG9mIHpvb21pbmcgYmFj ay4KKworICAgICAgICAqIFVJUHJvY2Vzcy9xdC9RdFZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmUu Y3BwOgorICAgICAgICAoV2ViS2l0OjpRdFZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmU6Onpvb21U b0FyZWFHZXN0dXJlRW5kZWQpOgorCisyMDEyLTA0LTIzICBBbGxhbiBTYW5kZmVsZCBKZW5zZW4g IDxhbGxhbi5qZW5zZW5Abm9raWEuY29tPgorCiAgICAgICAgIFtRdF0gUmVzdG9yZSB4LXBvc2l0 aW9uIHdoZW4gcmVzdG9yaW5nIHByZXZpb3VzIHpvb20tbGV2ZWwuCiAgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NDU5MQogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRWaWV3cG9ydEludGVyYWN0aW9uRW5naW5lLmNwcCBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmUu Y3BwCmluZGV4IGY5ZjhjYzY0MDQyZDZlN2ViYzMyNGY3NzU5MjEyNjU1YTE4NGRlZDAuLjhmNDJm ZTBjNTNjYjNlODM0OGZlYmNmNjc5ODM0MzIwZmQyZTA3NmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmUuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmUu Y3BwCkBAIC0zODgsMTUgKzM4OCwyMCBAQCB2b2lkIFF0Vmlld3BvcnRJbnRlcmFjdGlvbkVuZ2lu ZTo6em9vbVRvQXJlYUdlc3R1cmVFbmRlZChjb25zdCBRUG9pbnRGJiB0b3VjaFBvaQogCiAgICAg UVJlY3RGIGVuZFZpc2libGVDb250ZW50UmVjdChlbmRQb3NpdGlvbiAvIGVuZEl0ZW1TY2FsZSwg dmlld3BvcnRSZWN0LnNpemUoKSAvIGVuZEl0ZW1TY2FsZSk7CiAKLSAgICBlbnVtIHsgWm9vbUlu LCBab29tQmFjaywgWm9vbU91dCB9IHpvb21BY3Rpb24gPSBab29tSW47CisgICAgZW51bSB7IFpv b21JbiwgWm9vbUJhY2ssIFpvb21PdXQsIE5vWm9vbSB9IHpvb21BY3Rpb24gPSBab29tSW47CiAK ICAgICBpZiAoIW1fc2NhbGVTdGFjay5pc0VtcHR5KCkpIHsKICAgICAgICAgLy8gWm9vbSBiYWNr IG91dCBpZiBhdHRlbXB0aW5nIHRvIHNjYWxlIHRvIHRoZSBzYW1lIGN1cnJlbnQgc2NhbGUsIG9y CiAgICAgICAgIC8vIGF0dGVtcHRpbmcgdG8gY29udGludWUgc2NhbGluZyBvdXQgZnJvbSB0aGUg aW5uZXIgbW9zdCBsZXZlbC4KLSAgICAgICAgaWYgKGZ1enp5Q29tcGFyZShlbmRJdGVtU2NhbGUs IGN1cnJlbnRTY2FsZSwgMC4wMSkpCi0gICAgICAgICAgICAvLyBGSVhNRTogQ2hlY2sgaWYgd2Ug c2hvdWxkIG1vdmUgdGhlIHZpZXdwb3J0IGluc3RlYWQgb2Ygem9vbWluZyBiYWNrLgotICAgICAg ICAgICAgem9vbUFjdGlvbiA9IFpvb21CYWNrOwotICAgICAgICBlbHNlIGlmIChmdXp6eUNvbXBh cmUoZW5kSXRlbVNjYWxlLCBtX3pvb21PdXRTY2FsZSwgMC4wMSkpCisgICAgICAgIGlmIChmdXp6 eUNvbXBhcmUoZW5kSXRlbVNjYWxlLCBjdXJyZW50U2NhbGUsIDAuMDEpKSB7CisgICAgICAgICAg ICAvLyBJZiBtb3ZpbmcgdGhlIHZpZXdwb3J0IHdvdWxkIGV4cG9zZSBtb3JlIG9mIHRoZSB0YXJn ZXRSZWN0LCB1cGRhdGUgcG9zaXRpb24gYnV0IGRvIG5vdCBzY2FsZSBvdXQuCisgICAgICAgICAg ICBRUmVjdEYgY3VycmVudFJlY3QobV92aWV3cG9ydC0+Y29udGVudFBvcygpIC8gY3VycmVudFNj YWxlLCB2aWV3cG9ydFJlY3Quc2l6ZSgpIC8gY3VycmVudFNjYWxlKTsKKyAgICAgICAgICAgIFFS ZWN0RiB0YXJnZXRJbnRlcnNlY3Rpb24gPSBlbmRWaXNpYmxlQ29udGVudFJlY3QuaW50ZXJzZWN0 ZWQodGFyZ2V0QXJlYSk7CisgICAgICAgICAgICBpZiAoIWN1cnJlbnRSZWN0LmNvbnRhaW5zKHRh cmdldEludGVyc2VjdGlvbikpCisgICAgICAgICAgICAgICAgem9vbUFjdGlvbiA9IE5vWm9vbTsK KyAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICB6b29tQWN0aW9uID0gWm9vbUJhY2s7 CisgICAgICAgIH0gZWxzZSBpZiAoZnV6enlDb21wYXJlKGVuZEl0ZW1TY2FsZSwgbV96b29tT3V0 U2NhbGUsIDAuMDEpKQogICAgICAgICAgICAgem9vbUFjdGlvbiA9IFpvb21CYWNrOwogICAgICAg ICBlbHNlIGlmIChlbmRJdGVtU2NhbGUgPCBjdXJyZW50U2NhbGUpCiAgICAgICAgICAgICB6b29t QWN0aW9uID0gWm9vbU91dDsKQEAgLTQyMSw2ICs0MjYsOCBAQCB2b2lkIFF0Vmlld3BvcnRJbnRl cmFjdGlvbkVuZ2luZTo6em9vbVRvQXJlYUdlc3R1cmVFbmRlZChjb25zdCBRUG9pbnRGJiB0b3Vj aFBvaQogICAgICAgICAgICAgbV9zY2FsZVN0YWNrLnJlbW92ZUxhc3QoKTsKICAgICAgICAgbV96 b29tT3V0U2NhbGUgPSBlbmRJdGVtU2NhbGU7CiAgICAgICAgIGJyZWFrOworICAgIGNhc2UgTm9a b29tOgorICAgICAgICBicmVhazsKICAgICB9CiAKICAgICBhbmltYXRlSXRlbVJlY3RWaXNpYmxl KGVuZFZpc2libGVDb250ZW50UmVjdCk7Cg== 138537 2012-04-24 04:53:40 -0700 2012-04-24 08:27:22 -0700 Patch bug-84602-20120424135346.patch text/plain 3347 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1MDAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOWM1NjhlZTg2YmQ2MzFi M2E5OGVhZTljNDc4MjY4OTdiNDU1NDMwOS4uNTdjMzNlMGRkY2QxZmRhYzIxZTJiODQzN2Q5NWVk YTIzZDhhMTM3YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDEyLTA0LTIzICBBbGxh biBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5Abm9raWEuY29tPgogCisgICAgICAgIFtR dF0gVGFwLXRvIHpvb20gc2hvdWxkIG5hdmlnYXRlIHdoZW4gYXBwcm9waWF0ZQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODQ2MDIKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIGEgem9vbWFibGUgYXJl YSBpcyByZXR1cm5lZCBhbmQgaGFzIHRoZSBzYW1lIHpvb20tbGV2ZWwgYXMgdGhlIGN1cnJlbnQs IAorICAgICAgICBleGFtaW5lIGlmIHRoZSB1c2luZyB0aGlzIHRhcmdldCB3b3VsZCBleHBvc2Ug Y3VycmVudGx5IHVuZXhwb3NlZCBwYXJ0cyBvZgorICAgICAgICB0aGUgem9vbS10YXJnZXQuIElm IGl0IGRvZXMsIHBhbiB0byB0aGF0IGFyZWEgaW5zdGVhZCBvZiB6b29taW5nIGJhY2suCisKKyAg ICAgICAgKiBVSVByb2Nlc3MvcXQvUXRWaWV3cG9ydEludGVyYWN0aW9uRW5naW5lLmNwcDoKKyAg ICAgICAgKFdlYktpdDo6UXRWaWV3cG9ydEludGVyYWN0aW9uRW5naW5lOjp6b29tVG9BcmVhR2Vz dHVyZUVuZGVkKToKKworMjAxMi0wNC0yMyAgQWxsYW4gU2FuZGZlbGQgSmVuc2VuICA8YWxsYW4u amVuc2VuQG5va2lhLmNvbT4KKwogICAgICAgICBbUXRdIFJlc3RvcmUgeC1wb3NpdGlvbiB3aGVu IHJlc3RvcmluZyBwcmV2aW91cyB6b29tLWxldmVsLgogICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODQ1OTEKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL3F0L1F0Vmlld3BvcnRJbnRlcmFjdGlvbkVuZ2luZS5jcHAgYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRWaWV3cG9ydEludGVyYWN0aW9uRW5naW5lLmNwcAppbmRl eCAzODg0OTNkN2FkNjQ0MDZjMDg5OGFjNWFlZjRiYjYwMDBkZmRhYjhhLi42NzRmNjYyZDk0ZGZh ODI4YTcxZDk2YjZjMTYxODI5YmYxOGVjYTUyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvcXQvUXRWaWV3cG9ydEludGVyYWN0aW9uRW5naW5lLmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRWaWV3cG9ydEludGVyYWN0aW9uRW5naW5lLmNwcApAQCAt Mzg3LDE1ICszODcsMjAgQEAgdm9pZCBRdFZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmU6Onpvb21U b0FyZWFHZXN0dXJlRW5kZWQoY29uc3QgUVBvaW50RiYgdG91Y2hQb2kKIAogICAgIFFSZWN0RiBl bmRWaXNpYmxlQ29udGVudFJlY3QoZW5kUG9zaXRpb24gLyBlbmRJdGVtU2NhbGUsIHZpZXdwb3J0 UmVjdC5zaXplKCkgLyBlbmRJdGVtU2NhbGUpOwogCi0gICAgZW51bSB7IFpvb21JbiwgWm9vbUJh Y2ssIFpvb21PdXQgfSB6b29tQWN0aW9uID0gWm9vbUluOworICAgIGVudW0geyBab29tSW4sIFpv b21CYWNrLCBab29tT3V0LCBOb1pvb20gfSB6b29tQWN0aW9uID0gWm9vbUluOwogCiAgICAgaWYg KCFtX3NjYWxlU3RhY2suaXNFbXB0eSgpKSB7CiAgICAgICAgIC8vIFpvb20gYmFjayBvdXQgaWYg YXR0ZW1wdGluZyB0byBzY2FsZSB0byB0aGUgc2FtZSBjdXJyZW50IHNjYWxlLCBvcgogICAgICAg ICAvLyBhdHRlbXB0aW5nIHRvIGNvbnRpbnVlIHNjYWxpbmcgb3V0IGZyb20gdGhlIGlubmVyIG1v c3QgbGV2ZWwuCiAgICAgICAgIC8vIFVzZSBmdXp6eSBjb21wYXJlIHdpdGggYSBmaXhlZCBlcnJv ciB0byBiZSBhYmxlIHRvIGRlYWwgd2l0aCBsYXJnaXNoIGRpZmZlcmVuY2VzIGR1ZSB0byBwaXhl bCByb3VuZGluZy4KICAgICAgICAgaWYgKGZ1enp5Q29tcGFyZShlbmRJdGVtU2NhbGUsIGN1cnJl bnRTY2FsZSwgMC4wMSkpIHsKLSAgICAgICAgICAgIC8vIEZJWE1FOiBDaGVjayBpZiB3ZSBzaG91 bGQgbW92ZSB0aGUgdmlld3BvcnQgaW5zdGVhZCBvZiB6b29taW5nIGJhY2suCi0gICAgICAgICAg ICB6b29tQWN0aW9uID0gWm9vbUJhY2s7CisgICAgICAgICAgICAvLyBJZiBtb3ZpbmcgdGhlIHZp ZXdwb3J0IHdvdWxkIGV4cG9zZSBtb3JlIG9mIHRoZSB0YXJnZXRSZWN0IGFuZCBtb3ZlIGF0IGxl YXN0IDQwIHBpeGVscywgdXBkYXRlIHBvc2l0aW9uIGJ1dCBkbyBub3Qgc2NhbGUgb3V0LgorICAg ICAgICAgICAgUVJlY3RGIGN1cnJlbnRDb250ZW50UmVjdChtX3ZpZXdwb3J0LT5jb250ZW50UG9z KCkgLyBjdXJyZW50U2NhbGUsIHZpZXdwb3J0UmVjdC5zaXplKCkgLyBjdXJyZW50U2NhbGUpOwor ICAgICAgICAgICAgUVJlY3RGIHRhcmdldEludGVyc2VjdGlvbiA9IGVuZFZpc2libGVDb250ZW50 UmVjdC5pbnRlcnNlY3RlZCh0YXJnZXRBcmVhKTsKKyAgICAgICAgICAgIGlmICghY3VycmVudENv bnRlbnRSZWN0LmNvbnRhaW5zKHRhcmdldEludGVyc2VjdGlvbikgJiYgKHFBYnMoZW5kVmlzaWJs ZUNvbnRlbnRSZWN0LnRvcCgpIC0gY3VycmVudENvbnRlbnRSZWN0LnRvcCgpKSA+PSA0MCB8fCBx QWJzKGVuZFZpc2libGVDb250ZW50UmVjdC5sZWZ0KCkgLSBjdXJyZW50Q29udGVudFJlY3QubGVm dCgpKSA+PSA0MCkpCisgICAgICAgICAgICAgICAgem9vbUFjdGlvbiA9IE5vWm9vbTsKKyAgICAg ICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICB6b29tQWN0aW9uID0gWm9vbUJhY2s7CiAgICAg ICAgIH0gZWxzZSBpZiAoZnV6enlDb21wYXJlKGVuZEl0ZW1TY2FsZSwgbV96b29tT3V0U2NhbGUs IDAuMDEpKQogICAgICAgICAgICAgem9vbUFjdGlvbiA9IFpvb21CYWNrOwogICAgICAgICBlbHNl IGlmIChlbmRJdGVtU2NhbGUgPCBjdXJyZW50U2NhbGUpCkBAIC00MjEsNiArNDI2LDggQEAgdm9p ZCBRdFZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmU6Onpvb21Ub0FyZWFHZXN0dXJlRW5kZWQoY29u c3QgUVBvaW50RiYgdG91Y2hQb2kKICAgICAgICAgICAgIG1fc2NhbGVTdGFjay5yZW1vdmVMYXN0 KCk7CiAgICAgICAgIG1fem9vbU91dFNjYWxlID0gZW5kSXRlbVNjYWxlOwogICAgICAgICBicmVh azsKKyAgICBjYXNlIE5vWm9vbToKKyAgICAgICAgYnJlYWs7CiAgICAgfQogCiAgICAgYW5pbWF0 ZUl0ZW1SZWN0VmlzaWJsZShlbmRWaXNpYmxlQ29udGVudFJlY3QpOwo=