84595 2012-04-23 07:10:11 -0700 [Qt] Ensure zero-width space effectively accounts for a width of zero. 2012-11-21 06:45:05 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt, QtTriaged P2 Normal --- 42689 102920 1 pierre.rossi pierre.rossi hausmann jesus ossy oldest_to_newest 607652 0 pierre.rossi 2012-04-23 07:10:11 -0700 [Qt] Ensure zero-width space effectively accounts for a width of zero. 607671 1 138344 pierre.rossi 2012-04-23 07:44:28 -0700 Created attachment 138344 Patch 607682 2 pierre.rossi 2012-04-23 07:55:48 -0700 Committed r114899: <http://trac.webkit.org/changeset/114899> 607706 3 ossy 2012-04-23 08:40:13 -0700 Reopen, because it broke 62 tests on Qt5-WK1 and WK2 bots ... Could you check if it is regression or progression and then fix it soon? 607733 4 138344 ossy 2012-04-23 09:09:33 -0700 Comment on attachment 138344 Patch I skipped the failing tests to make the bot green and be able catch new regressions - http://trac.webkit.org/changeset/114905 Please unskip the tests with the proper fix. Just a question: Wouldn't be simpler to run layout tests before landing? 607776 5 pierre.rossi 2012-04-23 10:03:51 -0700 Committed new baselines manually in r114913: <http://trac.webkit.org/changeset/114913> 608444 6 ossy 2012-04-24 01:24:18 -0700 Reopen again, because two tests are still failing: - editing/selection/5354455-1.html - editing/selection/click-left-of-rtl-wrapping-text.html The first one is still fail on the bot: --- /home/webkitbuildbot/slaves/release32bit-qt5/buildslave/qt-linux-32-release-qt5/build/layout-test-results/editing/selection/5354455-1-expected.txt +++ /home/webkitbuildbot/slaves/release32bit-qt5/buildslave/qt-linux-32-release-qt5/build/layout-test-results/editing/selection/5354455-1-actual.txt @@ -1,6 +1,6 @@ This tests whether right clicking on a paragraph break in editable content selects it. The break should be selected on OS X, but not on Windows or Unix. To run it manually, right click on the paragraph break after the first paragraph below. -The following paragraph break should be selected on OS X. + Mac: Caret Win: Caret For the second one you committed wrong expected result: http://trac.webkit.org/browser/trunk/LayoutTests/platform/qt-5.0/editing/selection/click-left-of-rtl-wrapping-text-expected.txt?rev=114908 (diff: http://build.webkit.sed.hu/results/x86-32%20Linux%20Qt%20Release%20-%20Qt5-WebKit1/r114902%20%286441%29/editing/selection/click-left-of-rtl-wrapping-text-pretty-diff.html) It's hard to believe if it is the correct result. In my head FAIL instead of PASS words always mean regression. I'm going to skip these tests again to make bots happier a little bit. 608455 7 ossy 2012-04-24 01:36:41 -0700 I skipped them _again_ - http://trac.webkit.org/changeset/115010/trunk/LayoutTests/platform/qt-5.0/Skipped Please unskip them with the proper fix. 625855 8 jesus 2012-05-16 14:11:56 -0700 (In reply to comment #7) > I skipped them _again_ - http://trac.webkit.org/changeset/115010/trunk/LayoutTests/platform/qt-5.0/Skipped > > Please unskip them with the proper fix. Ossy, editing/selection/click-left-of-rtl-wrapping-text.html is passing locally for me with Qt5. Can you check and see if we can just unskip it please? I will have a look now at the other one. thanks! 625861 9 jesus 2012-05-16 14:17:10 -0700 editing/selection/5354455-1.html is not working because we need layoutTestController.setEditingBehavior (bug 42689). 626465 10 ossy 2012-05-17 05:04:39 -0700 (In reply to comment #8) > (In reply to comment #7) > > I skipped them _again_ - http://trac.webkit.org/changeset/115010/trunk/LayoutTests/platform/qt-5.0/Skipped > > > > Please unskip them with the proper fix. > > Ossy, editing/selection/click-left-of-rtl-wrapping-text.html is passing locally for me with Qt5. Can you check and see if we can just unskip it please? I will have a look now at the other one. Yes, it passes, because _WRONG_ expected file was committed with 3 big FAIL message. So it is still valid bug. 626469 11 ossy 2012-05-17 05:07:53 -0700 (In reply to comment #9) > editing/selection/5354455-1.html is not working because we need layoutTestController.setEditingBehavior (bug 42689). But it fails on Qt5-WK1, it is unrelated to WK2 missing feature you mentioned. And it passed before and fail now, so it is a regression. 772789 12 ossy 2012-11-21 04:23:14 -0800 editing/selection/click-left-of-rtl-wrapping-text.html passes now (I updated the expected file by r135382), but the other test still fails, because r114899 _broke_ it. I filed a new bug report to track this _regression_ - https://bugs.webkit.org/show_bug.cgi?id=102920 772907 13 pierre.rossi 2012-11-21 06:45:05 -0800 (In reply to comment #12) > editing/selection/click-left-of-rtl-wrapping-text.html passes now (I updated > the expected file by r135382), but the other test still fails, because r114899 > _broke_ it. I filed a new bug report to track this _regression_ - https://bugs.webkit.org/show_bug.cgi?id=102920 This was only intended as a workaround originally, but an attempt at fixing the root problem didn't turn out to be that popular. So we're stuck with that for now. I'll take another crack at it and maybe try a different approach once we're done with the WebKitWidget split. 138344 2012-04-23 07:44:28 -0700 2012-04-23 09:09:32 -0700 Patch bug-84595-20120423164412.patch text/plain 1967 pierre.rossi U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0ODk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWIyNjZmY2Q1NjA1NzAx NjMwN2U2OWU4NDk5YjAyZmE0ZjMwOTY3OS4uYzY5YTE4YjJjNzk0MjQxOTFkMWI0OTYwN2FhNzc1 OGU4NWExMDc5NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA0LTIzICBQaWVy cmUgUm9zc2kgIDxwaWVycmUucm9zc2lAZ21haWwuY29tPgorCisgICAgICAgIFtRdF0gRW5zdXJl IHplcm8td2lkdGggc3BhY2UgZWZmZWN0aXZlbHkgYWNjb3VudHMgZm9yIGEgd2lkdGggb2YgemVy by4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg0NTk1 CisKKyAgICAgICAgVGhlIGxvZ2ljIHNvIGZhciByZWxpZXMgb24gRm9udENhY2hlOjpnZXRGb250 RGF0YUZvckNoYXJhY3RlcnMgdG8KKyAgICAgICAgcmV0dXJuIGEgdmFsaWQgZm9udERhdGEgaW4g dGhlIGNhc2Ugd2hlcmUgdGhlIGZvbnRzIHNwZWNpZmllZCBkb24ndAorICAgICAgICBoYXZlIGEg Z2x5cGggZm9yIHRoZSB6ZXJvLXdpZHRoIHNwYWNlIGNoYXJhY3Rlci4KKyAgICAgICAgUVRleHRM YXlvdXQ6OmdseXBoUnVucyBzaW1wbHkgaWdub3JlcyBjaGFyYWN0ZXJzIHRoYXQgZG9uJ3QgcmVu ZGVyIGluCisgICAgICAgIHRoZSBnbHlwaCBydW5zIGl0IHJldHVybnMsIHNvIHdlIG5lZWQgdG8g ZW5zdXJlIHRoYXQgdGhlIHN1YnNlcXVlbnQKKyAgICAgICAgY2FsbCB0byBwbGF0Zm9ybVdpZHRo Rm9yR2x5cGggZG9lc24ndCBsZWFkIHRvIGEgbm9uLXplcm8gd2lkdGguCisKKyAgICAgICAgQ292 ZXJlZCBieSB0ZXN0cyBjb250YWluaW5nIGNvbnRyb2wgY2hhcmFjdGVycyBzdWNoIGFzCisgICAg ICAgIGEgc29mdC1oeXBoZW4gbGlrZSBpdCdzIHRoZSBjYXNlIGluOgorICAgICAgICBzdmcvYXMt aW1hZ2UvaW1nLXByZXNlcnZlQXNwZWN0UmF0aW8tc3VwcG9ydC0xLmh0bWwKKworICAgICAgICAq IHBsYXRmb3JtL2dyYXBoaWNzL3F0L1NpbXBsZUZvbnREYXRhUXQuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6U2ltcGxlRm9udERhdGE6OnBsYXRmb3JtV2lkdGhGb3JHbHlwaCk6CisKIDIwMTItMDQt MjMgIFl1cnkgU2VtaWtoYXRza3kgIDx5dXJ5c0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2Vi IEluc3BlY3RvcjogaW1wcm92ZSB0aGUgd2F5IGhlYXAgc25hcHNob3QgZGlmZiBpcyBjYWxjdWxh dGVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9TaW1w bGVGb250RGF0YVF0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L1Np bXBsZUZvbnREYXRhUXQuY3BwCmluZGV4IGIzMGNkNWY1MDcwOWEyYjdhMDAzZWE5ZTUwOGZmNzNj NDViM2Y0NzAuLjFiY2Q2YzA1YmMxM2ZhZDk2MmFjOGFjYjk0ZmQ5M2FjZDY4MTNkYTAgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L1NpbXBsZUZvbnREYXRh UXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L1NpbXBsZUZv bnREYXRhUXQuY3BwCkBAIC02MSw3ICs2MSw3IEBAIGJvb2wgU2ltcGxlRm9udERhdGE6OmNvbnRh aW5zQ2hhcmFjdGVycyhjb25zdCBVQ2hhciogY2hhcmFjdGVycywgaW50IGxlbmd0aCkgY29uCiAK IGZsb2F0IFNpbXBsZUZvbnREYXRhOjpwbGF0Zm9ybVdpZHRoRm9yR2x5cGgoR2x5cGggZ2x5cGgp IGNvbnN0CiB7Ci0gICAgaWYgKCFwbGF0Zm9ybURhdGEoKS5zaXplKCkpCisgICAgaWYgKCFnbHlw aCB8fCAhcGxhdGZvcm1EYXRhKCkuc2l6ZSgpKQogICAgICAgICByZXR1cm4gMDsKIAogICAgIFFW ZWN0b3I8cXVpbnQzMj4gZ2x5cGhJbmRleGVzOwo=