84594 2012-04-23 06:50:32 -0700 [Qt] Incomplete interaction-engine reset 2012-04-24 01:53:23 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 allan.jensen allan.jensen menard webkit.review.bot zoltan oldest_to_newest 607645 0 allan.jensen 2012-04-23 06:50:32 -0700 The scaling stack is not reset in QtViewportInteractionEngine::reset(), this leads to odd zooming behaviour if first using the tap-to-zoom gesture and then resizing the viewport in the minibrowser. 607647 1 138339 allan.jensen 2012-04-23 06:52:11 -0700 Created attachment 138339 Patch 607649 2 138339 menard 2012-04-23 06:58:46 -0700 Comment on attachment 138339 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138339&action=review Could you look if m_pinchStartScale needs also to be reset? I mean since you are fixing the reset method make sure all the content that needs to be cleared is actually reset. > Source/WebKit2/ChangeLog:3 > + [Qt] Scaling stack not reset on reset. nitpick : Scaling stack not cleared on reset. 607667 3 138342 allan.jensen 2012-04-23 07:43:11 -0700 Created attachment 138342 Patch 608463 4 138342 webkit.review.bot 2012-04-24 01:53:03 -0700 Comment on attachment 138342 Patch Clearing flags on attachment: 138342 Committed r115012: <http://trac.webkit.org/changeset/115012> 608464 5 webkit.review.bot 2012-04-24 01:53:23 -0700 All reviewed patches have been landed. Closing bug. 138339 2012-04-23 06:52:11 -0700 2012-04-23 07:43:05 -0700 Patch bug-84594-20120423155217.patch text/plain 1594 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0ODc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYTczNWI1NTAzNzViNDdi Nzg5ZGYwZTllNDlhOWUwYzAyMGE5NGQzMS4uZTA3MTI3NTdkZTA0ODgwYTU3ZjgxOTZlNDI1MDU0 MWZiNDMxNTA1ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE1IEBACiAyMDEyLTA0LTIzICBBbGxh biBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5Abm9raWEuY29tPgogCisgICAgICAgIFtR dF0gU2NhbGluZyBzdGFjayBub3QgcmVzZXQgb24gcmVzZXQuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NDU5NAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL3F0L1F0Vmlld3BvcnRJbnRl cmFjdGlvbkVuZ2luZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OlF0Vmlld3BvcnRJbnRlcmFjdGlv bkVuZ2luZTo6ZW5zdXJlQ29udGVudFdpdGhpblZpZXdwb3J0Qm91bmRhcnkpOgorCisyMDEyLTA0 LTIzICBBbGxhbiBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5Abm9raWEuY29tPgorCiAg ICAgICAgIFtRdF0gUmVzdG9yZSB4LXBvc2l0aW9uIHdoZW4gcmVzdG9yaW5nIHByZXZpb3VzIHpv b20tbGV2ZWwuCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD04NDU5MQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRWaWV3 cG9ydEludGVyYWN0aW9uRW5naW5lLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9R dFZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmUuY3BwCmluZGV4IDlhMjA4ZmVmZDcxMTllOTE1ZGEw ZGM0MDgxYWY3MjYyZTJjMmNmODYuLjQwYTg2ODE4YTFmY2NjMjA2MjhhMTllYmFlNTQ2ZTQyYTBm NWFkYTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFZpZXdwb3J0 SW50ZXJhY3Rpb25FbmdpbmUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9R dFZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmUuY3BwCkBAIC00NTIsMTEgKzQ1MiwxMyBAQCB2b2lk IFF0Vmlld3BvcnRJbnRlcmFjdGlvbkVuZ2luZTo6cmVzZXQoKQogICAgIG1fbWluaW11bVNjYWxl ID0gMTsKICAgICBtX21heGltdW1TY2FsZSA9IDE7CiAgICAgbV9kZXZpY2VQaXhlbFJhdGlvID0g MTsKKyAgICBtX3pvb21PdXRTY2FsZSA9IDAuMDsKIAogICAgIG1fdmlld3BvcnQtPmNhbmNlbEZs aWNrKCk7CiAgICAgbV9zY2FsZUFuaW1hdGlvbi0+c3RvcCgpOwogICAgIG1fc2NhbGVVcGRhdGVE ZWZlcnJlci5jbGVhcigpOwogICAgIG1fc2Nyb2xsVXBkYXRlRGVmZXJyZXIuY2xlYXIoKTsKKyAg ICBtX3NjYWxlU3RhY2suY2xlYXIoKTsKIH0KIAogdm9pZCBRdFZpZXdwb3J0SW50ZXJhY3Rpb25F bmdpbmU6OnNldENTU1NjYWxlQm91bmRzKHFyZWFsIG1pbmltdW0sIHFyZWFsIG1heGltdW0pCg== 138342 2012-04-23 07:43:11 -0700 2012-04-24 01:53:02 -0700 Patch bug-84594-20120423164317.patch text/plain 1572 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0ODk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMTdmZTFlYzg5YjVmZTkz YjUyN2FhMzgzYWRmZmY0YTdmMmVhZDZmNS4uMDg2ZTY2ZDM1ODQ3MTBjNGI3N2UyZjg0NTYwMTE3 MGNhYTU2ODM0NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA0LTIzICBBbGxh biBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5Abm9raWEuY29tPgorCisgICAgICAgIFtR dF0gSW5jb21wbGV0ZSBpbnRlcmFjdGlvbi1lbmdpbmUgcmVzZXQuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NDU5NAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlc2V0IGEgZmV3IHZhbHVlcyBmb3Jnb3R0 ZW4gaW4gdGhlIHJlc2V0IGZ1bmN0aW9uLgorCisgICAgICAgICogVUlQcm9jZXNzL3F0L1F0Vmll d3BvcnRJbnRlcmFjdGlvbkVuZ2luZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OlF0Vmlld3BvcnRJ bnRlcmFjdGlvbkVuZ2luZTo6cmVzZXQpOgorCiAyMDEyLTA0LTIzICBLZW50IFRhbXVyYSAgPHRr ZW50QGNocm9taXVtLm9yZz4KIAogICAgICAgICBBZGQgdGVzdCBmdW5jdGlvbiB0byBnZXQgcGxh Y2Vob2xkZXIgc3RyaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQv UXRWaWV3cG9ydEludGVyYWN0aW9uRW5naW5lLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9xdC9RdFZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmUuY3BwCmluZGV4IDEzOTAzNTZmMjg2ZTgy MThjZTQ1ZTVkNmQ4ODE3NjNhMTdhYmJhZWEuLjk1NzljZjQxODRlODFmYWRiZjQ1ZjZmMDQzZmZi MjAwNWNmZmZjYmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFZp ZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9xdC9RdFZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmUuY3BwCkBAIC00MzcsMTEgKzQzNywxNCBA QCB2b2lkIFF0Vmlld3BvcnRJbnRlcmFjdGlvbkVuZ2luZTo6cmVzZXQoKQogICAgIG1fbWluaW11 bVNjYWxlID0gMTsKICAgICBtX21heGltdW1TY2FsZSA9IDE7CiAgICAgbV9kZXZpY2VQaXhlbFJh dGlvID0gMTsKKyAgICBtX3BpbmNoU3RhcnRTY2FsZSA9IC0xOworICAgIG1fem9vbU91dFNjYWxl ID0gMC4wOwogCiAgICAgbV92aWV3cG9ydC0+Y2FuY2VsRmxpY2soKTsKICAgICBtX3NjYWxlQW5p bWF0aW9uLT5zdG9wKCk7CiAgICAgbV9zY2FsZVVwZGF0ZURlZmVycmVyLmNsZWFyKCk7CiAgICAg bV9zY3JvbGxVcGRhdGVEZWZlcnJlci5jbGVhcigpOworICAgIG1fc2NhbGVTdGFjay5jbGVhcigp OwogfQogCiB2b2lkIFF0Vmlld3BvcnRJbnRlcmFjdGlvbkVuZ2luZTo6c2V0Q1NTU2NhbGVCb3Vu ZHMocXJlYWwgbWluaW11bSwgcXJlYWwgbWF4aW11bSkK