84566 2012-04-22 23:32:24 -0700 Web Inspector: [chromium] show more useful information for throttled requests. 2012-05-01 05:28:11 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 79666 0 yzshen yzshen abarth apavlov bweinstein dglazkov fishd jamesr joepeck joi keishi kling loislo ossy pfeldman pmuellr rik szledan timothy tkent+wkapi webkit.review.bot yurys oldest_to_newest 607495 0 yzshen 2012-04-22 23:32:24 -0700 Currently, when a request is intentionally throttled by URLRequestThrottler, it shows up as a failure in the DevTools console and the network tab, without any specific information. It may cause confusion for users because it looks the same as other failures, such as the request is sent but no response is received. The corresponding Chromium bug is http://code.google.com/p/chromium/issues/detail?id=109857. 607496 1 yzshen 2012-04-22 23:32:41 -0700 I will upload a patch soon. 608127 2 138444 yzshen 2012-04-23 15:51:42 -0700 Created attachment 138444 Patch 608134 3 webkit.review.bot 2012-04-23 15:57:27 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 608152 4 yzshen 2012-04-23 16:10:34 -0700 Hi, Inspector experts. This patch shows the description for failed requests in the Status column of the Network tab. Currently the Status column shows things like: successful request: "304 \n Not Modified" failed request: "(failed)" This patch will show the following for failed requests: "(failed) \n <localizedFailDescription>" To me, this adds more useful information for failures (e.g., for requests rejected by the Chromium-specific feature of HTTP throttling). And it matches the successful cases, which have already had a human-friendly description. Please let me know if this looks okay to you. I would be happy to make changes if you have better ideas. Thanks in advance! 608879 5 138444 webkit.review.bot 2012-04-24 11:33:14 -0700 Comment on attachment 138444 Patch Clearing flags on attachment: 138444 Committed r115086: <http://trac.webkit.org/changeset/115086> 608880 6 webkit.review.bot 2012-04-24 11:33:33 -0700 All reviewed patches have been landed. Closing bug. 609556 7 ossy 2012-04-25 02:03:29 -0700 It made a test fail on Qt platform: --- /home/webkitbuildbot/slaves/release32bit-NRWT/buildslave/qt-linux-32-release-NRWT/build/layout-test-results/inspector/network-status-non-http-expected.txt +++ /home/webkitbuildbot/slaves/release32bit-NRWT/buildslave/qt-linux-32-release-NRWT/build/layout-test-results/inspector/network-status-non-http-actual.txt @@ -1,6 +1,6 @@ { 0 : "data:application/javascript: Success" 1 : "network-test.js: Success" - 2 : "non-existent-file.js: (failed)" + 2 : "non-existent-file.js: (failed)Error opening /home/webkitbuildbot/slaves/release32bit-NRWT/buildslave/qt-linux-32-release-NRWT/build/LayoutTests/inspector/non-existent-file.js: No such file or directory" } Could you check it, please? 609666 8 szledan 2012-04-25 05:29:50 -0700 This patch inspector/network-status-non-http.html fails on qt. This test has been skipped until it is fixed. See http://trac.webkit.org/changeset/115188 Please unskip it with the proper fix. 609838 9 yzshen 2012-04-25 09:40:18 -0700 Sorry for the inconvenience. I will fix it as soon as possible. 610272 10 138916 yzshen 2012-04-25 18:21:57 -0700 Created attachment 138916 Patch 610276 11 138916 yzshen 2012-04-25 18:23:54 -0700 Comment on attachment 138916 Patch This patch fixes the test regression. Please take a look. 610347 12 138916 yurys 2012-04-25 22:04:07 -0700 Comment on attachment 138916 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138916&action=review > LayoutTests/inspector/network-status-non-http.html:24 > + if (outputStatus.indexOf("(failed)") == 0) Please use .startsWith for prefix checks. 610694 13 yzshen 2012-04-26 10:03:31 -0700 (In reply to comment #12) > (From update of attachment 138916 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=138916&action=review > > > LayoutTests/inspector/network-status-non-http.html:24 > > + if (outputStatus.indexOf("(failed)") == 0) > > Please use .startsWith for prefix checks. Javascript string doesn't have .startsWith method, does it? 612192 14 138916 pfeldman 2012-04-28 00:31:09 -0700 Comment on attachment 138916 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138916&action=review >>> LayoutTests/inspector/network-status-non-http.html:24 >>> + if (outputStatus.indexOf("(failed)") == 0) >> >> Please use .startsWith for prefix checks. > > Javascript string doesn't have .startsWith method, does it? We added it to the String's prototype in utilities.js 612626 15 138916 webkit.review.bot 2012-04-30 07:44:59 -0700 Comment on attachment 138916 Patch Rejecting attachment 138916 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ueue/ Parsed 3 diffs from patch file(s). patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/inspector/network-status-non-http.html patching file LayoutTests/platform/qt/Skipped Hunk #1 FAILED at 2616. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/qt/Skipped.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Pavel Feld..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12597070 612882 16 yzshen 2012-04-30 12:55:35 -0700 (In reply to comment #14) > (From update of attachment 138916 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=138916&action=review > > >>> LayoutTests/inspector/network-status-non-http.html:24 > >>> + if (outputStatus.indexOf("(failed)") == 0) > >> > >> Please use .startsWith for prefix checks. > > > > Javascript string doesn't have .startsWith method, does it? > > We added it to the String's prototype in utilities.js (Sorry I am not familiar with this part of codebase.) Is it allowed to directly refer to utilities.js from the LayoutTests folder? Or we have other ways to access startsWith? 613348 17 kling 2012-05-01 05:28:11 -0700 Committed r115720: <http://trac.webkit.org/changeset/115720> 138444 2012-04-23 15:51:42 -0700 2012-04-25 18:21:52 -0700 Patch bug-84566-20120423155141.patch text/plain 4873 yzshen U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0ODYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCBiNjg4YTE0MTUwNzNl NTA2NGY1YzcxNmY3MGU4MTUwNDc2MDRlY2Y4Li5kMTM1OWZjY2E4YWI3MzRlYzNkYTdmYWRhOWVm MWNkNzJlMTVhYmE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMi0wNC0yMyAg WXV6aHUgU2hlbiAgPHl6c2hlbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBB ZGQgYSBkZXNjcmlwdGlvbiBmaWVsZCBpbiBXZWJVUkxFcnJvciBhbmQgc2hvdyBmYWlsdXJlIGRl c2NyaXB0aW9uIGluIHRoZSBpbnNwZWN0b3IgbmV0d29yayB0YWIuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NDU2NgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogY2hyb21pdW0vcHVibGljL1dlYlVSTEVy cm9yLmg6CisgICAgICAgIChXZWJVUkxFcnJvcik6CisKIDIwMTItMDQtMjAgIERhbmEgSmFuc2Vu cyAgPGRhbmFrakBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBXZWJGaWx0ZXJP cGVyYXRpb25zIEFQSSBkb2VzIG5vdCBjb21waWxlIG9yIGR5bmFtaWNhbGx5IGxpbmsKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv ZwppbmRleCAwYjVlZGY0ZTY4MDA3YThjNTU3MDBhNDE1NTNmOGIyZTA2YjA0ZjM4Li43NTJmNjE5 M2RkZGY2ZTA2Nzg3NTk4YWVlYzNlMTY0MmFlYzBkNDAwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTYgQEAKKzIwMTItMDQtMjMgIFl1emh1IFNoZW4gIDx5enNoZW5AY2hyb21pdW0ub3JnPgorCisg ICAgICAgIFtjaHJvbWl1bV0gQWRkIGEgZGVzY3JpcHRpb24gZmllbGQgaW4gV2ViVVJMRXJyb3Ig YW5kIHNob3cgZmFpbHVyZSBkZXNjcmlwdGlvbiBpbiB0aGUgaW5zcGVjdG9yIG5ldHdvcmsgdGFi LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODQ1NjYK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3Bl Y3Rvci9mcm9udC1lbmQvTmV0d29ya1BhbmVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLk5l dHdvcmtEYXRhR3JpZE5vZGUucHJvdG90eXBlLl9yZWZyZXNoU3RhdHVzQ2VsbCk6CisgICAgICAg ICogcGxhdGZvcm0vY2hyb21pdW0vc3VwcG9ydC9XZWJVUkxFcnJvci5jcHA6CisgICAgICAgIChX ZWJLaXQ6OldlYlVSTEVycm9yOjpvcGVyYXRvcj0pOgorICAgICAgICAoV2ViS2l0OjpXZWJVUkxF cnJvcjo6b3BlcmF0b3IgUmVzb3VyY2VFcnJvcik6CisKIDIwMTItMDQtMjIgIFNoYXduIFNpbmdo ICA8c2hhd25zaW5naEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBEYW1hZ2Ug VHJhY2tlciBuZWVkcyB0byB1c2UgQ0NNYXRoVXRpbCB0cmFuc2Zvcm1zCmRpZmYgLS1naXQgYS9T b3VyY2UvUGxhdGZvcm0vY2hyb21pdW0vcHVibGljL1dlYlVSTEVycm9yLmggYi9Tb3VyY2UvUGxh dGZvcm0vY2hyb21pdW0vcHVibGljL1dlYlVSTEVycm9yLmgKaW5kZXggODYyZGJlYWEzYjNjMGYy OGUyNjk0ZjhkOGI2ZmIxOGEyZDFlODUwZi4uYjZlYjg5MzU3NDRlMzIxYWRkM2UzNWZmZDYxODc4 NGU5YTBiZDhmOSAxMDA2NDQKLS0tIGEvU291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1YmxpYy9X ZWJVUkxFcnJvci5oCisrKyBiL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2ViVVJM RXJyb3IuaApAQCAtNTksNiArNTksOSBAQCBzdHJ1Y3QgV2ViVVJMRXJyb3IgewogICAgIC8vIFRo ZSB1cmwgdGhhdCBmYWlsZWQgdG8gbG9hZC4KICAgICBXZWJVUkwgdW5yZWFjaGFibGVVUkw7CiAK KyAgICAvLyBBIGRlc2NyaXB0aW9uIGZvciB0aGUgZXJyb3IuCisgICAgV2ViU3RyaW5nIGxvY2Fs aXplZERlc2NyaXB0aW9uOworCiAgICAgV2ViVVJMRXJyb3IoKSA6IHJlYXNvbigwKSwgaXNDYW5j ZWxsYXRpb24oZmFsc2UpIHsgfQogCiAjaWYgZGVmaW5lZChXRUJLSVRfSU1QTEVNRU5UQVRJT04p CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL05ldHdvcmtQ YW5lbC5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvTmV0d29ya1BhbmVs LmpzCmluZGV4IDNiZWI1N2Y5MjkyMGNiYmZiZDA2ZDljNGMxYzczYWM5M2Y3ZjZhZWUuLmY3ZDRj ZTBlY2I0ZjE5NGMwMDI1OTZiMzcxYmRiYTRhZTAzNmE1ZjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvTmV0d29ya1BhbmVsLmpzCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvTmV0d29ya1BhbmVsLmpzCkBAIC0xODU4LDEwICsx ODU4LDE0IEBAIFdlYkluc3BlY3Rvci5OZXR3b3JrRGF0YUdyaWROb2RlLnByb3RvdHlwZSA9IHsK ICAgICAgICAgdGhpcy5fc3RhdHVzQ2VsbC5yZW1vdmVDaGlsZHJlbigpOwogCiAgICAgICAgIGlm ICh0aGlzLl9yZXF1ZXN0LmZhaWxlZCkgewotICAgICAgICAgICAgaWYgKHRoaXMuX3JlcXVlc3Qu Y2FuY2VsZWQpCi0gICAgICAgICAgICAgICAgdGhpcy5fc3RhdHVzQ2VsbC5zZXRUZXh0QW5kVGl0 bGUoV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCIoY2FuY2VsZWQpIikpOwotICAgICAgICAgICAgZWxz ZQotICAgICAgICAgICAgICAgIHRoaXMuX3N0YXR1c0NlbGwuc2V0VGV4dEFuZFRpdGxlKFdlYklu c3BlY3Rvci5VSVN0cmluZygiKGZhaWxlZCkiKSk7CisgICAgICAgICAgICB2YXIgZmFpbFRleHQg PSB0aGlzLl9yZXF1ZXN0LmNhbmNlbGVkID8gV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCIoY2FuY2Vs ZWQpIikgOiBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIihmYWlsZWQpIik7CisgICAgICAgICAgICBp ZiAodGhpcy5fcmVxdWVzdC5sb2NhbGl6ZWRGYWlsRGVzY3JpcHRpb24pIHsKKyAgICAgICAgICAg ICAgICB0aGlzLl9zdGF0dXNDZWxsLmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZVRleHROb2Rl KGZhaWxUZXh0KSk7CisgICAgICAgICAgICAgICAgdGhpcy5fYXBwZW5kU3VidGl0bGUodGhpcy5f c3RhdHVzQ2VsbCwgdGhpcy5fcmVxdWVzdC5sb2NhbGl6ZWRGYWlsRGVzY3JpcHRpb24pOworICAg ICAgICAgICAgICAgIHRoaXMuX3N0YXR1c0NlbGwudGl0bGUgPSBmYWlsVGV4dCArICIgIiArIHRo aXMuX3JlcXVlc3QubG9jYWxpemVkRmFpbERlc2NyaXB0aW9uOworICAgICAgICAgICAgfSBlbHNl IHsKKyAgICAgICAgICAgICAgICB0aGlzLl9zdGF0dXNDZWxsLnNldFRleHRBbmRUaXRsZShmYWls VGV4dCk7CisgICAgICAgICAgICB9CiAgICAgICAgICAgICB0aGlzLl9zdGF0dXNDZWxsLmFkZFN0 eWxlQ2xhc3MoIm5ldHdvcmstZGltLWNlbGwiKTsKICAgICAgICAgICAgIHRoaXMuZWxlbWVudC5h ZGRTdHlsZUNsYXNzKCJuZXR3b3JrLWVycm9yLXJvdyIpOwogICAgICAgICAgICAgcmV0dXJuOwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vc3VwcG9ydC9XZWJV UkxFcnJvci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9zdXBwb3J0L1dl YlVSTEVycm9yLmNwcAppbmRleCBlYzMwYjlmMTI5NzJjOWQyMGEzMDlhODY5ZDhlNWVmOTgwZmZj OTU0Li4xMzQxZGVlZTY5YmUwMTlkZDc5ZTdjNzRlZjUxOTFmNTY3ODU0ZGI1IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9zdXBwb3J0L1dlYlVSTEVycm9yLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9zdXBwb3J0L1dlYlVSTEVy cm9yLmNwcApAQCAtNTMsNiArNTMsNyBAQCBXZWJVUkxFcnJvciYgV2ViVVJMRXJyb3I6Om9wZXJh dG9yPShjb25zdCBSZXNvdXJjZUVycm9yJiBlcnJvcikKICAgICAgICAgcmVhc29uID0gZXJyb3Iu ZXJyb3JDb2RlKCk7CiAgICAgICAgIHVucmVhY2hhYmxlVVJMID0gS1VSTChQYXJzZWRVUkxTdHJp bmcsIGVycm9yLmZhaWxpbmdVUkwoKSk7CiAgICAgICAgIGlzQ2FuY2VsbGF0aW9uID0gZXJyb3Iu aXNDYW5jZWxsYXRpb24oKTsKKyAgICAgICAgbG9jYWxpemVkRGVzY3JpcHRpb24gPSBlcnJvci5s b2NhbGl6ZWREZXNjcmlwdGlvbigpOwogICAgIH0KICAgICByZXR1cm4gKnRoaXM7CiB9CkBAIC02 NCw3ICs2NSw4IEBAIFdlYlVSTEVycm9yOjpvcGVyYXRvciBSZXNvdXJjZUVycm9yKCkgY29uc3QK ICAgICBDU3RyaW5nIHNwZWMgPSB1bnJlYWNoYWJsZVVSTC5zcGVjKCk7CiAgICAgUmVzb3VyY2VF cnJvciByZXNvdXJjZUVycm9yID0gUmVzb3VyY2VFcnJvcihkb21haW4sIHJlYXNvbiwKICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFN0cmluZzo6ZnJvbVVU Rjgoc3BlYy5kYXRhKCksCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBzcGVjLmxlbmd0aCgpKSwgU3RyaW5nKCkpOworICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgc3BlYy5sZW5ndGgoKSksCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBsb2NhbGl6ZWREZXNjcmlwdGlvbik7 CiAgICAgcmVzb3VyY2VFcnJvci5zZXRJc0NhbmNlbGxhdGlvbihpc0NhbmNlbGxhdGlvbik7CiAg ICAgcmV0dXJuIHJlc291cmNlRXJyb3I7CiB9Cg== 138916 2012-04-25 18:21:57 -0700 2012-04-30 07:44:59 -0700 Patch bug-84566-20120425182156.patch text/plain 2487 yzshen U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1MjMyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMjdkMzZhMzU2MjQ1MWRhMzRlOTZl M2RlYzJjODAxNjcxODU5NWE1Ni4uMTU2MTlhYTM3MWZkNDEzN2YwZGFlZDZkZjdjZGYwMmNiZTNi NzNjMyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTA0LTI1ICBZdXpodSBTaGVuICA8eXpz aGVuQGNocm9taXVtLm9yZz4KKworICAgICAgICBGaXggdGVzdCByZWdyZXNzaW9uIGludHJvZHVj ZWQgYnkgcjExNTA4Ni4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTg0NTY2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBpbnNwZWN0b3IvbmV0d29yay1zdGF0dXMtbm9uLWh0dHAuaHRtbDoKKyAgICAgICAg KiBwbGF0Zm9ybS9xdC9Ta2lwcGVkOgorCiAyMDEyLTA0LTI1ICBBbHBoYSBMYW0gIDxoY2xhbUBj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCB0ZXN0IGV4cGVjdGF0aW9ucyB1cGRh dGUuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvbmV0d29yay1zdGF0dXMtbm9u LWh0dHAuaHRtbCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9uZXR3b3JrLXN0YXR1cy1ub24taHR0 cC5odG1sCm9sZCBtb2RlIDEwMDY0NApuZXcgbW9kZSAxMDA3NTUKaW5kZXggZDVlNmRiOWZiNDFm ZjhmY2M2Y2JjN2VlYWJhOTZmNmY2OTE4MDIxMi4uMTEyY2FiMWM1YzllOTFhNGQzMTYxMDkxMjc3 NmRjYjE5MTVhMDBjZQotLS0gYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvbmV0d29yay1zdGF0dXMt bm9uLWh0dHAuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvbmV0d29yay1zdGF0dXMt bm9uLWh0dHAuaHRtbApAQCAtMTksNyArMTksMTEgQEAgZnVuY3Rpb24gdGVzdCgpIHsKICAgICAg ICAgICAgIGlmIChyZXF1ZXN0c1RvV2F0Y2gudGVzdCh1cmwpKSB7CiAgICAgICAgICAgICAgICAg dmFyIHVybEZyYWdtZW50ID0gL15kYXRhOi8udGVzdCh1cmwpID8gdXJsLnJlcGxhY2UoLywuKiQv LCAiIikgOiB1cmwucmVwbGFjZSgvLipcLy8sICIiKTsKICAgICAgICAgICAgICAgICB2YXIgc3Rh dHVzID0gZG9jdW1lbnQuZXZhbHVhdGUoImFuY2VzdG9yOjp0ci90ZFtwb3NpdGlvbigpPTNdIiwg dXJscy5zbmFwc2hvdEl0ZW0oaSksIG51bGwsIFhQYXRoUmVzdWx0LlNUUklOR19UWVBFLCBudWxs KTsKLSAgICAgICAgICAgICAgICBvdXRwdXRTdHJpbmdzLnB1c2godXJsRnJhZ21lbnQgKyAiOiAi ICsgc3RhdHVzLnN0cmluZ1ZhbHVlKTsKKyAgICAgICAgICAgICAgICB2YXIgb3V0cHV0U3RhdHVz ID0gc3RhdHVzLnN0cmluZ1ZhbHVlOworICAgICAgICAgICAgICAgIC8vIFRydW5jYXRlIHRoZSBz dGF0dXMgc3RyaW5nIG9uIGZhaWx1cmUsIHNpbmNlIHRoZSBkZXNjcmlwdGlvbiBmb2xsb3dpbmcg IihmYWlsZWQpIiBpcyBwbGF0Zm9ybS1kZXBlbmRlbnQuCisgICAgICAgICAgICAgICAgaWYgKG91 dHB1dFN0YXR1cy5pbmRleE9mKCIoZmFpbGVkKSIpID09IDApCisgICAgICAgICAgICAgICAgICAg IG91dHB1dFN0YXR1cyA9ICIoZmFpbGVkKSI7CisgICAgICAgICAgICAgICAgb3V0cHV0U3RyaW5n cy5wdXNoKHVybEZyYWdtZW50ICsgIjogIiArIG91dHB1dFN0YXR1cyk7CiAgICAgICAgICAgICB9 CiAgICAgICAgIH0KICAgICAgICAgb3V0cHV0U3RyaW5ncy5zb3J0KCk7CmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQv U2tpcHBlZAppbmRleCBlN2RkYWNhODFmMzBlYjI1YTI1MzljYjU4ODY1NjhlM2Y4NzQzNGViLi4y ZjNjOWRiMTBhMjE1ZTU3MTNmYmVkMzc3MDgxNjY0ZWFjYzY2ZTg0IDEwMDY0NAotLS0gYS9MYXlv dXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0 L1NraXBwZWQKQEAgLTI2MTYsNyArMjYxNiwzIEBAIHBsdWdpbnMvbnBydW50aW1lL29iamVjdC1m cm9tLWRlc3Ryb3llZC1wbHVnaW4taW4tc3ViZnJhbWUuaHRtbAogIyBbUXRdIE5ldyBpbnNwZWN0 b3IvZGVidWdnZXIvbGlua2lmaWVyLmh0bWwgaXMgZmxha2V5IGZyb20gdGhlIGJlZ2lubmluZyAo cjExNTA2NCkuCiAjIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NDg2 NgogaW5zcGVjdG9yL2RlYnVnZ2VyL2xpbmtpZmllci5odG1sCi0KLSMgW1F0XSBSRUdSRVNTSU9O KHIxMTUwODYpOiBpbnNwZWN0b3IvbmV0d29yay1zdGF0dXMtbm9uLWh0dHAuaHRtbCBpcyBmYWls aW5nCi0jIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NDU2NgotaW5z cGVjdG9yL25ldHdvcmstc3RhdHVzLW5vbi1odHRwLmh0bWwK