84563 2012-04-22 23:10:54 -0700 [BlackBerry] Build failure when DEBUG_FAT_FINGER is enabled 2012-04-23 19:01:37 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 charles.wei charles.wei tonikitoo webkit.review.bot oldest_to_newest 607487 0 charles.wei 2012-04-22 23:10:54 -0700 When DEBUG_FAT_FINGER enabled, it tries to log the screenFingerRect through the IntRect::toString(), but IntRect::toString is not upstreamed and will not. So we need to just use IntRect::x(), y(), width(), height() for logging. 607493 1 138296 charles.wei 2012-04-22 23:27:34 -0700 Created attachment 138296 Patch 608292 2 138296 webkit.review.bot 2012-04-23 19:01:28 -0700 Comment on attachment 138296 Patch Clearing flags on attachment: 138296 Committed r114984: <http://trac.webkit.org/changeset/114984> 608293 3 webkit.review.bot 2012-04-23 19:01:37 -0700 All reviewed patches have been landed. Closing bug. 138296 2012-04-22 23:27:34 -0700 2012-04-23 19:01:28 -0700 Patch bug-84563-20120423143414.patch text/plain 1835 charles.wei U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0ODcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCBjNzJlZGEyNTE5ZWEwYmNjMzllNDIwNWE4MGFlODUyZGFiZWFmNGYyLi40MTNmN2Q5YmM2 OTEyNzY1NWEyZWYzOWU4ZWE4ZDNlMzdjMjgzMjhlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMi0wNC0yMiAgQ2hhcmxlcyBXZWkgIDxjaGFybGVz LndlaUB0b3JjaG1vYmlsZS5jb20uY24+CisKKyAgICAgICAgW0JsYWNrQmVycnldIEJ1aWxkIGZh aWx1cmUgd2hlbiBERUJVR19GQVRfRklOR0VSIGlzIGVuYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg0NTYzCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRmF0IEZpbmdlciBsb2cgY29kZSB1c2VzIG9i c29sZXRlIEludFJlY3Q6OnRvU3RyaW5nKCkgZm9yIGxvZ2dpbmcsCisgICAgICAgIHdoaWNoIHdh cyBmaXJzdCBpbXBsZW1lbnRlZCBpbnRlcmFsbHkgYW5kIHJlbW92ZWQgbGF0ZXIuCisKKyAgICAg ICAgKiBXZWJLaXRTdXBwb3J0L0ZhdEZpbmdlcnMuY3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6 V2ViS2l0OjpGYXRGaW5nZXJzOjpmaW5kSW50ZXJzZWN0aW5nUmVnaW9ucyk6CisKIDIwMTItMDQt MjEgIEJlbmphbWluIEMgTWV5ZXIgIDxibWV5ZXJAcmltLmNvbT4KIAogICAgICAgICBEb24ndCBo YXJkIGNvZGUgdGhlIHBsdWdpbnMgdGhhdCBibGFja2JlcnJ5IHN1cHBvcnRzLgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvRmF0RmluZ2Vycy5jcHAg Yi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9GYXRGaW5nZXJzLmNwcApp bmRleCBiNDllMjQ4NWNkNzMxOTRjYzBkNWY1Y2Q4OWRmMzgwMzA4N2RlNDc2Li5mZTdmODQ4ZDc1 YzExNmM2Y2E5ZGZjNDJmNDZkZDJkY2NkOTgyN2E5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9GYXRGaW5nZXJzLmNwcAorKysgYi9Tb3VyY2UvV2Vi S2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9GYXRGaW5nZXJzLmNwcApAQCAtMzA2LDcgKzMw Niw3IEBAIGJvb2wgRmF0RmluZ2Vyczo6ZmluZEludGVyc2VjdGluZ1JlZ2lvbnMoRG9jdW1lbnQq IGRvY3VtZW50LAogI2lmIERFQlVHX0ZBVF9GSU5HRVJTCiAgICAgSW50UmVjdCBmaW5nZXJSZWN0 KGZpbmdlclJlY3RGb3JQb2ludChmcmFtZUNvbnRlbnRQb3MpKTsKICAgICBJbnRSZWN0IHNjcmVl bkZpbmdlclJlY3QgPSBtX3dlYlBhZ2UtPm1hcFRvVHJhbnNmb3JtZWQoZmluZ2VyUmVjdCk7Ci0g ICAgbG9nKExvZ0xldmVsSW5mbywgImZhdCBmaW5nZXIgcmVjdCBub3cgJXMiLCBzY3JlZW5GaW5n ZXJSZWN0LnRvU3RyaW5nKCkubGF0aW4xKCkuZGF0YSgpKTsKKyAgICBsb2coTG9nTGV2ZWxJbmZv LCAiZmF0IGZpbmdlciByZWN0IG5vdyAlZCwgJWQsICVkLCAlZCIsIHNjcmVlbkZpbmdlclJlY3Qu eCgpLCBzY3JlZW5GaW5nZXJSZWN0LnkoKSwgc2NyZWVuRmluZ2VyUmVjdC53aWR0aCgpLCBzY3Jl ZW5GaW5nZXJSZWN0LmhlaWdodCgpKTsKIAogICAgIC8vIG9ubHkgcmVjb3JkIHRoZSBmaXJzdCBm aW5nZXIgcmVjdAogICAgIGlmIChkb2N1bWVudCA9PSBtX3dlYlBhZ2UtPm1fbWFpbkZyYW1lLT5k b2N1bWVudCgpKQo=