84552 2012-04-22 14:57:24 -0700 [Chromium] Remove Webkit/chromium/public/WebReferrerPolicy.h thunk. 2012-04-30 15:41:10 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 85079 1 gavinp gavinp abarth dglazkov fishd jamesr tkent+wkapi tonyg webkit.review.bot oldest_to_newest 607386 0 gavinp 2012-04-22 14:57:24 -0700 [Chromium] Remove Webkit/chromium/public/WebReferrerPolicy.h thunk. 607387 1 138276 gavinp 2012-04-22 14:59:27 -0700 Created attachment 138276 Patch 607390 2 gavinp 2012-04-22 15:05:09 -0700 See https://bugs.webkit.org/show_bug.cgi?id=82478 and https://github.com/gavinp/git.webkit.org/commit/497ceedf75c56614eb610bcbd5559e682e7c7382 for Adam Barth's review. This can't land until after http://codereview.chromium.org/10139023/ , or else it will break the build... 611367 3 138276 gavinp 2012-04-27 04:12:15 -0700 Comment on attachment 138276 Patch This is now reviewable, as its dependant change has landed in chromium. jamesr, wdyt? 611368 4 gavinp 2012-04-27 04:12:42 -0700 oops: forgot to add you earlier. jamesr, wdyt? 611369 5 webkit.review.bot 2012-04-27 04:14:44 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 611370 6 138276 gavinp 2012-04-27 04:15:13 -0700 Comment on attachment 138276 Patch n/m James, this was already reviewed by abarth! 611484 7 138276 gavinp 2012-04-27 07:32:24 -0700 Comment on attachment 138276 Patch I wish I could wait on chromium EWS, but instead I'll trust the CQ as the potential error is caught early. Ugh, though. 611547 8 138276 webkit.review.bot 2012-04-27 08:56:21 -0700 Comment on attachment 138276 Patch Clearing flags on attachment: 138276 Committed r115436: <http://trac.webkit.org/changeset/115436> 611548 9 webkit.review.bot 2012-04-27 08:56:26 -0700 All reviewed patches have been landed. Closing bug. 611649 10 tonyg 2012-04-27 10:36:58 -0700 Rolled out in http://trac.webkit.org/changeset/115448 612027 11 138276 gavinp 2012-04-27 16:58:26 -0700 Comment on attachment 138276 Patch Attachment 138276 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12551380 612934 12 138276 gavinp 2012-04-30 14:07:11 -0700 Comment on attachment 138276 Patch I'm feeling much luckier today. 613019 13 138276 webkit.review.bot 2012-04-30 15:41:02 -0700 Comment on attachment 138276 Patch Clearing flags on attachment: 138276 Committed r115680: <http://trac.webkit.org/changeset/115680> 613020 14 webkit.review.bot 2012-04-30 15:41:10 -0700 All reviewed patches have been landed. Closing bug. 138276 2012-04-22 14:59:27 -0700 2012-04-30 15:41:02 -0700 Patch bug-84552-20120422175926.patch text/plain 3557 gavinp U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0NjIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDY3ZTA1OTk3MDQyN2I2ZTEwODM0NmFiYjVhNzk4MTcxNzc2MTMxNTIuLmEyNzUyMzVjNmJkNGJl OGJkYzkzNGQ0Y2NmYzJiMDU0MTAzZTFjNjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTItMDQtMjIgIEdhdmluIFBldGVycyAgPGdhdmlucEBjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgW0Nocm9taXVtXSBSZW1vdmUgV2Via2l0L2Nocm9taXVtL3B1Ymxp Yy9XZWJSZWZlcnJlclBvbGljeS5oIHRodW5rLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODQ1NTIKKworICAgICAgICBBZnRlciBodHRwOi8vY29kZXJl dmlldy5jaHJvbWl1bS5vcmcvMTAxMzkwMjMvIGxhbmRzLCB0aGlzIHRodW5rIGlzIG5vCisgICAg ICAgIGxvbmdlciBuZWVkZWQuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KKwor ICAgICAgICAqIFdlYktpdC5neXA6CisgICAgICAgICogcHVibGljL1dlYlJlZmVycmVyUG9saWN5 Lmg6IFJlbW92ZWQuCisKIDIwMTItMDQtMjEgIEdhdmluIFBldGVycyAgPGdhdmlucEBjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgTW92ZSBXZWJSZWZlcnJlclBvbGljeS5oIGZyb20gV2ViS2l0IHRv IFBsYXRmb3JtCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL1dlYktpdC5neXAg Yi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL1dlYktpdC5neXAKaW5kZXggZjE4MGNmODgyY2RlMWJl YzBjMmRjNGEzMjM5YmI1N2YyNGQxN2MzNy4uYzM4MTJiODI4NmRkODE2NzQ5ZjNmZDBmYWJkNGE3 NjU1MjRmNmEwYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9XZWJLaXQuZ3lw CisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vV2ViS2l0Lmd5cApAQCAtMjI4LDcgKzIyOCw2 IEBACiAgICAgICAgICAgICAgICAgJ3B1YmxpYy9XZWJQb3B1cE1lbnVJbmZvLmgnLAogICAgICAg ICAgICAgICAgICdwdWJsaWMvV2ViUG9wdXBUeXBlLmgnLAogICAgICAgICAgICAgICAgICdwdWJs aWMvV2ViUmFuZ2UuaCcsCi0gICAgICAgICAgICAgICAgJ3B1YmxpYy9XZWJSZWZlcnJlclBvbGlj eS5oJywKICAgICAgICAgICAgICAgICAncHVibGljL1dlYlJlZ3VsYXJFeHByZXNzaW9uLmgnLAog ICAgICAgICAgICAgICAgICdwdWJsaWMvV2ViUnVudGltZUZlYXR1cmVzLmgnLAogICAgICAgICAg ICAgICAgICdwdWJsaWMvV2ViU2NvcGVkTWljcm90YXNrU3VwcHJlc3Npb24uaCcsCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJSZWZlcnJlclBvbGljeS5oIGIv U291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViUmVmZXJyZXJQb2xpY3kuaApkZWxldGVk IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggZGI1NzMwNGNiYzkxNDM4MWVlNTM4NjhkNjc3NjY5NzZm YmM2NzUxMS4uMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMAotLS0gYS9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJSZWZlcnJlclBvbGljeS5oCisrKyAvZGV2 L251bGwKQEAgLTEsMzMgKzAsMCBAQAotLyoKLSAqIENvcHlyaWdodCAoQykgMjAxMiBHb29nbGUg SW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgotICoKLSAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2Ug aW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAotICogbW9kaWZpY2F0 aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25z IGFyZQotICogbWV0OgotICoKLSAqICAgICAqIFJlZGlzdHJpYnV0aW9ucyBvZiBzb3VyY2UgY29k ZSBtdXN0IHJldGFpbiB0aGUgYWJvdmUgY29weXJpZ2h0Ci0gKiBub3RpY2UsIHRoaXMgbGlzdCBv ZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIuCi0gKiAgICAgKiBSZWRp c3RyaWJ1dGlvbnMgaW4gYmluYXJ5IGZvcm0gbXVzdCByZXByb2R1Y2UgdGhlIGFib3ZlCi0gKiBj b3B5cmlnaHQgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2lu ZyBkaXNjbGFpbWVyCi0gKiBpbiB0aGUgZG9jdW1lbnRhdGlvbiBhbmQvb3Igb3RoZXIgbWF0ZXJp YWxzIHByb3ZpZGVkIHdpdGggdGhlCi0gKiBkaXN0cmlidXRpb24uCi0gKiAgICAgKiBOZWl0aGVy IHRoZSBuYW1lIG9mIEdvb2dsZSBJbmMuIG5vciB0aGUgbmFtZXMgb2YgaXRzCi0gKiBjb250cmli dXRvcnMgbWF5IGJlIHVzZWQgdG8gZW5kb3JzZSBvciBwcm9tb3RlIHByb2R1Y3RzIGRlcml2ZWQg ZnJvbQotICogdGhpcyBzb2Z0d2FyZSB3aXRob3V0IHNwZWNpZmljIHByaW9yIHdyaXR0ZW4gcGVy bWlzc2lvbi4KLSAqCi0gKiBUSElTIFNPRlRXQVJFIElTIFBST1ZJREVEIEJZIFRIRSBDT1BZUklH SFQgSE9MREVSUyBBTkQgQ09OVFJJQlVUT1JTCi0gKiAiQVMgSVMiIEFORCBBTlkgRVhQUkVTUyBP UiBJTVBMSUVEIFdBUlJBTlRJRVMsIElOQ0xVRElORywgQlVUIE5PVAotICogTElNSVRFRCBUTywg VEhFIElNUExJRUQgV0FSUkFOVElFUyBPRiBNRVJDSEFOVEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9S Ci0gKiBBIFBBUlRJQ1VMQVIgUFVSUE9TRSBBUkUgRElTQ0xBSU1FRC4gSU4gTk8gRVZFTlQgU0hB TEwgVEhFIENPUFlSSUdIVAotICogT1dORVIgT1IgQ09OVFJJQlVUT1JTIEJFIExJQUJMRSBGT1Ig QU5ZIERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUwsCi0gKiBTUEVDSUFMLCBFWEVNUExBUlks IE9SIENPTlNFUVVFTlRJQUwgREFNQUdFUyAoSU5DTFVESU5HLCBCVVQgTk9UCi0gKiBMSU1JVEVE IFRPLCBQUk9DVVJFTUVOVCBPRiBTVUJTVElUVVRFIEdPT0RTIE9SIFNFUlZJQ0VTOyBMT1NTIE9G IFVTRSwKLSAqIERBVEEsIE9SIFBST0ZJVFM7IE9SIEJVU0lORVNTIElOVEVSUlVQVElPTikgSE9X RVZFUiBDQVVTRUQgQU5EIE9OIEFOWQotICogVEhFT1JZIE9GIExJQUJJTElUWSwgV0hFVEhFUiBJ TiBDT05UUkFDVCwgU1RSSUNUIExJQUJJTElUWSwgT1IgVE9SVAotICogKElOQ0xVRElORyBORUdM SUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFCi0g KiBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9G IFNVQ0ggREFNQUdFLgotICovCi0KLS8vIFRoaXMgZm9yd2FyZGluZyBoZWFkZXIgZXhpc3RzIG9u bHkgZm9yIHN0YWdpbmcgb3VyIGZpbGUgbW92ZSBpbnRvIHRoZSBjaHJvbWl1bSBwb3J0LgotLy8g RklYTUU6IFJlbW92ZSB0aGlzIGZvcndhcmRlciBhZnRlciBjaHJvbWUgaXNzdWUgaHR0cDovL2Nv ZGVyZXZpZXcuY2hyb21pdW0ub3JnLzEwMTM5MDIzLyBsYW5kcy4KLSNpbmNsdWRlICJwbGF0Zm9y bS9XZWJSZWZlcnJlclBvbGljeS5oIgo=