84544 2012-04-22 06:06:26 -0700 [TestResultsServer] Impossible to inspect builds on non-Chromium builders 2012-04-24 05:41:41 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan mihaip ojan webkit.review.bot oldest_to_newest 607342 0 zan 2012-04-22 06:06:26 -0700 In the timeline view on the http://test-results.appspot.com/ it is impossible to see details for any build when inspecting the layout tests results for non-Chromium builders. TypeError occurs in dashboard_base.js when clicking on the dashboard with intent to inspect any build. Stack trace obtained from the Web Inspector: revisionLink (dashboard_base.js:954) chromiumRevisionLink (dashboard_base.js:977) updateBuildInspector (/dashboards/timeline_explorer.html#group=%40ToT%20-%20webkit.org&builder=Chromium%20Linux%20Release%20(Tests):300) selectBuild (/dashboards/timeline_explorer.html#group=%40ToT%20-%20webkit.org&builder=Chromium%20Linux%20Release%20(Tests):248) Dygraph.clickCallback (/dashboards/timeline_explorer.html#group=%40ToT%20-%20webkit.org&builder=Chromium%20Linux%20Release%20(Tests):224) Dygraph.addEvent.o.dateWindow_ (dygraph-combined.js:1) d (dygraph-combined.js:1) It seems that in updateBuildInspector, Chromium revision link is being added despite not inspecting builds on a Chromium builder. shouldShowWebKitRevisionsOnly() returns false, and on further inspection it shows that isTipOfTreeWebKitBuilder() returns and undefined value which then gets converted to boolean value. Seems that isToTWebKit parameter of the BuilderGroup object is not properly assigned. 607344 1 138270 zan 2012-04-22 06:52:42 -0700 Created attachment 138270 Patch 607345 2 zan 2012-04-22 06:58:43 -0700 CC-ing both author and reviewer from bug #82924 from which r112971 originates, introducing the problem. 607445 3 138270 rniwa 2012-04-22 21:48:33 -0700 Comment on attachment 138270 Patch Looks sane to me. 607459 4 138270 webkit.review.bot 2012-04-22 22:23:15 -0700 Comment on attachment 138270 Patch Clearing flags on attachment: 138270 Committed r114868: <http://trac.webkit.org/changeset/114868> 607460 5 webkit.review.bot 2012-04-22 22:23:20 -0700 All reviewed patches have been landed. Closing bug. 607790 6 138270 ojan 2012-04-23 10:20:09 -0700 Comment on attachment 138270 Patch Could you also add a test for this? The tests are in the poorly named flakiness_dashboard_tests.js. You run them by loading flakiness_dashboard.html#useTestData=true off your local filesystem. 607895 7 zan 2012-04-23 11:49:06 -0700 (In reply to comment #6) > (From update of attachment 138270 [details]) > Could you also add a test for this? The tests are in the poorly named flakiness_dashboard_tests.js. You run them by loading flakiness_dashboard.html#useTestData=true off your local filesystem. Could you please give some pointers on what exactly to test here? Simply the isToTWebKit attribute value that depends on whether BuilderGroup.TOT_WEBKIT or BuilderGroup.DEPS_WEBKIT is given as the first parameter to the BuilderGroup constructor or the complete builder lists loading, from loadBuildersList function in builders.js onwards, with the final isToTWebKit attribute value check? 607925 8 ojan 2012-04-23 12:35:41 -0700 (In reply to comment #7) > (In reply to comment #6) > > (From update of attachment 138270 [details] [details]) > > Could you also add a test for this? The tests are in the poorly named flakiness_dashboard_tests.js. You run them by loading flakiness_dashboard.html#useTestData=true off your local filesystem. > > Could you please give some pointers on what exactly to test here? Simply the isToTWebKit attribute value that depends on whether BuilderGroup.TOT_WEBKIT or BuilderGroup.DEPS_WEBKIT is given as the first parameter to the BuilderGroup constructor or the complete builder lists loading, from loadBuildersList function in builders.js onwards, with the final isToTWebKit attribute value check? Yeah. The simple test was all I had in mind. Just call onBuilderListLoad with the right dummy arguments and check that builderGroups[groupName] has a BuilderGroup with the right isToTWebKit value. 608579 9 zan 2012-04-24 05:41:41 -0700 (In reply to comment #8) > (In reply to comment #7) > > (In reply to comment #6) > > > (From update of attachment 138270 [details] [details] [details]) > > > Could you also add a test for this? The tests are in the poorly named flakiness_dashboard_tests.js. You run them by loading flakiness_dashboard.html#useTestData=true off your local filesystem. > > > > Could you please give some pointers on what exactly to test here? Simply the isToTWebKit attribute value that depends on whether BuilderGroup.TOT_WEBKIT or BuilderGroup.DEPS_WEBKIT is given as the first parameter to the BuilderGroup constructor or the complete builder lists loading, from loadBuildersList function in builders.js onwards, with the final isToTWebKit attribute value check? > > Yeah. The simple test was all I had in mind. Just call onBuilderListLoad with the right dummy arguments and check that builderGroups[groupName] has a BuilderGroup with the right isToTWebKit value. Patch coming up in #84713. 138270 2012-04-22 06:52:42 -0700 2012-04-23 10:20:09 -0700 Patch bug-84544-20120422155238.patch text/plain 1763 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0ODU1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTlkZjVkNmNjYTg5N2IyYzUzOGYyYmY4OGZkYzZlOWFj ZmYxMTE5MS4uN2ZhM2FlNDg0OWFkODc5N2Y2ODA0N2QxOTRjZmQyOTA0ZWVhZTRjZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEyLTA0LTIyICBaYW4gRG9iZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CisK KyAgICAgICAgW1Rlc3RSZXN1bHRzU2VydmVyXSBJbXBvc3NpYmxlIHRvIGluc3BlY3QgYnVpbGRz IG9uIG5vbi1DaHJvbWl1bSBidWlsZGVycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9ODQ1NDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBVc2UgdGhlIGdyb3VwRW51bSBwYXJhbWV0ZXIgdGhhdCBpcyBwYXNz ZWQgdGhyb3VnaCB0byB0aGUgb25CdWlsZGVyTGlzdExvYWQKKyAgICAgICAgZnVuY3Rpb24gcmF0 aGVyIHRoYW4gYW4gdW5kZWZpbmVkIGF0dHJpYnV0ZSBvZiB0aGUgQnVpbGRlckdyb3VwIG9iamVj dC4gVGhpcworICAgICAgICBtYWtlcyBpdCBhZ2FpbiBwb3NzaWJsZSB0byBpbnNwZWN0IGJ1aWxk cyBvbiBub24tQ2hyb21pdW0gYnVpbGRlcnMgaW4gdGhlCisgICAgICAgIHRlc3QgcmVzdWx0cyBz ZXJ2ZXIgYnkgbm90IHRyeWluZyB0byBhbHdheXMgYWRkIENocm9taXVtIHJldmlzaW9uIGxpbmtz LgorCisgICAgICAgICogVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9idWlsZGVy cy5qczoKKwogMjAxMi0wNC0yMCAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5j b20+CiAKICAgICAgICAgW0dUS10gUmV2ZXJ0IGNoYW5nZXMgdGhhdCBkaXNhYmxlZCBDYWlybyBm b250cyBtZXRyaWNzIGhpbnRpbmcKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RSZXN1bHRTZXJ2ZXIv c3RhdGljLWRhc2hib2FyZHMvYnVpbGRlcnMuanMgYi9Ub29scy9UZXN0UmVzdWx0U2VydmVyL3N0 YXRpYy1kYXNoYm9hcmRzL2J1aWxkZXJzLmpzCmluZGV4IDBlODA0N2YxZWM2NzRlYjliMDc3ZTky OTJiNGY0OWRmY2FmMTBiNzEuLjgzYjkyNDVjMzQyOWRmNTIyOGZjZTY2OGJhYWI1NGMzNGI1OTQw NDQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RSZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMv YnVpbGRlcnMuanMKKysrIGIvVG9vbHMvVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJk cy9idWlsZGVycy5qcwpAQCAtMTc5LDcgKzE3OSw3IEBAIGZ1bmN0aW9uIG9uQnVpbGRlckxpc3RM b2FkKGJ1aWxkZXJHcm91cHMsIGJ1aWxkZXJGaWx0ZXIsIG1hc3RlciwgZ3JvdXBOYW1lLCBncm91 CiB7CiAgICAgdmFyIGJ1aWxkZXJzID0gZ2VuZXJhdGVCdWlsZGVyc0Zyb21CdWlsZGVyTGlzdChP YmplY3Qua2V5cyhqc29uKSwgYnVpbGRlckZpbHRlcik7CiAgICAgYXNzb2NpYXRlQnVpbGRlcnNX aXRoTWFzdGVyKGJ1aWxkZXJzLCBtYXN0ZXIpOwotICAgIGJ1aWxkZXJHcm91cHNbZ3JvdXBOYW1l XSA9IG5ldyBCdWlsZGVyR3JvdXAoQnVpbGRlckdyb3VwLmdyb3VwRW51bSwgYnVpbGRlcnMpOwor ICAgIGJ1aWxkZXJHcm91cHNbZ3JvdXBOYW1lXSA9IG5ldyBCdWlsZGVyR3JvdXAoZ3JvdXBFbnVt LCBidWlsZGVycyk7CiAgICAgZ19oYW5kbGVCdWlsZGVyc0xpc3RMb2FkZWQoKTsKIH0KIAo=