84542 2012-04-21 23:47:27 -0700 [chromium][workers] setTargetType(ResourceRequest::TargetIsWorker) is repeatedly called in chromium 2012-04-25 07:51:27 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 li.yin webkit-unassigned abarth ap jianli levin webkit.review.bot oldest_to_newest 607331 0 li.yin 2012-04-21 23:47:27 -0700 In chromium platform, the default value of m_targetType is ResourceRequest::TargetIsWorker, it isn't necessary to call worker->m_scriptLoader->setTargetType(ResourceRequest::TargetIsWorker) again in Worker.cpp. 607332 1 138265 li.yin 2012-04-22 00:09:18 -0700 Created attachment 138265 Patch 608372 2 li.yin 2012-04-23 23:00:45 -0700 Would you please have a look? 608381 3 138265 levin 2012-04-23 23:29:45 -0700 Comment on attachment 138265 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138265&action=review > Source/WebCore/ChangeLog:12 > + No new tests. The current test has covered it already. Which test? > Source/WebCore/workers/Worker.cpp:75 > #endif Should we add an assert here to verify the target type? 608393 4 li.yin 2012-04-23 23:51:05 -0700 (In reply to comment #3) > (From update of attachment 138265 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=138265&action=review > > > Source/WebCore/ChangeLog:12 > > + No new tests. The current test has covered it already. > > Which test? This patch just deleted a duplicated statement. It can't impact any features. So no test case is required. > > > Source/WebCore/workers/Worker.cpp:75 > > #endif > > Should we add an assert here to verify the target type? There isn't public function to get the target type in current code, if we need to assert the target type, I must add the new function for chromium platform, it indeed adds the difficulty of code. And in WorkerScriptLoader Constructor, there is a obvious statement about the target type, and no change about the value. Maybe it isn't necessary to add the assert statement. do you think so? Thanks for your review. 608401 5 levin 2012-04-24 00:00:33 -0700 (In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 138265 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=138265&action=review > > > > > Source/WebCore/ChangeLog:12 > > > + No new tests. The current test has covered it already. > > > > Which test? > This patch just deleted a duplicated statement. It can't impact any features. So no test case is required. You said in the change log that "The current test has covered it already." Which test covers this? Which test will fail if this value is incorrect? (It would be nice to make sure something is going to fail if someone changes the default value in chromium.) Why is this change being done? :) > > > > > Source/WebCore/workers/Worker.cpp:75 > > > #endif > > > > Should we add an assert here to verify the target type? > There isn't public function to get the target type in current code, if we need to assert the target type, I must add the new function for chromium platform, it indeed adds the difficulty of code. > And in WorkerScriptLoader Constructor, there is a obvious statement about the target type, and no change about the value. Maybe it isn't necessary to add the assert statement. do you think so? > > Thanks for your review. 608407 6 li.yin 2012-04-24 00:10:59 -0700 (In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #3) > > > (From update of attachment 138265 [details] [details] [details]) > > > View in context: https://bugs.webkit.org/attachment.cgi?id=138265&action=review > > > > > > > Source/WebCore/ChangeLog:12 > > > > + No new tests. The current test has covered it already. > > > > > > Which test? > > This patch just deleted a duplicated statement. It can't impact any features. So no test case is required. > > You said in the change log that "The current test has covered it already." > > Which test covers this? Which test will fail if this value is incorrect? (It would be nice to make sure something is going to fail if someone changes the default value in chromium.) > > Why is this change being done? :) > Okay, I will change the log, thanks for your detailed review. 608415 7 138509 li.yin 2012-04-24 00:28:48 -0700 Created attachment 138509 Patch 608435 8 li.yin 2012-04-24 01:12:27 -0700 Add the detailed description in ChangLog, please have a look, thanks. 608437 9 138513 li.yin 2012-04-24 01:13:51 -0700 Created attachment 138513 Patch 608712 10 levin 2012-04-24 08:42:25 -0700 The ChangeLog doesn't answer the question: What test would fail if this value is incorrect? (It would be nice to know that there is one.) 608714 11 138513 levin 2012-04-24 08:43:36 -0700 Comment on attachment 138513 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138513&action=review > Source/WebCore/ChangeLog:13 > + No new tests because this patch just deletes a repeated code, it can reduce code workload and can't impact any feature. This may impact features if the target type is set incorrectly and may result in a change in behavior so it would be good to know the test that would expose if there were this problem. 609474 12 138740 li.yin 2012-04-24 22:59:11 -0700 Created attachment 138740 Patch 609476 13 138740 levin 2012-04-24 23:03:41 -0700 Comment on attachment 138740 Patch I wonder why http://code.google.com/searchframe#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/workers/WorkerScriptLoader.cpp&type=cs&l=55 isn't changed to be "|| PLATFORM(BLACKBERRY)" and then just get rid of this. But this is fine as is. Thanks! 609489 14 li.yin 2012-04-24 23:31:28 -0700 (In reply to comment #13) > (From update of attachment 138740 [details]) > I wonder why http://code.google.com/searchframe#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/workers/WorkerScriptLoader.cpp&type=cs&l=55 isn't changed to be "|| PLATFORM(BLACKBERRY)" and then just get rid of this. > > But this is fine as is. Thanks! You should look this linked address. http://code.google.com/searchframe#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/workers/Worker.cpp&type=cs&l=73 609746 15 levin 2012-04-25 07:45:54 -0700 (In reply to comment #14) > (In reply to comment #13) > > (From update of attachment 138740 [details] [details]) > > I wonder why http://code.google.com/searchframe#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/workers/WorkerScriptLoader.cpp&type=cs&l=55 isn't changed to be "|| PLATFORM(BLACKBERRY)" and then just get rid of this. > > > > But this is fine as is. Thanks! > > You should look this linked address. http://code.google.com/searchframe#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/workers/Worker.cpp&type=cs&l=73 I don't understand what you are saying. The line that you referred to is the code you are changing. Here's what I was saying. On blackberry, this field is uninitialized because on this line http://code.google.com/searchframe#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/workers/WorkerScriptLoader.cpp&type=cs&l=55 it is only initialized for Chromium. If we changed that line to also initialize the field for blackberry, then this line http://code.google.com/searchframe#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/workers/Worker.cpp&type=cs&l=73 would be necessary on blackberry either and it could be removed. 609750 16 138740 webkit.review.bot 2012-04-25 07:51:21 -0700 Comment on attachment 138740 Patch Clearing flags on attachment: 138740 Committed r115207: <http://trac.webkit.org/changeset/115207> 609751 17 webkit.review.bot 2012-04-25 07:51:27 -0700 All reviewed patches have been landed. Closing bug. 138265 2012-04-22 00:09:18 -0700 2012-04-24 00:28:36 -0700 Patch bug-84542-20120423151212.patch text/plain 1703 li.yin U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0ODU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODljN2UxOGRiMTRhZDQy ZTRlNTYwOWU3NDliYjExYmVjNTRkMmU3MC4uYzhlN2ZiYWJlNGM0ZWE0Mjg2YzMxY2ZmOWZiZjZk ODI0MTI4NGFjYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA0LTIyICBMaSBZ aW4gIDxsaS55aW5AaW50ZWwuY29tPgorCisgICAgICAgIFtjaHJvbWl1bV1bd29ya2Vyc10gc2V0 VGFyZ2V0VHlwZShSZXNvdXJjZVJlcXVlc3Q6OlRhcmdldElzV29ya2VyKSBpcyByZXBlYXRlZGx5 IGNhbGxlZCBpbiBjaHJvbWl1bQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9ODQ1NDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBJbiBjaHJvbWl1bSBwbGF0Zm9ybSwgdGhlIGRlZmF1bHQgdmFsdWUgb2YgbV90 YXJnZXRUeXBlIGlzIFJlc291cmNlUmVxdWVzdDo6VGFyZ2V0SXNXb3JrZXIKKyAgICAgICAgaXQg aXNuJ3QgbmVjZXNzYXJ5IHRvIGNhbGwKKyAgICAgICAgd29ya2VyLT5tX3NjcmlwdExvYWRlci0+ c2V0VGFyZ2V0VHlwZShSZXNvdXJjZVJlcXVlc3Q6OlRhcmdldElzV29ya2VyKSBhZ2FpbiBpbiBX b3JrZXIuY3BwCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBUaGUgY3VycmVudCB0ZXN0IGhhcyBj b3ZlcmVkIGl0IGFscmVhZHkuCisKKyAgICAgICAgKiB3b3JrZXJzL1dvcmtlci5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpXb3JrZXI6OmNyZWF0ZSk6CisKIDIwMTItMDQtMjAgIEpvbiBMZWUgIDxq b25sZWVAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBOb3RpZmljYXRpb24gY29uc3RydWN0b3IK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvV29ya2VyLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3dvcmtlcnMvV29ya2VyLmNwcAppbmRleCAxZDQ0MGY1NDg1YjY5MzU0ZDUzYjE3MjA0 MzQwNzczMTcwNzc5ZTA4Li4zNDI5OGYxODhjODMxOGYyYTUxNzJlODg5ZWJkMDhkNzMxNmU5OTY3 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL1dvcmtlci5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvd29ya2Vycy9Xb3JrZXIuY3BwCkBAIC03MCw3ICs3MCw3IEBAIFBhc3NSZWZQ dHI8V29ya2VyPiBXb3JrZXI6OmNyZWF0ZShTY3JpcHRFeGVjdXRpb25Db250ZXh0KiBjb250ZXh0 LCBjb25zdCBTdHJpbmcmCiAgICAgd29ya2VyLT5zZXRQZW5kaW5nQWN0aXZpdHkod29ya2VyLmdl dCgpKTsKIAogICAgIHdvcmtlci0+bV9zY3JpcHRMb2FkZXIgPSBXb3JrZXJTY3JpcHRMb2FkZXI6 OmNyZWF0ZSgpOwotI2lmIFBMQVRGT1JNKENIUk9NSVVNKSB8fCBQTEFURk9STShCTEFDS0JFUlJZ KQorI2lmIFBMQVRGT1JNKEJMQUNLQkVSUlkpCiAgICAgd29ya2VyLT5tX3NjcmlwdExvYWRlci0+ c2V0VGFyZ2V0VHlwZShSZXNvdXJjZVJlcXVlc3Q6OlRhcmdldElzV29ya2VyKTsKICNlbmRpZgog ICAgIHdvcmtlci0+bV9zY3JpcHRMb2FkZXItPmxvYWRBc3luY2hyb25vdXNseShjb250ZXh0LCBz Y3JpcHRVUkwsIERlbnlDcm9zc09yaWdpblJlcXVlc3RzLCB3b3JrZXIuZ2V0KCkpOwo= 138509 2012-04-24 00:28:48 -0700 2012-04-24 01:13:35 -0700 Patch bug-84542-20120425153145.patch text/plain 1768 li.yin U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0ODU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODljN2UxOGRiMTRhZDQy ZTRlNTYwOWU3NDliYjExYmVjNTRkMmU3MC4uMjhmNmY0NWZmMGMyNjgzMjZkNGZlZmFiNTc5MTVi ZGI0NzMwMzgzZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA0LTIyICBMaSBZ aW4gIDxsaS55aW5AaW50ZWwuY29tPgorCisgICAgICAgIFtjaHJvbWl1bV1bd29ya2Vyc10gc2V0 VGFyZ2V0VHlwZShSZXNvdXJjZVJlcXVlc3Q6OlRhcmdldElzV29ya2VyKSBpcyByZXBlYXRlZGx5 IGNhbGxlZCBpbiBjaHJvbWl1bQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9ODQ1NDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBJbiBjaHJvbWl1bSBwbGF0Zm9ybSwgdGhlIGRlZmF1bHQgdmFsdWUgb2YgbV90 YXJnZXRUeXBlIGlzIFJlc291cmNlUmVxdWVzdDo6VGFyZ2V0SXNXb3JrZXIKKyAgICAgICAgaXQg aXNuJ3QgbmVjZXNzYXJ5IHRvIGNhbGwKKyAgICAgICAgd29ya2VyLT5tX3NjcmlwdExvYWRlci0+ c2V0VGFyZ2V0VHlwZShSZXNvdXJjZVJlcXVlc3Q6OlRhcmdldElzV29ya2VyKSBhZ2FpbiBpbiBX b3JrZXIuY3BwCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIGJlY2F1c2UgdGhpcyBwYXRjaCBqdXN0 IGRlbGV0ZXMgYSByZXBlYXRlZCBjb2RlLCBpdCBjYW4gcmVkdWNlIGNvZGUgd29ya2xvYWQgYW5k IGNhbid0IGltcGFjdCBhbnkgZmVhdHVyZS4KKworICAgICAgICAqIHdvcmtlcnMvV29ya2VyLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6Oldvcmtlcjo6Y3JlYXRlKToKKwogMjAxMi0wNC0yMCAgSm9u IExlZSAgPGpvbmxlZUBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIE5vdGlmaWNhdGlvbiBjb25z dHJ1Y3RvcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvd29ya2Vycy9Xb3JrZXIuY3BwIGIv U291cmNlL1dlYkNvcmUvd29ya2Vycy9Xb3JrZXIuY3BwCmluZGV4IDFkNDQwZjU0ODViNjkzNTRk NTNiMTcyMDQzNDA3NzMxNzA3NzllMDguLjM0Mjk4ZjE4OGM4MzE4ZjJhNTE3MmU4ODllYmQwOGQ3 MzE2ZTk5NjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvV29ya2VyLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL1dvcmtlci5jcHAKQEAgLTcwLDcgKzcwLDcgQEAg UGFzc1JlZlB0cjxXb3JrZXI+IFdvcmtlcjo6Y3JlYXRlKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQq IGNvbnRleHQsIGNvbnN0IFN0cmluZyYKICAgICB3b3JrZXItPnNldFBlbmRpbmdBY3Rpdml0eSh3 b3JrZXIuZ2V0KCkpOwogCiAgICAgd29ya2VyLT5tX3NjcmlwdExvYWRlciA9IFdvcmtlclNjcmlw dExvYWRlcjo6Y3JlYXRlKCk7Ci0jaWYgUExBVEZPUk0oQ0hST01JVU0pIHx8IFBMQVRGT1JNKEJM QUNLQkVSUlkpCisjaWYgUExBVEZPUk0oQkxBQ0tCRVJSWSkKICAgICB3b3JrZXItPm1fc2NyaXB0 TG9hZGVyLT5zZXRUYXJnZXRUeXBlKFJlc291cmNlUmVxdWVzdDo6VGFyZ2V0SXNXb3JrZXIpOwog I2VuZGlmCiAgICAgd29ya2VyLT5tX3NjcmlwdExvYWRlci0+bG9hZEFzeW5jaHJvbm91c2x5KGNv bnRleHQsIHNjcmlwdFVSTCwgRGVueUNyb3NzT3JpZ2luUmVxdWVzdHMsIHdvcmtlci5nZXQoKSk7 Cg== 138513 2012-04-24 01:13:51 -0700 2012-04-24 22:58:59 -0700 Patch bug-84542-20120425161648.patch text/plain 1866 li.yin U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0ODU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODljN2UxOGRiMTRhZDQy ZTRlNTYwOWU3NDliYjExYmVjNTRkMmU3MC4uMzM4OGJkMzcxOTMwMjI4Y2YyMDNiMzQzZjFiMThj NjhiNzlkOWU5YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA0LTIyICBMaSBZ aW4gIDxsaS55aW5AaW50ZWwuY29tPgorCisgICAgICAgIFtjaHJvbWl1bV1bd29ya2Vyc10gc2V0 VGFyZ2V0VHlwZShSZXNvdXJjZVJlcXVlc3Q6OlRhcmdldElzV29ya2VyKSBpcyByZXBlYXRlZGx5 IGNhbGxlZCBpbiBjaHJvbWl1bQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9ODQ1NDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBJbiBjaHJvbWl1bSBwbGF0Zm9ybSwgdGhlIGRlZmF1bHQgdmFsdWUgb2YgbV90 YXJnZXRUeXBlIGlzIFJlc291cmNlUmVxdWVzdDo6VGFyZ2V0SXNXb3JrZXIKKyAgICAgICAgaXQg aXNuJ3QgbmVjZXNzYXJ5IHRvIGNhbGwKKyAgICAgICAgd29ya2VyLT5tX3NjcmlwdExvYWRlci0+ c2V0VGFyZ2V0VHlwZShSZXNvdXJjZVJlcXVlc3Q6OlRhcmdldElzV29ya2VyKSBhZ2FpbiBpbiBX b3JrZXIuY3BwCisgICAgICAgIEluIGNocm9taXVtIHBsYXRmb3JtLCB0aGUgbV90YXJnZXR0eXBl IHZhbHVlIGRldGVybWluZXMgdGhlIHByaW9yaXR5IG9mIHJlc291cmNlIGxvYWRlZC4KKworICAg ICAgICBObyBuZXcgdGVzdHMgYmVjYXVzZSB0aGlzIHBhdGNoIGp1c3QgZGVsZXRlcyBhIHJlcGVh dGVkIGNvZGUsIGl0IGNhbiByZWR1Y2UgY29kZSB3b3JrbG9hZCBhbmQgY2FuJ3QgaW1wYWN0IGFu eSBmZWF0dXJlLgorCisgICAgICAgICogd29ya2Vycy9Xb3JrZXIuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6V29ya2VyOjpjcmVhdGUpOgorCiAyMDEyLTA0LTIwICBKb24gTGVlICA8am9ubGVlQGFw cGxlLmNvbT4KIAogICAgICAgICBBZGQgTm90aWZpY2F0aW9uIGNvbnN0cnVjdG9yCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL1dvcmtlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS93 b3JrZXJzL1dvcmtlci5jcHAKaW5kZXggMWQ0NDBmNTQ4NWI2OTM1NGQ1M2IxNzIwNDM0MDc3MzE3 MDc3OWUwOC4uMzQyOThmMTg4YzgzMThmMmE1MTcyZTg4OWViZDA4ZDczMTZlOTk2NyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvd29ya2Vycy9Xb3JrZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3dvcmtlcnMvV29ya2VyLmNwcApAQCAtNzAsNyArNzAsNyBAQCBQYXNzUmVmUHRyPFdvcmtl cj4gV29ya2VyOjpjcmVhdGUoU2NyaXB0RXhlY3V0aW9uQ29udGV4dCogY29udGV4dCwgY29uc3Qg U3RyaW5nJgogICAgIHdvcmtlci0+c2V0UGVuZGluZ0FjdGl2aXR5KHdvcmtlci5nZXQoKSk7CiAK ICAgICB3b3JrZXItPm1fc2NyaXB0TG9hZGVyID0gV29ya2VyU2NyaXB0TG9hZGVyOjpjcmVhdGUo KTsKLSNpZiBQTEFURk9STShDSFJPTUlVTSkgfHwgUExBVEZPUk0oQkxBQ0tCRVJSWSkKKyNpZiBQ TEFURk9STShCTEFDS0JFUlJZKQogICAgIHdvcmtlci0+bV9zY3JpcHRMb2FkZXItPnNldFRhcmdl dFR5cGUoUmVzb3VyY2VSZXF1ZXN0OjpUYXJnZXRJc1dvcmtlcik7CiAjZW5kaWYKICAgICB3b3Jr ZXItPm1fc2NyaXB0TG9hZGVyLT5sb2FkQXN5bmNocm9ub3VzbHkoY29udGV4dCwgc2NyaXB0VVJM LCBEZW55Q3Jvc3NPcmlnaW5SZXF1ZXN0cywgd29ya2VyLmdldCgpKTsK 138740 2012-04-24 22:59:11 -0700 2012-04-25 07:51:20 -0700 Patch bug-84542-20120426140209.patch text/plain 2196 li.yin U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0ODU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODljN2UxOGRiMTRhZDQy ZTRlNTYwOWU3NDliYjExYmVjNTRkMmU3MC4uYTlhYjdmYjExMjJmYzJlYzBmMGU2MGMyODdhZTEy ZmZjYjU5NjA2ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEyLTA0LTIyICBMaSBZ aW4gIDxsaS55aW5AaW50ZWwuY29tPgorCisgICAgICAgIFtjaHJvbWl1bV1bd29ya2Vyc10gc2V0 VGFyZ2V0VHlwZShSZXNvdXJjZVJlcXVlc3Q6OlRhcmdldElzV29ya2VyKSBpcyByZXBlYXRlZGx5 IGNhbGxlZCBpbiBjaHJvbWl1bQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9ODQ1NDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBJbiBjaHJvbWl1bSBwbGF0Zm9ybSwgdGhlIGRlZmF1bHQgdmFsdWUgb2YgbV90 YXJnZXRUeXBlIGlzIFJlc291cmNlUmVxdWVzdDo6VGFyZ2V0SXNXb3JrZXIKKyAgICAgICAgaXQg aXNuJ3QgbmVjZXNzYXJ5IHRvIGNhbGwKKyAgICAgICAgd29ya2VyLT5tX3NjcmlwdExvYWRlci0+ c2V0VGFyZ2V0VHlwZShSZXNvdXJjZVJlcXVlc3Q6OlRhcmdldElzV29ya2VyKSBhZ2FpbiBpbiBX b3JrZXIuY3BwCisgICAgICAgIEluIGNocm9taXVtIHBsYXRmb3JtLCB0aGUgbV90YXJnZXR0eXBl IHZhbHVlIGRldGVybWluZXMgdGhlIHByaW9yaXR5IG9mIHJlc291cmNlIGxvYWRlZC4KKworICAg ICAgICBObyBuZXcgdGVzdHMgYmVjYXVzZSB0aGlzIHBhdGNoIGp1c3QgZGVsZXRlcyBhIHJlcGVh dGVkIGNvZGUsIGl0IGNhbiByZWR1Y2UgY29kZSB3b3JrbG9hZCBhbmQgY2FuJ3QgaW1wYWN0IGFu eSBmZWF0dXJlLgorICAgICAgICBJZiB0aGUgdGFyZ2V0IHR5cGUgaXNuJ3Qgc2V0IGNvcnJlY3Rs eSwgdGhlIGZvbGxvd2luZyB0ZXN0IG1heWJlIGZhaWwgYmVjYXVzZSBvZiB0aW1lb3V0IGluIHRo ZSBjaHJvbWl1bS4KKyAgICAgICAgZmFzdC93b3JrZXJzL3N0b3JhZ2UvbXVsdGlwbGUtdHJhbnNh Y3Rpb25zLW9uLWRpZmZlcmVudC1oYW5kbGVzLmh0bWwKKyAgICAgICAgZmFzdC93b3JrZXJzL3N0 b3JhZ2UvbXVsdGlwbGUtdHJhbnNhY3Rpb25zLW9uLWRpZmZlcmVudC1oYW5kbGVzLXN5bmMuaHRt bAorICAgICAgICBmYXN0L3dvcmtlcnMvc3RvcmFnZS9pbnRlcnJ1cHQtZGF0YWJhc2UuaHRtbAor CisgICAgICAgICogd29ya2Vycy9Xb3JrZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6V29ya2Vy OjpjcmVhdGUpOgorCiAyMDEyLTA0LTIwICBKb24gTGVlICA8am9ubGVlQGFwcGxlLmNvbT4KIAog ICAgICAgICBBZGQgTm90aWZpY2F0aW9uIGNvbnN0cnVjdG9yCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS93b3JrZXJzL1dvcmtlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL1dvcmtl ci5jcHAKaW5kZXggMWQ0NDBmNTQ4NWI2OTM1NGQ1M2IxNzIwNDM0MDc3MzE3MDc3OWUwOC4uMzQy OThmMTg4YzgzMThmMmE1MTcyZTg4OWViZDA4ZDczMTZlOTk2NyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvd29ya2Vycy9Xb3JrZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMv V29ya2VyLmNwcApAQCAtNzAsNyArNzAsNyBAQCBQYXNzUmVmUHRyPFdvcmtlcj4gV29ya2VyOjpj cmVhdGUoU2NyaXB0RXhlY3V0aW9uQ29udGV4dCogY29udGV4dCwgY29uc3QgU3RyaW5nJgogICAg IHdvcmtlci0+c2V0UGVuZGluZ0FjdGl2aXR5KHdvcmtlci5nZXQoKSk7CiAKICAgICB3b3JrZXIt Pm1fc2NyaXB0TG9hZGVyID0gV29ya2VyU2NyaXB0TG9hZGVyOjpjcmVhdGUoKTsKLSNpZiBQTEFU Rk9STShDSFJPTUlVTSkgfHwgUExBVEZPUk0oQkxBQ0tCRVJSWSkKKyNpZiBQTEFURk9STShCTEFD S0JFUlJZKQogICAgIHdvcmtlci0+bV9zY3JpcHRMb2FkZXItPnNldFRhcmdldFR5cGUoUmVzb3Vy Y2VSZXF1ZXN0OjpUYXJnZXRJc1dvcmtlcik7CiAjZW5kaWYKICAgICB3b3JrZXItPm1fc2NyaXB0 TG9hZGVyLT5sb2FkQXN5bmNocm9ub3VzbHkoY29udGV4dCwgc2NyaXB0VVJMLCBEZW55Q3Jvc3NP cmlnaW5SZXF1ZXN0cywgd29ya2VyLmdldCgpKTsK