84526 2012-04-21 02:29:29 -0700 webkit-gtk-1.8.0 fails to build with --disable-video in DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp 2013-09-12 14:36:08 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 tetromino webkit-unassigned abarth berto gnome haraken japhet webkit.review.bot oldest_to_newest 607189 0 tetromino 2012-04-21 02:29:29 -0700 (as reported downstream at https://bugs.gentoo.org/show_bug.cgi?id=412221) If configured with --disable-video, webkit-gtk-1.8.0 build fails with: DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp: In function ‘void webkit_dom_html_media_element_set_property(GObject*, guint, const GValue*, GParamSpec*)’: DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:149:5: error: ‘HTMLMediaElement’ is not a member of ‘WebCore’ DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:149:32: error: ‘coreSelf’ was not declared in this scope DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:149:43: error: ‘core’ is not a member of ‘WebKit’ DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp: In function ‘void webkit_dom_html_media_element_get_property(GObject*, guint, GValue*, GParamSpec*)’: DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:234:5: error: ‘HTMLMediaElement’ is not a member of ‘WebCore’ DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:234:32: error: ‘coreSelf’ was not declared in this scope DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:234:43: error: ‘core’ is not a member of ‘WebKit’ DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:238:16: error: ‘MediaError’ is not a member of ‘WebCore’ DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:238:16: error: ‘MediaError’ is not a member of ‘WebCore’ DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:238:35: error: template argument 1 is invalid DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:238:41: error: invalid type in declaration before ‘=’ token DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:239:51: error: request for member ‘get’ in ‘ptr’, which is of non-class type ‘int’ DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:265:56: error: no matching function for call to ‘kit(WebCore::TimeRanges*)’ DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:265:56: note: candidates are: ./Source/WebCore/bindings/gobject/WebKitDOMBinding.h:38:16: note: WebKitDOMNode* WebKit::kit(WebCore::Node*) ./Source/WebCore/bindings/gobject/WebKitDOMBinding.h:38:16: note: no known conversion for argument 1 from ‘WebCore::TimeRanges*’ to ‘WebCore::Node*’ ./Source/WebCore/bindings/gobject/WebKitDOMBinding.h:39:19: note: WebKitDOMElement* WebKit::kit(WebCore::Element*) ./Source/WebCore/bindings/gobject/WebKitDOMBinding.h:39:19: note: no known conversion for argument 1 from ‘WebCore::TimeRanges*’ to ‘WebCore::Element*’ ./Source/WebCore/bindings/gobject/WebKitDOMBinding.h:40:17: note: WebKitDOMEvent* WebKit::kit(WebCore::Event*) ./Source/WebCore/bindings/gobject/WebKitDOMBinding.h:40:17: note: no known conversion for argument 1 from ‘WebCore::TimeRanges*’ to ‘WebCore::Event*’ ./Source/WebCore/bindings/gobject/WebKitDOMBinding.h:41:23: note: WebKitDOMEventTarget* WebKit::kit(WebCore::EventTarget*) ./Source/WebCore/bindings/gobject/WebKitDOMBinding.h:41:23: note: no known conversion for argument 1 from ‘WebCore::TimeRanges*’ to ‘WebCore::EventTarget*’ DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:316:56: error: no matching function for call to ‘kit(WebCore::TimeRanges*)’ DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:316:56: note: candidates are: ./Source/WebCore/bindings/gobject/WebKitDOMBinding.h:38:16: note: WebKitDOMNode* WebKit::kit(WebCore::Node*) ./Source/WebCore/bindings/gobject/WebKitDOMBinding.h:38:16: note: no known conversion for argument 1 from ‘WebCore::TimeRanges*’ to ‘WebCore::Node*’ ./Source/WebCore/bindings/gobject/WebKitDOMBinding.h:39:19: note: WebKitDOMElement* WebKit::kit(WebCore::Element*) ./Source/WebCore/bindings/gobject/WebKitDOMBinding.h:39:19: note: no known conversion for argument 1 from ‘WebCore::TimeRanges*’ to ‘WebCore::Element*’ ./Source/WebCore/bindings/gobject/WebKitDOMBinding.h:40:17: note: WebKitDOMEvent* WebKit::kit(WebCore::Event*) ./Source/WebCore/bindings/gobject/WebKitDOMBinding.h:40:17: note: no known conversion for argument 1 from ‘WebCore::TimeRanges*’ to ‘WebCore::Event*’ ./Source/WebCore/bindings/gobject/WebKitDOMBinding.h:41:23: note: WebKitDOMEventTarget* WebKit::kit(WebCore::EventTarget*) ./Source/WebCore/bindings/gobject/WebKitDOMBinding.h:41:23: note: no known conversion for argument 1 from ‘WebCore::TimeRanges*’ to ‘WebCore::EventTarget*’ DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:322:56: error: no matching function for call to ‘kit(WebCore::TimeRanges*)’ DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:322:56: note: candidates are: ./Source/WebCore/bindings/gobject/WebKitDOMBinding.h:38:16: note: WebKitDOMNode* WebKit::kit(WebCore::Node*) ./Source/WebCore/bindings/gobject/WebKitDOMBinding.h:38:16: note: no known conversion for argument 1 from ‘WebCore::TimeRanges*’ to ‘WebCore::Node*’ ./Source/WebCore/bindings/gobject/WebKitDOMBinding.h:39:19: note: WebKitDOMElement* WebKit::kit(WebCore::Element*) ./Source/WebCore/bindings/gobject/WebKitDOMBinding.h:39:19: note: no known conversion for argument 1 from ‘WebCore::TimeRanges*’ to ‘WebCore::Element*’ ./Source/WebCore/bindings/gobject/WebKitDOMBinding.h:40:17: note: WebKitDOMEvent* WebKit::kit(WebCore::Event*) ./Source/WebCore/bindings/gobject/WebKitDOMBinding.h:40:17: note: no known conversion for argument 1 from ‘WebCore::TimeRanges*’ to ‘WebCore::Event*’ ./Source/WebCore/bindings/gobject/WebKitDOMBinding.h:41:23: note: WebKitDOMEventTarget* WebKit::kit(WebCore::EventTarget*) ./Source/WebCore/bindings/gobject/WebKitDOMBinding.h:41:23: note: no known conversion for argument 1 from ‘WebCore::TimeRanges*’ to ‘WebCore::EventTarget*’ make: *** [DerivedSources/webkit/libwebkitgtk_3_0_la-WebKitDOMHTMLMediaElement.lo] Error 1 612228 1 139350 mikhail.khokhlov 2012-04-28 03:31:21 -0700 Created attachment 139350 Simple patch for CodeGeneratorGObject.pm 615055 2 tetromino 2012-05-02 23:52:08 -0700 (In reply to comment #1) > Created an attachment (id=139350) [details] > Simple patch for CodeGeneratorGObject.pm Thanks, that fixes the build failure. 928494 3 berto 2013-09-12 14:36:08 -0700 There's a problem now since disabling VIDEO also requires to disable VIDEO_TRACK (I filed bug 121259 about that problem). But otherwise the issue described here is no longer present, so I'm closing this bug. 139350 2012-04-28 03:31:21 -0700 2012-04-28 03:31:21 -0700 Simple patch for CodeGeneratorGObject.pm WebKit-CodeGeneratorGObject.patch text/plain 614 mikhail.khokhlov SW5kZXg6IFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckdPYmpl Y3QucG0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2Rl R2VuZXJhdG9yR09iamVjdC5wbQkocmV2aXNpb24gMTE1NTYyKQorKysgU291cmNlL1dlYkNvcmUv YmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yR09iamVjdC5wbQkod29ya2luZyBjb3B5KQpA QCAtMTQ0NCw5ICsxNDQ0LDEwIEBACiAgICAgcHJpbnQgSU1QTCAibmFtZXNwYWNlIFdlYktpdCB7 XG5cbiI7CiAgICAgcHJpbnQgSU1QTCBAY0JvZHlQcml2OwogICAgIHByaW50IElNUEwgIn0gLy8g bmFtZXNwYWNlIFdlYktpdFxuXG4iOworCisgICAgcHJpbnQgSU1QTCBAY0JvZHlQcm9wZXJ0aWVz OwogICAgIHByaW50IElNUEwgIiNlbmRpZiAvLyAke2NvbmRpdGlvbmFsU3RyaW5nfVxuXG4iIGlm ICRjb25kaXRpb25hbFN0cmluZzsKIAotICAgIHByaW50IElNUEwgQGNCb2R5UHJvcGVydGllczsK ICAgICBwcmludCBJTVBMIEBjQm9keTsKIAogICAgIGNsb3NlKElNUEwpOwo=