84520 2012-04-20 20:57:00 -0700 [chromium] When prepareToDraw fails due to animation checkerboard, we need to call setNeedsCommit 2012-04-23 07:53:31 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 vollick vollick cc-bugs jamesr nduca webkit.review.bot oldest_to_newest 607141 0 vollick 2012-04-20 20:57:00 -0700 Make sure we commit if we drop frames due to animation checkerboard. 607142 1 138219 vollick 2012-04-20 21:00:05 -0700 Created attachment 138219 Patch 607273 2 138219 enne 2012-04-21 15:03:15 -0700 Comment on attachment 138219 Patch I feel like I remember that this used to happen, but maybe it got removed in a refactoring. Thanks! R=me. 607678 3 138219 webkit.review.bot 2012-04-23 07:53:27 -0700 Comment on attachment 138219 Patch Clearing flags on attachment: 138219 Committed r114898: <http://trac.webkit.org/changeset/114898> 607679 4 webkit.review.bot 2012-04-23 07:53:31 -0700 All reviewed patches have been landed. Closing bug. 138219 2012-04-20 21:00:05 -0700 2012-04-23 07:53:27 -0700 Patch bug-84520-20120421000003.patch text/plain 3408 vollick U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0NTE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTI5YzlhYThiZDNhOWYz NzY5YjNmZGJlNjVmMDZiOWVlOWEwMDI0OS4uMTg5ZmNiYmU5NzUxZTgxNTdkZWFjNzAyNmE3MWMz NDdkYTMwYmM3MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA0LTIwICBJYW4g Vm9sbGljayAgPHZvbGxpY2tAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gV2hl biBwcmVwYXJlVG9EcmF3IGZhaWxzIGR1ZSB0byBhbmltYXRpb24gY2hlY2tlcmJvYXJkLCB3ZSBu ZWVkIHRvIGNhbGwgc2V0TmVlZHNDb21taXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTg0NTIwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVGVzdGVkIGluIENDTGF5ZXJUcmVlSG9zdEltcGxUZXN0LnByZXBh cmVUb0RyYXdGYWlsc1doZW5BbmltYXRpb25Vc2VzQ2hlY2tlcmJvYXJkCisKKyAgICAgICAgKiBw bGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVyVHJlZUhvc3RJbXBsLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkNDTGF5ZXJUcmVlSG9zdEltcGw6OnByZXBhcmVUb0RyYXcpOgorCiAy MDEyLTA0LTE4ICBNYXJrIFBpbGdyaW0gIDxwaWxncmltQGNocm9taXVtLm9yZz4KIAogICAgICAg ICBGb2xsb3d1cCB0byAiQ2FsbCBpbmNyZW1lbnRTdGF0c0NvdW50ZXIgZGlyZWN0bHkiCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4IDQ2OTE5ZTRkOTNlNzRiNzhhYzA0MzdmMDg2NzgwNzE0 NmZiODEzNDMuLmYzNDJjZmIyM2U5YjliYzM0NmFlMjRjMDRjOWFhYWI0OTk4MWFhNGIgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTItMDQtMjAgIElhbiBW b2xsaWNrICA8dm9sbGlja0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBXaGVu IHByZXBhcmVUb0RyYXcgZmFpbHMgZHVlIHRvIGFuaW1hdGlvbiBjaGVja2VyYm9hcmQsIHdlIG5l ZWQgdG8gY2FsbCBzZXROZWVkc0NvbW1pdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9ODQ1MjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIHRlc3RzL0NDTGF5ZXJUcmVlSG9zdEltcGxUZXN0LmNwcDoKKyAg ICAgICAgKFdlYktpdFRlc3RzOjpURVNUX0YpOgorCiAyMDEyLTA0LTE4ICBBbGV4YW5kZXIgUGF2 bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW0Nocm9taXVtXSBSRUdSRVNT SU9OOiBQb3B1cCBzaHJpbmtzIGJlY2F1c2Ugb2YgYXV0b2NvbXBsZXRlCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVyVHJlZUhv c3RJbXBsLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2Nj L0NDTGF5ZXJUcmVlSG9zdEltcGwuY3BwCmluZGV4IDVlZjVhMzIwMjcwODE3OGNjMzgzNzc0OWI3 MDU5Y2RkYmI3MWRkYzkuLjY4NzUzMmZhYTUxOTc5NjI5ZTdjMjQzODc1ODI2NmFkOTMwYTk2ZDAg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2Nj L0NDTGF5ZXJUcmVlSG9zdEltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJUcmVlSG9zdEltcGwuY3BwCkBAIC0zODAsOCArMzgw LDExIEBAIGJvb2wgQ0NMYXllclRyZWVIb3N0SW1wbDo6cHJlcGFyZVRvRHJhdyhGcmFtZURhdGEm IGZyYW1lKQogICAgIGlmICghbV9yb290TGF5ZXJJbXBsKQogICAgICAgICByZXR1cm4gZmFsc2U7 CiAKLSAgICBpZiAoIWNhbGN1bGF0ZVJlbmRlclBhc3NlcyhmcmFtZS5yZW5kZXJQYXNzZXMsIGZy YW1lLnJlbmRlclN1cmZhY2VMYXllckxpc3QpKQorICAgIGlmICghY2FsY3VsYXRlUmVuZGVyUGFz c2VzKGZyYW1lLnJlbmRlclBhc3NlcywgZnJhbWUucmVuZGVyU3VyZmFjZUxheWVyTGlzdCkpIHsK KyAgICAgICAgLy8gV2UncmUgbWlzc2luZyB0ZXh0dXJlcyBvbiBhbiBhbmltYXRpbmcgbGF5ZXIu IFJlcXVlc3QgYSBjb21taXQuCisgICAgICAgIG1fY2xpZW50LT5zZXROZWVkc0NvbW1pdE9uSW1w bFRocmVhZCgpOwogICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgfQogCiAgICAgLy8gSWYgd2Ug cmV0dXJuIHRydWUsIHRoZW4gd2UgZXhwZWN0IGRyYXdMYXllcnMoKSB0byBiZSBjYWxsZWQgYmVm b3JlIHRoaXMgZnVuY3Rpb24gaXMgY2FsbGVkIGFnYWluLgogICAgIHJldHVybiB0cnVlOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9DQ0xheWVyVHJlZUhvc3RJbXBs VGVzdC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0NDTGF5ZXJUcmVlSG9zdElt cGxUZXN0LmNwcAppbmRleCAwNzdlNGMyMzliZDM1Mzc4OWE5NzIxNWYxMmFlOTgwOTMwNzgwODk5 Li5mYThjNzJlYTMwZGUxM2NhYmFmZTYzMmJlNTI4Y2ZjY2YzYzI0ZDc2IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0NDTGF5ZXJUcmVlSG9zdEltcGxUZXN0LmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0NDTGF5ZXJUcmVlSG9zdEltcGxUZXN0 LmNwcApAQCAtNTQ5LDcgKzU0OSw5IEBAIFRFU1RfRihDQ0xheWVyVHJlZUhvc3RJbXBsVGVzdCwg cHJlcGFyZVRvRHJhd0ZhaWxzV2hlbkFuaW1hdGlvblVzZXNDaGVja2VyYm9hcmQpCiAgICAgcm9v dCA9IHN0YXRpY19jYXN0PERpZERyYXdDaGVja0xheWVyKj4obV9ob3N0SW1wbC0+cm9vdExheWVy KCkpOwogICAgIHJvb3QtPmFkZENoaWxkKE1pc3NpbmdUZXh0dXJlQW5pbWF0aW5nTGF5ZXI6OmNy ZWF0ZSgxLCB0cnVlLCBmYWxzZSwgdHJ1ZSkpOwogCisgICAgbV9kaWRSZXF1ZXN0Q29tbWl0ID0g ZmFsc2U7CiAgICAgRVhQRUNUX0ZBTFNFKG1faG9zdEltcGwtPnByZXBhcmVUb0RyYXcoZnJhbWUp KTsKKyAgICBFWFBFQ1RfVFJVRShtX2RpZFJlcXVlc3RDb21taXQpOwogICAgIG1faG9zdEltcGwt PmRyYXdMYXllcnMoZnJhbWUpOwogCiAgICAgLy8gV2hlbiB0aGUgbGF5ZXIgc2tpcHMgZHJhdyBh bmQgd2UncmUgYW5pbWF0aW5nLCB3ZSBzdGlsbCBkcmF3IHRoZSBmcmFtZS4K