84513 2012-04-20 16:50:29 -0700 Add an ability to find the extent of a callframe 2012-04-24 21:06:27 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 79668 1 oliver oliver d-r ggaren loki mrobinson naginenis ossy pnormand rakuco spena tmpsantos zherczeg oldest_to_newest 607059 0 oliver 2012-04-20 16:50:29 -0700 Add an ability to find the extent of a callframe 607070 1 138202 oliver 2012-04-20 16:57:07 -0700 Created attachment 138202 Patch 607079 2 oliver 2012-04-20 17:12:30 -0700 Committed r114803: <http://trac.webkit.org/changeset/114803> 607163 3 ossy 2012-04-21 00:56:29 -0700 Reopen, because it broke zillion jsc tests and layout tests in debug mode on the GTK and on the Qt x86_64 bots. Maybe they are broken on Mac too, but unfortunately Mac debug bots aren't working properly now. - http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug/builds/32645 - http://build.webkit.sed.hu/builders/x86-64%20Linux%20Qt%20Debug/builds/22391 Could you check and fix this regression please? 607194 4 tmpsantos 2012-04-21 04:03:03 -0700 Hi guys, looks like all debug build (EFL, GTK, Win, etc) bots are sick after this change. Release bots are passing on these tests. http://build.webkit.org/builders/EFL%20Linux%20Debug/builds/379 ** Danger, Will Robinson! Danger! The following failures have been introduced: ecma/Expressions/11.2.2-1-n.js ecma/Expressions/11.2.2-10-n.js ecma/Expressions/11.2.2-7-n.js ecma/Expressions/11.2.2-8-n.js ecma/Expressions/11.2.2-9-n.js ecma/GlobalObject/15.1-1-n.js ecma/GlobalObject/15.1-2-n.js ecma/Math/15.8-2-n.js ecma/Math/15.8-3-n.js ecma_2/Exceptions/exception-001.js ecma_2/Exceptions/exception-002.js ecma_2/Exceptions/expression-005.js ecma_2/Exceptions/expression-006.js ecma_2/Exceptions/expression-012.js ecma_2/Exceptions/expression-013.js ecma_2/Exceptions/expression-014.js ecma_2/Exceptions/expression-019.js ecma_2/Exceptions/global-001.js ecma_2/Exceptions/global-002.js js1_2/function/regexparg-2-n.js js1_4/Regress/function-004-n.js 607690 5 pnormand 2012-04-23 08:03:46 -0700 Hi Oliver, any idea about this issue? 607718 6 oliver 2012-04-23 08:53:32 -0700 I'm looking at this today -- the assertion that's firing is *very* bad. It's actually showing up on a number of other sites in mac (just not on the test suite :-/ ). This is currently my #1 priority. 607725 7 d-r 2012-04-23 08:57:55 -0700 Thanks for getting back on this - if it's taking longer than a day - do you think we could roll this out until the sites are fixed that hit this assertion? Reason is, this hits the "20 crashes to bailout" threshold on our (EFL Linux Debug) buildbot. Similar for GTK Debug Buildbot. So we can't use the results. 607843 8 oliver 2012-04-23 10:59:45 -0700 Ah ha, if LLINT isn't enabled, i get crashes running webkit tests on mac. I assume effected builds have llint disabled. Investigating some more. 607871 9 oliver 2012-04-23 11:30:20 -0700 It looks like there are a few places in the baseline jit that mix-and-match the current callframe and the caller's callframe. Fixing. 607883 10 oliver 2012-04-23 11:41:52 -0700 Running tests on my patch, then some tidying up and should be good. Then we'll just be stuck with the horrible bug that i originally added these assertions to catch. 607912 11 tmpsantos 2012-04-23 12:12:19 -0700 (In reply to comment #10) > Running tests on my patch, then some tidying up and should be good. Then we'll just be stuck with the horrible bug that i originally added these assertions to catch. I'm still online for a couple of hours if you need a second opinion (i.e. run your patch/fix on other port). 608412 12 d-r 2012-04-24 00:20:26 -0700 Debug Buildbots are back to work after Oliver removed one assertion: http://trac.webkit.org/changeset/114953 608416 13 pnormand 2012-04-24 00:32:54 -0700 (In reply to comment #10) > Running tests on my patch, then some tidying up and should be good. Then we'll just be stuck with the horrible bug that i originally added these assertions to catch. Thanks Oliver! Bots are bleeding less now :) This bug can be closed now, maybe? 138202 2012-04-20 16:57:07 -0700 2012-04-20 17:10:05 -0700 Patch bug-84513-20120420165706.patch text/plain 3409 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0NzcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 YWNkMjNiYWVhZTQ1MDc0MTI4OGIwOWYxZjBmNTdiMDJkMDJjYWQ3Li45M2YyNzNkMWU0YThjYjdj ZjFiZTNhOGRhYzdjMTM5OWFhZGE0NGE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMyBAQAorMjAxMi0wNC0yMCAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgor CisgICAgICAgIEFkZCBhbiBhYmlsaXR5IHRvIGZpbmQgdGhlIGV4dGVudCBvZiBhIGNhbGxmcmFt ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODQ1MTMK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSBm dW5jdGlvbiB0byBnZXQgdGhlIGV4dGVudCBvZiBhIGNhbGxmcmFtZSBhbmQKKyAgICAgICAgdXNl IHRoYXQgZnVuY3Rpb24gZm9yIGEgbmV3IGFzc2VydGlvbiB0byBtYWtlIHN1cmUgdGhlCisgICAg ICAgIFJlZ2lzdGVyRmlsZSBtYWtlcyBzZW5zZSB1c2luZyB0aGF0IGluZm9ybWF0aW9uLgorCisg ICAgICAgICogaW50ZXJwcmV0ZXIvQ2FsbEZyYW1lLmNwcDoKKyAgICAgICAgKEpTQzo6Q2FsbEZy YW1lOjpmcmFtZUV4dGVudEludGVybmFsKToKKyAgICAgICAgKEpTQyk6CisgICAgICAgICogaW50 ZXJwcmV0ZXIvQ2FsbEZyYW1lLmg6CisgICAgICAgIChKU0M6OkV4ZWNTdGF0ZTo6ZnJhbWVFeHRl bnQpOgorICAgICAgICAoRXhlY1N0YXRlKToKKyAgICAgICAgKiBpbnRlcnByZXRlci9JbnRlcnBy ZXRlci5jcHA6CisgICAgICAgIChKU0M6OkludGVycHJldGVyOjpleGVjdXRlQ2FsbCk6CisKIDIw MTItMDQtMjAgIE1hcmsgSGFobmVuYmVyZyAgPG1oYWhuZW5iZXJnQGFwcGxlLmNvbT4KIAogICAg ICAgICBKU0dhcmJhZ2VDb2xsZWN0IHNob3VsZCBub3QgY2FsbCBjb2xsZWN0QWxsR2FyYmFnZSgp CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIvQ2FsbEZyYW1l LmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9DYWxsRnJhbWUuY3BwCmlu ZGV4IDE4ZWFhYjI0ZDk1OGUwMzIwNmFiZTU5NWIwMDA2ZmY0ZmQyYTkzODcuLmE1ZmZhZWU4ZDYx NDk5ZjRkNjk2NTc1NjIzYWM4ZDNkMzA5M2E0OGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9pbnRlcnByZXRlci9DYWxsRnJhbWUuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9pbnRlcnByZXRlci9DYWxsRnJhbWUuY3BwCkBAIC0xODMsNCArMTgzLDExIEBAIENhbGxG cmFtZSogQ2FsbEZyYW1lOjp0cnVlQ2FsbGVyRnJhbWUoKQogfQogI2VuZGlmCiAKK1JlZ2lzdGVy KiBDYWxsRnJhbWU6OmZyYW1lRXh0ZW50SW50ZXJuYWwoKQoreworICAgIENvZGVCbG9jayogY29k ZUJsb2NrID0gdGhpcy0+Y29kZUJsb2NrKCk7CisgICAgQVNTRVJUKGNvZGVCbG9jayk7CisgICAg cmV0dXJuIHJlZ2lzdGVycygpICsgY29kZUJsb2NrLT5tX251bUNhbGxlZVJlZ2lzdGVyczsKK30K KwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0NhbGxG cmFtZS5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0NhbGxGcmFtZS5oCmlu ZGV4IDViZjJiOTQ4ODc2MjczYjYwMzAyOTdjY2JlM2IzNDg0MTBjN2QwZWUuLjRlYzNkZTdmM2Q2 ZjFlMDY1YTMxZmUyNmVkOTNmNzZjYzA5ZTYyZmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9pbnRlcnByZXRlci9DYWxsRnJhbWUuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvaW50ZXJwcmV0ZXIvQ2FsbEZyYW1lLmgKQEAgLTEyNSw2ICsxMjUsMTUgQEAgbmFtZXNwYWNl IEpTQyAgewogICAgICAgICB9CiAjZW5kaWYKIAorICAgICAgICBSZWdpc3RlciogZnJhbWVFeHRl bnQoKQorICAgICAgICB7CisgICAgICAgICAgICBpZiAoIWNvZGVCbG9jaygpKQorICAgICAgICAg ICAgICAgIHJldHVybiByZWdpc3RlcnMoKTsKKyAgICAgICAgICAgIHJldHVybiBmcmFtZUV4dGVu dEludGVybmFsKCk7CisgICAgICAgIH0KKyAgICAKKyAgICAgICAgUmVnaXN0ZXIqIGZyYW1lRXh0 ZW50SW50ZXJuYWwoKTsKKyAgICAKICNpZiBFTkFCTEUoREZHX0pJVCkKICAgICAgICAgSW5saW5l Q2FsbEZyYW1lKiBpbmxpbmVDYWxsRnJhbWUoKSBjb25zdCB7IHJldHVybiB0aGlzW1JlZ2lzdGVy RmlsZTo6UmV0dXJuUENdLmFzSW5saW5lQ2FsbEZyYW1lKCk7IH0KICAgICAgICAgdW5zaWduZWQg Y29kZU9yaWdpbkluZGV4Rm9yREZHKCkgY29uc3QgeyByZXR1cm4gdGhpc1tSZWdpc3RlckZpbGU6 OkFyZ3VtZW50Q291bnRdLnRhZygpOyB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvaW50ZXJwcmV0ZXIvSW50ZXJwcmV0ZXIuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2lu dGVycHJldGVyL0ludGVycHJldGVyLmNwcAppbmRleCAwNDYwNTZjMDU4Mjg1YTZmYTVlNjI3ZDVh N2FkMDVhMjFkM2Y4ZmZjLi5mYTYzY2ZiODY1ZjUxYzdiMTQ3YzhkNGU2ZjJkN2E4MjA0MDc2NWFl IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIvSW50ZXJwcmV0 ZXIuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9JbnRlcnByZXRl ci5jcHAKQEAgLTEyNTIsNiArMTI1Miw4IEBAIEpTVmFsdWUgSW50ZXJwcmV0ZXI6OmV4ZWN1dGVD YWxsKENhbGxGcmFtZSogY2FsbEZyYW1lLCBKU09iamVjdCogZnVuY3Rpb24sIENhbGxUCiAgICAg ICAgIHJldHVybiBjaGVja2VkUmV0dXJuKHRocm93U3RhY2tPdmVyZmxvd0Vycm9yKGNhbGxGcmFt ZSkpOwogCiAgICAgUmVnaXN0ZXIqIG9sZEVuZCA9IG1fcmVnaXN0ZXJGaWxlLmVuZCgpOworICAg IEFTU0VSVChjYWxsRnJhbWUtPmZyYW1lRXh0ZW50KCkgPD0gb2xkRW5kIHx8IGNhbGxGcmFtZSA9 PSBjYWxsRnJhbWUtPnNjb3BlQ2hhaW4oKS0+Z2xvYmFsT2JqZWN0LT5nbG9iYWxFeGVjKCkpOwor ICAgIEFTU0VSVChjYWxsRnJhbWUgPT0gY2FsbEZyYW1lLT5nbG9iYWxEYXRhKCkudG9wQ2FsbEZy YW1lIHx8IGNhbGxGcmFtZSA9PSBjYWxsRnJhbWUtPnNjb3BlQ2hhaW4oKS0+Z2xvYmFsT2JqZWN0 LT5nbG9iYWxFeGVjKCkpOwogICAgIGludCBhcmdDb3VudCA9IDEgKyBhcmdzLnNpemUoKTsgLy8g aW1wbGljaXQgInRoaXMiIHBhcmFtZXRlcgogICAgIHNpemVfdCByZWdpc3Rlck9mZnNldCA9IGFy Z0NvdW50ICsgUmVnaXN0ZXJGaWxlOjpDYWxsRnJhbWVIZWFkZXJTaXplOwogCg==