84501 2012-04-20 15:51:22 -0700 REGRESSION (r94497): Pressing Command+A when inline (Marked Text) is not empty will clean whole content 2012-04-26 23:44:31 -0700 1 1 1 Unclassified WebKit Text 528+ (Nightly build) Mac Unspecified RESOLVED FIXED InRadar P1 Major --- 1 ap rniwa jiapu.mail jshin morrita rniwa tkent xji oldest_to_newest 606981 0 ap 2012-04-20 15:51:22 -0700 Steps to reproduce: 1. Type anything in any editable content (contenteditable, textarea, Mail.app etc.) 2. Type anything else with an input method using inline input (such as Kotoeri). 3. Hit Cmd+A Results: entire editable content disappears. Expected results: input area is confirmed, all text is selected. <rdar://problem/11242705> 609228 1 ap 2012-04-24 16:33:52 -0700 Ryosuke, would you be willing to look into this? 611058 2 rniwa 2012-04-26 16:15:23 -0700 Interesting this bug doesn't reproduce on Chrome because we ignore Cmd+A. 611078 3 rniwa 2012-04-26 16:45:02 -0700 We're hitting: // If text is empty, then delete the old composition here. If text is non-empty, InsertTextCommand::input // will delete the old composition with an optimized replace operation. if (text.isEmpty()) TypingCommand::deleteSelection(m_frame->document(), 0); 611258 4 139135 rniwa 2012-04-26 22:53:56 -0700 Created attachment 139135 Fixes the bug 611264 5 139135 ap 2012-04-26 23:04:36 -0700 Comment on attachment 139135 Fixes the bug Thank you! I suggest putting this test in editing/input. Ports that don't implement textInputController often skip the whole directory, so it's less book-keeping for everyone. 611265 6 rniwa 2012-04-26 23:07:23 -0700 (In reply to comment #5) > (From update of attachment 139135 [details]) > Thank you! > > I suggest putting this test in editing/input. Ports that don't implement textInputController often skip the whole directory, so it's less book-keeping for everyone. Okay, will do. 611277 7 rniwa 2012-04-26 23:44:31 -0700 Committed r115409: <http://trac.webkit.org/changeset/115409> 139135 2012-04-26 22:53:56 -0700 2012-04-26 23:04:36 -0700 Fixes the bug bug-84501-20120426225355.patch text/plain 4566 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNTQwNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA0LTI2ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04gKHI5NDQ5Nyk6 IFByZXNzaW5nIENvbW1hbmQrQSB3aGVuIGlubGluZSAoTWFya2VkIFRleHQpIGlzIG5vdCBlbXB0 eSB3aWxsIGNsZWFuIHdob2xlIGNvbnRlbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTg0NTAxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVGhlIGJ1ZyB3YXMgY2F1c2VkIGJ5IHNldENvbXBvc2l0aW9uLCB3 aGljaCBpcyBjYWxsZWQgYnkgY2FuY2VsQ29tcG9zaXRpb24sIGRlbGV0aW5nIHRoZSBjb250ZW50 cyB3aGVuCisgICAgICAgIHRoZSBwYXNzZWQgdGV4dCBpcyBlbXB0eS4gRml4ZWQgaXQgYnkgbm90 IGRlbGV0aW5nIHRleHQgd2hlbiBjYW5jZWxpbmcgY29tcG9zaXRpb25zLiBUaGlzIGlzIG9rYXkg YmVjYXVzZQorICAgICAgICBhcyB0aGUgY29tbWVudCBhYm92ZSB0aGUgbGluZSBzdWdnZXN0cywg dGhpcyBwYXJ0aWN1bGFyIGNhbGwgdG8gVHlwaW5nQ29tbWFuZDo6ZGVsZXRlU2VsZWN0aW9uIGlz IG9ubHkgdXNlZnVsCisgICAgICAgIHdoZW4gdGhlIGNvbmZpcm1lZCB0ZXh0IGlzIGVtcHR5IGFu ZCB0aGUgY29tcG9zaXRpb24gdGV4dCBoYWQgcHJldmlvdXNseSBiZWVuIG5vbi1lbXB0eS4KKwor ICAgICAgICBUZXN0OiBlZGl0aW5nL3NlbGVjdGlvbi9zZWxlY3QtYWxsLWNsZWFyLWlucHV0LW1l dGhvZC5odG1sCisKKyAgICAgICAgKiBlZGl0aW5nL0VkaXRvci5jcHA6CisgICAgICAgIChXZWJD b3JlOjpFZGl0b3I6OnNldENvbXBvc2l0aW9uKToKKwogMjAxMi0wNC0yNiAgS2Vpc2hpIEhhdHRv cmkgIDxrZWlzaGlAd2Via2l0Lm9yZz4KIAogICAgICAgICBkYXRhbGlzdDogRm9ybSBjb250cm9s IGluIGEgPGRhdGFsaXN0PiBzaG91bGQgYmUgYmFycmVkIGZyb20gY29uc3RyYWludCB2YWxpZGF0 aW9uCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRvci5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0b3IuY3BwCShyZXZpc2lvbiAxMTUzNTYpCisr KyBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRvci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEz NTksNyArMTM1OSw3IEBAIHZvaWQgRWRpdG9yOjpzZXRDb21wb3NpdGlvbihjb25zdCBTdHJpbmcK IAogICAgIC8vIElmIHRleHQgaXMgZW1wdHksIHRoZW4gZGVsZXRlIHRoZSBvbGQgY29tcG9zaXRp b24gaGVyZS4gIElmIHRleHQgaXMgbm9uLWVtcHR5LCBJbnNlcnRUZXh0Q29tbWFuZDo6aW5wdXQK ICAgICAvLyB3aWxsIGRlbGV0ZSB0aGUgb2xkIGNvbXBvc2l0aW9uIHdpdGggYW4gb3B0aW1pemVk IHJlcGxhY2Ugb3BlcmF0aW9uLgotICAgIGlmICh0ZXh0LmlzRW1wdHkoKSkKKyAgICBpZiAodGV4 dC5pc0VtcHR5KCkgJiYgbW9kZSAhPSBDYW5jZWxDb21wb3NpdGlvbikKICAgICAgICAgVHlwaW5n Q29tbWFuZDo6ZGVsZXRlU2VsZWN0aW9uKG1fZnJhbWUtPmRvY3VtZW50KCksIDApOwogCiAgICAg bV9jb21wb3NpdGlvbk5vZGUgPSAwOwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMTE1NDA3KQorKysgTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTIt MDQtMjYgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUkVHUkVT U0lPTiAocjk0NDk3KTogUHJlc3NpbmcgQ29tbWFuZCtBIHdoZW4gaW5saW5lIChNYXJrZWQgVGV4 dCkgaXMgbm90IGVtcHR5IHdpbGwgY2xlYW4gd2hvbGUgY29udGVudAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODQ1MDEKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSByZWdyZXNzaW9uIHRlc3QgZm9y IHNlbGVjdGluZyBhbGwgd2hlbiB0aGVyZSBpcyBhIGNvbXBvc2l0aW9uIHRleHQuCisKKyAgICAg ICAgKiBlZGl0aW5nL3NlbGVjdGlvbi9zZWxlY3QtYWxsLWNsZWFyLWlucHV0LW1ldGhvZC1leHBl Y3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGVkaXRpbmcvc2VsZWN0aW9uL3NlbGVjdC1hbGwt Y2xlYXItaW5wdXQtbWV0aG9kLmh0bWw6IEFkZGVkLgorCiAyMDEyLTA0LTI2ICBLZWlzaGkgSGF0 dG9yaSAgPGtlaXNoaUB3ZWJraXQub3JnPgogCiAgICAgICAgIGRhdGFsaXN0OiBGb3JtIGNvbnRy b2wgaW4gYSA8ZGF0YWxpc3Q+IHNob3VsZCBiZSBiYXJyZWQgZnJvbSBjb25zdHJhaW50IHZhbGlk YXRpb24KSW5kZXg6IExheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL3NlbGVjdC1hbGwtY2xl YXItaW5wdXQtbWV0aG9kLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9l ZGl0aW5nL3NlbGVjdGlvbi9zZWxlY3QtYWxsLWNsZWFyLWlucHV0LW1ldGhvZC1leHBlY3RlZC50 eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9zZWxlY3Qt YWxsLWNsZWFyLWlucHV0LW1ldGhvZC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAg KzEsNiBAQAorVGhpcyB0ZXN0cyBzZWxlY3RpbmcgYWxsIHdpdGggYW4gb3BlbiBpbnB1dCBtZXRo b2QgY29tcG9zaXRpb24uCitUbyBtYW51YWxseSB0ZXN0LCB0eXBlIHNvbWUgbGV0dGVyIGluIHRo ZSBlZGl0YWJsZSByZWdpb24gYmVsb3cgYW5kIHRoZW4gc2VsZWN0IGFsbC4KK1dlYktpdCBzaG91 bGQgbm90IGRlbGV0ZSBjb250ZW50cy4KK3wgPGRpdj4KK3wgICBjb250ZW50ZWRpdGFibGU9IiIK K3wgICAiPCNzZWxlY3Rpb24tYW5jaG9yPlBBU1M8I3NlbGVjdGlvbi1mb2N1cz4iCkluZGV4OiBM YXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9zZWxlY3QtYWxsLWNsZWFyLWlucHV0LW1ldGhv ZC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL3NlbGVj dC1hbGwtY2xlYXItaW5wdXQtbWV0aG9kLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0 cy9lZGl0aW5nL3NlbGVjdGlvbi9zZWxlY3QtYWxsLWNsZWFyLWlucHV0LW1ldGhvZC5odG1sCShy ZXZpc2lvbiAwKQpAQCAtMCwwICsxLDI4IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGJv ZHk+Cis8cD5UaGlzIHRlc3RzIHNlbGVjdGluZyBhbGwgd2l0aCBhbiBvcGVuIGlucHV0IG1ldGhv ZCBjb21wb3NpdGlvbi4KK1RvIG1hbnVhbGx5IHRlc3QsIHR5cGUgc29tZSBsZXR0ZXIgaW4gdGhl IGVkaXRhYmxlIHJlZ2lvbiBiZWxvdyBhbmQgdGhlbiBzZWxlY3QgYWxsLgorV2ViS2l0IHNob3Vs ZCBub3QgZGVsZXRlIGNvbnRlbnRzLjwvcD4KKzxkaXYgaWQ9ImNvbnRhaW5lciI+PGRpdiBjb250 ZW50ZWRpdGFibGU+UEFTPC9kaXY+PC9kaXY+Cis8c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2Vz L2R1bXAtYXMtbWFya3VwLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQ+CisKK2lmICh3aW5kb3cubGF5 b3V0VGVzdENvbnRyb2xsZXIpIHsKKyAgICB2YXIgY29udGFpbmVyID0gZG9jdW1lbnQuZ2V0RWxl bWVudEJ5SWQoJ2NvbnRhaW5lcicpOworICAgIGNvbnRhaW5lci5maXJzdENoaWxkLmZvY3VzKCk7 CisgICAgZ2V0U2VsZWN0aW9uKCkuc2V0UG9zaXRpb24oY29udGFpbmVyLmZpcnN0Q2hpbGQuZmly c3RDaGlsZCwgNSk7CisgICAgaWYgKHdpbmRvdy50ZXh0SW5wdXRDb250cm9sbGVyKSB7CisgICAg ICAgIE1hcmt1cC5kZXNjcmlwdGlvbihkb2N1bWVudC5nZXRFbGVtZW50c0J5VGFnTmFtZSgncCcp WzBdLnRleHRDb250ZW50KTsKKworICAgICAgICB0ZXh0SW5wdXRDb250cm9sbGVyLnNldE1hcmtl ZFRleHQoIlMiLCAwLCAxKTsKKyAgICAgICAgZG9jdW1lbnQuZXhlY0NvbW1hbmQoJ3NlbGVjdEFs bCcsIGZhbHNlLCBudWxsKTsKKworICAgICAgICBNYXJrdXAuZHVtcChjb250YWluZXIpOworICAg IH0gZWxzZQorICAgICAgICBNYXJrdXAuZGVzY3JpcHRpb24oJ0ZBSUwgLSBUaGlzIHRlc3QgcmVx dWlyZXMgdGV4dElucHV0Q29udHJvbGxlcicpOworfQorCis8L3NjcmlwdD4KKzwvYm9keT4KKzwv aHRtbD4K