84500 2012-04-20 15:14:11 -0700 [chromium] Very minor tweak to DomStorage v8 bindings would be nice. 2012-04-20 18:03:12 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 michaeln michaeln abarth haraken japhet webkit.review.bot oldest_to_newest 606947 0 michaeln 2012-04-20 15:14:11 -0700 See patch for details. 606954 1 138177 michaeln 2012-04-20 15:19:56 -0700 Created attachment 138177 tweak 606961 2 138177 haraken 2012-04-20 15:24:45 -0700 Comment on attachment 138177 tweak OK. Though it would be better if you could show some performance improvement data in ChangeLog (artificial benchmark is fine). 607115 3 138177 webkit.review.bot 2012-04-20 18:03:08 -0700 Comment on attachment 138177 tweak Clearing flags on attachment: 138177 Committed r114814: <http://trac.webkit.org/changeset/114814> 607116 4 webkit.review.bot 2012-04-20 18:03:12 -0700 All reviewed patches have been landed. Closing bug. 138177 2012-04-20 15:19:56 -0700 2012-04-20 18:03:08 -0700 tweak tweak.txt text/plain 1903 michaeln SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNDc4NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA0LTIwICBNaWNoYWVs IE5vcmRtYW4gIDxtaWNoYWVsbkBnb29nbGUuY29tPgorCisgICAgICAgIFtjaHJvbWl1bV0gVGlu eSBjaGFuZ2UgdG8gRG9tU3RvcmFnZSB2OCBiaW5kaW5ncyB0byBhdm9pZCBhIHJlbGF0aXZlbHkg ZXhwZW5zaXZlIHRlc3QgaW4gYSBjb3VwbGUKKyAgICAgICAgb2YgcGxhY2VzIGJ5IHJlb3JkZXJp bmcgdGhlIGV4cHJlc3Npb25zIGluIGNvbXBvdW5kIGNvbmRpdGlvbnMsIGlmIChmYXN0VGVzdCAm JiBtb3JlRXhwZW5zaXZlVGVzdCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTg0NTAwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBuZXcgZnVuY3Rpb25hbGl0eS4KKworICAgICAg ICAqIGJpbmRpbmdzL3Y4L2N1c3RvbS9WOFN0b3JhZ2VDdXN0b20uY3BwOgorICAgICAgICAoV2Vi Q29yZTo6c3RvcmFnZUdldHRlcik6CisgICAgICAgIChXZWJDb3JlOjpWOFN0b3JhZ2U6Om5hbWVk UHJvcGVydHlRdWVyeSk6CisKIDIwMTItMDQtMjAgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxl LmNvbT4KIAogICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTA3ODYwMDA+IFNlbGVjdGlvbiBoaWdo bGlnaHRzIG9mIGxpbmVzIGluIGFkam9pbmluZyBibG9ja3MgY2FuIG92ZXJsYXAKSW5kZXg6IFNv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOFN0b3JhZ2VDdXN0b20uY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOFN0b3JhZ2VDdXN0 b20uY3BwCShyZXZpc2lvbiAxMTQ3NzcpCisrKyBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9j dXN0b20vVjhTdG9yYWdlQ3VzdG9tLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTgsNyArNTgsNyBA QCBzdGF0aWMgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IHN0b3JhZ2VHZXR0CiAgICAgU3RvcmFnZSog c3RvcmFnZSA9IFY4U3RvcmFnZTo6dG9OYXRpdmUoaW5mby5Ib2xkZXIoKSk7CiAgICAgU3RyaW5n IG5hbWUgPSB0b1dlYkNvcmVTdHJpbmcodjhOYW1lKTsKIAotICAgIGlmIChzdG9yYWdlLT5jb250 YWlucyhuYW1lKSAmJiBuYW1lICE9ICJsZW5ndGgiKQorICAgIGlmIChuYW1lICE9ICJsZW5ndGgi ICYmIHN0b3JhZ2UtPmNvbnRhaW5zKG5hbWUpKQogICAgICAgICByZXR1cm4gdjhTdHJpbmcoc3Rv cmFnZS0+Z2V0SXRlbShuYW1lKSk7CiAKICAgICByZXR1cm4gbm90SGFuZGxlZEJ5SW50ZXJjZXB0 b3IoKTsKQEAgLTg2LDcgKzg2LDcgQEAgdjg6OkhhbmRsZTx2ODo6SW50ZWdlcj4gVjhTdG9yYWdl OjpuYW1lZAogICAgIFN0b3JhZ2UqIHN0b3JhZ2UgPSBWOFN0b3JhZ2U6OnRvTmF0aXZlKGluZm8u SG9sZGVyKCkpOwogICAgIFN0cmluZyBuYW1lID0gdG9XZWJDb3JlU3RyaW5nKHY4TmFtZSk7CiAK LSAgICBpZiAoc3RvcmFnZS0+Y29udGFpbnMobmFtZSkgJiYgbmFtZSAhPSAibGVuZ3RoIikKKyAg ICBpZiAobmFtZSAhPSAibGVuZ3RoIiAmJiBzdG9yYWdlLT5jb250YWlucyhuYW1lKSkKICAgICAg ICAgcmV0dXJuIHY4OjpJbnRlZ2VyOjpOZXcodjg6Ok5vbmUpOwogCiAgICAgcmV0dXJuIHY4OjpI YW5kbGU8djg6OkludGVnZXI+KCk7Cg==