84476 2012-04-20 12:09:18 -0700 JSGarbageCollect should not call collectAllGarbage() 2012-04-20 12:36:28 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg oldest_to_newest 606788 0 mhahnenberg 2012-04-20 12:09:18 -0700 JSGarbageCollect should not synchronously call collectAllGarbage(). Instead, it should notify the GCActivityCallback that it has abandoned an object graph, which will set the timer to run at some point in the future that JSC can decide according to its own policies. 606790 1 138139 mhahnenberg 2012-04-20 12:11:25 -0700 Created attachment 138139 Patch 606796 2 138139 ggaren 2012-04-20 12:17:14 -0700 Comment on attachment 138139 Patch Let's fix the FIXME by taking advantage of our new callback, like so: - Cancel the GC timer at the start of collection (rename didCollect to willCollect) - If collection causes a didAbandonObjectGraph, it can now start the timer, which will, in fact, cause another collection later. In the same patch, you can remove the isBusy() check, since didAbandonObjectGraph is safe to call while the heap is busy. 606813 3 mhahnenberg 2012-04-20 12:36:28 -0700 Committed r114771: <http://trac.webkit.org/changeset/114771> 138139 2012-04-20 12:11:25 -0700 2012-04-20 12:21:13 -0700 Patch bug-84476-20120420121124.patch text/plain 1329 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTE0NzY5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDEyLTA0LTIwICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgSlNHYXJiYWdlQ29sbGVjdCBzaG91bGQgbm90IGNhbGwgY29sbGVjdEFsbEdhcmJh Z2UoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODQ0 NzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEFQ SS9KU0Jhc2UuY3BwOgorICAgICAgICAoSlNHYXJiYWdlQ29sbGVjdCk6IE5vdGlmeSB0aGUgSGVh cCdzIEdDQWN0aXZpdHlDYWxsYmFjayB1c2luZyBkaWRBYmFuZG9uT2JqZWN0R3JhcGguCisKIDIw MTItMDQtMTkgIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBFeGNl cHRpb24gc3RhY2sgdHJhY2VzIGFyZW4ndCBjb21wbGV0ZSB3aGVuIHRoZSBleGNlcHRpb24gc3Rh cnRzIGluIG5hdGl2ZSBjb2RlCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTQmFz ZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU0Jhc2UuY3Bw CShyZXZpc2lvbiAxMTQ3NjUpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTQmFzZS5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTEwMiw3ICsxMDIsNyBAQCB2b2lkIEpTR2FyYmFnZUNvbGxl Y3QoSlNDb250ZXh0UmVmIGN0eCkKIAogICAgIEpTR2xvYmFsRGF0YSYgZ2xvYmFsRGF0YSA9IGV4 ZWMtPmdsb2JhbERhdGEoKTsKICAgICBpZiAoIWdsb2JhbERhdGEuaGVhcC5pc0J1c3koKSkKLSAg ICAgICAgZ2xvYmFsRGF0YS5oZWFwLmNvbGxlY3RBbGxHYXJiYWdlKCk7CisgICAgICAgIGdsb2Jh bERhdGEuaGVhcC5hY3Rpdml0eUNhbGxiYWNrKCktPmRpZEFiYW5kb25PYmplY3RHcmFwaCgpOwog CiAgICAgLy8gRklYTUU6IFBlcmhhcHMgd2Ugc2hvdWxkIHRyaWdnZXIgYSBzZWNvbmQgbWFyayBh bmQgc3dlZXAKICAgICAvLyBvbmNlIHRoZSBnYXJiYWdlIGNvbGxlY3RvciBpcyBkb25lIGlmIHRo aXMgaXMgY2FsbGVkIHdoZW4K