84472 2012-04-20 11:24:36 -0700 Fix use of LayoutUnits in DOMNodeHighlighter 2012-04-20 13:22:41 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60318 1 eae eae eric leviw pfeldman wangxianzhu webkit.review.bot oldest_to_newest 606732 0 eae 2012-04-20 11:24:36 -0700 Bug 84181 added a bunch of new logic to DOMNodeHighlighter that doesn't use the right unit types. 606741 1 138127 eae 2012-04-20 11:34:25 -0700 Created attachment 138127 Patch 606763 2 wangxianzhu 2012-04-20 11:53:18 -0700 Thanks Emil. Sorry I thought the methods accept LayoutUnits without checking. Will they be changed to LayoutUnits in the future? 606765 3 eae 2012-04-20 11:54:46 -0700 (In reply to comment #2) > Thanks Emil. Sorry I thought the methods accept LayoutUnits without checking. Will they be changed to LayoutUnits in the future? No worries. They might be, in the medium term they'll stay int based to line up with device pixels. Thanks for asking. 606851 4 138127 webkit.review.bot 2012-04-20 13:22:24 -0700 Comment on attachment 138127 Patch Clearing flags on attachment: 138127 Committed r114775: <http://trac.webkit.org/changeset/114775> 606852 5 webkit.review.bot 2012-04-20 13:22:41 -0700 All reviewed patches have been landed. Closing bug. 138127 2012-04-20 11:34:25 -0700 2012-04-20 13:22:23 -0700 Patch bug-84472-20120420113423.patch text/plain 2364 eae SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNDc2NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA0LTIwICBFbWlsIEEg RWtsdW5kICA8ZWFlQGNocm9taXVtLm9yZz4KKworICAgICAgICBGaXggdXNlIG9mIExheW91dFVu aXRzIGluIERPTU5vZGVIaWdobGlnaHRlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9ODQ0NzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBGaXggdXNlIG9mIHN1YnBpeGVsIHVuaXRzIGFuZCByb3VuZGluZyBp biBuZXcgY29kZSBpbnRyb2R1Y2VkIGluIHIxMTQ2NTkuCisKKyAgICAgICAgTm8gbmV3IHRlc3Rz LCBubyBjaGFuZ2UgaW4gZnVuY3Rpb25hbGl0eS4KKworICAgICAgICAqIGluc3BlY3Rvci9ET01O b2RlSGlnaGxpZ2h0ZXIuY3BwOgorCiAyMDEyLTA0LTIwICBFbWlsIEEgRWtsdW5kICA8ZWFlQGNo cm9taXVtLm9yZz4KIAogICAgICAgICBbd2luXSBVcGRhdGUgd2luZG93cyBwbGF0Zm9ybSBjb2Rl IHRvIHVzZSBwaXhlbCBzbmFwcGVkIHZhbHVlcwpJbmRleDogU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL0RPTU5vZGVIaWdobGlnaHRlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv aW5zcGVjdG9yL0RPTU5vZGVIaWdobGlnaHRlci5jcHAJKHJldmlzaW9uIDExNDc1OCkKKysrIFNv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9ET01Ob2RlSGlnaGxpZ2h0ZXIuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0zNTUsMTAgKzM1NSwxMCBAQCB2b2lkIGRyYXdFbGVtZW50VGl0bGUoR3JhcGhpY3ND b250ZXh0JiBjCiAKIHN0YXRpYyB2b2lkIGNvbnRlbnRzUXVhZFRvUm9vdFZpZXcoRmxvYXRRdWFk JiBxdWFkLCBGcmFtZVZpZXcqIHZpZXcpCiB7Ci0gICAgcXVhZC5zZXRQMSh2aWV3LT5jb250ZW50 c1RvUm9vdFZpZXcocm91bmRlZExheW91dFBvaW50KHF1YWQucDEoKSkpKTsKLSAgICBxdWFkLnNl dFAyKHZpZXctPmNvbnRlbnRzVG9Sb290Vmlldyhyb3VuZGVkTGF5b3V0UG9pbnQocXVhZC5wMigp KSkpOwotICAgIHF1YWQuc2V0UDModmlldy0+Y29udGVudHNUb1Jvb3RWaWV3KHJvdW5kZWRMYXlv dXRQb2ludChxdWFkLnAzKCkpKSk7Ci0gICAgcXVhZC5zZXRQNCh2aWV3LT5jb250ZW50c1RvUm9v dFZpZXcocm91bmRlZExheW91dFBvaW50KHF1YWQucDQoKSkpKTsKKyAgICBxdWFkLnNldFAxKHZp ZXctPmNvbnRlbnRzVG9Sb290Vmlldyhyb3VuZGVkSW50UG9pbnQocXVhZC5wMSgpKSkpOworICAg IHF1YWQuc2V0UDIodmlldy0+Y29udGVudHNUb1Jvb3RWaWV3KHJvdW5kZWRJbnRQb2ludChxdWFk LnAyKCkpKSk7CisgICAgcXVhZC5zZXRQMyh2aWV3LT5jb250ZW50c1RvUm9vdFZpZXcocm91bmRl ZEludFBvaW50KHF1YWQucDMoKSkpKTsKKyAgICBxdWFkLnNldFA0KHZpZXctPmNvbnRlbnRzVG9S b290Vmlldyhyb3VuZGVkSW50UG9pbnQocXVhZC5wNCgpKSkpOwogfQogCiBzdGF0aWMgdm9pZCBn ZXRPckRyYXdOb2RlSGlnaGxpZ2h0KEdyYXBoaWNzQ29udGV4dCogY29udGV4dCwgSGlnaGxpZ2h0 RGF0YSogaGlnaGxpZ2h0RGF0YSwgSGlnaGxpZ2h0KiBoaWdobGlnaHQpCkBAIC00NTcsNyArNDU3 LDcgQEAgc3RhdGljIHZvaWQgZ2V0T3JEcmF3Tm9kZUhpZ2hsaWdodChHcmFwaAogICAgICAgICBy ZXR1cm47CiAKICAgICBpZiAoY29udGV4dCAmJiBoaWdobGlnaHREYXRhLT5zaG93SW5mbykKLSAg ICAgICAgZHJhd0VsZW1lbnRUaXRsZSgqY29udGV4dCwgbm9kZSwgcmVuZGVyZXIsIGJvdW5kaW5n Qm94LCB0aXRsZUFuY2hvckJveCwgdmlzaWJsZVJlY3QsIGNvbnRhaW5pbmdGcmFtZS0+c2V0dGlu Z3MoKSk7CisgICAgICAgIGRyYXdFbGVtZW50VGl0bGUoKmNvbnRleHQsIG5vZGUsIHJlbmRlcmVy LCBwaXhlbFNuYXBwZWRJbnRSZWN0KGJvdW5kaW5nQm94KSwgcGl4ZWxTbmFwcGVkSW50UmVjdCh0 aXRsZUFuY2hvckJveCksIHZpc2libGVSZWN0LCBjb250YWluaW5nRnJhbWUtPnNldHRpbmdzKCkp OwogfQogCiBzdGF0aWMgdm9pZCBnZXRPckRyYXdSZWN0SGlnaGxpZ2h0KEdyYXBoaWNzQ29udGV4 dCogY29udGV4dCwgRG9jdW1lbnQqIGRvY3VtZW50LCBIaWdobGlnaHREYXRhKiBoaWdobGlnaHRE YXRhLCBIaWdobGlnaHQgKmhpZ2hsaWdodCkK