84470 2012-04-20 11:03:24 -0700 Avoid synchronously recalculating the nonFastScrollableRegion when the ScrollableArea set changes 2012-04-20 14:18:23 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jamesr jamesr andersca tonikitoo webkit.review.bot oldest_to_newest 606715 0 jamesr 2012-04-20 11:03:24 -0700 Avoid synchronously recalculating the nonFastScrollableRegion when the ScrollableArea set changes 606718 1 138120 jamesr 2012-04-20 11:05:38 -0700 Created attachment 138120 Patch 606719 2 jamesr 2012-04-20 11:05:59 -0700 I can probably construct a layout test for this too (but it'll be a bit convoluted) 606896 3 138120 webkit.review.bot 2012-04-20 14:18:12 -0700 Comment on attachment 138120 Patch Clearing flags on attachment: 138120 Committed r114778: <http://trac.webkit.org/changeset/114778> 606898 4 webkit.review.bot 2012-04-20 14:18:23 -0700 All reviewed patches have been landed. Closing bug. 138120 2012-04-20 11:05:38 -0700 2012-04-20 14:18:12 -0700 Patch bug-84470-20120420110537.patch text/plain 6116 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0NzAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTlhZjYyOWI1OWYxYzFk M2Q0YTc0OTM4ODRlYmRhMTAwZDQ3MTZhMi4uZDYwYzBjOTc0OTBmZGY4MWNmMGQwMTA4ZWMyOTA5 YWM3ZGEzMDMwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA0LTIwICBKYW1l cyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgQXZvaWQgc3luY2hy b25vdXNseSByZWNhbGN1bGF0aW5nIHRoZSBub25GYXN0U2Nyb2xsYWJsZVJlZ2lvbiB3aGVuIHRo ZSBTY3JvbGxhYmxlQXJlYSBzZXQgY2hhbmdlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODQ0NzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXaGVuIGEgc2Nyb2xsYWJsZSBhcmVhIGlzIGFkZGVkIG9yIHJl bW92ZWQsIHdlIHNob3VsZG4ndCByZWNhbGN1bGF0ZSB0aGUgbm9uRmFzdFNjcm9sbGFibGVSZWdp b24gc3luY2hyb25vdXNseQorICAgICAgICBzaW5jZSB0aGlzIGlzIHNsb3csIHRoZSBSZW5kZXJP YmplY3QgdHJlZSBtaWdodCBub3QgYmUgaW4gYW4gdXAtdG8tZGF0ZSBzdGF0ZSwgYW5kIHdlJ2xs IHR5cGljYWxseSBkbyBsYXlvdXQKKyAgICAgICAgc29vbiBhbnl3YXkuCisKKyAgICAgICAgKiBw YWdlL0ZyYW1lVmlldy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZVZpZXc6OmFkZFNjcm9s bGFibGVBcmVhKToKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lVmlldzo6cmVtb3ZlU2Nyb2xsYWJs ZUFyZWEpOgorICAgICAgICAqIHBhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ0Nvb3JkaW5hdG9yLmNw cDoKKyAgICAgICAgKiBwYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdDb29yZGluYXRvci5oOgorICAg ICAgICAoU2Nyb2xsaW5nQ29vcmRpbmF0b3IpOgorCiAyMDEyLTA0LTE5ICBBbmRyZWFzIEtsaW5n ICA8a2xpbmdAd2Via2l0Lm9yZz4KIAogICAgICAgICBFbGVtZW50QXR0cmlidXRlRGF0YSBzaG91 bGQgYmUgZmFzdC1tYWxsb2MnZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggNjA3NWZm ZWE1MmVlZWFmYTJjZGVmY2UzOGM4MmZlYWUxMTAzN2I5OS4uNzdlZTdjZGJlYTg3OTdmMWRlMjQ1 ZTBmOWExMDM0MGNlNDg4MDc3OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9D aGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxNyBAQAorMjAxMi0wNC0yMCAgSmFtZXMgUm9iaW5zb24gIDxqYW1lc3JAY2hyb21pdW0ub3Jn PgorCisgICAgICAgIEF2b2lkIHN5bmNocm9ub3VzbHkgcmVjYWxjdWxhdGluZyB0aGUgbm9uRmFz dFNjcm9sbGFibGVSZWdpb24gd2hlbiB0aGUgU2Nyb2xsYWJsZUFyZWEgc2V0IGNoYW5nZXMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg0NDcwCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVHJpZ2dlciBhIGxh eW91dCB3aGVuIGEgcGx1Z2luIGJlY29tZXMgb3Igc3RvcHMgYmVpbmcgc2Nyb2xsYWJsZSBzbyB0 aGUgbm9uRmFzdFNjcm9sbGFibGVSZWdpb24KKyAgICAgICAgY2FuIGJlIHVwZGF0ZWQuCisKKyAg ICAgICAgKiBzcmMvU2Nyb2xsYmFyR3JvdXAuY3BwOgorICAgICAgICAoV2ViS2l0OjpTY3JvbGxi YXJHcm91cDo6c2Nyb2xsYmFyQ3JlYXRlZCk6CisgICAgICAgIChXZWJLaXQ6OlNjcm9sbGJhckdy b3VwOjpzY3JvbGxiYXJEZXN0cm95ZWQpOgorCiAyMDEyLTA0LTE5ICBBbmRyZWFzIEtsaW5nICA8 a2xpbmdAd2Via2l0Lm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIEFkZCBzaW1wbGlmaWVkIEFQ SSBmb3IgaXRlcmF0aW5nIG92ZXIgYSBXZWJFbGVtZW50J3MgYXR0cmlidXRlcy4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Bh Z2UvRnJhbWVWaWV3LmNwcAppbmRleCAwM2FmOTRmMGVmNGU0NzdhN2NlNjgwNzc3YTA3YTIxZDE1 OWI2N2FmLi4wN2Y5YmNhZTJkYWYyYThiZmRmNzE3Y2I5ZmIyZDAxN2IwM2VmMGY2IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGFnZS9GcmFtZVZpZXcuY3BwCkBAIC0zNDc4LDExICszNDc4LDYgQEAgdm9pZCBGcmFtZVZp ZXc6OmFkZFNjcm9sbGFibGVBcmVhKFNjcm9sbGFibGVBcmVhKiBzY3JvbGxhYmxlQXJlYSkKICAg ICBpZiAoIW1fc2Nyb2xsYWJsZUFyZWFzKQogICAgICAgICBtX3Njcm9sbGFibGVBcmVhcyA9IGFk b3B0UHRyKG5ldyBTY3JvbGxhYmxlQXJlYVNldCk7CiAgICAgbV9zY3JvbGxhYmxlQXJlYXMtPmFk ZChzY3JvbGxhYmxlQXJlYSk7Ci0KLSAgICBpZiAoUGFnZSogcGFnZSA9IG1fZnJhbWUtPnBhZ2Uo KSkgewotICAgICAgICBpZiAoU2Nyb2xsaW5nQ29vcmRpbmF0b3IqIHNjcm9sbGluZ0Nvb3JkaW5h dG9yID0gcGFnZS0+c2Nyb2xsaW5nQ29vcmRpbmF0b3IoKSkKLSAgICAgICAgICAgIHNjcm9sbGlu Z0Nvb3JkaW5hdG9yLT5mcmFtZVZpZXdTY3JvbGxhYmxlQXJlYXNEaWRDaGFuZ2UodGhpcyk7Ci0g ICAgfQogfQogCiB2b2lkIEZyYW1lVmlldzo6cmVtb3ZlU2Nyb2xsYWJsZUFyZWEoU2Nyb2xsYWJs ZUFyZWEqIHNjcm9sbGFibGVBcmVhKQpAQCAtMzQ5MCwxMSArMzQ4NSw2IEBAIHZvaWQgRnJhbWVW aWV3OjpyZW1vdmVTY3JvbGxhYmxlQXJlYShTY3JvbGxhYmxlQXJlYSogc2Nyb2xsYWJsZUFyZWEp CiAgICAgaWYgKCFtX3Njcm9sbGFibGVBcmVhcykKICAgICAgICAgcmV0dXJuOwogICAgIG1fc2Ny b2xsYWJsZUFyZWFzLT5yZW1vdmUoc2Nyb2xsYWJsZUFyZWEpOwotCi0gICAgaWYgKFBhZ2UqIHBh Z2UgPSBtX2ZyYW1lLT5wYWdlKCkpIHsKLSAgICAgICAgaWYgKFNjcm9sbGluZ0Nvb3JkaW5hdG9y KiBzY3JvbGxpbmdDb29yZGluYXRvciA9IHBhZ2UtPnNjcm9sbGluZ0Nvb3JkaW5hdG9yKCkpCi0g ICAgICAgICAgICBzY3JvbGxpbmdDb29yZGluYXRvci0+ZnJhbWVWaWV3U2Nyb2xsYWJsZUFyZWFz RGlkQ2hhbmdlKHRoaXMpOwotICAgIH0KIH0KIAogYm9vbCBGcmFtZVZpZXc6OmNvbnRhaW5zU2Ny b2xsYWJsZUFyZWEoU2Nyb2xsYWJsZUFyZWEqIHNjcm9sbGFibGVBcmVhKSBjb25zdApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nQ29vcmRpbmF0b3Iu Y3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nQ29vcmRpbmF0b3Iu Y3BwCmluZGV4IDlhNjZhY2E4YzExYWI5YmMzZTQzMjdmZjY2MTBmMjgzYzRjNTg1MjYuLjkwNzU0 ZjU1MTY1YWMzZWVjYzYwYjMzYWIyNGRjNDQ4MDQxNTljMTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ0Nvb3JkaW5hdG9yLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdDb29yZGluYXRvci5jcHAKQEAgLTE1 NiwxNSArMTU2LDYgQEAgdm9pZCBTY3JvbGxpbmdDb29yZGluYXRvcjo6ZnJhbWVWaWV3TGF5b3V0 VXBkYXRlZChGcmFtZVZpZXcqIGZyYW1lVmlldykKIAogfQogCi12b2lkIFNjcm9sbGluZ0Nvb3Jk aW5hdG9yOjpmcmFtZVZpZXdTY3JvbGxhYmxlQXJlYXNEaWRDaGFuZ2UoRnJhbWVWaWV3KikKLXsK LSAgICBBU1NFUlQoaXNNYWluVGhyZWFkKCkpOwotICAgIEFTU0VSVChtX3BhZ2UpOwotCi0gICAg UmVnaW9uIG5vbkZhc3RTY3JvbGxhYmxlUmVnaW9uID0gY29tcHV0ZU5vbkZhc3RTY3JvbGxhYmxl UmVnaW9uKG1fcGFnZS0+bWFpbkZyYW1lKCktPnZpZXcoKSk7Ci0gICAgc2V0Tm9uRmFzdFNjcm9s bGFibGVSZWdpb24obm9uRmFzdFNjcm9sbGFibGVSZWdpb24pOwotfQotCiB2b2lkIFNjcm9sbGlu Z0Nvb3JkaW5hdG9yOjpmcmFtZVZpZXdXaGVlbEV2ZW50SGFuZGxlckNvdW50Q2hhbmdlZChGcmFt ZVZpZXcqKQogewogICAgIEFTU0VSVChpc01haW5UaHJlYWQoKSk7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdDb29yZGluYXRvci5oIGIvU291cmNl L1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nQ29vcmRpbmF0b3IuaAppbmRleCAzZDAz NDIwYjI2M2E3M2I1NDQxNTdiYWQwNjQyYWY3NjExOTJlMTljLi40YTIyMzJkMjRkY2ZhMzE4MDNi NDMzZDc0YTAyZTQyZGRhNThjOGYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Nj cm9sbGluZy9TY3JvbGxpbmdDb29yZGluYXRvci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv c2Nyb2xsaW5nL1Njcm9sbGluZ0Nvb3JkaW5hdG9yLmgKQEAgLTcyLDkgKzcyLDYgQEAgcHVibGlj OgogICAgIC8vIFNob3VsZCBiZSBjYWxsZWQgd2hlbmV2ZXIgdGhlIGdpdmVuIGZyYW1lIHZpZXcg aGFzIGJlZW4gbGFpZCBvdXQuCiAgICAgdm9pZCBmcmFtZVZpZXdMYXlvdXRVcGRhdGVkKEZyYW1l VmlldyopOwogCi0gICAgLy8gU2hvdWxkIGJlIGNhbGxlZCB3aGVuZXZlciB0aGUgc2V0IG9mIFNj cm9sbGFibGVBcmVhcyBpbnNpZGUgYSBGcmFtZVZpZXcgY2hhbmdlcy4KLSAgICB2b2lkIGZyYW1l Vmlld1Njcm9sbGFibGVBcmVhc0RpZENoYW5nZShGcmFtZVZpZXcqKTsKLQogICAgIC8vIFNob3Vs ZCBiZSBjYWxsZWQgd2hlbmV2ZXIgYSB3aGVlbCBldmVudCBoYW5kbGVyIGlzIGFkZGVkIG9yIHJl bW92ZWQgaW4gdGhlIAogICAgIC8vIGZyYW1lIHZpZXcncyB1bmRlcmx5aW5nIGRvY3VtZW50Lgog ICAgIHZvaWQgZnJhbWVWaWV3V2hlZWxFdmVudEhhbmRsZXJDb3VudENoYW5nZWQoRnJhbWVWaWV3 Kik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9TY3JvbGxiYXJHcm91 cC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9TY3JvbGxiYXJHcm91cC5jcHAKaW5k ZXggYzQ4ZGIzZDliYTVmNzY1M2VlNTY2MzBiMDU5N2NmN2RkYWE1NWI0OS4uMTlmZGJhZGU0MDA0 NWIxZTVlOGM0MTFjZmIzYjQ4YzM4YzE5NGEzNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9j aHJvbWl1bS9zcmMvU2Nyb2xsYmFyR3JvdXAuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vc3JjL1Njcm9sbGJhckdyb3VwLmNwcApAQCAtNjMsOCArNjMsMTAgQEAgdm9pZCBTY3JvbGxi YXJHcm91cDo6c2Nyb2xsYmFyQ3JlYXRlZChXZWJTY3JvbGxiYXJJbXBsKiBzY3JvbGxiYXIpCiAg ICAgICAgIGRpZEFkZFZlcnRpY2FsU2Nyb2xsYmFyKHNjcm9sbGJhci0+c2Nyb2xsYmFyKCkpOwog ICAgIH0KIAotICAgIGlmICghaGFkU2Nyb2xsYmFycykKKyAgICBpZiAoIWhhZFNjcm9sbGJhcnMp IHsKICAgICAgICAgbV9mcmFtZVZpZXctPmFkZFNjcm9sbGFibGVBcmVhKHRoaXMpOworICAgICAg ICBtX2ZyYW1lVmlldy0+c2V0TmVlZHNMYXlvdXQoKTsKKyAgICB9CiB9CiAKIHZvaWQgU2Nyb2xs YmFyR3JvdXA6OnNjcm9sbGJhckRlc3Ryb3llZChXZWJTY3JvbGxiYXJJbXBsKiBzY3JvbGxiYXIp CkBAIC03OCw4ICs4MCwxMCBAQCB2b2lkIFNjcm9sbGJhckdyb3VwOjpzY3JvbGxiYXJEZXN0cm95 ZWQoV2ViU2Nyb2xsYmFySW1wbCogc2Nyb2xsYmFyKQogICAgICAgICBtX3ZlcnRpY2FsU2Nyb2xs YmFyID0gMDsKICAgICB9CiAKLSAgICBpZiAoIW1faG9yaXpvbnRhbFNjcm9sbGJhciAmJiAhbV92 ZXJ0aWNhbFNjcm9sbGJhcikKKyAgICBpZiAoIW1faG9yaXpvbnRhbFNjcm9sbGJhciAmJiAhbV92 ZXJ0aWNhbFNjcm9sbGJhcikgewogICAgICAgICBtX2ZyYW1lVmlldy0+cmVtb3ZlU2Nyb2xsYWJs ZUFyZWEodGhpcyk7CisgICAgICAgIG1fZnJhbWVWaWV3LT5zZXROZWVkc0xheW91dCgpOworICAg IH0KIH0KIAogdm9pZCBTY3JvbGxiYXJHcm91cDo6c2V0TGFzdE1vdXNlUG9zaXRpb24oY29uc3Qg SW50UG9pbnQmIHBvaW50KQo=