84455 2012-04-20 08:20:06 -0700 [chromium] Don't crash when scrolling empty layer tree 2012-04-20 10:53:37 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 skyostil skyostil cc-bugs jamesr webkit.review.bot oldest_to_newest 606583 0 skyostil 2012-04-20 08:20:06 -0700 [chromium] Don't crash when scrolling empty layer tree 606584 1 138096 skyostil 2012-04-20 08:22:36 -0700 Created attachment 138096 Patch 606588 2 138096 danakj 2012-04-20 08:40:43 -0700 Comment on attachment 138096 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138096&action=review > Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:245 > + if (!m_rootLayerImpl) > + return false; > + false here means something specific (we checkerboarded with an animation). i'd rather as assert in this function, and guard on m_rootLayerImpl in the calling function, like we do with prepareToDraw. 606591 3 skyostil 2012-04-20 08:47:46 -0700 (In reply to comment #2) > (From update of attachment 138096 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=138096&action=review > > > Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:245 > > + if (!m_rootLayerImpl) > > + return false; > > + > > false here means something specific (we checkerboarded with an animation). i'd rather as assert in this function, and guard on m_rootLayerImpl in the calling function, like we do with prepareToDraw. Ah, I missed that. New patch coming up. 606598 4 138100 skyostil 2012-04-20 08:53:35 -0700 Created attachment 138100 Patch 606702 5 138100 webkit.review.bot 2012-04-20 10:53:27 -0700 Comment on attachment 138100 Patch Clearing flags on attachment: 138100 Committed r114761: <http://trac.webkit.org/changeset/114761> 606703 6 webkit.review.bot 2012-04-20 10:53:37 -0700 All reviewed patches have been landed. Closing bug. 138096 2012-04-20 08:22:36 -0700 2012-04-20 08:53:29 -0700 Patch bug-84455-20120420162234.patch text/plain 3161 skyostil U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0NzI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDQwOWE0ZDYwZDM3ZjRl OTlmYjJjZjA1NjYwNjQ5YmZiMjU0ODVkOS4uMWJjMzBlN2QwZTFlMDlkNTlhNTBhMDM4ZTU3YWM4 NGEyOGVmZmNlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA0LTIwICBTYW1p IEt5b3N0aWxhICA8c2t5b3N0aWxAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0g RG9uJ3QgY3Jhc2ggd2hlbiBzY3JvbGxpbmcgZW1wdHkgbGF5ZXIgdHJlZQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODQ0NTUKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEbyBub3QgdHJ5IHRvIGNhbGN1bGF0 ZSByZW5kZXIgcGFzc2VzIHdoZW4gdGhlcmUgYXJlIG5vIGxheWVycyBpbiB0aGUKKyAgICAgICAg bGF5ZXIgdHJlZS4KKworICAgICAgICBBZGRlZCBuZXcgdW5pdCB0ZXN0LgorCisgICAgICAgICog cGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NMYXllclRyZWVIb3N0SW1wbC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpDQ0xheWVyVHJlZUhvc3RJbXBsOjpjYWxjdWxhdGVSZW5kZXJQYXNz ZXMpOgorCiAyMDEyLTA0LTE5ICBQYXZlbCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IHJlcGxhY2UgQHR5cGUgYW5ub3RhdGlvbiB3aXRo IEByZXR1cm4gYW5ub3RhdGlvbiBmb3IgZ2V0dGVycwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpp bmRleCA1N2E0N2QxYTI5MTkwM2FiNGI2MjZhNGE3ODZkZmE3NDgxODlkZTcwLi5jZWE0MTg1ZjU0 MTk2M2RiNWYwZTZlMzhlZDM5NTQzNDA5OWQ1NjEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2Nocm9taXVtL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA0LTIwICBTYW1pIEt5b3N0aWxhICA8c2t5b3N0aWxA Y2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gRG9uJ3QgY3Jhc2ggd2hlbiBzY3Jv bGxpbmcgZW1wdHkgbGF5ZXIgdHJlZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9ODQ0NTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBUcnkgdG8gc2Nyb2xsIGFuIGVtcHR5IGxheWVyIHRyZWUuCisKKyAgICAg ICAgKiB0ZXN0cy9DQ0xheWVyVHJlZUhvc3RJbXBsVGVzdC5jcHA6CisgICAgICAgIChXZWJLaXRU ZXN0czo6VEVTVF9GKToKKyAgICAgICAgKFdlYktpdFRlc3RzKToKKwogMjAxMi0wNC0yMCAgTWFy ayBQaWxncmltICA8cGlsZ3JpbUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW0Nocm9taXVtXSBD YWxsIGNhY2hlTWV0YWRhdGEgZGlyZWN0bHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJUcmVlSG9zdEltcGwuY3BwIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NMYXllclRyZWVIb3N0 SW1wbC5jcHAKaW5kZXggZmE1MzU2MzA5MDRhZTJhMmE0OWFkZDc2ZTk5M2JkNGU4NzNiZGRiOC4u MDViZTIxMjUyNWM4NDQxZTBiY2FmNjViYzM1NWQwNWI0ODVjOTExNyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NMYXllclRyZWVIb3N0 SW1wbC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0v Y2MvQ0NMYXllclRyZWVIb3N0SW1wbC5jcHAKQEAgLTI0MCw2ICsyNDAsOSBAQCBib29sIENDTGF5 ZXJUcmVlSG9zdEltcGw6OmNhbGN1bGF0ZVJlbmRlclBhc3NlcyhDQ1JlbmRlclBhc3NMaXN0JiBw YXNzZXMsIENDTGF5ZQogICAgIEFTU0VSVChwYXNzZXMuaXNFbXB0eSgpKTsKICAgICBBU1NFUlQo cmVuZGVyU3VyZmFjZUxheWVyTGlzdC5pc0VtcHR5KCkpOwogCisgICAgaWYgKCFtX3Jvb3RMYXll ckltcGwpCisgICAgICAgIHJldHVybiBmYWxzZTsKKwogICAgIHJlbmRlclN1cmZhY2VMYXllckxp c3QuYXBwZW5kKG1fcm9vdExheWVySW1wbC5nZXQoKSk7CiAKICAgICBpZiAoIW1fcm9vdExheWVy SW1wbC0+cmVuZGVyU3VyZmFjZSgpKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1 bS90ZXN0cy9DQ0xheWVyVHJlZUhvc3RJbXBsVGVzdC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3Rlc3RzL0NDTGF5ZXJUcmVlSG9zdEltcGxUZXN0LmNwcAppbmRleCAwYzBjNWNjYTY4Nzdl N2Q4Zjc5OGE2MTVjNDBmZmM4NWMzN2M1YTAwLi44ZTRhMTQ3ZGM5M2IxZTM5ZjE0ZTdkYmI5NDJk YjI1M2YyM2I4YWQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0ND TGF5ZXJUcmVlSG9zdEltcGxUZXN0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rl c3RzL0NDTGF5ZXJUcmVlSG9zdEltcGxUZXN0LmNwcApAQCAtMjE0LDYgKzIxNCwxMiBAQCBURVNU X0YoQ0NMYXllclRyZWVIb3N0SW1wbFRlc3QsIHNjcm9sbFJvb3RDYWxsc0NvbW1pdEFuZFJlZHJh dykKICAgICBFWFBFQ1RfVFJVRShtX2RpZFJlcXVlc3RDb21taXQpOwogfQogCitURVNUX0YoQ0NM YXllclRyZWVIb3N0SW1wbFRlc3QsIHNjcm9sbFdpdGhvdXRSb290TGF5ZXIpCit7CisgICAgLy8g V2Ugc2hvdWxkIG5vdCBjcmFzaCB3aGVuIHRyeWluZyB0byBzY3JvbGwgYW4gZW1wdHkgbGF5ZXIg dHJlZS4KKyAgICBFWFBFQ1RfRVEobV9ob3N0SW1wbC0+c2Nyb2xsQmVnaW4oSW50UG9pbnQoMCwg MCksIENDSW5wdXRIYW5kbGVyQ2xpZW50OjpXaGVlbCksIENDSW5wdXRIYW5kbGVyQ2xpZW50OjpT Y3JvbGxJZ25vcmVkKTsKK30KKwogVEVTVF9GKENDTGF5ZXJUcmVlSG9zdEltcGxUZXN0LCB3aGVl bEV2ZW50SGFuZGxlcnMpCiB7CiAgICAgewo= 138100 2012-04-20 08:53:35 -0700 2012-04-20 10:53:26 -0700 Patch bug-84455-20120420165333.patch text/plain 3541 skyostil U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0NzI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDQwOWE0ZDYwZDM3ZjRl OTlmYjJjZjA1NjYwNjQ5YmZiMjU0ODVkOS4uMWJjMzBlN2QwZTFlMDlkNTlhNTBhMDM4ZTU3YWM4 NGEyOGVmZmNlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA0LTIwICBTYW1p IEt5b3N0aWxhICA8c2t5b3N0aWxAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0g RG9uJ3QgY3Jhc2ggd2hlbiBzY3JvbGxpbmcgZW1wdHkgbGF5ZXIgdHJlZQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODQ0NTUKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEbyBub3QgdHJ5IHRvIGNhbGN1bGF0 ZSByZW5kZXIgcGFzc2VzIHdoZW4gdGhlcmUgYXJlIG5vIGxheWVycyBpbiB0aGUKKyAgICAgICAg bGF5ZXIgdHJlZS4KKworICAgICAgICBBZGRlZCBuZXcgdW5pdCB0ZXN0LgorCisgICAgICAgICog cGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NMYXllclRyZWVIb3N0SW1wbC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpDQ0xheWVyVHJlZUhvc3RJbXBsOjpjYWxjdWxhdGVSZW5kZXJQYXNz ZXMpOgorCiAyMDEyLTA0LTE5ICBQYXZlbCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IHJlcGxhY2UgQHR5cGUgYW5ub3RhdGlvbiB3aXRo IEByZXR1cm4gYW5ub3RhdGlvbiBmb3IgZ2V0dGVycwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpp bmRleCA1N2E0N2QxYTI5MTkwM2FiNGI2MjZhNGE3ODZkZmE3NDgxODlkZTcwLi5jZWE0MTg1ZjU0 MTk2M2RiNWYwZTZlMzhlZDM5NTQzNDA5OWQ1NjEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2Nocm9taXVtL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA0LTIwICBTYW1pIEt5b3N0aWxhICA8c2t5b3N0aWxA Y2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gRG9uJ3QgY3Jhc2ggd2hlbiBzY3Jv bGxpbmcgZW1wdHkgbGF5ZXIgdHJlZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9ODQ0NTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBUcnkgdG8gc2Nyb2xsIGFuIGVtcHR5IGxheWVyIHRyZWUuCisKKyAgICAg ICAgKiB0ZXN0cy9DQ0xheWVyVHJlZUhvc3RJbXBsVGVzdC5jcHA6CisgICAgICAgIChXZWJLaXRU ZXN0czo6VEVTVF9GKToKKyAgICAgICAgKFdlYktpdFRlc3RzKToKKwogMjAxMi0wNC0yMCAgTWFy ayBQaWxncmltICA8cGlsZ3JpbUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW0Nocm9taXVtXSBD YWxsIGNhY2hlTWV0YWRhdGEgZGlyZWN0bHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJUcmVlSG9zdEltcGwuY3BwIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NMYXllclRyZWVIb3N0 SW1wbC5jcHAKaW5kZXggZmE1MzU2MzA5MDRhZTJhMmE0OWFkZDc2ZTk5M2JkNGU4NzNiZGRiOC4u Njg4NzE5NWRjYTY4ZGIzZDAzNmU1OWZhZDZjYmQxYmU5NTY1MjM2NiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NMYXllclRyZWVIb3N0 SW1wbC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0v Y2MvQ0NMYXllclRyZWVIb3N0SW1wbC5jcHAKQEAgLTIzOSw2ICsyMzksNyBAQCBib29sIENDTGF5 ZXJUcmVlSG9zdEltcGw6OmNhbGN1bGF0ZVJlbmRlclBhc3NlcyhDQ1JlbmRlclBhc3NMaXN0JiBw YXNzZXMsIENDTGF5ZQogewogICAgIEFTU0VSVChwYXNzZXMuaXNFbXB0eSgpKTsKICAgICBBU1NF UlQocmVuZGVyU3VyZmFjZUxheWVyTGlzdC5pc0VtcHR5KCkpOworICAgIEFTU0VSVChtX3Jvb3RM YXllckltcGwpOwogCiAgICAgcmVuZGVyU3VyZmFjZUxheWVyTGlzdC5hcHBlbmQobV9yb290TGF5 ZXJJbXBsLmdldCgpKTsKIApAQCAtNjY0LDYgKzY2NSw5IEBAIGJvb2wgQ0NMYXllclRyZWVIb3N0 SW1wbDo6ZW5zdXJlTW9zdFJlY2VudFJlbmRlclN1cmZhY2VMYXllckxpc3QoKQogICAgIGlmICht X21vc3RSZWNlbnRSZW5kZXJTdXJmYWNlTGF5ZXJMaXN0LnNpemUoKSkKICAgICAgICAgcmV0dXJu IHRydWU7CiAKKyAgICBpZiAoIW1fcm9vdExheWVySW1wbCkKKyAgICAgICAgcmV0dXJuIGZhbHNl OworCiAgICAgLy8gSWYgd2UgYXJlIGNhbGxlZCBhZnRlciBzZXRSb290TGF5ZXIoKSBidXQgYmVm b3JlIHByZXBhcmVUb0RyYXcoKSwgd2UgbmVlZCB0byByZWNhbGN1bGF0ZQogICAgIC8vIHRoZSB2 aXNpYmxlIGxheWVycy4gVGhlIHJldHVybiB2YWx1ZSBpcyBpZ25vcmVkIGJlY2F1c2Ugd2UgZG9u J3QgY2FyZSBhYm91dCBjaGVja2VyYm9hcmRpbmcuCiAgICAgQ0NSZW5kZXJQYXNzTGlzdCBwYXNz ZXM7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0NDTGF5ZXJUcmVl SG9zdEltcGxUZXN0LmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvQ0NMYXllclRy ZWVIb3N0SW1wbFRlc3QuY3BwCmluZGV4IDBjMGM1Y2NhNjg3N2U3ZDhmNzk4YTYxNWM0MGZmYzg1 YzM3YzVhMDAuLjhlNGExNDdkYzkzYjFlMzlmMTRlN2RiYjk0MmRiMjUzZjIzYjhhZDUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvQ0NMYXllclRyZWVIb3N0SW1wbFRl c3QuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvQ0NMYXllclRyZWVIb3N0 SW1wbFRlc3QuY3BwCkBAIC0yMTQsNiArMjE0LDEyIEBAIFRFU1RfRihDQ0xheWVyVHJlZUhvc3RJ bXBsVGVzdCwgc2Nyb2xsUm9vdENhbGxzQ29tbWl0QW5kUmVkcmF3KQogICAgIEVYUEVDVF9UUlVF KG1fZGlkUmVxdWVzdENvbW1pdCk7CiB9CiAKK1RFU1RfRihDQ0xheWVyVHJlZUhvc3RJbXBsVGVz dCwgc2Nyb2xsV2l0aG91dFJvb3RMYXllcikKK3sKKyAgICAvLyBXZSBzaG91bGQgbm90IGNyYXNo IHdoZW4gdHJ5aW5nIHRvIHNjcm9sbCBhbiBlbXB0eSBsYXllciB0cmVlLgorICAgIEVYUEVDVF9F UShtX2hvc3RJbXBsLT5zY3JvbGxCZWdpbihJbnRQb2ludCgwLCAwKSwgQ0NJbnB1dEhhbmRsZXJD bGllbnQ6OldoZWVsKSwgQ0NJbnB1dEhhbmRsZXJDbGllbnQ6OlNjcm9sbElnbm9yZWQpOworfQor CiBURVNUX0YoQ0NMYXllclRyZWVIb3N0SW1wbFRlc3QsIHdoZWVsRXZlbnRIYW5kbGVycykKIHsK ICAgICB7Cg==