8445 2006-04-17 12:14:13 -0700 -[DOMHTMLSelectElement multiple] returns no when the select element is multiple 2006-05-05 07:45:01 -0700 1 1 1 Unclassified WebKit DOM 420+ Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 rachael webkit-unassigned oldest_to_newest 39530 0 rachael 2006-04-17 12:14:13 -0700 - (BOOL)multiple { return ![self _selectElement]->multiple(); } seems like a call to 'multiple' should return YES if it's multiple and not vice versa. 39531 1 rachael 2006-04-17 12:19:04 -0700 http://trac.webkit.org/dev/changeset/9825/trunk/WebCore/kwq/DOMHTML.mm Looks like it was broken here, along with some other methods, when webkit switched to using a bool to keep track of it's multiple status from just checking if getAttribute(ATTR_MULTIPLE).isNull(), which DID require the inversion to be correct. 40814 2 8055 rwlbuis 2006-05-01 13:25:10 -0700 Created attachment 8055 Proposed patch Simple fix really. Just wondering whether there may be more wrong replacements in objC bindings like this? Cheers, Rob. 40816 3 8055 darin 2006-05-01 14:21:44 -0700 Comment on attachment 8055 Proposed patch The long term solution for things like this is to automatically generate the Objective-C DOM bindings just as we are doing with the JavaScript bindings. r=me 8055 2006-05-01 13:25:10 -0700 2006-05-01 14:21:44 -0700 Proposed patch 8445.diff text/plain 2547 rwlbuis SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAxNDEzOCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjMgQEAKKzIwMDYtMDUtMDEgIFJvYiBCdWlzICA8YnVpc0BrZGUub3JnPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdBUk5JTkc6IE5P IFRFU1QgQ0FTRVMgQURERUQgT1IgQ0hBTkdFRAorCisgICAgICAgIEZpeCBmb3IgaHR0cDovL2J1 Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNnaT9pZD04NjUxOgorICAgICAgICBbRE9N SFRNTFNlbGVjdEVsZW1lbnQgbXVsdGlwbGVdIHJldHVybnMgbm8gd2hlbiB0aGUgc2VsZWN0IGVs ZW1lbnQgaXMgbXVsdGlwbGUKKworICAgICAgICBDb3JyZWN0IHRoZSBsb2dpYyBlcnJvcnMsIHdo aWNoIGFyZSBjbGVhcmx5IGluZGljYXRlZCBieSB0aGUgY2hhbmdlc2V0IGdpdmVuCisgICAgICAg IGluIHRoZSBidWcgcmVwb3J0LgorCisgICAgICAgICogYmluZGluZ3Mvb2JqYy9ET01IVE1MLm1t OgorICAgICAgICAoLVtET01IVE1MTGlua0VsZW1lbnQgZGlzYWJsZWRdKToKKyAgICAgICAgKC1b RE9NSFRNTFNlbGVjdEVsZW1lbnQgZGlzYWJsZWRdKToKKyAgICAgICAgKC1bRE9NSFRNTFNlbGVj dEVsZW1lbnQgbXVsdGlwbGVdKToKKyAgICAgICAgKC1bRE9NSFRNTE9wdEdyb3VwRWxlbWVudCBk aXNhYmxlZF0pOgorICAgICAgICAoLVtET01IVE1MT3B0aW9uRWxlbWVudCBkZWZhdWx0U2VsZWN0 ZWRdKToKKyAgICAgICAgKC1bRE9NSFRNTE9wdGlvbkVsZW1lbnQgZGlzYWJsZWRdKToKKwogMjAw Ni0wNC0zMCAgUm9iIEJ1aXMgIDxidWlzQGtkZS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg ZXNlaWRlbC4gIExhbmRlZCBieSBlc2VpZGVsLgpJbmRleDogV2ViQ29yZS9iaW5kaW5ncy9vYmpj L0RPTUhUTUwubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy9vYmpjL0RPTUhUTUwu bW0JKHJldmlzaW9uIDE0MTI3KQorKysgV2ViQ29yZS9iaW5kaW5ncy9vYmpjL0RPTUhUTUwubW0J KHdvcmtpbmcgY29weSkKQEAgLTU2Miw3ICs1NjIsNyBAQCB1c2luZyBuYW1lc3BhY2UgV2ViQ29y ZTo6SFRNTE5hbWVzOwogCiAtIChCT09MKWRpc2FibGVkCiB7Ci0gICAgcmV0dXJuICFbc2VsZiBf bGlua0VsZW1lbnRdLT5kaXNhYmxlZCgpOworICAgIHJldHVybiBbc2VsZiBfbGlua0VsZW1lbnRd LT5kaXNhYmxlZCgpOwogfQogCiAtICh2b2lkKXNldERpc2FibGVkOihCT09MKWRpc2FibGVkCkBA IC0xMDQyLDcgKzEwNDIsNyBAQCB1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTo6SFRNTE5hbWVzOwog CiAtIChCT09MKWRpc2FibGVkCiB7Ci0gICAgcmV0dXJuICFbc2VsZiBfc2VsZWN0RWxlbWVudF0t PmRpc2FibGVkKCk7CisgICAgcmV0dXJuIFtzZWxmIF9zZWxlY3RFbGVtZW50XS0+ZGlzYWJsZWQo KTsKIH0KIAogLSAodm9pZClzZXREaXNhYmxlZDooQk9PTClkaXNhYmxlZApAQCAtMTA1Miw3ICsx MDUyLDcgQEAgdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU6OkhUTUxOYW1lczsKIAogLSAoQk9PTClt dWx0aXBsZQogewotICAgIHJldHVybiAhW3NlbGYgX3NlbGVjdEVsZW1lbnRdLT5tdWx0aXBsZSgp OworICAgIHJldHVybiBbc2VsZiBfc2VsZWN0RWxlbWVudF0tPm11bHRpcGxlKCk7CiB9CiAKIC0g KHZvaWQpc2V0TXVsdGlwbGU6KEJPT0wpbXVsdGlwbGUKQEAgLTExMjMsNyArMTEyMyw3IEBAIHVz aW5nIG5hbWVzcGFjZSBXZWJDb3JlOjpIVE1MTmFtZXM7CiAKIC0gKEJPT0wpZGlzYWJsZWQKIHsK LSAgICByZXR1cm4gIVtzZWxmIF9vcHRHcm91cEVsZW1lbnRdLT5kaXNhYmxlZCgpOworICAgIHJl dHVybiBbc2VsZiBfb3B0R3JvdXBFbGVtZW50XS0+ZGlzYWJsZWQoKTsKIH0KIAogLSAodm9pZClz ZXREaXNhYmxlZDooQk9PTClkaXNhYmxlZApAQCAtMTE1Nyw3ICsxMTU3LDcgQEAgdXNpbmcgbmFt ZXNwYWNlIFdlYkNvcmU6OkhUTUxOYW1lczsKIAogLSAoQk9PTClkZWZhdWx0U2VsZWN0ZWQKIHsK LSAgICByZXR1cm4gIVtzZWxmIF9vcHRpb25FbGVtZW50XS0+ZGVmYXVsdFNlbGVjdGVkKCk7Cisg ICAgcmV0dXJuIFtzZWxmIF9vcHRpb25FbGVtZW50XS0+ZGVmYXVsdFNlbGVjdGVkKCk7CiB9CiAK IC0gKHZvaWQpc2V0RGVmYXVsdFNlbGVjdGVkOihCT09MKWRlZmF1bHRTZWxlY3RlZApAQCAtMTE3 Nyw3ICsxMTc3LDcgQEAgdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU6OkhUTUxOYW1lczsKIAogLSAo Qk9PTClkaXNhYmxlZAogewotICAgIHJldHVybiAhW3NlbGYgX29wdGlvbkVsZW1lbnRdLT5kaXNh YmxlZCgpOworICAgIHJldHVybiBbc2VsZiBfb3B0aW9uRWxlbWVudF0tPmRpc2FibGVkKCk7CiB9 CiAKIC0gKHZvaWQpc2V0RGlzYWJsZWQ6KEJPT0wpZGlzYWJsZWQK