84437 2012-04-20 05:04:35 -0700 [Qt] PlatformMouseEventQt.cpp should be deleted 2012-04-20 10:05:35 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 allan.jensen allan.jensen webkit.review.bot oldest_to_newest 606514 0 allan.jensen 2012-04-20 05:04:35 -0700 File is not compiled and functionality moved elsewhere. 606516 1 138073 allan.jensen 2012-04-20 05:07:01 -0700 Created attachment 138073 Patch 606665 2 138073 webkit.review.bot 2012-04-20 10:05:30 -0700 Comment on attachment 138073 Patch Clearing flags on attachment: 138073 Committed r114755: <http://trac.webkit.org/changeset/114755> 606666 3 webkit.review.bot 2012-04-20 10:05:35 -0700 All reviewed patches have been landed. Closing bug. 138073 2012-04-20 05:07:01 -0700 2012-04-20 10:05:30 -0700 Patch bug-84437-20120420140707.patch text/plain 7319 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0NzI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGUzOTYzODcwMzhiNGQw ZTNjMDI5ZDNlYmY4NjY2ZGRjMzdjMTM2Ni4uNTVhYmI0ODczYzM0MjRlM2RhN2IwYWU5N2VkOWU1 OWFlZTI1MzhiZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEyLTA0LTIwICBBbGxh biBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5Abm9raWEuY29tPgorCisgICAgICAgIFtR dF0gUGxhdGZvcm1Nb3VzZUV2ZW50UXQuY3BwIHNob3VsZCBiZSBkZWxldGVkLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODQ0MzcKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL3F0L1BsYXRm b3JtTW91c2VFdmVudFF0LmNwcDogUmVtb3ZlZC4KKwogMjAxMi0wNC0xNyAgQWxsYW4gU2FuZGZl bGQgSmVuc2VuICA8YWxsYW4uamVuc2VuQG5va2lhLmNvbT4KIAogICAgICAgICBbUXRdIE9wdGlv bmFsbHkgc3VwcG9ydCBzbW9vdGgtc2Nyb2xsaW5nIG9uIGFsbCBwbGF0Zm9ybXMKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3F0L1BsYXRmb3JtTW91c2VFdmVudFF0LmNwcCBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3F0L1BsYXRmb3JtTW91c2VFdmVudFF0LmNwcApkZWxl dGVkIGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggOTk0NmM0ZTQ5MzA4NjA5NGU2YTFlYTJjNDllNWJl YjMxOGNlYThmZC4uMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9xdC9QbGF0Zm9ybU1vdXNlRXZlbnRRdC5jcHAKKysr IC9kZXYvbnVsbApAQCAtMSwxNjQgKzAsMCBAQAotLyoKLSAqIENvcHlyaWdodCAoQykgMjAwNiBa YWNrIFJ1c2luIDx6YWNrQGtkZS5vcmc+Ci0gKiBDb3B5cmlnaHQgKEMpIDIwMTEgUmVzZWFyY2gg SW4gTW90aW9uIExpbWl0ZWQuCi0gKgotICogQWxsIHJpZ2h0cyByZXNlcnZlZC4KLSAqCi0gKiBS ZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9y IHdpdGhvdXQKLSAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRo ZSBmb2xsb3dpbmcgY29uZGl0aW9ucwotICogYXJlIG1ldDoKLSAqIDEuIFJlZGlzdHJpYnV0aW9u cyBvZiBzb3VyY2UgY29kZSBtdXN0IHJldGFpbiB0aGUgYWJvdmUgY29weXJpZ2h0Ci0gKiAgICBu b3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWlt ZXIuCi0gKiAyLiBSZWRpc3RyaWJ1dGlvbnMgaW4gYmluYXJ5IGZvcm0gbXVzdCByZXByb2R1Y2Ug dGhlIGFib3ZlIGNvcHlyaWdodAotICogICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9u cyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyIGluIHRoZQotICogICAgZG9jdW1lbnRhdGlv biBhbmQvb3Igb3RoZXIgbWF0ZXJpYWxzIHByb3ZpZGVkIHdpdGggdGhlIGRpc3RyaWJ1dGlvbi4K LSAqCi0gKiBUSElTIFNPRlRXQVJFIElTIFBST1ZJREVEIEJZIEFQUExFIENPTVBVVEVSLCBJTkMu IGBgQVMgSVMnJyBBTkQgQU5ZCi0gKiBFWFBSRVNTIE9SIElNUExJRUQgV0FSUkFOVElFUywgSU5D TFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sIFRIRQotICogSU1QTElFRCBXQVJSQU5USUVTIE9G IE1FUkNIQU5UQUJJTElUWSBBTkQgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSCi0gKiBQVVJQT1NF IEFSRSBESVNDTEFJTUVELiAgSU4gTk8gRVZFTlQgU0hBTEwgQVBQTEUgQ09NUFVURVIsIElOQy4g T1IKLSAqIENPTlRSSUJVVE9SUyBCRSBMSUFCTEUgRk9SIEFOWSBESVJFQ1QsIElORElSRUNULCBJ TkNJREVOVEFMLCBTUEVDSUFMLAotICogRVhFTVBMQVJZLCBPUiBDT05TRVFVRU5USUFMIERBTUFH RVMgKElOQ0xVRElORywgQlVUIE5PVCBMSU1JVEVEIFRPLAotICogUFJPQ1VSRU1FTlQgT0YgU1VC U1RJVFVURSBHT09EUyBPUiBTRVJWSUNFUzsgTE9TUyBPRiBVU0UsIERBVEEsIE9SCi0gKiBQUk9G SVRTOyBPUiBCVVNJTkVTUyBJTlRFUlJVUFRJT04pIEhPV0VWRVIgQ0FVU0VEIEFORCBPTiBBTlkg VEhFT1JZCi0gKiBPRiBMSUFCSUxJVFksIFdIRVRIRVIgSU4gQ09OVFJBQ1QsIFNUUklDVCBMSUFC SUxJVFksIE9SIFRPUlQKLSAqIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBPVEhFUldJU0UpIEFS SVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRQotICogT0YgVEhJUyBTT0ZUV0FSRSwgRVZF TiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KLSAqLwotCi0j aW5jbHVkZSAiY29uZmlnLmgiCi0jaW5jbHVkZSAiUGxhdGZvcm1Nb3VzZUV2ZW50LmgiCi0KLSNp bmNsdWRlIDxRR3JhcGhpY3NTY2VuZU1vdXNlRXZlbnQ+Ci0jaW5jbHVkZSA8UU1vdXNlRXZlbnQ+ Ci0jaW5jbHVkZSA8d3RmL0N1cnJlbnRUaW1lLmg+Ci0KLW5hbWVzcGFjZSBXZWJDb3JlIHsKLQot c3RhdGljIHZvaWQgbW91c2VFdmVudE1vZGlmaWVyc0Zyb21RdEtleWJvYXJkTW9kaWZpZXJzKFF0 OjpLZXlib2FyZE1vZGlmaWVycyBrZXlib2FyZE1vZGlmaWVycywgdW5zaWduZWQmIG1vZGlmaWVy cykKLXsKLSAgICBtb2RpZmllcnMgPSAwOwotICAgIGlmIChrZXlib2FyZE1vZGlmaWVycyAmIFF0 OjpTaGlmdE1vZGlmaWVyKQotICAgICAgICBtb2RpZmllcnMgfD0gUGxhdGZvcm1FdmVudDo6U2hp ZnRLZXk7Ci0gICAgaWYgKGtleWJvYXJkTW9kaWZpZXJzICYgUXQ6OkNvbnRyb2xNb2RpZmllcikK LSAgICAgICAgbW9kaWZpZXJzIHw9IFBsYXRmb3JtRXZlbnQ6OkN0cmxLZXk7Ci0gICAgaWYgKGtl eWJvYXJkTW9kaWZpZXJzICYgUXQ6OkFsdE1vZGlmaWVyKQotICAgICAgICBtb2RpZmllcnMgfD0g UGxhdGZvcm1FdmVudDo6QWx0S2V5OwotICAgIGlmIChrZXlib2FyZE1vZGlmaWVycyAmIFF0OjpN ZXRhTW9kaWZpZXIpCi0gICAgICAgIG1vZGlmaWVycyB8PSBQbGF0Zm9ybUV2ZW50OjpNZXRhS2V5 OwotfQotCi1zdGF0aWMgdm9pZCBtb3VzZUV2ZW50VHlwZUFuZE1vdXNlQnV0dG9uRnJvbVFFdmVu dChjb25zdCBRRXZlbnQqIGV2ZW50LCBQbGF0Zm9ybUV2ZW50OjpUeXBlJiBtb3VzZUV2ZW50VHlw ZSwgTW91c2VCdXR0b24mIG1vdXNlQnV0dG9uKQotewotICAgIGVudW0geyBNb3VzZUV2ZW50LCBH cmFwaGljc1NjZW5lTW91c2VFdmVudCB9IGZyYW1ld29ya01vdXNlRXZlbnRUeXBlOwotICAgIHN3 aXRjaCAoZXZlbnQtPnR5cGUoKSkgewotICAgIGNhc2UgUUV2ZW50OjpNb3VzZUJ1dHRvbkRibENs aWNrOgotICAgIGNhc2UgUUV2ZW50OjpNb3VzZUJ1dHRvblByZXNzOgotICAgICAgICBmcmFtZXdv cmtNb3VzZUV2ZW50VHlwZSA9IE1vdXNlRXZlbnQ7Ci0gICAgICAgIG1vdXNlRXZlbnRUeXBlID0g UGxhdGZvcm1FdmVudDo6TW91c2VQcmVzc2VkOwotICAgICAgICBicmVhazsKLSAgICBjYXNlIFFF dmVudDo6TW91c2VCdXR0b25SZWxlYXNlOgotICAgICAgICBmcmFtZXdvcmtNb3VzZUV2ZW50VHlw ZSA9IE1vdXNlRXZlbnQ7Ci0gICAgICAgIG1vdXNlRXZlbnRUeXBlID0gUGxhdGZvcm1FdmVudDo6 TW91c2VSZWxlYXNlZDsKLSAgICAgICAgYnJlYWs7Ci0gICAgY2FzZSBRRXZlbnQ6Ok1vdXNlTW92 ZToKLSAgICAgICAgZnJhbWV3b3JrTW91c2VFdmVudFR5cGUgPSBNb3VzZUV2ZW50OwotICAgICAg ICBtb3VzZUV2ZW50VHlwZSA9IFBsYXRmb3JtRXZlbnQ6Ok1vdXNlTW92ZWQ7Ci0gICAgICAgIGJy ZWFrOwotI2lmICFkZWZpbmVkKFFUX05PX0dSQVBISUNTVklFVykKLSAgICBjYXNlIFFFdmVudDo6 R3JhcGhpY3NTY2VuZU1vdXNlRG91YmxlQ2xpY2s6Ci0gICAgY2FzZSBRRXZlbnQ6OkdyYXBoaWNz U2NlbmVNb3VzZVByZXNzOgotICAgICAgICBmcmFtZXdvcmtNb3VzZUV2ZW50VHlwZSA9IEdyYXBo aWNzU2NlbmVNb3VzZUV2ZW50OwotICAgICAgICBtb3VzZUV2ZW50VHlwZSA9IFBsYXRmb3JtRXZl bnQ6Ok1vdXNlUHJlc3NlZDsKLSAgICAgICAgYnJlYWs7Ci0gICAgY2FzZSBRRXZlbnQ6OkdyYXBo aWNzU2NlbmVNb3VzZVJlbGVhc2U6Ci0gICAgICAgIGZyYW1ld29ya01vdXNlRXZlbnRUeXBlID0g R3JhcGhpY3NTY2VuZU1vdXNlRXZlbnQ7Ci0gICAgICAgIG1vdXNlRXZlbnRUeXBlID0gUGxhdGZv cm1FdmVudDo6TW91c2VSZWxlYXNlZDsKLSAgICAgICAgYnJlYWs7Ci0gICAgY2FzZSBRRXZlbnQ6 OkdyYXBoaWNzU2NlbmVNb3VzZU1vdmU6Ci0gICAgICAgIGZyYW1ld29ya01vdXNlRXZlbnRUeXBl ID0gR3JhcGhpY3NTY2VuZU1vdXNlRXZlbnQ7Ci0gICAgICAgIG1vdXNlRXZlbnRUeXBlID0gUGxh dGZvcm1FdmVudDo6TW91c2VNb3ZlZDsKLSAgICAgICAgYnJlYWs7Ci0jZW5kaWYKLSAgICBkZWZh dWx0OgotICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKLSAgICAgICAgZnJhbWV3b3JrTW91 c2VFdmVudFR5cGUgPSBNb3VzZUV2ZW50OwotICAgICAgICBtb3VzZUV2ZW50VHlwZSA9IFBsYXRm b3JtRXZlbnQ6Ok1vdXNlTW92ZWQ7Ci0gICAgICAgIGJyZWFrOwotICAgIH0KLQotICAgIFF0OjpN b3VzZUJ1dHRvbnMgbW91c2VCdXR0b25zOwotICAgIHN3aXRjaCAoZnJhbWV3b3JrTW91c2VFdmVu dFR5cGUpIHsKLSAgICBjYXNlIE1vdXNlRXZlbnQ6IHsKLSAgICAgICAgY29uc3QgUU1vdXNlRXZl bnQqIG1vdXNlRXZlbnQgPSBzdGF0aWNfY2FzdDxjb25zdCBRTW91c2VFdmVudCo+KGV2ZW50KTsK LSAgICAgICAgbW91c2VCdXR0b25zID0gbW91c2VFdmVudFR5cGUgPT0gUGxhdGZvcm1FdmVudDo6 TW91c2VNb3ZlZCA/IG1vdXNlRXZlbnQtPmJ1dHRvbnMoKSA6IG1vdXNlRXZlbnQtPmJ1dHRvbigp OwotICAgICAgICBicmVhazsKLSAgICB9Ci0gICAgY2FzZSBHcmFwaGljc1NjZW5lTW91c2VFdmVu dDogewotICAgICAgICBjb25zdCBRR3JhcGhpY3NTY2VuZU1vdXNlRXZlbnQqIG1vdXNlRXZlbnQg PSBzdGF0aWNfY2FzdDxjb25zdCBRR3JhcGhpY3NTY2VuZU1vdXNlRXZlbnQqPihldmVudCk7Ci0g ICAgICAgIG1vdXNlQnV0dG9ucyA9IG1vdXNlRXZlbnRUeXBlID09IFBsYXRmb3JtRXZlbnQ6Ok1v dXNlTW92ZWQgPyBtb3VzZUV2ZW50LT5idXR0b25zKCkgOiBtb3VzZUV2ZW50LT5idXR0b24oKTsK LSAgICAgICAgYnJlYWs7Ci0gICAgfQotICAgIH0KLQotICAgIGlmIChtb3VzZUJ1dHRvbnMgJiBR dDo6TGVmdEJ1dHRvbikKLSAgICAgICAgbW91c2VCdXR0b24gPSBMZWZ0QnV0dG9uOwotICAgIGVs c2UgaWYgKG1vdXNlQnV0dG9ucyAmIFF0OjpSaWdodEJ1dHRvbikKLSAgICAgICAgbW91c2VCdXR0 b24gPSBSaWdodEJ1dHRvbjsKLSAgICBlbHNlIGlmIChtb3VzZUJ1dHRvbnMgJiBRdDo6TWlkQnV0 dG9uKQotICAgICAgICBtb3VzZUJ1dHRvbiA9IE1pZGRsZUJ1dHRvbjsKLSAgICBlbHNlCi0gICAg ICAgIG1vdXNlQnV0dG9uID0gTm9CdXR0b247Ci19Ci0KLSNpZiAhZGVmaW5lZChRVF9OT19HUkFQ SElDU1ZJRVcpCi1QbGF0Zm9ybU1vdXNlRXZlbnQ6OlBsYXRmb3JtTW91c2VFdmVudChRR3JhcGhp Y3NTY2VuZU1vdXNlRXZlbnQqIGV2ZW50LCBpbnQgY2xpY2tDb3VudCkKLXsKLSAgICBtX3RpbWVz dGFtcCA9IFdURjo6Y3VycmVudFRpbWUoKTsKLQotICAgIC8vIEZJWE1FOiBXaHkgZG9uJ3Qgd2Ug aGFuZGxlIGEgY29udGV4dCBtZW51IGV2ZW50IGhlcmUgYXMgd2UgZG8gaW4gUGxhdGZvcm1Nb3Vz ZUV2ZW50KFFJbnB1dEV2ZW50KiwgaW50KT8KLSAgICAvLyBTZWUgPGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MDcyOD4uCi0gICAgUGxhdGZvcm1FdmVudDo6VHlwZSB0 eXBlOwotICAgIG1vdXNlRXZlbnRUeXBlQW5kTW91c2VCdXR0b25Gcm9tUUV2ZW50KGV2ZW50LCB0 eXBlLCBtX2J1dHRvbik7Ci0KLSAgICBtX3R5cGUgPSB0eXBlOwotICAgIG1fcG9zaXRpb24gPSBJ bnRQb2ludChldmVudC0+cG9zKCkudG9Qb2ludCgpKTsKLSAgICBtX2dsb2JhbFBvc2l0aW9uID0g SW50UG9pbnQoZXZlbnQtPnNjcmVlblBvcygpKTsKLQotICAgIG1fY2xpY2tDb3VudCA9IGNsaWNr Q291bnQ7Ci0gICAgbW91c2VFdmVudE1vZGlmaWVyc0Zyb21RdEtleWJvYXJkTW9kaWZpZXJzKGV2 ZW50LT5tb2RpZmllcnMoKSwgbV9tb2RpZmllcnMpOwotfQotI2VuZGlmIC8vIFFUX05PX0dSQVBI SUNTVklFVwotCi1QbGF0Zm9ybU1vdXNlRXZlbnQ6OlBsYXRmb3JtTW91c2VFdmVudChRSW5wdXRF dmVudCogZXZlbnQsIGludCBjbGlja0NvdW50KQotewotICAgIG1fdGltZXN0YW1wID0gV1RGOjpj dXJyZW50VGltZSgpOwotCi0gICAgYm9vbCBpc0NvbnRleHRNZW51RXZlbnQgPSBmYWxzZTsKLSNp Zm5kZWYgUVRfTk9fQ09OVEVYVE1FTlUKLSAgICBpZiAoZXZlbnQtPnR5cGUoKSA9PSBRRXZlbnQ6 OkNvbnRleHRNZW51KSB7Ci0gICAgICAgIGlzQ29udGV4dE1lbnVFdmVudCA9IHRydWU7Ci0gICAg ICAgIG1fdHlwZSA9IFBsYXRmb3JtRXZlbnQ6Ok1vdXNlUHJlc3NlZDsKLSAgICAgICAgUUNvbnRl eHRNZW51RXZlbnQqIGNlID0gc3RhdGljX2Nhc3Q8UUNvbnRleHRNZW51RXZlbnQqPihldmVudCk7 Ci0gICAgICAgIG1fcG9zaXRpb24gPSBJbnRQb2ludChjZS0+cG9zKCkpOwotICAgICAgICBtX2ds b2JhbFBvc2l0aW9uID0gSW50UG9pbnQoY2UtPmdsb2JhbFBvcygpKTsKLSAgICAgICAgbV9idXR0 b24gPSBSaWdodEJ1dHRvbjsKLSAgICB9Ci0jZW5kaWYKLSAgICBpZiAoIWlzQ29udGV4dE1lbnVF dmVudCkgewotICAgICAgICBQbGF0Zm9ybUV2ZW50OjpUeXBlIHR5cGU7Ci0gICAgICAgIG1vdXNl RXZlbnRUeXBlQW5kTW91c2VCdXR0b25Gcm9tUUV2ZW50KGV2ZW50LCB0eXBlLCBtX2J1dHRvbik7 Ci0gICAgICAgIFFNb3VzZUV2ZW50KiBtb3VzZUV2ZW50ID0gc3RhdGljX2Nhc3Q8UU1vdXNlRXZl bnQqPihldmVudCk7Ci0KLSAgICAgICAgbV90eXBlID0gdHlwZTsKLSAgICAgICAgbV9wb3NpdGlv biA9IEludFBvaW50KG1vdXNlRXZlbnQtPnBvcygpKTsKLSAgICAgICAgbV9nbG9iYWxQb3NpdGlv biA9IEludFBvaW50KG1vdXNlRXZlbnQtPmdsb2JhbFBvcygpKTsKLSAgICB9Ci0KLSAgICBtX2Ns aWNrQ291bnQgPSBjbGlja0NvdW50OwotICAgIG1vdXNlRXZlbnRNb2RpZmllcnNGcm9tUXRLZXli b2FyZE1vZGlmaWVycyhldmVudC0+bW9kaWZpZXJzKCksIG1fbW9kaWZpZXJzKTsKLX0KLQotfQot Ci0vLyB2aW06IHRzPTQgc3c9NCBldAo=