84424 2012-04-19 22:44:16 -0700 REGRESSION(r112781): Windows build slaves are no longer including .pdb files in archives handed to testers 2012-04-20 00:42:49 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mrowe rniwa rniwa tony webkit.review.bot oldest_to_newest 606369 0 mrowe 2012-04-19 22:44:16 -0700 I noticed while poking around this evening that the Windows build slaves are no longer including .pdb files in the .zip file that they upload to the master for the test slaves to use. The change in question appears to have been made for the benefit of Chromium bots, so it's unclear why these files are being excluded from non-Chromium builds. 606371 1 rniwa 2012-04-19 22:47:47 -0700 (In reply to comment #0) > I noticed while poking around this evening that the Windows build slaves are no longer including .pdb files in the .zip file that they upload to the master for the test slaves to use. The change in question appears to have been made for the benefit of Chromium bots, so it's unclear why these files are being excluded from non-Chromium builds. Oh, I didn't know that. Let me upload a patch then. 606395 2 138050 rniwa 2012-04-19 23:38:25 -0700 Created attachment 138050 Fix the bug 606403 3 138050 mrowe 2012-04-19 23:52:34 -0700 Comment on attachment 138050 Fix the bug I'm not sure how I feel about this change. I'm not sure how much sense it makes for the patterns to be shared like this given that there's very little overlap between the patterns used by Windows vs Chromium. The Windows code only wants to exclude *.ilk (that's what it did prior to r112781). Can the callers pass in the array of patterns instead, with the Windows and Chromium sets being defined as module-level variables? 606404 4 rniwa 2012-04-19 23:53:50 -0700 Sure. 606406 5 138052 rniwa 2012-04-19 23:56:55 -0700 Created attachment 138052 Fixed per Mark's comment 606423 6 138052 webkit.review.bot 2012-04-20 00:42:45 -0700 Comment on attachment 138052 Fixed per Mark's comment Clearing flags on attachment: 138052 Committed r114725: <http://trac.webkit.org/changeset/114725> 606424 7 webkit.review.bot 2012-04-20 00:42:49 -0700 All reviewed patches have been landed. Closing bug. 138050 2012-04-19 23:38:25 -0700 2012-04-19 23:56:51 -0700 Fix the bug bug-84424-20120419233824.patch text/plain 2073 rniwa SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDExNDcxNykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDEyLTA0LTE5ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIFJFR1JFU1NJT04ocjExMjc4MSk6IFdpbmRvd3MgYnVpbGQgc2xhdmVzIGFyZSBu byBsb25nZXIgaW5jbHVkaW5nIC5wZGIgZmlsZXMgaW4gYXJjaGl2ZXMgaGFuZGVkIHRvIHRlc3Rl cnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg0NDI0 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ29weSBw ZGIgZmlsZXMgdG8gdGhpbiBkaXJlY3RvcnkuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9y dC9idWlsdC1wcm9kdWN0LWFyY2hpdmU6CisgICAgICAgIChyZW1vdmVEaXJlY3RvcnlJZkV4aXN0 cyk6CisgICAgICAgIChjb3B5QnVpbGRGaWxlcyk6CisgICAgICAgIChhcmNoaXZlQnVpbHRQcm9k dWN0KToKKwogMjAxMi0wNC0xOSAgSmVyZW15IE1hbyAgPHl1amllLm1hb0BpbnRlbC5jb20+CiAK ICAgICAgICAgTWVkaWEgU3RyZWFtIEFQSTogUGllY2Ugb2YgY29kZSBjbGVhbnVwIGZvciB0aGUg Y2hyb21pdW0gcG9ydApJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbHQtcHJvZHVj dC1hcmNoaXZlCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWx0LXBy b2R1Y3QtYXJjaGl2ZQkocmV2aXNpb24gMTE0MjE0KQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBv cnQvYnVpbHQtcHJvZHVjdC1hcmNoaXZlCSh3b3JraW5nIGNvcHkpCkBAIC03Myw5ICs3MywxMSBA QCBkZWYgcmVtb3ZlRGlyZWN0b3J5SWZFeGlzdHModGhpbkRpcmVjdG9yCiAgICAgICAgIHNodXRp bC5ybXRyZWUodGhpbkRpcmVjdG9yeSkKIAogCi1kZWYgY29weUJ1aWxkRmlsZXMoc291cmNlLCBk ZXN0aW5hdGlvbik6Ci0gICAgc2h1dGlsLmNvcHl0cmVlKHNvdXJjZSwgZGVzdGluYXRpb24sCi0g ICAgICAgIGlnbm9yZT1zaHV0aWwuaWdub3JlX3BhdHRlcm5zKCcuc3ZuJywgJyouYScsICcqLmQn LCAnKi5kU1lNJywgJyoubycsICcqLmlsaycsICcqLmxpYicsICcqLmlkYicsICdCdWlsZExvZy5o dG0nLCAnKi5vYmonLCAnKi5wZGInKSkKK2RlZiBjb3B5QnVpbGRGaWxlcyhzb3VyY2UsIGRlc3Rp bmF0aW9uLCBjb3B5UGRiPUZhbHNlKToKKyAgICBwYXR0ZXJucyA9IFsnLnN2bicsICcqLmEnLCAn Ki5kJywgJyouZFNZTScsICcqLm8nLCAnKi5pbGsnLCAnKi5saWInLCAnKi5pZGInLCAnQnVpbGRM b2cuaHRtJywgJyoub2JqJ10KKyAgICBpZiBub3QgY29weVBkYjoKKyAgICAgICAgcGF0dGVybnMu YXBwZW5kKCcqLnBkYicpCisgICAgc2h1dGlsLmNvcHl0cmVlKHNvdXJjZSwgZGVzdGluYXRpb24s IGlnbm9yZT1zaHV0aWwuaWdub3JlX3BhdHRlcm5zKCpwYXR0ZXJucykpCiAKIAogZGVmIGNyZWF0 ZVppcE1hbnVhbGx5KGRpcmVjdG9yeVRvWmlwLCBhcmNoaXZlRmlsZSk6CkBAIC0xMzAsNyArMTMy LDcgQEAgZGVmIGFyY2hpdmVCdWlsdFByb2R1Y3QoY29uZmlndXJhdGlvbiwgcAogICAgICAgICB0 aGluQmluRGlyZWN0b3J5ID0gb3MucGF0aC5qb2luKHRoaW5EaXJlY3RvcnksICJiaW4iKQogCiAg ICAgICAgIHJlbW92ZURpcmVjdG9yeUlmRXhpc3RzKHRoaW5EaXJlY3RvcnkpCi0gICAgICAgIGNv cHlCdWlsZEZpbGVzKGJpbkRpcmVjdG9yeSwgdGhpbkJpbkRpcmVjdG9yeSkKKyAgICAgICAgY29w eUJ1aWxkRmlsZXMoYmluRGlyZWN0b3J5LCB0aGluQmluRGlyZWN0b3J5LCBjb3B5UGRiPVRydWUp CiAgICAgICAgIGlmIGNyZWF0ZVppcCh0aGluRGlyZWN0b3J5LCBjb25maWd1cmF0aW9uKToKICAg ICAgICAgICAgIHJldHVybiAxCiAK 138052 2012-04-19 23:56:55 -0700 2012-04-20 00:42:45 -0700 Fixed per Mark's comment bug-84424-20120419235654.patch text/plain 2444 rniwa SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDExNDcxNykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDEyLTA0LTE5ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIFJFR1JFU1NJT04ocjExMjc4MSk6IFdpbmRvd3MgYnVpbGQgc2xhdmVzIGFyZSBu byBsb25nZXIgaW5jbHVkaW5nIC5wZGIgZmlsZXMgaW4gYXJjaGl2ZXMgaGFuZGVkIHRvIHRlc3Rl cnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg0NDI0 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTGV0IFdp bmRvd3MgYW5kIENocm9taXVtIGhhdmUgdGhlaXIgb3duIGxpc3Qgb2YgZmlsZXMgdG8gY29weS4K KworICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2J1aWx0LXByb2R1Y3QtYXJjaGl2ZToKKyAg ICAgICAgKHJlbW92ZURpcmVjdG9yeUlmRXhpc3RzKToKKyAgICAgICAgKGNvcHlCdWlsZEZpbGVz KToKKyAgICAgICAgKGFyY2hpdmVCdWlsdFByb2R1Y3QpOgorCiAyMDEyLTA0LTE5ICBKZXJlbXkg TWFvICA8eXVqaWUubWFvQGludGVsLmNvbT4KIAogICAgICAgICBNZWRpYSBTdHJlYW0gQVBJOiBQ aWVjZSBvZiBjb2RlIGNsZWFudXAgZm9yIHRoZSBjaHJvbWl1bSBwb3J0CkluZGV4OiBUb29scy9C dWlsZFNsYXZlU3VwcG9ydC9idWlsdC1wcm9kdWN0LWFyY2hpdmUKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9v bHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbHQtcHJvZHVjdC1hcmNoaXZlCShyZXZpc2lvbiAxMTQy MTQpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsdC1wcm9kdWN0LWFyY2hpdmUJKHdv cmtpbmcgY29weSkKQEAgLTczLDkgKzczLDggQEAgZGVmIHJlbW92ZURpcmVjdG9yeUlmRXhpc3Rz KHRoaW5EaXJlY3RvcgogICAgICAgICBzaHV0aWwucm10cmVlKHRoaW5EaXJlY3RvcnkpCiAKIAot ZGVmIGNvcHlCdWlsZEZpbGVzKHNvdXJjZSwgZGVzdGluYXRpb24pOgotICAgIHNodXRpbC5jb3B5 dHJlZShzb3VyY2UsIGRlc3RpbmF0aW9uLAotICAgICAgICBpZ25vcmU9c2h1dGlsLmlnbm9yZV9w YXR0ZXJucygnLnN2bicsICcqLmEnLCAnKi5kJywgJyouZFNZTScsICcqLm8nLCAnKi5pbGsnLCAn Ki5saWInLCAnKi5pZGInLCAnQnVpbGRMb2cuaHRtJywgJyoub2JqJywgJyoucGRiJykpCitkZWYg Y29weUJ1aWxkRmlsZXMoc291cmNlLCBkZXN0aW5hdGlvbiwgcGF0dGVybnMpOgorICAgIHNodXRp bC5jb3B5dHJlZShzb3VyY2UsIGRlc3RpbmF0aW9uLCBpZ25vcmU9c2h1dGlsLmlnbm9yZV9wYXR0 ZXJucygqcGF0dGVybnMpKQogCiAKIGRlZiBjcmVhdGVaaXBNYW51YWxseShkaXJlY3RvcnlUb1pp cCwgYXJjaGl2ZUZpbGUpOgpAQCAtMTMwLDcgKzEyOSw3IEBAIGRlZiBhcmNoaXZlQnVpbHRQcm9k dWN0KGNvbmZpZ3VyYXRpb24sIHAKICAgICAgICAgdGhpbkJpbkRpcmVjdG9yeSA9IG9zLnBhdGgu am9pbih0aGluRGlyZWN0b3J5LCAiYmluIikKIAogICAgICAgICByZW1vdmVEaXJlY3RvcnlJZkV4 aXN0cyh0aGluRGlyZWN0b3J5KQotICAgICAgICBjb3B5QnVpbGRGaWxlcyhiaW5EaXJlY3Rvcnks IHRoaW5CaW5EaXJlY3RvcnkpCisgICAgICAgIGNvcHlCdWlsZEZpbGVzKGJpbkRpcmVjdG9yeSwg dGhpbkJpbkRpcmVjdG9yeSwgWycqLmlsayddKQogICAgICAgICBpZiBjcmVhdGVaaXAodGhpbkRp cmVjdG9yeSwgY29uZmlndXJhdGlvbik6CiAgICAgICAgICAgICByZXR1cm4gMQogCkBAIC0xNjYs NyArMTY1LDggQEAgZGVmIGFyY2hpdmVCdWlsdFByb2R1Y3QoY29uZmlndXJhdGlvbiwgcAogICAg ICAgICB0aGluRGlyZWN0b3J5ID0gb3MucGF0aC5qb2luKGNvbmZpZ3VyYXRpb25CdWlsZERpcmVj dG9yeSwgInRoaW4iKQogCiAgICAgICAgIHJlbW92ZURpcmVjdG9yeUlmRXhpc3RzKHRoaW5EaXJl Y3RvcnkpCi0gICAgICAgIGNvcHlCdWlsZEZpbGVzKGNvbmZpZ3VyYXRpb25CdWlsZERpcmVjdG9y eSwgdGhpbkRpcmVjdG9yeSkKKyAgICAgICAgY29weUJ1aWxkRmlsZXMoY29uZmlndXJhdGlvbkJ1 aWxkRGlyZWN0b3J5LCB0aGluRGlyZWN0b3J5LAorICAgICAgICAgICAgWycuc3ZuJywgJyouYScs ICcqLmQnLCAnKi5kU1lNJywgJyoubycsICcqLmlsaycsICcqLmxpYicsICcqLmlkYicsICdCdWls ZExvZy5odG0nLCAnKi5vYmonLCAnKi5wZGInXSkKICAgICAgICAgaWYgY3JlYXRlWmlwKHRoaW5E aXJlY3RvcnksIGNvbmZpZ3VyYXRpb24pOgogICAgICAgICAgICAgcmV0dXJuIDEKIAo=