84416 2012-04-19 20:12:51 -0700 Inline the JSArray constructor 2012-04-20 15:53:44 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin barraclough ggaren oldest_to_newest 606320 0 benjamin 2012-04-19 20:12:51 -0700 Inline the JSArray constructor, it is trivial, all its parents are inline, and it takes time to jump to it. 606331 1 138036 benjamin 2012-04-19 20:44:23 -0700 Created attachment 138036 Patch 606337 2 138036 buildbot 2012-04-19 21:11:11 -0700 Comment on attachment 138036 Patch Attachment 138036 did not pass win-ews (win): Output: http://queues.webkit.org/results/12469112 606402 3 benjamin 2012-04-19 23:49:10 -0700 9>jsc.obj : error LNK2005: "protected: __thiscall JSC::JSArray::JSArray(class JSC::JSGlobalData &,class JSC::Structure *)" (??0JSArray@JSC@@IAE@AAVJSGlobalData@1@PAVStructure@1@@Z) already defined in JavaScriptCore.lib(JavaScriptCore.dll) This is mysterious. Does Windows systematically generate symbols for inlined functions? 606738 4 138126 benjamin 2012-04-20 11:32:10 -0700 Created attachment 138126 Patch 606953 5 138126 ggaren 2012-04-20 15:18:55 -0700 Comment on attachment 138126 Patch r=me 606987 6 benjamin 2012-04-20 15:53:44 -0700 Committed r114793: <http://trac.webkit.org/changeset/114793> 138036 2012-04-19 20:44:23 -0700 2012-04-20 11:31:57 -0700 Patch bug-84416-20120419204422.patch text/plain 2478 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0NTQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi YTY0YmVhNDIzOGQzM2Q2MzI5MzIwZjcxYWM4MTJiNmM4N2UwMGEwLi4xZjQwMjNjNDRkYTcwNWI0 OWFlZDQwNTM1YTc0ZTU3YzM4YzM4NDExIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxMi0wNC0xOSAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxl LmNvbT4KKworICAgICAgICBJbmxpbmUgdGhlIEpTQXJyYXkgY29uc3RydWN0b3IKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg0NDE2CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGNvbnN0cnVjdG9yIGlz IHRyaXZpYWwsIG5vIHJlYXNvbiB0byBqdW1wIGZvciBpdC4KKworICAgICAgICBUaGlzIG1ha2Vz IHRoZSBjcmVhdGlvbiBvZiBhcnJheSB+NSUgZmFzdGVyIChvbiBub24tdHJpdmlhbCBjYXNlcywg bm8gZW1wdHkgYXJyYXlzKS4KKworICAgICAgICAqIHJ1bnRpbWUvSlNBcnJheS5jcHA6CisgICAg ICAgIChKU0MpOgorICAgICAgICAqIHJ1bnRpbWUvSlNBcnJheS5oOgorICAgICAgICAoSlNDOjpK U0FycmF5OjpKU0FycmF5KToKKwogMjAxMi0wNC0xOCAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3Vs YWluQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgbV9zdWJjbGFzc0RhdGEgZnJvbSBKU0Fy cmF5LCBtb3ZlIHRoZSBhdHRyaWJ1dGUgdG8gc3ViY2xhc3MgYXMgbmVlZGVkCmRpZmYgLS1naXQg YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0FycmF5LmNwcCBiL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9ydW50aW1lL0pTQXJyYXkuY3BwCmluZGV4IDJhOTE5YzM0NjM3YzQxZWJmNzQy NDMxNzE2N2Y4MmFhYTg5YzM1ZjYuLmFhMWI4YjdkOTgxY2ZjNjUyZjY5MjFjZDQ3OTgyODQ4Yjgz Zjk5YTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQXJyYXku Y3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQXJyYXkuY3BwCkBAIC0x MjUsMTQgKzEyNSw2IEBAIGlubGluZSB2b2lkIEpTQXJyYXk6OmNoZWNrQ29uc2lzdGVuY3koQ29u c2lzdGVuY3lDaGVja1R5cGUpCiAKICNlbmRpZgogCi1KU0FycmF5OjpKU0FycmF5KEpTR2xvYmFs RGF0YSYgZ2xvYmFsRGF0YSwgU3RydWN0dXJlKiBzdHJ1Y3R1cmUpCi0gICAgOiBKU05vbkZpbmFs T2JqZWN0KGdsb2JhbERhdGEsIHN0cnVjdHVyZSkKLSAgICAsIG1faW5kZXhCaWFzKDApCi0gICAg LCBtX3N0b3JhZ2UoMCkKLSAgICAsIG1fc3BhcnNlVmFsdWVNYXAoMCkKLXsKLX0KLQogdm9pZCBK U0FycmF5OjpmaW5pc2hDcmVhdGlvbihKU0dsb2JhbERhdGEmIGdsb2JhbERhdGEsIHVuc2lnbmVk IGluaXRpYWxMZW5ndGgpCiB7CiAgICAgQmFzZTo6ZmluaXNoQ3JlYXRpb24oZ2xvYmFsRGF0YSk7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0FycmF5LmggYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0FycmF5LmgKaW5kZXggNzkxMjUzN2JiM2U3 MWIyNDUxZjhlNTZjZTBjZDUwOTBjYTBmMmEwOS4uMTdjN2YzZWQ3MTlmZjEzZDRiNmU3YmY3NGJl YjExOWQ3MWMwMWI0MSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv SlNBcnJheS5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQXJyYXkuaApA QCAtMTM5LDcgKzEzOSwxMyBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAgZnJpZW5kIGNsYXNz IEpJVDsKIAogICAgIHByb3RlY3RlZDoKLSAgICAgICAgSlNfRVhQT1JUX1BSSVZBVEUgZXhwbGlj aXQgSlNBcnJheShKU0dsb2JhbERhdGEmLCBTdHJ1Y3R1cmUqKTsKKyAgICAgICAgZXhwbGljaXQg SlNBcnJheShKU0dsb2JhbERhdGEmIGdsb2JhbERhdGEsIFN0cnVjdHVyZSogc3RydWN0dXJlKQor ICAgICAgICAgICAgOiBKU05vbkZpbmFsT2JqZWN0KGdsb2JhbERhdGEsIHN0cnVjdHVyZSkKKyAg ICAgICAgICAgICwgbV9pbmRleEJpYXMoMCkKKyAgICAgICAgICAgICwgbV9zdG9yYWdlKDApCisg ICAgICAgICAgICAsIG1fc3BhcnNlVmFsdWVNYXAoMCkKKyAgICAgICAgeworICAgICAgICB9CiAK ICAgICAgICAgSlNfRVhQT1JUX1BSSVZBVEUgdm9pZCBmaW5pc2hDcmVhdGlvbihKU0dsb2JhbERh dGEmLCB1bnNpZ25lZCBpbml0aWFsTGVuZ3RoID0gMCk7CiAgICAgICAgIEpTX0VYUE9SVF9QUklW QVRFIEpTQXJyYXkqIHRyeUZpbmlzaENyZWF0aW9uVW5pbml0aWFsaXplZChKU0dsb2JhbERhdGEm LCB1bnNpZ25lZCBpbml0aWFsTGVuZ3RoKTsK 138126 2012-04-20 11:32:10 -0700 2012-04-20 15:18:55 -0700 Patch bug-84416-20120420113208.patch text/plain 3423 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0NzYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx ZTRkM2EzMzYxNDZlNjE1Y2NiMmZmNGMxMzU5ODYwNTQ5NzM2MDc1Li43NDljZmU0OGMyMDcxZWRh NmNhYzNhMGZjZDc2N2MzYTI4ZTdjNTMzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxMi0wNC0yMCAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxl LmNvbT4KKworICAgICAgICBJbmxpbmUgdGhlIEpTQXJyYXkgY29uc3RydWN0b3IKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg0NDE2CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGNvbnN0cnVjdG9yIGlz IHRyaXZpYWwsIG5vIHJlYXNvbiB0byBqdW1wIGZvciBpdC4KKworICAgICAgICBUaGlzIG1ha2Vz IHRoZSBjcmVhdGlvbiBvZiBhcnJheSB+NSUgZmFzdGVyIChvbiBub24tdHJpdmlhbCBjYXNlcywg bm8gZW1wdHkgYXJyYXlzKS4KKworICAgICAgICAqIHJ1bnRpbWUvSlNBcnJheS5jcHA6CisgICAg ICAgIChKU0MpOgorICAgICAgICAqIHJ1bnRpbWUvSlNBcnJheS5oOgorICAgICAgICAoSlNDOjpK U0FycmF5OjpKU0FycmF5KToKKyAgICAgICAgKiBKYXZhU2NyaXB0Q29yZS52Y3Byb2ovSmF2YVNj cmlwdENvcmUvSmF2YVNjcmlwdENvcmUuZGVmOgorCiAyMDEyLTA0LTE5ICBPbGl2ZXIgSHVudCAg PG9saXZlckBhcHBsZS5jb20+CiAKICAgICAgICAgRXhjZXB0aW9uIHN0YWNrIHRyYWNlcyBhcmVu J3QgY29tcGxldGUgd2hlbiB0aGUgZXhjZXB0aW9uIHN0YXJ0cyBpbiBuYXRpdmUgY29kZQpkaWZm IC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnZjcHJvai9KYXZh U2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5kZWYgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvSmF2 YVNjcmlwdENvcmUudmNwcm9qL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLmRlZgppbmRl eCAyZDMxYWE3ZjMyNDliNzBkNTIxMzgzMWVjMDFiMmEyMzhjYzBhNWEwLi5jYzVjMzkxMTc1MWRk MTlhMWIxMjg5MjE4ZGIzYzU4YzkzODdlNjQ5IDEwMDc1NQotLS0gYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvSmF2YVNjcmlwdENvcmUudmNwcm9qL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3Jl LmRlZgorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUudmNwcm9qL0ph dmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLmRlZgpAQCAtOSw3ICs5LDYgQEAgRVhQT1JUUwog ICAgID8/MERyb3BBbGxMb2Nrc0BKU0xvY2tASlNDQEBRQUVAVzRKU0xvY2tCZWhhdmlvckAyQEBa CiAgICAgPz8wRHluYW1pY0dsb2JhbE9iamVjdFNjb3BlQEpTQ0BAUUFFQEFBVkpTR2xvYmFsRGF0 YUAxQFBBVkpTR2xvYmFsT2JqZWN0QDFAQFogCiAgICAgPz8wSW50ZXJuYWxGdW5jdGlvbkBKU0NA QElBRUBQQVZKU0dsb2JhbE9iamVjdEAxQFBBVlN0cnVjdHVyZUAxQEBaCi0gICAgPz8wSlNBcnJh eUBKU0NAQElBRUBBQVZKU0dsb2JhbERhdGFAMUBQQVZTdHJ1Y3R1cmVAMUBAWgogICAgID8/MEpT Qnl0ZUFycmF5QEpTQ0BAQUFFQFBBVkV4ZWNTdGF0ZUAxQFBBVlN0cnVjdHVyZUAxQFBBVkJ5dGVB cnJheUBXVEZAQEBaCiAgICAgPz8wSlNMb2NrQEpTQ0BAUUFFQFBBVkV4ZWNTdGF0ZUAxQEBaCiAg ICAgPz8wTUQ1QFdURkBAUUFFQFhaCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9KU0FycmF5LmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQXJy YXkuY3BwCmluZGV4IDJhOTE5YzM0NjM3YzQxZWJmNzQyNDMxNzE2N2Y4MmFhYTg5YzM1ZjYuLmFh MWI4YjdkOTgxY2ZjNjUyZjY5MjFjZDQ3OTgyODQ4YjgzZjk5YTAgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQXJyYXkuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL0pTQXJyYXkuY3BwCkBAIC0xMjUsMTQgKzEyNSw2IEBAIGlubGluZSB2 b2lkIEpTQXJyYXk6OmNoZWNrQ29uc2lzdGVuY3koQ29uc2lzdGVuY3lDaGVja1R5cGUpCiAKICNl bmRpZgogCi1KU0FycmF5OjpKU0FycmF5KEpTR2xvYmFsRGF0YSYgZ2xvYmFsRGF0YSwgU3RydWN0 dXJlKiBzdHJ1Y3R1cmUpCi0gICAgOiBKU05vbkZpbmFsT2JqZWN0KGdsb2JhbERhdGEsIHN0cnVj dHVyZSkKLSAgICAsIG1faW5kZXhCaWFzKDApCi0gICAgLCBtX3N0b3JhZ2UoMCkKLSAgICAsIG1f c3BhcnNlVmFsdWVNYXAoMCkKLXsKLX0KLQogdm9pZCBKU0FycmF5OjpmaW5pc2hDcmVhdGlvbihK U0dsb2JhbERhdGEmIGdsb2JhbERhdGEsIHVuc2lnbmVkIGluaXRpYWxMZW5ndGgpCiB7CiAgICAg QmFzZTo6ZmluaXNoQ3JlYXRpb24oZ2xvYmFsRGF0YSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvcnVudGltZS9KU0FycmF5LmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9KU0FycmF5LmgKaW5kZXggNzkxMjUzN2JiM2U3MWIyNDUxZjhlNTZjZTBjZDUwOTBjYTBm MmEwOS4uMTdjN2YzZWQ3MTlmZjEzZDRiNmU3YmY3NGJlYjExOWQ3MWMwMWI0MSAxMDA2NDQKLS0t IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNBcnJheS5oCisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQXJyYXkuaApAQCAtMTM5LDcgKzEzOSwxMyBAQCBuYW1l c3BhY2UgSlNDIHsKICAgICAgICAgZnJpZW5kIGNsYXNzIEpJVDsKIAogICAgIHByb3RlY3RlZDoK LSAgICAgICAgSlNfRVhQT1JUX1BSSVZBVEUgZXhwbGljaXQgSlNBcnJheShKU0dsb2JhbERhdGEm LCBTdHJ1Y3R1cmUqKTsKKyAgICAgICAgZXhwbGljaXQgSlNBcnJheShKU0dsb2JhbERhdGEmIGds b2JhbERhdGEsIFN0cnVjdHVyZSogc3RydWN0dXJlKQorICAgICAgICAgICAgOiBKU05vbkZpbmFs T2JqZWN0KGdsb2JhbERhdGEsIHN0cnVjdHVyZSkKKyAgICAgICAgICAgICwgbV9pbmRleEJpYXMo MCkKKyAgICAgICAgICAgICwgbV9zdG9yYWdlKDApCisgICAgICAgICAgICAsIG1fc3BhcnNlVmFs dWVNYXAoMCkKKyAgICAgICAgeworICAgICAgICB9CiAKICAgICAgICAgSlNfRVhQT1JUX1BSSVZB VEUgdm9pZCBmaW5pc2hDcmVhdGlvbihKU0dsb2JhbERhdGEmLCB1bnNpZ25lZCBpbml0aWFsTGVu Z3RoID0gMCk7CiAgICAgICAgIEpTX0VYUE9SVF9QUklWQVRFIEpTQXJyYXkqIHRyeUZpbmlzaENy ZWF0aW9uVW5pbml0aWFsaXplZChKU0dsb2JhbERhdGEmLCB1bnNpZ25lZCBpbml0aWFsTGVuZ3Ro KTsK