84409 2012-04-19 18:11:20 -0700 computeNonFastScrollableRegion needs to traverse the entire frame tree 2012-04-20 15:38:58 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 84412 1 andersca andersca jamesr tonikitoo webkit.review.bot oldest_to_newest 606252 0 andersca 2012-04-19 18:11:20 -0700 computeNonFastScrollableRegion needs to traverse the entire frame tree 606256 1 138021 andersca 2012-04-19 18:13:13 -0700 Created attachment 138021 Patch 606264 2 138021 jamesr 2012-04-19 18:21:07 -0700 Comment on attachment 138021 Patch Can you write some tests for this using the numberOfScrollable... hook? 606266 3 andersca 2012-04-19 18:22:27 -0700 (In reply to comment #2) > (From update of attachment 138021 [details]) > Can you write some tests for this using the numberOfScrollable... hook? Unfortunately not, the number of scrollable areas will be the same after this fix, it's just the non-fast-scrollable region that will be different. We should really figure out a good way to test this :( 606273 4 138021 mitz 2012-04-19 18:38:47 -0700 Comment on attachment 138021 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138021&action=review > Source/WebCore/ChangeLog:14 > + (WebCore::ScrollingCoordinator::frameViewLayoutUpdated): Please explain why checking for scrollability is no longer needed in this function. 606276 5 andersca 2012-04-19 18:41:09 -0700 Committed r114711: <http://trac.webkit.org/changeset/114711> 606333 6 tonikitoo 2012-04-19 20:56:45 -0700 It was rolled out, reopening... 606972 7 andersca 2012-04-20 15:38:58 -0700 Committed r114792: <http://trac.webkit.org/changeset/114792> 138021 2012-04-19 18:13:13 -0700 2012-04-19 18:38:47 -0700 Patch bug-84409-20120419181456.patch text/plain 4596 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0NzA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDM4NDI4NjFjNjg0YWFl NDc1OTE1YmFiNTE3ODA1ODAyYjg2NzI1My4uYzYwZGU0Y2E4ZGQ5ZTQ3OGRhYmY4N2IzNWMyMGY3 OTAwNzdkYTNkZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDEyLTA0LTE5ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgY29tcHV0ZU5vbkZh c3RTY3JvbGxhYmxlUmVnaW9uIG5lZWRzIHRvIHRyYXZlcnNlIHRoZSBlbnRpcmUgZnJhbWUgdHJl ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODQ0MDkK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzExMjg1NzQxPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vdyB0aGF0IHNjcm9sbGFibGUgYXJlYXMgd29u J3QgYmUgaW4gdGhlIHNldCBvZiBzY3JvbGxhYmxlIGFyZWFzIHVubGVzcyB0aGV5IGFyZSBhY3R1 YWxseSBzY3JvbGxhYmxlLCB3ZSBuZWVkIHRvIGxvb2sgZm9yIHNjcm9sbGFibGUKKyAgICAgICAg YXJlYXMgaW4gdGhlIGVudGlyZSBmcmFtZSB0cmVlIHNpbmNlIHRoZXJlIGNhbiBiZSBhIHNjcm9s bGFibGUgZnJhbWUgdGhhdCdzIGEgc3ViZnJhbWUgb2YgYSBub24tc2Nyb2xsYWJsZSBmcmFtZSBm b3IgZXhhbXBsZS4KKworICAgICAgICAqIHBhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ0Nvb3JkaW5h dG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmNvbXB1dGVOb25GYXN0U2Nyb2xsYWJsZVJlZ2lv bik6CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxpbmdDb29yZGluYXRvcjo6ZnJhbWVWaWV3TGF5 b3V0VXBkYXRlZCk6CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxpbmdDb29yZGluYXRvcjo6ZnJh bWVWaWV3U2Nyb2xsYWJsZUFyZWFzRGlkQ2hhbmdlKToKKworMjAxMi0wNC0xOSAgQW5kZXJzIENh cmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgorCiAgICAgICAgIEZvY3VzIHJpbmcgb24gd2lr aXBlZGlhIGdldHMgYmxvYnMgd2hlbiB5b3UgdHlwZQogICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODQ0MDcKICAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzEx MDExODQ3PgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xs aW5nQ29vcmRpbmF0b3IuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xs aW5nQ29vcmRpbmF0b3IuY3BwCmluZGV4IDlhNjZhY2E4YzExYWI5YmMzZTQzMjdmZjY2MTBmMjgz YzRjNTg1MjYuLmFjMDNmODc5ZDkzMDQ3NTg0MzdiMDVmOWIwM2I0YzdlY2YyNjVmNTAgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ0Nvb3JkaW5hdG9y LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdDb29yZGlu YXRvci5jcHAKQEAgLTEwNSwyNyArMTA1LDIxIEBAIGJvb2wgU2Nyb2xsaW5nQ29vcmRpbmF0b3I6 OmNvb3JkaW5hdGVzU2Nyb2xsaW5nRm9yRnJhbWVWaWV3KEZyYW1lVmlldyogZnJhbWVWaWV3CiAj ZW5kaWYKIH0KIAotc3RhdGljIFJlZ2lvbiBjb21wdXRlTm9uRmFzdFNjcm9sbGFibGVSZWdpb24o RnJhbWVWaWV3KiBmcmFtZVZpZXcpCitzdGF0aWMgUmVnaW9uIGNvbXB1dGVOb25GYXN0U2Nyb2xs YWJsZVJlZ2lvbihGcmFtZSogbWFpbkZyYW1lKQogewogICAgIFJlZ2lvbiBub25GYXN0U2Nyb2xs YWJsZVJlZ2lvbjsKIAotICAgIEhhc2hTZXQ8RnJhbWVWaWV3Kj4gY2hpbGRGcmFtZVZpZXdzOwot ICAgIGZvciAoSGFzaFNldDxSZWZQdHI8V2lkZ2V0PiA+Ojpjb25zdF9pdGVyYXRvciBpdCA9IGZy YW1lVmlldy0+Y2hpbGRyZW4oKS0+YmVnaW4oKSwgZW5kID0gZnJhbWVWaWV3LT5jaGlsZHJlbigp LT5lbmQoKTsgaXQgIT0gZW5kOyArK2l0KSB7Ci0gICAgICAgIGlmICgoKml0KS0+aXNGcmFtZVZp ZXcoKSkKLSAgICAgICAgICAgIGNoaWxkRnJhbWVWaWV3cy5hZGQoc3RhdGljX2Nhc3Q8RnJhbWVW aWV3Kj4oaXQtPmdldCgpKSk7Ci0gICAgfQotCi0gICAgaWYgKGNvbnN0IEZyYW1lVmlldzo6U2Ny b2xsYWJsZUFyZWFTZXQqIHNjcm9sbGFibGVBcmVhcyA9IGZyYW1lVmlldy0+c2Nyb2xsYWJsZUFy ZWFzKCkpIHsKKyAgICBmb3IgKEZyYW1lKiBmcmFtZSA9IG1haW5GcmFtZTsgZnJhbWU7IGZyYW1l ID0gZnJhbWUtPnRyZWUoKS0+dHJhdmVyc2VOZXh0KCkpIHsKKyAgICAgICAgRnJhbWVWaWV3KiBm cmFtZVZpZXcgPSBmcmFtZS0+dmlldygpOworICAgICAgICBpZiAoIWZyYW1lVmlldykKKyAgICAg ICAgICAgIGNvbnRpbnVlOworICAgICAgICAKKyAgICAgICAgY29uc3QgRnJhbWVWaWV3OjpTY3Jv bGxhYmxlQXJlYVNldCogc2Nyb2xsYWJsZUFyZWFzID0gZnJhbWVWaWV3LT5zY3JvbGxhYmxlQXJl YXMoKTsKKyAgICAgICAgaWYgKCFzY3JvbGxhYmxlQXJlYXMpCisgICAgICAgICAgICBjb250aW51 ZTsKKyAgICAKICAgICAgICAgZm9yIChGcmFtZVZpZXc6OlNjcm9sbGFibGVBcmVhU2V0Ojpjb25z dF9pdGVyYXRvciBpdCA9IHNjcm9sbGFibGVBcmVhcy0+YmVnaW4oKSwgZW5kID0gc2Nyb2xsYWJs ZUFyZWFzLT5lbmQoKTsgaXQgIT0gZW5kOyArK2l0KSB7CiAgICAgICAgICAgICBTY3JvbGxhYmxl QXJlYSogc2Nyb2xsYWJsZUFyZWEgPSAqaXQ7Ci0KLSAgICAgICAgICAgIC8vIENoZWNrIGlmIHRo aXMgYXJlYSBjYW4gYmUgc2Nyb2xsZWQgYXQgYWxsLgotICAgICAgICAgICAgLy8gSWYgdGhpcyBz Y3JvbGxhYmxlIGFyZWEgaXMgYSBmcmFtZSB2aWV3IHRoYXQgaXRzZWxmIGhhcyBzY3JvbGxhYmxl IGFyZWFzLCB0aGVuIHdlIG5lZWQgdG8gYWRkIGl0IHRvIHRoZSByZWdpb24uCi0gICAgICAgICAg ICBpZiAoKCFzY3JvbGxhYmxlQXJlYS0+aG9yaXpvbnRhbFNjcm9sbGJhcigpIHx8ICFzY3JvbGxh YmxlQXJlYS0+aG9yaXpvbnRhbFNjcm9sbGJhcigpLT5lbmFibGVkKCkpCi0gICAgICAgICAgICAg ICAgJiYgKCFzY3JvbGxhYmxlQXJlYS0+dmVydGljYWxTY3JvbGxiYXIoKSB8fCAhc2Nyb2xsYWJs ZUFyZWEtPnZlcnRpY2FsU2Nyb2xsYmFyKCktPmVuYWJsZWQoKSkKLSAgICAgICAgICAgICAgICAm JiAoIWNoaWxkRnJhbWVWaWV3cy5jb250YWlucyhzdGF0aWNfY2FzdDxGcmFtZVZpZXcqPihzY3Jv bGxhYmxlQXJlYSkpIHx8ICFzdGF0aWNfY2FzdDxGcmFtZVZpZXcqPihzY3JvbGxhYmxlQXJlYSkt PnNjcm9sbGFibGVBcmVhcygpKSkKLSAgICAgICAgICAgICAgICAgICAgY29udGludWU7Ci0KICAg ICAgICAgICAgIG5vbkZhc3RTY3JvbGxhYmxlUmVnaW9uLnVuaXRlKHNjcm9sbGFibGVBcmVhLT5z Y3JvbGxhYmxlQXJlYUJvdW5kaW5nQm94KCkpOwogICAgICAgICB9CiAgICAgfQpAQCAtMTQxLDcg KzEzNSw3IEBAIHZvaWQgU2Nyb2xsaW5nQ29vcmRpbmF0b3I6OmZyYW1lVmlld0xheW91dFVwZGF0 ZWQoRnJhbWVWaWV3KiBmcmFtZVZpZXcpCiAgICAgLy8gQ29tcHV0ZSB0aGUgcmVnaW9uIG9mIHRo ZSBwYWdlIHRoYXQgd2UgY2FuJ3QgZG8gZmFzdCBzY3JvbGxpbmcgZm9yLiBUaGlzIGN1cnJlbnRs eSBpbmNsdWRlcwogICAgIC8vIGFsbCBzY3JvbGxhYmxlIGFyZWFzLCBzdWNoIGFzIHN1YmZyYW1l cywgb3ZlcmZsb3cgZGl2cyBhbmQgbGlzdCBib3hlcy4gV2UgbmVlZCB0byBkbyB0aGlzIGV2ZW4g aWYgdGhlCiAgICAgLy8gZnJhbWUgdmlldyB3aG9zZSBsYXlvdXQgd2FzIHVwZGF0ZWQgaXMgbm90 IHRoZSBtYWluIGZyYW1lLgotICAgIFJlZ2lvbiBub25GYXN0U2Nyb2xsYWJsZVJlZ2lvbiA9IGNv bXB1dGVOb25GYXN0U2Nyb2xsYWJsZVJlZ2lvbihtX3BhZ2UtPm1haW5GcmFtZSgpLT52aWV3KCkp OworICAgIFJlZ2lvbiBub25GYXN0U2Nyb2xsYWJsZVJlZ2lvbiA9IGNvbXB1dGVOb25GYXN0U2Ny b2xsYWJsZVJlZ2lvbihtX3BhZ2UtPm1haW5GcmFtZSgpKTsKICAgICBzZXROb25GYXN0U2Nyb2xs YWJsZVJlZ2lvbihub25GYXN0U2Nyb2xsYWJsZVJlZ2lvbik7CiAKICAgICBpZiAoIWNvb3JkaW5h dGVzU2Nyb2xsaW5nRm9yRnJhbWVWaWV3KGZyYW1lVmlldykpCkBAIC0xNjEsNyArMTU1LDcgQEAg dm9pZCBTY3JvbGxpbmdDb29yZGluYXRvcjo6ZnJhbWVWaWV3U2Nyb2xsYWJsZUFyZWFzRGlkQ2hh bmdlKEZyYW1lVmlldyopCiAgICAgQVNTRVJUKGlzTWFpblRocmVhZCgpKTsKICAgICBBU1NFUlQo bV9wYWdlKTsKIAotICAgIFJlZ2lvbiBub25GYXN0U2Nyb2xsYWJsZVJlZ2lvbiA9IGNvbXB1dGVO b25GYXN0U2Nyb2xsYWJsZVJlZ2lvbihtX3BhZ2UtPm1haW5GcmFtZSgpLT52aWV3KCkpOworICAg IFJlZ2lvbiBub25GYXN0U2Nyb2xsYWJsZVJlZ2lvbiA9IGNvbXB1dGVOb25GYXN0U2Nyb2xsYWJs ZVJlZ2lvbihtX3BhZ2UtPm1haW5GcmFtZSgpKTsKICAgICBzZXROb25GYXN0U2Nyb2xsYWJsZVJl Z2lvbihub25GYXN0U2Nyb2xsYWJsZVJlZ2lvbik7CiB9CiAK