84408 2012-04-19 17:30:12 -0700 REGRESSION(r114690): Broke GlueSerializeTest.BackwardsCompatibleTest in Chromium test_shell_tests (Requested by dimich on #webkit). 2012-04-19 19:05:32 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 84385 1 webkit.review.bot webkit.review.bot aelias dimich japhet oldest_to_newest 606226 0 webkit.review.bot 2012-04-19 17:30:12 -0700 http://trac.webkit.org/changeset/114690 broke the build: Broke GlueSerializeTest.BackwardsCompatibleTest in Chromium test_shell_tests (Requested by dimich on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 606229 1 138014 webkit.review.bot 2012-04-19 17:30:51 -0700 Created attachment 138014 ROLLOUT of r114690 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 606231 2 138014 dimich 2012-04-19 17:33:24 -0700 Comment on attachment 138014 ROLLOUT of r114690 Clearing flags on attachment: 138014 Committed r114703: <http://trac.webkit.org/changeset/114703> 606232 3 dimich 2012-04-19 17:33:29 -0700 All reviewed patches have been landed. Closing bug. 606233 4 dimich 2012-04-19 17:33:59 -0700 The failure: [ RUN ] GlueSerializeTest.BackwardsCompatibleTest /b/build/slave/webkit-mac-latest-dbg/build/src/webkit/glue/glue_serialize_unittest.cc:118: Failure Value of: b.pageScaleFactor() Actual: 0 Expected: a.pageScaleFactor() Which is: 1 /b/build/slave/webkit-mac-latest-dbg/build/src/webkit/glue/glue_serialize_unittest.cc:118: Failure Value of: b.pageScaleFactor() Actual: 0 Expected: a.pageScaleFactor() Which is: 1 /b/build/slave/webkit-mac-latest-dbg/build/src/webkit/glue/glue_serialize_unittest.cc:118: Failure Value of: b.pageScaleFactor() Actual: 0 Expected: a.pageScaleFactor() Which is: 1 /b/build/slave/webkit-mac-latest-dbg/build/src/webkit/glue/glue_serialize_unittest.cc:118: Failure Value of: b.pageScaleFactor() Actual: 0 Expected: a.pageScaleFactor() Which is: 1 /b/build/slave/webkit-mac-latest-dbg/build/src/webkit/glue/glue_serialize_unittest.cc:118: Failure Value of: b.pageScaleFactor() Actual: 0 Expected: a.pageScaleFactor() Which is: 1 /b/build/slave/webkit-mac-latest-dbg/build/src/webkit/glue/glue_serialize_unittest.cc:118: Failure Value of: b.pageScaleFactor() Actual: 0 Expected: a.pageScaleFactor() Which is: 1 /b/build/slave/webkit-mac-latest-dbg/build/src/webkit/glue/glue_serialize_unittest.cc:118: Failure Value of: b.pageScaleFactor() Actual: 0 Expected: a.pageScaleFactor() Which is: 1 /b/build/slave/webkit-mac-latest-dbg/build/src/webkit/glue/glue_serialize_unittest.cc:118: Failure Value of: b.pageScaleFactor() Actual: 0 Expected: a.pageScaleFactor() Which is: 1 /b/build/slave/webkit-mac-latest-dbg/build/src/webkit/glue/glue_serialize_unittest.cc:118: Failure Value of: b.pageScaleFactor() Actual: 0 Expected: a.pageScaleFactor() Which is: 1 /b/build/slave/webkit-mac-latest-dbg/build/src/webkit/glue/glue_serialize_unittest.cc:118: Failure Value of: b.pageScaleFactor() Actual: 0 Expected: a.pageScaleFactor() Which is: 1 [ FAILED ] GlueSerializeTest.BackwardsCompatibleTest (1 ms) 606285 5 aelias 2012-04-19 19:05:32 -0700 The problem was that the GlueSerializeTest was inadvertently relying on the default value. I have a fix pending in https://chromiumcodereview.appspot.com/10153008 138014 2012-04-19 17:30:51 -0700 2012-04-19 17:33:24 -0700 ROLLOUT of r114690 bug-84408-20120420003416.patch text/plain 3349 webkit.review.bot U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0NzAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTlhZjYyOWI1OWYxYzFk M2Q0YTc0OTM4ODRlYmRhMTAwZDQ3MTZhMi4uODAzYzM1NWEwYTlhZDMwYTBlNTNjYTA1ODhkMTZk MDA3ZTY1ZmNlNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA0LTE5ICBTaGVy aWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KKworICAgICAgICBVbnJldmll d2VkLCByb2xsaW5nIG91dCByMTE0NjkwLgorICAgICAgICBodHRwOi8vdHJhYy53ZWJraXQub3Jn L2NoYW5nZXNldC8xMTQ2OTAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTg0NDA4CisKKyAgICAgICAgQnJva2UgR2x1ZVNlcmlhbGl6ZVRlc3QuQmFja3dh cmRzQ29tcGF0aWJsZVRlc3QgaW4gQ2hyb21pdW0KKyAgICAgICAgdGVzdF9zaGVsbF90ZXN0cyAo UmVxdWVzdGVkIGJ5IGRpbWljaCBvbiAjd2Via2l0KS4KKworICAgICAgICAqIGhpc3RvcnkvSGlz dG9yeUl0ZW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6SGlzdG9yeUl0ZW06Okhpc3RvcnlJdGVt KToKKyAgICAgICAgKiBsb2FkZXIvSGlzdG9yeUNvbnRyb2xsZXIuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6SGlzdG9yeUNvbnRyb2xsZXI6OnJlc3RvcmVTY3JvbGxQb3NpdGlvbkFuZFZpZXdTdGF0 ZSk6CisKIDIwMTItMDQtMTkgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgogCiAg ICAgICAgIEVsZW1lbnRBdHRyaWJ1dGVEYXRhIHNob3VsZCBiZSBmYXN0LW1hbGxvYydkLgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaGlzdG9yeS9IaXN0b3J5SXRlbS5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9oaXN0b3J5L0hpc3RvcnlJdGVtLmNwcAppbmRleCBjNTlkYmFiM2I2ZWUxMGJjNDIz YzU0YmQ0N2Q5YmExZWVlYTQyOTQ0Li4yMWM4MWVkZTdlZmUyNjFhZDg2OTc1MWRjZjllOGYyYTQw YTVlODkyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9oaXN0b3J5L0hpc3RvcnlJdGVtLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9oaXN0b3J5L0hpc3RvcnlJdGVtLmNwcApAQCAtNjEsNyAr NjEsNyBAQCB2b2lkICgqbm90aWZ5SGlzdG9yeUl0ZW1DaGFuZ2VkKShIaXN0b3J5SXRlbSopID0g ZGVmYXVsdE5vdGlmeUhpc3RvcnlJdGVtQ2hhbmdlZAogSGlzdG9yeUl0ZW06Okhpc3RvcnlJdGVt KCkKICAgICA6IG1fbGFzdFZpc2l0ZWRUaW1lKDApCiAgICAgLCBtX2xhc3RWaXNpdFdhc0hUVFBO b25HZXQoZmFsc2UpCi0gICAgLCBtX3BhZ2VTY2FsZUZhY3RvcigwKQorICAgICwgbV9wYWdlU2Nh bGVGYWN0b3IoMSkKICAgICAsIG1fbGFzdFZpc2l0V2FzRmFpbHVyZShmYWxzZSkKICAgICAsIG1f aXNUYXJnZXRJdGVtKGZhbHNlKQogICAgICwgbV92aXNpdENvdW50KDApCkBAIC03OCw3ICs3OCw3 IEBAIEhpc3RvcnlJdGVtOjpIaXN0b3J5SXRlbShjb25zdCBTdHJpbmcmIHVybFN0cmluZywgY29u c3QgU3RyaW5nJiB0aXRsZSwgZG91YmxlIHRpCiAgICAgLCBtX3RpdGxlKHRpdGxlKQogICAgICwg bV9sYXN0VmlzaXRlZFRpbWUodGltZSkKICAgICAsIG1fbGFzdFZpc2l0V2FzSFRUUE5vbkdldChm YWxzZSkKLSAgICAsIG1fcGFnZVNjYWxlRmFjdG9yKDApCisgICAgLCBtX3BhZ2VTY2FsZUZhY3Rv cigxKQogICAgICwgbV9sYXN0VmlzaXRXYXNGYWlsdXJlKGZhbHNlKQogICAgICwgbV9pc1Rhcmdl dEl0ZW0oZmFsc2UpCiAgICAgLCBtX3Zpc2l0Q291bnQoMCkKQEAgLTk3LDcgKzk3LDcgQEAgSGlz dG9yeUl0ZW06Okhpc3RvcnlJdGVtKGNvbnN0IFN0cmluZyYgdXJsU3RyaW5nLCBjb25zdCBTdHJp bmcmIHRpdGxlLCBjb25zdCBTdHIKICAgICAsIG1fZGlzcGxheVRpdGxlKGFsdGVybmF0ZVRpdGxl KQogICAgICwgbV9sYXN0VmlzaXRlZFRpbWUodGltZSkKICAgICAsIG1fbGFzdFZpc2l0V2FzSFRU UE5vbkdldChmYWxzZSkKLSAgICAsIG1fcGFnZVNjYWxlRmFjdG9yKDApCisgICAgLCBtX3BhZ2VT Y2FsZUZhY3RvcigxKQogICAgICwgbV9sYXN0VmlzaXRXYXNGYWlsdXJlKGZhbHNlKQogICAgICwg bV9pc1RhcmdldEl0ZW0oZmFsc2UpCiAgICAgLCBtX3Zpc2l0Q291bnQoMCkKQEAgLTExNyw3ICsx MTcsNyBAQCBIaXN0b3J5SXRlbTo6SGlzdG9yeUl0ZW0oY29uc3QgS1VSTCYgdXJsLCBjb25zdCBT dHJpbmcmIHRhcmdldCwgY29uc3QgU3RyaW5nJiBwYQogICAgICwgbV90aXRsZSh0aXRsZSkKICAg ICAsIG1fbGFzdFZpc2l0ZWRUaW1lKDApCiAgICAgLCBtX2xhc3RWaXNpdFdhc0hUVFBOb25HZXQo ZmFsc2UpCi0gICAgLCBtX3BhZ2VTY2FsZUZhY3RvcigwKQorICAgICwgbV9wYWdlU2NhbGVGYWN0 b3IoMSkKICAgICAsIG1fbGFzdFZpc2l0V2FzRmFpbHVyZShmYWxzZSkKICAgICAsIG1faXNUYXJn ZXRJdGVtKGZhbHNlKQogICAgICwgbV92aXNpdENvdW50KDApCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9sb2FkZXIvSGlzdG9yeUNvbnRyb2xsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvbG9h ZGVyL0hpc3RvcnlDb250cm9sbGVyLmNwcAppbmRleCBkNWRmNjM5YmNiOGRlNTk1NTYzNzk0MjFj N2YyMWMyYmVlZWM3OTkwLi5lYzQ3OGE3OTJiZTQyODUzNTIxZjlhNzBjZTc4YTYyMzRkNGY0OTI0 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvSGlzdG9yeUNvbnRyb2xsZXIuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9IaXN0b3J5Q29udHJvbGxlci5jcHAKQEAgLTEy Niw3ICsxMjYsNyBAQCB2b2lkIEhpc3RvcnlDb250cm9sbGVyOjpyZXN0b3JlU2Nyb2xsUG9zaXRp b25BbmRWaWV3U3RhdGUoKQogICAgICAgICBpZiAoIXZpZXctPndhc1Njcm9sbGVkQnlVc2VyKCkp IHsKICAgICAgICAgICAgIHZpZXctPnNldFNjcm9sbFBvc2l0aW9uKG1fY3VycmVudEl0ZW0tPnNj cm9sbFBvaW50KCkpOwogICAgICAgICAgICAgUGFnZSogcGFnZSA9IG1fZnJhbWUtPnBhZ2UoKTsK LSAgICAgICAgICAgIGlmIChwYWdlICYmIHBhZ2UtPm1haW5GcmFtZSgpID09IG1fZnJhbWUgJiYg bV9jdXJyZW50SXRlbS0+cGFnZVNjYWxlRmFjdG9yKCkpCisgICAgICAgICAgICBpZiAocGFnZSAm JiBwYWdlLT5tYWluRnJhbWUoKSA9PSBtX2ZyYW1lKQogICAgICAgICAgICAgICAgIHBhZ2UtPnNl dFBhZ2VTY2FsZUZhY3RvcihtX2N1cnJlbnRJdGVtLT5wYWdlU2NhbGVGYWN0b3IoKSwgbV9jdXJy ZW50SXRlbS0+c2Nyb2xsUG9pbnQoKSk7CiAgICAgICAgIH0KICAgICB9Cg==