84397 2012-04-19 16:09:45 -0700 Web Inspector: Enable touch events feature fails touch feature detection 2012-04-28 07:19:52 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 paulirish apavlov apavlov bweinstein ericbidelman joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 606084 0 paulirish 2012-04-19 16:09:45 -0700 Handling both desktop and touch devices, js app code will often fork the libraries loaded in and behavior wired up depending on if touch events are detected. The most common detect for this is: 'ontouchstart' in window The Emulate Touch Events feature in the Inspector will create touch events, but any code relying on a feature detect will fork in the wrong path. Could the feature also expose touch events like the above in the DOM so the page can fork behavior correctly? 612261 1 139359 apavlov 2012-04-28 06:23:24 -0700 Created attachment 139359 Patch 612272 2 139359 pfeldman 2012-04-28 07:13:31 -0700 Comment on attachment 139359 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=139359&action=review > Source/WebCore/inspector/front-end/DOMAgent.js:1185 > + const functionText = you should declare a function a call toString on it. 612273 3 apavlov 2012-04-28 07:19:52 -0700 Committed r115569: <http://trac.webkit.org/changeset/115569> 139359 2012-04-28 06:23:24 -0700 2012-04-28 07:13:31 -0700 Patch bug-84397-20120428172322.patch text/plain 6178 apavlov U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1NTU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmQ5Mjk0ZGM2YmQxNzY1 OTg5NDkxZGQ5NmRjNWI0OGQ3M2Q2OTNkZi4uMzQ2Njg4YWMxMDY5MzgzM2RmYzczMWQzZWFjN2Jh NWU1ZDZmZWNjYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA0LTI4ICBBbGV4 YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3Bl Y3RvcjogRW5hYmxlIHRvdWNoIGV2ZW50cyBmZWF0dXJlIGZhaWxzIHRvdWNoIGZlYXR1cmUgZGV0 ZWN0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04 NDM5NworCisgICAgICAgIFdoZW5ldmVyIHRoZSB0b3VjaCBlbXVsYXRpb24gaXMgZW5hYmxlZCwg SW5zcGVjdG9yIGFkZHMgYSBzY3JpcHQgdG8gZXZhbHVhdGUgb24gbG9hZCwKKyAgICAgICAgdGhh dCBhZGRzIG9udG91Y2goc3RhcnR8ZW5kfG1vdmV8Y2FuY2VsKSBwcm9wZXJ0aWVzIHRvIHdpbmRv dy5fX3Byb3RvX18gYW5kIGRvY3VtZW50Ll9fcHJvdG9fXy4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvRE9NQWdl bnQuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRE9NQWdlbnQucHJvdG90eXBlLl9lbXVsYXRl VG91Y2hFdmVudHNDaGFuZ2VkLmdldCBpZik6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRE9NQWdl bnQucHJvdG90eXBlLl9lbXVsYXRlVG91Y2hFdmVudHNDaGFuZ2VkLnNjcmlwdEFkZGVkQ2FsbGJh Y2spOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkRPTUFnZW50LnByb3RvdHlwZS5fZW11bGF0ZVRv dWNoRXZlbnRzQ2hhbmdlZCk6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0 b3IuanM6CisKIDIwMTItMDQtMjggIE5pa29sYXMgWmltbWVybWFubiAgPG56aW1tZXJtYW5uQHJp bS5jb20+CiAKICAgICAgICAgRml4IHJlcGV0aXRpb25zICYgYnkgYW5pbWF0aW9uIHN1cHBvcnQg Zm9yIHBhdGggYW5pbWF0aW9ucwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L2Zyb250LWVuZC9ET01BZ2VudC5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvRE9NQWdlbnQuanMKaW5kZXggMzI2NGZlZTJmZmJkZjg4YjUwMjU2NjNkYjliYzI4NjA3NmUx YTY0Ni4uZjk5Y2Q5M2JkMDUyZjM4ZGM2NzcwMWY5OWYwOWJlZWY2MjM4NGIwYiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9ET01BZ2VudC5qcworKysgYi9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0RPTUFnZW50LmpzCkBAIC0xMTgyLDcg KzExODIsMzUgQEAgV2ViSW5zcGVjdG9yLkRPTUFnZW50LnByb3RvdHlwZSA9IHsKIAogICAgIF9l bXVsYXRlVG91Y2hFdmVudHNDaGFuZ2VkOiBmdW5jdGlvbigpCiAgICAgewotICAgICAgICBET01B Z2VudC5zZXRUb3VjaEVtdWxhdGlvbkVuYWJsZWQoV2ViSW5zcGVjdG9yLnNldHRpbmdzLmVtdWxh dGVUb3VjaEV2ZW50cy5nZXQoKSk7CisgICAgICAgIGNvbnN0IGZ1bmN0aW9uVGV4dCA9CisgICAg ICAgICAgICAiY29uc3QgdG91Y2hFdmVudHMgPSBbXCJvbnRvdWNoc3RhcnRcIiwgXCJvbnRvdWNo ZW5kXCIsIFwib250b3VjaG1vdmVcIiwgXCJvbnRvdWNoY2FuY2VsXCJdOyIgKworICAgICAgICAg ICAgImZvciAodmFyIGkgPSAwOyBpIDwgdG91Y2hFdmVudHMubGVuZ3RoOyArK2kpIHsiICsKKyAg ICAgICAgICAgICAgICAiaWYgKCEodG91Y2hFdmVudHNbaV0gaW4gd2luZG93Ll9fcHJvdG9fXykp IiArCisgICAgICAgICAgICAgICAgICAgICJPYmplY3QuZGVmaW5lUHJvcGVydHkod2luZG93Ll9f cHJvdG9fXywgdG91Y2hFdmVudHNbaV0sIHsgdmFsdWU6IG51bGwsIHdyaXRhYmxlOiB0cnVlLCBj b25maWd1cmFibGU6IHRydWUsIGVudW1lcmFibGU6IHRydWUgfSk7XG4iICsKKyAgICAgICAgICAg ICAgICAiaWYgKCEodG91Y2hFdmVudHNbaV0gaW4gZG9jdW1lbnQuX19wcm90b19fKSkiICsKKyAg ICAgICAgICAgICAgICAgICAgIk9iamVjdC5kZWZpbmVQcm9wZXJ0eShkb2N1bWVudC5fX3Byb3Rv X18sIHRvdWNoRXZlbnRzW2ldLCB7IHZhbHVlOiBudWxsLCB3cml0YWJsZTogdHJ1ZSwgY29uZmln dXJhYmxlOiB0cnVlLCBlbnVtZXJhYmxlOiB0cnVlIH0pO1xuIiArCisgICAgICAgICAgICAifSI7 CisKKyAgICAgICAgdmFyIGVtdWxhdGlvbkVuYWJsZWQgPSBXZWJJbnNwZWN0b3Iuc2V0dGluZ3Mu ZW11bGF0ZVRvdWNoRXZlbnRzLmdldCgpOworICAgICAgICBpZiAoZW11bGF0aW9uRW5hYmxlZCAm JiAhdGhpcy5fYWRkVG91Y2hFdmVudHNTY3JpcHRJbmplY3RpbmcpIHsKKyAgICAgICAgICAgIHRo aXMuX2FkZFRvdWNoRXZlbnRzU2NyaXB0SW5qZWN0aW5nID0gdHJ1ZTsKKyAgICAgICAgICAgIFBh Z2VBZ2VudC5hZGRTY3JpcHRUb0V2YWx1YXRlT25Mb2FkKCIoZnVuY3Rpb24oKSB7ICIgKyBmdW5j dGlvblRleHQgKyAiIH0pIiwgc2NyaXB0QWRkZWRDYWxsYmFjay5iaW5kKHRoaXMpKTsKKyAgICAg ICAgfSBlbHNlIHsKKyAgICAgICAgICAgIGlmICh0eXBlb2YgdGhpcy5fYWRkVG91Y2hFdmVudHNT Y3JpcHRJZCAhPT0gInVuZGVmaW5lZCIpIHsKKyAgICAgICAgICAgICAgICBQYWdlQWdlbnQucmVt b3ZlU2NyaXB0VG9FdmFsdWF0ZU9uTG9hZCh0aGlzLl9hZGRUb3VjaEV2ZW50c1NjcmlwdElkKTsK KyAgICAgICAgICAgICAgICBkZWxldGUgdGhpcy5fYWRkVG91Y2hFdmVudHNTY3JpcHRJZDsKKyAg ICAgICAgICAgIH0KKyAgICAgICAgfQorCisgICAgICAgIGZ1bmN0aW9uIHNjcmlwdEFkZGVkQ2Fs bGJhY2soZXJyb3IsIHNjcmlwdElkKQorICAgICAgICB7CisgICAgICAgICAgICBkZWxldGUgdGhp cy5fYWRkVG91Y2hFdmVudHNTY3JpcHRJbmplY3Rpbmc7CisgICAgICAgICAgICBpZiAoZXJyb3Ip CisgICAgICAgICAgICAgICAgcmV0dXJuOworICAgICAgICAgICAgdGhpcy5fYWRkVG91Y2hFdmVu dHNTY3JpcHRJZCA9IHNjcmlwdElkOworICAgICAgICB9CisKKyAgICAgICAgRE9NQWdlbnQuc2V0 VG91Y2hFbXVsYXRpb25FbmFibGVkKGVtdWxhdGlvbkVuYWJsZWQpOwogICAgIH0sCiAKICAgICBt YXJrVW5kb2FibGVTdGF0ZTogZnVuY3Rpb24oKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv aW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qcwppbmRleCA3YzgxNGZkOWRiMGI4ZWQ2NmUxNTllMWIz YTg3ZGIzMTM4YzA2OWM2Li5kNzJiNjhlZjVhNGYyYjgxYmIzZDVhZTY5ZDk2Yjk3Zjc3OTAzMjU5 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rv ci5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5q cwpAQCAtNDg0LDYgKzQ4NCw4IEBAIFdlYkluc3BlY3Rvci5fZG9Mb2FkZWREb25lV2l0aENhcGFi aWxpdGllcyA9IGZ1bmN0aW9uKCkKICAgICBpZiAoV2ViSW5zcGVjdG9yLnNldHRpbmdzLmphdmFT Y3JpcHREaXNhYmxlZC5nZXQoKSkKICAgICAgICAgUGFnZUFnZW50LnNldFNjcmlwdEV4ZWN1dGlv bkRpc2FibGVkKHRydWUpOwogCisgICAgdGhpcy5kb21BZ2VudC5fZW11bGF0ZVRvdWNoRXZlbnRz Q2hhbmdlZCgpOworCiAgICAgV2ViSW5zcGVjdG9yLldvcmtlck1hbmFnZXIubG9hZENvbXBsZXRl ZCgpOwogICAgIEluc3BlY3RvckZyb250ZW5kQVBJLmxvYWRDb21wbGV0ZWQoKTsKIH0KZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRl eCBiYzIzZmM4MjQyYWM2YjM1NDQ3YmIxYTA1MDBlZTEyY2UyNzI3MWFhLi5jN2U0YWEyMjkxODA0 OTU3MmYxOTE1ZjI1OWI2NjNkYTE4MjljNjk0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTIt MDQtMjggIEFsZXhhbmRlciBQYXZsb3YgIDxhcGF2bG92QGNocm9taXVtLm9yZz4KKworICAgICAg ICBXZWIgSW5zcGVjdG9yOiBFbmFibGUgdG91Y2ggZXZlbnRzIGZlYXR1cmUgZmFpbHMgdG91Y2gg ZmVhdHVyZSBkZXRlY3Rpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTg0Mzk3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBmYXN0L2V2ZW50cy90b3VjaC9lbXVsYXRlLXRvdWNoLWV2ZW50cy1leHBlY3Rl ZC50eHQ6CisgICAgICAgICogZmFzdC9ldmVudHMvdG91Y2gvZW11bGF0ZS10b3VjaC1ldmVudHMu aHRtbDoKKwogMjAxMi0wNC0yNyAgTmlrb2xhcyBaaW1tZXJtYW5uICA8bnppbW1lcm1hbm5Acmlt LmNvbT4KIAogICAgICAgICBGaXggcmVwZXRpdGlvbnMgJiBieSBhbmltYXRpb24gc3VwcG9ydCBm b3IgcGF0aCBhbmltYXRpb25zCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy90 b3VjaC9lbXVsYXRlLXRvdWNoLWV2ZW50cy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0 L2V2ZW50cy90b3VjaC9lbXVsYXRlLXRvdWNoLWV2ZW50cy1leHBlY3RlZC50eHQKaW5kZXggOGNm ODI2ZTNiOTEwMTU3ZDNkNzllZWVkNmFjMzQzZjI2NTljZjIwOS4uNmUxMmRmZjY4OTI0ZjJiOWNi ZjdkOWNiODcwYWIyOGI0MjQ4YzBkOSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9ldmVu dHMvdG91Y2gvZW11bGF0ZS10b3VjaC1ldmVudHMtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRl c3RzL2Zhc3QvZXZlbnRzL3RvdWNoL2VtdWxhdGUtdG91Y2gtZXZlbnRzLWV4cGVjdGVkLnR4dApA QCAtMyw2ICszLDggQEAgVGhpcyB0ZXN0cyBzaW5nbGUgdG91Y2ggZXZlbnQgZW11bGF0aW9uIHVz aW5nIG1vdXNlIGV2ZW50cy4KIE9uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAi UEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KIAogCitQQVNTICdv bnRvdWNoc3RhcnQnIGluIHdpbmRvdyBpcyB0cnVlCitQQVNTICdvbnRvdWNoZW5kJyBpbiBkb2N1 bWVudCBpcyB0cnVlCiBQQVNTIGxhc3RFdmVudC50eXBlIGlzICJ0b3VjaHN0YXJ0IgogUEFTUyBs YXN0RXZlbnQudG91Y2hlcy5sZW5ndGggaXMgMQogUEFTUyBsYXN0RXZlbnQuY2hhbmdlZFRvdWNo ZXMubGVuZ3RoIGlzIDEKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL3RvdWNo L2VtdWxhdGUtdG91Y2gtZXZlbnRzLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy90b3Vj aC9lbXVsYXRlLXRvdWNoLWV2ZW50cy5odG1sCmluZGV4IDQ2NTFmNmQyNzExYTAwNGZlYmVkMTQ5 YzM1N2NlZmFlYmI4NTVjZjcuLjMxNzgzMmRjNTM4OGI1NTk4NzA3NDY3OTNlN2YzMDhiMGM5YzEx YTggMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL3RvdWNoL2VtdWxhdGUtdG91 Y2gtZXZlbnRzLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvdG91Y2gvZW11bGF0 ZS10b3VjaC1ldmVudHMuaHRtbApAQCAtODksNiArODksMTAgQEAgaWYgKHdpbmRvdy5ldmVudFNl bmRlciAmJiB3aW5kb3cuaW50ZXJuYWxzICYmIHdpbmRvdy5pbnRlcm5hbHMuc2V0dGluZ3MpIHsK ICAgICB3aW5kb3cuZXZlbnRTZW5kZXIuZHJhZ01vZGUgPSBmYWxzZTsKICAgICB3aW5kb3cuanNU ZXN0SXNBc3luYyA9IHRydWU7CiAgICAgd2luZG93LmludGVybmFscy5zZXR0aW5ncy5zZXRUb3Vj aEV2ZW50RW11bGF0aW9uRW5hYmxlZCh0cnVlKTsKKworICAgIHNob3VsZEJlKCInb250b3VjaHN0 YXJ0JyBpbiB3aW5kb3ciLCAidHJ1ZSIpOworICAgIHNob3VsZEJlKCInb250b3VjaGVuZCcgaW4g ZG9jdW1lbnQiLCAidHJ1ZSIpOworCiAgICAgbW91c2VFdmVudFNlcXVlbmNlKCk7CiB9IGVsc2UK ICAgICBkZWJ1ZygiVGhpcyB0ZXN0IHJlcXVpcmVzIER1bXBSZW5kZXJUcmVlLiBUYXAgb24gdGhl IGJsdWUgcmVjdCB0byBsb2cuIik7Cg==