84378 2012-04-19 13:32:14 -0700 [GTK] media/track/track-cue-rendering-snap-to-lines-not-set.html fails 2012-05-02 08:14:10 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand pnormand eric.carlson feature-media-reviews macpherson menard vcarbune webkit.review.bot oldest_to_newest 605837 0 pnormand 2012-04-19 13:32:14 -0700 Consistently. Diff: --- /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/media/track/track-cue-rendering-snap-to-lines-not-set-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/media/track/track-cue-rendering-snap-to-lines-not-set-actual.txt @@ -2,7 +2,7 @@ EVENT(canplaythrough) The track container and the media controls should completely cover the video element -EXPECTED (cueDisplayContainer.offsetHeight + controlsPanelElement.offsetHeight == video.videoHeight == 'true') OK +EXPECTED (cueDisplayContainer.offsetHeight + controlsPanelElement.offsetHeight == video.videoHeight == 'true'), OBSERVED 'false' FAIL EXPECTED (cueDisplayContainer.offsetWidth == video.videoWidth == 'true') OK ** Default ** This test was introduced in http://trac.webkit.org/changeset/114640 605848 1 vcarbune 2012-04-19 13:50:11 -0700 (In reply to comment #0) > Consistently. Diff: > > --- /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/media/track/track-cue-rendering-snap-to-lines-not-set-expected.txt > +++ /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/media/track/track-cue-rendering-snap-to-lines-not-set-actual.txt > @@ -2,7 +2,7 @@ > EVENT(canplaythrough) > > The track container and the media controls should completely cover the video element > -EXPECTED (cueDisplayContainer.offsetHeight + controlsPanelElement.offsetHeight == video.videoHeight == 'true') OK > +EXPECTED (cueDisplayContainer.offsetHeight + controlsPanelElement.offsetHeight == video.videoHeight == 'true'), OBSERVED 'false' FAIL > EXPECTED (cueDisplayContainer.offsetWidth == video.videoWidth == 'true') OK > > ** Default ** > > This test was introduced in > http://trac.webkit.org/changeset/114640 I believe this particular check fails because the -webkit-media-controls-panel element is absolutely positioned in mediaControlsGTK. This change from absolute to relative positioning is required because the area on top of the video is now a flexible box, with two main boxes on top of each other: cue container box and control panel element. If the panel element is absolutely positioned the flexible box is not positioning it, and the cue container expands towards the bottom of the video. 607007 2 pnormand 2012-04-20 16:10:06 -0700 (In reply to comment #1) > (In reply to comment #0) > > Consistently. Diff: > > > > --- /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/media/track/track-cue-rendering-snap-to-lines-not-set-expected.txt > > +++ /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/media/track/track-cue-rendering-snap-to-lines-not-set-actual.txt > > @@ -2,7 +2,7 @@ > > EVENT(canplaythrough) > > > > The track container and the media controls should completely cover the video element > > -EXPECTED (cueDisplayContainer.offsetHeight + controlsPanelElement.offsetHeight == video.videoHeight == 'true') OK > > +EXPECTED (cueDisplayContainer.offsetHeight + controlsPanelElement.offsetHeight == video.videoHeight == 'true'), OBSERVED 'false' FAIL > > EXPECTED (cueDisplayContainer.offsetWidth == video.videoWidth == 'true') OK > > > > ** Default ** > > > > This test was introduced in > > http://trac.webkit.org/changeset/114640 > I believe this particular check fails because the -webkit-media-controls-panel element is absolutely positioned in mediaControlsGTK. > > This change from absolute to relative positioning is required because the area on top of the video is now a flexible box, with two main boxes on top of each other: cue container box and control panel element. > > If the panel element is absolutely positioned the flexible box is not positioning it, and the cue container expands towards the bottom of the video. Thanks Victor! I was just trying to figure out why the media controls panel was invisible now... And I remembered this bug. Will try your proposed solution and upload a patch. 607013 3 pnormand 2012-04-20 16:19:46 -0700 The invisible controls timeline is a different issue, sorry for the noise. 613447 4 139635 pnormand 2012-05-01 09:18:37 -0700 Created attachment 139635 Patch 613448 5 pnormand 2012-05-01 09:20:00 -0700 (In reply to comment #4) > Created an attachment (id=139635) [details] > Patch When landing this the files DerivedSources/WebCore/UserAgentStyleSheetsData* should be removed on the bots to ensure the updated CSS file is parsed during the build. 613476 6 139635 buildbot 2012-05-01 09:40:09 -0700 Comment on attachment 139635 Patch Attachment 139635 did not pass win-ews (win): Output: http://queues.webkit.org/results/12587591 614293 7 pnormand 2012-05-02 07:39:45 -0700 Committed r115829: <http://trac.webkit.org/changeset/115829> 614307 8 pnormand 2012-05-02 08:14:10 -0700 Hum this patch introduced a regression: bug 85376 139635 2012-05-01 09:18:37 -0700 2012-05-01 09:40:09 -0700 Patch bug-84378-20120501181835.patch text/plain 3077 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1NzE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTg4NDViZWM0NDMxM2M3 ZWI1NTFlMDllY2YwM2IwYjFmNzIzYzc2MS4uOTcyNDhiNzc0ZGIwZTk0MDMzZjczYWJjNjNhYjJh MGJmZDM4ZGU1ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA1LTAxICBQaGls aXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBtZWRp YS90cmFjay90cmFjay1jdWUtcmVuZGVyaW5nLXNuYXAtdG8tbGluZXMtbm90LXNldC5odG1sIGZh aWxzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NDM3 OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBw b3NpdGlvbmluZyBvZiB0aGUgY29udHJvbHMgcGFuZWwgYmFjayB0byByZWxhdGl2ZSwgYXMgaXQg aXMKKyAgICAgICAgaW4gdGhlIHBhcmVudCBDU1MuIEFsc28gcmVtb3ZlIHNvbWUgZHVwbGljYXRl IENTUyBhdHRyaWJ1dGVzLgorCisgICAgICAgICogY3NzL21lZGlhQ29udHJvbHNHdGsuY3NzOgor ICAgICAgICAoYXVkaW86Oi13ZWJraXQtbWVkaWEtY29udHJvbHMtcGFuZWwsIHZpZGVvOjotd2Vi a2l0LW1lZGlhLWNvbnRyb2xzLXBhbmVsKToKKwogMjAxMi0wNC0zMCAgS2VudCBUYW11cmEgIDx0 a2VudEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW0Nocm9taXVtL1dpbmRvd3NdIEFkZCBMb2Nh bGl6ZWREYXRlV2luCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvbWVkaWFDb250cm9s c0d0ay5jc3MgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvbWVkaWFDb250cm9sc0d0ay5jc3MKaW5kZXgg MzAzYjQyOTIwOGIxZDEzNDQxZDllOWFlZDU0ODY3NTVlYTllNjZmOC4uOTRjM2YxZDFkMmI5NWJl NDFmMGUzYmJiMTlmMmZhNWM4Y2I1MjAwMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3Nz L21lZGlhQ29udHJvbHNHdGsuY3NzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9tZWRpYUNvbnRy b2xzR3RrLmNzcwpAQCAtMjYsMTcgKzI2LDkgQEAgYXVkaW8gewogfQogCiBhdWRpbzo6LXdlYmtp dC1tZWRpYS1jb250cm9scy1wYW5lbCwgdmlkZW86Oi13ZWJraXQtbWVkaWEtY29udHJvbHMtcGFu ZWwgewotICAgIGRpc3BsYXk6IC13ZWJraXQtYm94OwotICAgIC13ZWJraXQtYm94LW9yaWVudDog aG9yaXpvbnRhbDsKICAgICAtd2Via2l0LWJveC1hbGlnbjogZW5kOwotICAgIC13ZWJraXQtdXNl ci1zZWxlY3Q6IG5vbmU7Ci0gICAgcG9zaXRpb246IGFic29sdXRlOwotICAgIGJvdHRvbTogMDsK LSAgICB3aWR0aDogMTAwJTsKLSAgICB6LWluZGV4OiAwOwotICAgIG92ZXJmbG93OiBoaWRkZW47 CiAgICAgdGV4dC1hbGlnbjogcmlnaHQ7Ci0gICAgaGVpZ2h0OiAxMDAlOworICAgIGhlaWdodDog MjBweDsKIH0KIAogYXVkaW86Oi13ZWJraXQtbWVkaWEtY29udHJvbHMtbXV0ZS1idXR0b24sIHZp ZGVvOjotd2Via2l0LW1lZGlhLWNvbnRyb2xzLW11dGUtYnV0dG9uIHsKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBjY2M3YjQz ZjZkMTNmNWRmNjk5YWIzNzFlNmI1MTkxMDA4ZjcwMDEzLi42ZDc4YWY2OWU2ODY5MjI5NTAxNjUx ZmQxZDI1Y2UyNDE4ZTlmYTc4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysr IGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTQgQEAKIDIwMTItMDUtMDEgIFBo aWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgogCisgICAgICAgIFtHVEtdIG1l ZGlhL3RyYWNrL3RyYWNrLWN1ZS1yZW5kZXJpbmctc25hcC10by1saW5lcy1ub3Qtc2V0Lmh0bWwg ZmFpbHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg0 Mzc4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBw bGF0Zm9ybS9ndGsvdGVzdF9leHBlY3RhdGlvbnMudHh0OiBVbmZsYWcgZml4ZWQgdGVzdC4KKwor MjAxMi0wNS0wMSAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CisKICAg ICAgICAgVW5yZXZpZXdlZCwgR1RLIHRlc3RfZXhwZWN0YXRpb25zIHVwZGF0ZS4KIAogICAgICAg ICAqIHBsYXRmb3JtL2d0ay90ZXN0X2V4cGVjdGF0aW9ucy50eHQ6IG1lZGlhL3RyYWNrL3RyYWNr LW1vZGUuaHRtbApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL3Rlc3RfZXhw ZWN0YXRpb25zLnR4dCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay90ZXN0X2V4cGVjdGF0aW9u cy50eHQKaW5kZXggOGVkZDI4Zjk0NjM4NzQwNzRhYzM1YTg1ZTRmZWVhOTBiNDQ4M2FiNy4uOWVi YTc1ZDMzMzJhM2ZhNDlmMzdjZTZiM2UwNzdmMGUzMjM3YmRhNSAxMDA2NDQKLS0tIGEvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vZ3RrL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAorKysgYi9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9ndGsvdGVzdF9leHBlY3RhdGlvbnMudHh0CkBAIC0xNTI4LDggKzE1MjgsNiBA QCBCVUdXSzgyNjI4IDogc3ZnL2hpdHRlc3Qvc3ZnLWVsbGlwc2Utbm9uLXNjYWxlLXN0cm9rZS54 aHRtbCA9IEZBSUwKIAogQlVHV0s3Mzc0NCA6IGZhc3QvdGFibGUvdGQtd2lkdGgtZmlmdHktcGVy Y2VudC1yZWdyZXNzaW9uLmh0bWwgPSBGQUlMCiAKLUJVR1dLODQzNzggOiBtZWRpYS90cmFjay90 cmFjay1jdWUtcmVuZGVyaW5nLXNuYXAtdG8tbGluZXMtbm90LXNldC5odG1sID0gRkFJTAotCiBC VUdXSzg0Njc1IDogZmFzdC9mb3Jtcy9kcmFnLWludG8tdGV4dGFyZWEuaHRtbCA9IFRFWFQKIEJV R1dLODQ2NzUgOiBmYXN0L2Zvcm1zL2RyYWctb3V0LW9mLXRleHRhcmVhLmh0bWwgPSBURVhUCiBC VUdXSzg0Njc1IDogZmFzdC9mb3Jtcy9maWxlL2dldC1maWxlLXVwbG9hZC5odG1sID0gVEVYVAo=