84377 2012-04-19 13:23:02 -0700 Initialize member variables in CSSParser's constructor. 2012-04-29 18:27:55 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 macpherson macpherson haraken macpherson menard webkit.review.bot oldest_to_newest 605826 0 macpherson 2012-04-19 13:23:02 -0700 Initialize member variables in CSSParser's constructor. 605828 1 137965 macpherson 2012-04-19 13:23:51 -0700 Created attachment 137965 Patch 605861 2 137965 menard 2012-04-19 14:05:09 -0700 Comment on attachment 137965 Patch INVALID_NUM_PARSED_PROPERTIES seems to be used when clearing this variable. 605870 3 137965 haraken 2012-04-19 14:11:48 -0700 Comment on attachment 137965 Patch OK 605871 4 137965 eric 2012-04-19 14:12:09 -0700 Comment on attachment 137965 Patch Eek. Can this be tested? 605883 5 137965 haraken 2012-04-19 14:18:23 -0700 Comment on attachment 137965 Patch Sorry for the overlooking. 605899 6 macpherson 2012-04-19 14:25:59 -0700 I don't have any particular bug report for this - it's one that has been turned up by static analysis of the code. So in some sense this is tested, in that we regularly run static analysis that detects uninitialized member variables. 605925 7 haraken 2012-04-19 14:37:15 -0700 (In reply to comment #6) > I don't have any particular bug report for this - it's one that has been turned up by static analysis of the code. So in some sense this is tested, in that we regularly run static analysis that detects uninitialized member variables. - We want a test case for each change as long as we can test it. - However, in this case, testing the change is difficult. This is because the initialization value does not matter. In other words, even an uninitialized value would not have caused any issue. - As darktears@ pointed out, if we want to initialize it (we should), it would make sense to initialize it with (not 0 but) INVALID_NUM_PARSED_PROPERTIES. Right? 605947 8 137982 macpherson 2012-04-19 14:52:22 -0700 Created attachment 137982 Patch 605988 9 haraken 2012-04-19 15:16:53 -0700 (In reply to comment #7) > (In reply to comment #6) > > I don't have any particular bug report for this - it's one that has been turned up by static analysis of the code. So in some sense this is tested, in that we regularly run static analysis that detects uninitialized member variables. > > - We want a test case for each change as long as we can test it. > - However, in this case, testing the change is difficult. This is because the initialization value does not matter. In other words, even an uninitialized value would not have caused any issue. > - As darktears@ pointed out, if we want to initialize it (we should), it would make sense to initialize it with (not 0 but) INVALID_NUM_PARSED_PROPERTIES. > > Right? I want to confirm the above understanding before r+ it. 606148 10 haraken 2012-04-19 16:39:18 -0700 (In reply to comment #9) > > - We want a test case for each change as long as we can test it. > > - However, in this case, testing the change is difficult. This is because the initialization value does not matter. In other words, even an uninitialized value would not have caused any issue. > > - As darktears@ pointed out, if we want to initialize it (we should), it would make sense to initialize it with (not 0 but) INVALID_NUM_PARSED_PROPERTIES. > > > > Right? > > I want to confirm the above understanding before r+ it. Luke: Is my understanding right? 606448 11 haraken 2012-04-20 01:48:32 -0700 See also the webkit-dev@ discussion: http://markmail.org/thread/i6lzp4iwwba2yua3 606709 12 macpherson 2012-04-20 10:59:47 -0700 (In reply to comment #10) > (In reply to comment #9) > > > - We want a test case for each change as long as we can test it. > > > - However, in this case, testing the change is difficult. This is because the initialization value does not matter. In other words, even an uninitialized value would not have caused any issue. > > > - As darktears@ pointed out, if we want to initialize it (we should), it would make sense to initialize it with (not 0 but) INVALID_NUM_PARSED_PROPERTIES. > > > > > > Right? > > > > I want to confirm the above understanding before r+ it. > > Luke: Is my understanding right? Yes. 606712 13 haraken 2012-04-20 11:02:33 -0700 (In reply to comment #12) > > Luke: Is my understanding right? > > Yes. OK, then please write the rational to ChangeLog, instead of "No new tests / code cleanup." And let me wait for r+ it until we reach a consensus on how we should treat such kind of fixes in webkit-dev@. 606771 14 138134 macpherson 2012-04-20 11:55:59 -0700 Created attachment 138134 Patch 607860 15 138134 haraken 2012-04-23 11:14:50 -0700 Comment on attachment 138134 Patch It seems we reached consensus on this patch. Please explain that "This bug is detected by static analyzer ..." in ChangeLog, as maciej pointed out. 612460 16 139407 macpherson 2012-04-29 17:50:13 -0700 Created attachment 139407 Patch for landing 612468 17 139407 webkit.review.bot 2012-04-29 18:27:51 -0700 Comment on attachment 139407 Patch for landing Clearing flags on attachment: 139407 Committed r115602: <http://trac.webkit.org/changeset/115602> 612469 18 webkit.review.bot 2012-04-29 18:27:55 -0700 All reviewed patches have been landed. Closing bug. 137965 2012-04-19 13:23:51 -0700 2012-04-19 14:52:14 -0700 Patch bug-84377-20120420062349.patch text/plain 1345 macpherson U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0NjY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODUxNjI1OTJlMWIxYzUx YTdkYTBiYWI5ODc0YzUxNzhhOWE1NmIzMy4uYmRhNDk2ZWFiNDM4ZDZlOGExMGFjNjYxMzljNGI3 YTRhOTMwZTQ1MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA0LTE5ICBMdWtl IE1hY3BoZXJzb24gIDxtYWNwaGVyc29uQGNocm9taXVtLm9yZz4KKworICAgICAgICBJbml0aWFs aXplIG1lbWJlciB2YXJpYWJsZXMgaW4gQ1NTUGFyc2VyJ3MgY29uc3RydWN0b3IuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NDM3NworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyAvIGNv ZGUgY2xlYW51cC4KKworICAgICAgICAqIGNzcy9DU1NQYXJzZXIuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6Q1NTUGFyc2VyOjpDU1NQYXJzZXIpOgorCiAyMDEyLTA0LTE5ICB2c2V2aWtAY2hyb21p dW0ub3JnICA8dnNldmlrQGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBO byByZXNwb25zZSBib2R5IGF2YWlsYWJsZSBmb3IgY2FjaGVkIHJlc291cmNlIHJlcXVlc3RzIHdp dGggZXJyb3Igc3RhdHVzIGNvZGVzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0NT U1BhcnNlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcAppbmRleCA4ODJm MjdjYTI3ODQwMzAxYjBhNzU4NDcyYjZjNmJlMTE0OWQ4MDQyLi4xY2VhYmQ0OTJhZWEzZWZjMTRm ZjViOGI4NDI1M2Y3NTRmN2RiOWU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NT UGFyc2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcApAQCAtMjA0 LDYgKzIwNCw3IEBAIENTU1BhcnNlcjo6Q1NTUGFyc2VyKGNvbnN0IENTU1BhcnNlckNvbnRleHQm IGNvbnRleHQpCiAgICAgLCBtX2lkKENTU1Byb3BlcnR5SW52YWxpZCkKICAgICAsIG1fc3R5bGVT aGVldCgwKQogICAgICwgbV9zZWxlY3Rvckxpc3RGb3JQYXJzZVNlbGVjdG9yKDApCisgICAgLCBt X251bVBhcnNlZFByb3BlcnRpZXNCZWZvcmVNYXJnaW5Cb3goMCkKICAgICAsIG1faW5QYXJzZVNo b3J0aGFuZCgwKQogICAgICwgbV9jdXJyZW50U2hvcnRoYW5kKENTU1Byb3BlcnR5SW52YWxpZCkK ICAgICAsIG1faW1wbGljaXRTaG9ydGhhbmQoZmFsc2UpCg== 137982 2012-04-19 14:52:22 -0700 2012-04-20 11:55:43 -0700 Patch bug-84377-20120420075219.patch text/plain 1338 macpherson U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0NjY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWUyNTk3ZDllN2RkODll NTEwZDk2ZWM0M2JhZDY5NjVmMWI1Yzc2Ny4uYWQzY2IyMjI2Mzc1ZTZkMmZlMjkzZTVhODc4ZjA4 MTYxMzkzZjIyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA0LTE5ICBMdWtl IE1hY3BoZXJzb24gIDxtYWNwaGVyc29uQGNocm9taXVtLm9yZz4KKworICAgICAgICBJbml0aWFs aXplIG1lbWJlciB2YXJpYWJsZXMgaW4gQ1NTUGFyc2VyJ3MgY29uc3RydWN0b3IuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NDM3NworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyAvIGNv ZGUgY2xlYW51cC4KKworICAgICAgICAqIGNzcy9DU1NQYXJzZXIuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6Q1NTUGFyc2VyOjpDU1NQYXJzZXIpOgorCiAyMDEyLTA0LTE5ICBLZW4gQnVjaGFuYW4g IDxrZW5yYkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUG9zaXRpb25lZCBjaGlsZHJlbiBvZiBy dWJ5IHJ1bnMgbm90IGhhbmRsZWQgY29ycmVjdGx5IGR1cmluZyBsYXlvdXQKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL0NT U1BhcnNlci5jcHAKaW5kZXggODgyZjI3Y2EyNzg0MDMwMWIwYTc1ODQ3MmI2YzZiZTExNDlkODA0 Mi4uODg5N2E5OWQzMzdiN2JmNTYyYjM2MTJmMTQxZGYxZGRmY2U0ZTM0NyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3Nz L0NTU1BhcnNlci5jcHAKQEAgLTIwNCw2ICsyMDQsNyBAQCBDU1NQYXJzZXI6OkNTU1BhcnNlcihj b25zdCBDU1NQYXJzZXJDb250ZXh0JiBjb250ZXh0KQogICAgICwgbV9pZChDU1NQcm9wZXJ0eUlu dmFsaWQpCiAgICAgLCBtX3N0eWxlU2hlZXQoMCkKICAgICAsIG1fc2VsZWN0b3JMaXN0Rm9yUGFy c2VTZWxlY3RvcigwKQorICAgICwgbV9udW1QYXJzZWRQcm9wZXJ0aWVzQmVmb3JlTWFyZ2luQm94 KElOVkFMSURfTlVNX1BBUlNFRF9QUk9QRVJUSUVTKQogICAgICwgbV9pblBhcnNlU2hvcnRoYW5k KDApCiAgICAgLCBtX2N1cnJlbnRTaG9ydGhhbmQoQ1NTUHJvcGVydHlJbnZhbGlkKQogICAgICwg bV9pbXBsaWNpdFNob3J0aGFuZChmYWxzZSkK 138134 2012-04-20 11:55:59 -0700 2012-04-29 17:50:03 -0700 Patch bug-84377-20120421045557.patch text/plain 1976 macpherson U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0NzYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmQ5MjAzNDE0ZjcxY2Zk ODNlY2E2NTc4NzA1YzdkYjFkNDRkMzVkZS4uNzFjNmFiYjcyNDkwMzdmZDdhZmYxZmU0YWU0OWVh ODhkNTY0ZTc4ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA0LTE5ICBMdWtl IE1hY3BoZXJzb24gIDxtYWNwaGVyc29uQGNocm9taXVtLm9yZz4KKworICAgICAgICBJbml0aWFs aXplIG1lbWJlciB2YXJpYWJsZXMgaW4gQ1NTUGFyc2VyJ3MgY29uc3RydWN0b3IuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NDM3NworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEl0IGlzIGdvb2QgcHJhY3Rp Y2Ugbm90IHRvIGxlYXZlIG1lbWJlciB2YXJpYWJsZXMgdW5pbml0aWFsaXplZC4gVGhleSBtYWtl IGRlYnVnZ2luZyBtb3JlIGRpZmZpY3VsdCBieSByZWR1Y2luZworICAgICAgICByZXBlYXRhYmls aXR5LCBhbmQgaW4gc29tZSBjYXNlcyBsZWFkIHRvIHRoZSBwb3NzaWJpbGl0eSBvZiBpbmZvcm1h dGlvbiBsZWFrYWdlIG9jY3VyaW5nLiBUaGlzIHBhdGNoIHNpbXBseSBhZGRzCisgICAgICAgIGlu aXRpYWxpemF0aW9uIG9mIG1fbnVtUGFyc2VkUHJvcGVydGllc0JlZm9yZU1hcmdpbkJveCB0byBD U1NQYXJzZXIncyBjb25zdHJ1Y3RvciB0byBJTlZBTElEX05VTV9QQVJTRURfUFJPUEVSVElFUwor ICAgICAgICBzbyB0aGF0IHRoZSBpbml0aWFsIHN0YXRlIGlzIHRoZSBzYW1lIGFzIHRoZSBzdGF0 ZSBhZnRlciB0aGUgcHJvcGVydGllcyBhcmUgY2xlYXJlZC4KKworICAgICAgICBObyB0ZXN0cyBh ZGRlZCBiZWNhdXNlIHRoaXMgaXMgYSBjb2RlIHN0eWxlIGZpeCwgbm90IGFuIGFjdHVhbCBidWcg c28gbG9uZyBhcyB0aGUgYmlzb24gZ2VuZXJhdGVkIGNvZGUgY2FsbHMKKyAgICAgICAgc3RhcnRE ZWNsYXJhdGlvbnNGb3JNYXJnaW5Cb3goKSBhbmQgZW5kRGVjbGFyYXRpb25zRm9yTWFyZ2luQm94 KCkgc3ltbWV0cmljYWxseS4KKworICAgICAgICAqIGNzcy9DU1NQYXJzZXIuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6Q1NTUGFyc2VyOjpDU1NQYXJzZXIpOgorCiAyMDEyLTA0LTIwICBEYW5hIEph bnNlbnMgIDxkYW5ha2pAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gU29tZSBm aWx0ZXJzIHJlcXVpcmUgaW5mbGF0aW5nIGRhbWFnZSByZWN0IGluIENDRGFtYWdlVHJhY2tlcgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9jc3MvQ1NTUGFyc2VyLmNwcAppbmRleCBhYzFjN2RlZWQ2MzI5OTE5YjczMWI2NzRmYzcw ODE4MDQwNTgwZmI3Li44OGY5NjYzZjY4YTUwM2EzYzNmNGU5NDI4OTM4ZTY5YjJiMjU2YjM3IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcApAQCAtMjA0LDYgKzIwNCw3IEBAIENTU1BhcnNlcjo6 Q1NTUGFyc2VyKGNvbnN0IENTU1BhcnNlckNvbnRleHQmIGNvbnRleHQpCiAgICAgLCBtX2lkKENT U1Byb3BlcnR5SW52YWxpZCkKICAgICAsIG1fc3R5bGVTaGVldCgwKQogICAgICwgbV9zZWxlY3Rv ckxpc3RGb3JQYXJzZVNlbGVjdG9yKDApCisgICAgLCBtX251bVBhcnNlZFByb3BlcnRpZXNCZWZv cmVNYXJnaW5Cb3goSU5WQUxJRF9OVU1fUEFSU0VEX1BST1BFUlRJRVMpCiAgICAgLCBtX2luUGFy c2VTaG9ydGhhbmQoMCkKICAgICAsIG1fY3VycmVudFNob3J0aGFuZChDU1NQcm9wZXJ0eUludmFs aWQpCiAgICAgLCBtX2ltcGxpY2l0U2hvcnRoYW5kKGZhbHNlKQo= 139407 2012-04-29 17:50:13 -0700 2012-04-29 18:27:51 -0700 Patch for landing bug-84377-20120430105011.patch text/plain 2013 macpherson U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1NTk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzM4NTc1MmMzZWE1MGFj OWZhNmZiYmRmNjNjMDEzOWZhNmUyMjQ5My4uZTE0ZjMxMjhiYWI3YzU0Yjk3NThhNTY1ZmRkYjc0 ZGU0ZjdhMjVlZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA0LTE5ICBMdWtl IE1hY3BoZXJzb24gIDxtYWNwaGVyc29uQGNocm9taXVtLm9yZz4KKworICAgICAgICBJbml0aWFs aXplIG1lbWJlciB2YXJpYWJsZXMgaW4gQ1NTUGFyc2VyJ3MgY29uc3RydWN0b3IuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NDM3NworCisgICAgICAg IFJldmlld2VkIGJ5IEtlbnRhcm8gSGFyYS4KKworICAgICAgICBJdCBpcyBnb29kIHByYWN0aWNl IG5vdCB0byBsZWF2ZSBtZW1iZXIgdmFyaWFibGVzIHVuaW5pdGlhbGl6ZWQuIFRoZXkgbWFrZSBk ZWJ1Z2dpbmcgbW9yZSBkaWZmaWN1bHQgYnkgcmVkdWNpbmcKKyAgICAgICAgcmVwZWF0YWJpbGl0 eSwgYW5kIGluIHNvbWUgY2FzZXMgbGVhZCB0byB0aGUgcG9zc2liaWxpdHkgb2YgaW5mb3JtYXRp b24gbGVha2FnZSBvY2N1cmluZy4gVGhpcyBwYXRjaCBzaW1wbHkgYWRkcworICAgICAgICBpbml0 aWFsaXphdGlvbiBvZiBtX251bVBhcnNlZFByb3BlcnRpZXNCZWZvcmVNYXJnaW5Cb3ggdG8gQ1NT UGFyc2VyJ3MgY29uc3RydWN0b3IgdG8gSU5WQUxJRF9OVU1fUEFSU0VEX1BST1BFUlRJRVMKKyAg ICAgICAgc28gdGhhdCB0aGUgaW5pdGlhbCBzdGF0ZSBpcyB0aGUgc2FtZSBhcyB0aGUgc3RhdGUg YWZ0ZXIgdGhlIHByb3BlcnRpZXMgYXJlIGNsZWFyZWQuCisKKyAgICAgICAgTm8gdGVzdHMgYWRk ZWQgYmVjYXVzZSB0aGlzIGlzIGEgY29kZSBzdHlsZSBmaXgsIG5vdCBhbiBhY3R1YWwgYnVnIHNv IGxvbmcgYXMgdGhlIGJpc29uIGdlbmVyYXRlZCBjb2RlIGNhbGxzCisgICAgICAgIHN0YXJ0RGVj bGFyYXRpb25zRm9yTWFyZ2luQm94KCkgYW5kIGVuZERlY2xhcmF0aW9uc0Zvck1hcmdpbkJveCgp IHN5bW1ldHJpY2FsbHkuIFRoZSBsYWNrIG9mIGluaXRpYWxpemF0aW9uIHdhcworICAgICAgICBv cmlnaW5hbGx5IGRldGVjdGVkIGJ5IGNvdmVyaXR5LgorCisgICAgICAgICogY3NzL0NTU1BhcnNl ci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NQYXJzZXI6OkNTU1BhcnNlcik6CisKIDIwMTIt MDQtMjkgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBBZGQgc3VwcG9y dCBmb3IgdGhlIEJsb2IgY29uc3RydWN0b3IgKFBhcnQgMikKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5j cHAKaW5kZXggMjk0N2QxNmQ0ZWQyNDE4MGRlZDBlNjY3OGZlZTk0NjYyNWU2ODYwMy4uNTY3MGJh ZjIyYjE2ZjMzYjkyOTNjM2Y4YWNjYzEzYjU0NGRiYTMzNCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNl ci5jcHAKQEAgLTIyMiw2ICsyMjIsNyBAQCBDU1NQYXJzZXI6OkNTU1BhcnNlcihjb25zdCBDU1NQ YXJzZXJDb250ZXh0JiBjb250ZXh0KQogICAgICwgbV9pZChDU1NQcm9wZXJ0eUludmFsaWQpCiAg ICAgLCBtX3N0eWxlU2hlZXQoMCkKICAgICAsIG1fc2VsZWN0b3JMaXN0Rm9yUGFyc2VTZWxlY3Rv cigwKQorICAgICwgbV9udW1QYXJzZWRQcm9wZXJ0aWVzQmVmb3JlTWFyZ2luQm94KElOVkFMSURf TlVNX1BBUlNFRF9QUk9QRVJUSUVTKQogICAgICwgbV9pblBhcnNlU2hvcnRoYW5kKDApCiAgICAg LCBtX2N1cnJlbnRTaG9ydGhhbmQoQ1NTUHJvcGVydHlJbnZhbGlkKQogICAgICwgbV9pbXBsaWNp dFNob3J0aGFuZChmYWxzZSkK