84375 2012-04-19 13:18:49 -0700 [Chromium] Tooltip issue with visually contiguous elements having the same `title` attribute 2012-05-18 09:39:39 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID http://jsbin.com/omahe3 P2 Normal --- 43112 1 shezbaig.wk shezbaig.wk abarth eric fishd shezbaig.wk oldest_to_newest 605817 0 shezbaig.wk 2012-04-19 13:18:49 -0700 Webkit behaves oddly when visually contiguous elements have the same value for the `title` attribute. As soon as you start hovering one of them, the title tooltip won’t move as you move to another element. Needless to say, this can be very annoying. Quick test case at http://jsbin.com/omahe3 This is to track the Chromium fix for bug 43112. Patch will follow shortly 605893 1 137974 shezbaig.wk 2012-04-19 14:23:34 -0700 Created attachment 137974 Patch for review 605901 2 shezbaig.wk 2012-04-19 14:26:42 -0700 CC Adam for review 605906 3 shezbaig.wk 2012-04-19 14:28:33 -0700 CC Darin (Adam is away) 612894 4 139505 shezbaig.wk 2012-04-30 13:19:42 -0700 Created attachment 139505 Patch (without dangling pointer) remove the dangling pointer issue from the first patch. Instead of keeping a pointer to the hold, this patch keeps the rect of the node 612907 5 shezbaig.wk 2012-04-30 13:27:09 -0700 correction: instead of keeping a pointer to the *node*, this patch keeps the rect of the node 617983 6 eric 2012-05-07 15:09:12 -0700 Seems very odd to be keeping this extra state on ChromeClient. :( But I'm not the right reviewer for this patch. 617994 7 shezbaig.wk 2012-05-07 15:20:17 -0700 I saw your name in the svn blame of setToolTip, although that was from the initial checkin at rev 50741 ;) Maybe WebViewImpl is a better place to keep this state? I tried to avoid affecting cross-platform code for this though, but maybe I should just remove this bug and make a cross-platform change in bug 43112 618000 8 eric 2012-05-07 15:23:51 -0700 Presumably that's from when the commit-queue was running under my account. You should look at the ChangeLog to find who wrote the actual patch. :) 627758 9 shezbaig.wk 2012-05-18 09:39:39 -0700 I'll make this change in bug 43112 for all platforms 137974 2012-04-19 14:23:34 -0700 2012-04-30 13:19:42 -0700 Patch bug-84375-20120419171422.patch text/plain 3810 shezbaig.wk U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0NjI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDA0NDA5ZWEyOGVkYzQ2N2E5OTYwN2Q4ODMxODgyNWEyNWMxNDZmM2UuLjhkZWExNGJkMGJiZGFk NTE1MDAyOTI3NDc3YjkxMGVhZGFlYmY3ZjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjcgQEAKKzIwMTItMDQtMTkgIFNoZXphbiBCYWlnICA8c2hlemJhaWcud2tAZ21h aWwuY29tPgorCisgICAgICAgIFtDaHJvbWl1bV0gVG9vbHRpcCBpc3N1ZSB3aXRoIHZpc3VhbGx5 IGNvbnRpZ3VvdXMgZWxlbWVudHMgaGF2aW5nIHRoZSBzYW1lIGB0aXRsZWAgYXR0cmlidXRlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NDM3NQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIGZsYWcg dG8ga2VlcCB0cmFjayBvZiB3aGV0aGVyIHRoZSBsYXN0IHNldFRvb2x0aXBUZXh0IGFjdHVhbGx5 CisgICAgICAgIGNvbnRhaW5lZCBhbnkgdGV4dC4gIElmIGl0IGRvZXMsIHRoZW4gd2hlbmV2ZXIg dGhlIG1vdXNlIG1vdmVzIG92ZXIgYQorICAgICAgICBuZXcgZWxlbWVudCwgaW52b2tlIHNldFRv b2xUaXBUZXh0IGFnYWluIHdpdGggYW4gZW1wdHkgc3RyaW5nLCBjYXVzaW5nCisgICAgICAgIHRo ZSB0b29sdGlwIHRvIGRpc2FwcGVhci4gIElmIHRoZSBuZXdseSBtb3VzZS1vdmVyJ2QgZWxlbWVu dCBjb250YWlucyBhCisgICAgICAgIHRvb2x0aXAsIHNldFRvb2xUaXAgd2lsbCBiZSBjYWxsZWQg YWdhaW4gd2l0aCB0aGUgbmV3IHRleHQsIGFuZCB0aGUKKyAgICAgICAgdG9vbHRpcCB3aWxsIGFw cGVhciBpbiB0aGUgY29ycmVjdCBsb2NhdGlvbiBuZWFyIHRoZSBtb3VzZS4KKworICAgICAgICBO byB0ZXN0cyBhZGRlZCBhcyBpdCBpcyBub3QgY2xlYXIgaG93IHRvIHRlc3QgYSB0b29sIHRpcCBm cm9tCisgICAgICAgIER1bXBSZW5kZXJUcmVlLgorCisgICAgICAgICogc3JjL0Nocm9tZUNsaWVu dEltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpDaHJvbWVDbGllbnRJbXBsOjpDaHJvbWVDbGll bnRJbXBsKToKKyAgICAgICAgKFdlYktpdDo6Q2hyb21lQ2xpZW50SW1wbDo6bW91c2VEaWRNb3Zl T3ZlckVsZW1lbnQpOgorICAgICAgICAoV2ViS2l0OjpDaHJvbWVDbGllbnRJbXBsOjpzZXRUb29s VGlwKToKKyAgICAgICAgKiBzcmMvQ2hyb21lQ2xpZW50SW1wbC5oOgorICAgICAgICAoQ2hyb21l Q2xpZW50SW1wbCk6CisKIDIwMTItMDQtMTggIE5pY28gV2ViZXIgIDx0aGFraXNAY2hyb21pdW0u b3JnPgogCiAgICAgICAgIFtjaHJvbWl1bS9tYWNdIEZpeCBidWlsZC4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0Nocm9tZUNsaWVudEltcGwuY3BwIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9zcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHAKaW5kZXggMTk5MmNkNGFhYWY2 NWRkOTFmNTA2MWNkZjkzNWEyOGZhMDA1YjFmZC4uNjc5NTZlNTc4OWIwMjRkZGFmNGVlMDc1ZGZl MGE1MWJiODM2MjhlNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQ2hy b21lQ2xpZW50SW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21l Q2xpZW50SW1wbC5jcHAKQEAgLTEzMyw2ICsxMzMsOCBAQCBzdGF0aWMgV2ViQWNjZXNzaWJpbGl0 eU5vdGlmaWNhdGlvbiB0b1dlYkFjY2Vzc2liaWxpdHlOb3RpZmljYXRpb24oQVhPYmplY3RDYWNo ZQogCiBDaHJvbWVDbGllbnRJbXBsOjpDaHJvbWVDbGllbnRJbXBsKFdlYlZpZXdJbXBsKiB3ZWJW aWV3KQogICAgIDogbV93ZWJWaWV3KHdlYlZpZXcpCisgICAgLCBtX2xhc3RNb3VzZU92ZXJOb2Rl KDApCisgICAgLCBtX2xhc3RUb29sdGlwSGFkVGV4dChmYWxzZSkKICAgICAsIG1fdG9vbGJhcnNW aXNpYmxlKHRydWUpCiAgICAgLCBtX3N0YXR1c2JhclZpc2libGUodHJ1ZSkKICAgICAsIG1fc2Ny b2xsYmFyc1Zpc2libGUodHJ1ZSkKQEAgLTYyNiw2ICs2MjgsMTYgQEAgdm9pZCBDaHJvbWVDbGll bnRJbXBsOjptb3VzZURpZE1vdmVPdmVyRWxlbWVudCgKICAgICB9CiAKICAgICBtX3dlYlZpZXct PmNsaWVudCgpLT5zZXRNb3VzZU92ZXJVUkwodXJsKTsKKworICAgIC8vIElmIHdlIGRpc3BsYXll ZCBhIHRvb2x0aXAgZWFybGllciwgYW5kIHdlIG1vdmUgb3ZlciBhIG5ldyBub2RlLCBtYWtlCisg ICAgLy8gc3VyZSB3ZSB1bnNldCB0aGUgdG9vbHRpcC4gSWYgdGhlIG5ldyBub2RlIGhhcyBhIHRv b2x0aXAsIHRoZW4KKyAgICAvLyBzZXRUb29sVGlwIHdpbGwgYmUgY2FsbGVkIGxhdGVyIHdpdGgg dGhlIG5ldyB0ZXh0LgorICAgIGlmIChtX2xhc3RUb29sdGlwSGFkVGV4dCAmJiBtX2xhc3RNb3Vz ZU92ZXJOb2RlICE9IHJlc3VsdC5pbm5lck5vblNoYXJlZE5vZGUoKSkgeworICAgICAgICBtX3dl YlZpZXctPmNsaWVudCgpLT5zZXRUb29sVGlwVGV4dChTdHJpbmcoKSwgV2ViVGV4dERpcmVjdGlv bkxlZnRUb1JpZ2h0KTsKKyAgICAgICAgbV9sYXN0VG9vbHRpcEhhZFRleHQgPSBmYWxzZTsKKyAg ICB9CisKKyAgICBtX2xhc3RNb3VzZU92ZXJOb2RlID0gcmVzdWx0LmlubmVyTm9uU2hhcmVkTm9k ZSgpOwogfQogCiB2b2lkIENocm9tZUNsaWVudEltcGw6OnNldFRvb2xUaXAoY29uc3QgU3RyaW5n JiB0b29sdGlwVGV4dCwgVGV4dERpcmVjdGlvbiBkaXIpCkBAIC02MzcsNiArNjQ5LDcgQEAgdm9p ZCBDaHJvbWVDbGllbnRJbXBsOjpzZXRUb29sVGlwKGNvbnN0IFN0cmluZyYgdG9vbHRpcFRleHQs IFRleHREaXJlY3Rpb24gZGlyKQogICAgICAgICBXZWJUZXh0RGlyZWN0aW9uTGVmdFRvUmlnaHQ7 CiAgICAgbV93ZWJWaWV3LT5jbGllbnQoKS0+c2V0VG9vbFRpcFRleHQoCiAgICAgICAgIHRvb2x0 aXBUZXh0LCB0ZXh0RGlyZWN0aW9uKTsKKyAgICBtX2xhc3RUb29sdGlwSGFkVGV4dCA9ICF0b29s dGlwVGV4dC5pc0VtcHR5KCk7CiB9CiAKIHZvaWQgQ2hyb21lQ2xpZW50SW1wbDo6ZGlzcGF0Y2hW aWV3cG9ydFByb3BlcnRpZXNEaWRDaGFuZ2UoY29uc3QgVmlld3BvcnRBcmd1bWVudHMmIGFyZ3Vt ZW50cykgY29uc3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0Nocm9t ZUNsaWVudEltcGwuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0Nocm9tZUNsaWVudElt cGwuaAppbmRleCA1ODk0MTc3ZTAxMjFkMThkNWUzNzQ5YmJkMjZiMThmMjY5ZGE4ZTU1Li5lZDYw YjU0OGIzYTBhNmNiYzVkYWY3ZGY3Zjk3NjE3NmU3MzJkMTZmIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3NyYy9DaHJvbWVDbGllbnRJbXBsLmgKKysrIGIvU291cmNlL1dlYktp dC9jaHJvbWl1bS9zcmMvQ2hyb21lQ2xpZW50SW1wbC5oCkBAIC0yMjAsNiArMjIwLDggQEAgcHJp dmF0ZToKICAgICB2b2lkIHNldEN1cnNvcihjb25zdCBXZWJDdXJzb3JJbmZvJik7CiAKICAgICBX ZWJWaWV3SW1wbCogbV93ZWJWaWV3OyAgLy8gd2VhayBwb2ludGVyCisgICAgV2ViQ29yZTo6Tm9k ZSogbV9sYXN0TW91c2VPdmVyTm9kZTsgLy8gd2VhayBwb2ludGVyCisgICAgYm9vbCBtX2xhc3RU b29sdGlwSGFkVGV4dDsKICAgICBib29sIG1fdG9vbGJhcnNWaXNpYmxlOwogICAgIGJvb2wgbV9z dGF0dXNiYXJWaXNpYmxlOwogICAgIGJvb2wgbV9zY3JvbGxiYXJzVmlzaWJsZTsK 139505 2012-04-30 13:19:42 -0700 2012-05-18 09:38:55 -0700 Patch (without dangling pointer) bug-84375-20120430161707.patch text/plain 4506 shezbaig.wk U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1NjI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGQ4MjY1MjUwN2M3YTUwZTQ1NDc1YWRhMGY0ZGE3YzdkYjg0NGY3ZjUuLjQ4NTUwMmM1Y2MxZDRh MzExMTRjMTkwNzg1MjAxNGZkYzhhMmQ3ODIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjkgQEAKKzIwMTItMDQtMzAgIFNoZXphbiBCYWlnICA8c2hlemJhaWcud2tAZ21h aWwuY29tPgorCisgICAgICAgIFtDaHJvbWl1bV0gVG9vbHRpcCBpc3N1ZSB3aXRoIHZpc3VhbGx5 IGNvbnRpZ3VvdXMgZWxlbWVudHMgaGF2aW5nIHRoZSBzYW1lIGB0aXRsZWAgYXR0cmlidXRlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NDM3NQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIGZsYWcg dG8ga2VlcCB0cmFjayBvZiB3aGV0aGVyIHRoZSBsYXN0IHNldFRvb2x0aXBUZXh0IGFjdHVhbGx5 CisgICAgICAgIGNvbnRhaW5lZCBhbnkgdGV4dC4gQWxzbyBhZGQgYSByZWN0IHRvIGtlZXAgdHJh Y2sgb2YgdGhlIHJlY3Qgb2YgdGhlCisgICAgICAgIGxhc3Qgbm9kZSB0aGF0IHRoZSBtb3VzZSBt b3ZlZCBvdmVyLiBXaGVuZXZlciB0aGUgbW91c2UgbW92ZXMgb3ZlciBhCisgICAgICAgIG5vZGUg d2l0aCBhIGRpZmZlcmVudCByZWN0LCBpbnZva2Ugc2V0VG9vbFRpcFRleHQgYWdhaW4gd2l0aCBh biBlbXB0eQorICAgICAgICBzdHJpbmcsIGNhdXNpbmcgdGhlIHRvb2x0aXAgdG8gZGlzYXBwZWFy LiAgSWYgdGhlIG5ld2x5IG1vdXNlLW92ZXInZAorICAgICAgICBub2RlIGNvbnRhaW5zIGEgdG9v bHRpcCwgc2V0VG9vbFRpcCB3aWxsIGJlIGNhbGxlZCBhZ2FpbiB3aXRoIHRoZSBuZXcKKyAgICAg ICAgdGV4dCwgYW5kIHRoZSB0b29sdGlwIHdpbGwgYXBwZWFyIGluIHRoZSBjb3JyZWN0IGxvY2F0 aW9uIG5lYXIgdGhlCisgICAgICAgIG1vdXNlLgorCisgICAgICAgIE5vIHRlc3RzIGFkZGVkIGFz IGl0IGlzIG5vdCBjbGVhciBob3cgdG8gdGVzdCBhIHRvb2wgdGlwIGZyb20KKyAgICAgICAgRHVt cFJlbmRlclRyZWUuCisKKyAgICAgICAgKiBzcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHA6CisgICAg ICAgIChXZWJLaXQ6OkNocm9tZUNsaWVudEltcGw6OkNocm9tZUNsaWVudEltcGwpOgorICAgICAg ICAoV2ViS2l0OjpDaHJvbWVDbGllbnRJbXBsOjptb3VzZURpZE1vdmVPdmVyRWxlbWVudCk6Cisg ICAgICAgIChXZWJLaXQ6OkNocm9tZUNsaWVudEltcGw6OnNldFRvb2xUaXApOgorICAgICAgICAq IHNyYy9DaHJvbWVDbGllbnRJbXBsLmg6CisgICAgICAgIChDaHJvbWVDbGllbnRJbXBsKToKKwog MjAxMi0wNC0yOSAgTWFyayBQaWxncmltICA8cGlsZ3JpbUBjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgW0Nocm9taXVtXSBDYWxsIGhpZ2hVc2FnZURlbHRhTUIgZGlyZWN0bHkKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0Nocm9tZUNsaWVudEltcGwuY3BwIGIvU291cmNl L1dlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHAKaW5kZXggMTk5MmNkNGFh YWY2NWRkOTFmNTA2MWNkZjkzNWEyOGZhMDA1YjFmZC4uYmZhYWI4ZWI5MTAxZGM3NGQwZTk4NjM2 MmM2ZjA4ZGRiMDIyNDRmZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMv Q2hyb21lQ2xpZW50SW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQ2hy b21lQ2xpZW50SW1wbC5jcHAKQEAgLTEzMyw2ICsxMzMsNyBAQCBzdGF0aWMgV2ViQWNjZXNzaWJp bGl0eU5vdGlmaWNhdGlvbiB0b1dlYkFjY2Vzc2liaWxpdHlOb3RpZmljYXRpb24oQVhPYmplY3RD YWNoZQogCiBDaHJvbWVDbGllbnRJbXBsOjpDaHJvbWVDbGllbnRJbXBsKFdlYlZpZXdJbXBsKiB3 ZWJWaWV3KQogICAgIDogbV93ZWJWaWV3KHdlYlZpZXcpCisgICAgLCBtX2xhc3RUb29sdGlwSGFk VGV4dChmYWxzZSkKICAgICAsIG1fdG9vbGJhcnNWaXNpYmxlKHRydWUpCiAgICAgLCBtX3N0YXR1 c2JhclZpc2libGUodHJ1ZSkKICAgICAsIG1fc2Nyb2xsYmFyc1Zpc2libGUodHJ1ZSkKQEAgLTYy Niw2ICs2MjcsMjggQEAgdm9pZCBDaHJvbWVDbGllbnRJbXBsOjptb3VzZURpZE1vdmVPdmVyRWxl bWVudCgKICAgICB9CiAKICAgICBtX3dlYlZpZXctPmNsaWVudCgpLT5zZXRNb3VzZU92ZXJVUkwo dXJsKTsKKworICAgIC8vIFRoZSByZWN0Rm9yVG9vbHRpcCBpcyBuZXZlciBleHBvc2VkIHRvIHRo ZSBXZWJWaWV3Q2xpZW50LiBJdHMgb25seQorICAgIC8vIHB1cnBvc2UgaGVyZSBpcyB0byBkZXRl Y3Qgd2hldGhlciB0aGUgbW91c2UgbW92ZWQgb3ZlciBhIG5ldyBlbGVtZW50LCBvcgorICAgIC8v IHdoZXRoZXIgdGhlIGVsZW1lbnQgaGFzIG1vdmVkLiBJbiBvcmRlciB0byBtYWtlIHRoZSB0b29s dGlwIGFwcGVhciBhdAorICAgIC8vIHRoZSBjb3JyZWN0IGxvY2F0aW9uLCB3ZSB3aWxsIGNhbGwg c2V0VG9vbFRpcFRleHQgd2l0aCBhbiBlbXB0eSBzdHJpbmcKKyAgICAvLyB3aGVuIHRoZSBtb3Vz ZSBtb3ZlcyBvdmVyIGEgZGlmZmVyZW50IG5vZGUsIHNvIHRoYXQgdGhlIGV4aXN0aW5nIHRvb2x0 aXAKKyAgICAvLyB3aWxsIGJlIHJlbW92ZWQuIElmIHRoaXMgbm9kZSBoYXMgYSB0b29sdGlwLCB0 aGVuIHNldFRvb2xUaXAgd2lsbCBiZQorICAgIC8vIGNhbGxlZCBsYXRlciwgYXQgd2hpY2ggcG9p bnQgdGhlIHRvb2x0aXAgd2lsbCBiZSBkaXNwbGF5ZWQgYXQgdGhlCisgICAgLy8gY29ycmVjdCBs b2NhdGlvbi4KKyAgICBJbnRSZWN0IHJlY3RGb3JUb29sdGlwOworICAgIGlmIChOb2RlKiBub2Rl ID0gcmVzdWx0LmlubmVyTm9uU2hhcmVkTm9kZSgpKSB7CisgICAgICAgIEZyYW1lKiBmcmFtZSA9 IG5vZGUtPmRvY3VtZW50KCktPmZyYW1lKCk7CisgICAgICAgIEZyYW1lVmlldyogdmlldyA9IGZy YW1lID8gZnJhbWUtPnZpZXcoKSA6IDA7CisgICAgICAgIHJlY3RGb3JUb29sdGlwID0gdmlldyA/ IHZpZXctPmNvbnRlbnRzVG9XaW5kb3cobm9kZS0+Z2V0UmVjdCgpKSA6IEludFJlY3QoKTsKKyAg ICB9CisKKyAgICBpZiAobV9sYXN0VG9vbHRpcEhhZFRleHQgJiYgbV9sYXN0UmVjdEZvclRvb2x0 aXAgIT0gcmVjdEZvclRvb2x0aXApIHsKKyAgICAgICAgbV93ZWJWaWV3LT5jbGllbnQoKS0+c2V0 VG9vbFRpcFRleHQoU3RyaW5nKCksIFdlYlRleHREaXJlY3Rpb25MZWZ0VG9SaWdodCk7CisgICAg ICAgIG1fbGFzdFRvb2x0aXBIYWRUZXh0ID0gZmFsc2U7CisgICAgfQorCisgICAgbV9sYXN0UmVj dEZvclRvb2x0aXAgPSByZWN0Rm9yVG9vbHRpcDsKIH0KIAogdm9pZCBDaHJvbWVDbGllbnRJbXBs OjpzZXRUb29sVGlwKGNvbnN0IFN0cmluZyYgdG9vbHRpcFRleHQsIFRleHREaXJlY3Rpb24gZGly KQpAQCAtNjM3LDYgKzY2MCw3IEBAIHZvaWQgQ2hyb21lQ2xpZW50SW1wbDo6c2V0VG9vbFRpcChj b25zdCBTdHJpbmcmIHRvb2x0aXBUZXh0LCBUZXh0RGlyZWN0aW9uIGRpcikKICAgICAgICAgV2Vi VGV4dERpcmVjdGlvbkxlZnRUb1JpZ2h0OwogICAgIG1fd2ViVmlldy0+Y2xpZW50KCktPnNldFRv b2xUaXBUZXh0KAogICAgICAgICB0b29sdGlwVGV4dCwgdGV4dERpcmVjdGlvbik7CisgICAgbV9s YXN0VG9vbHRpcEhhZFRleHQgPSAhdG9vbHRpcFRleHQuaXNFbXB0eSgpOwogfQogCiB2b2lkIENo cm9tZUNsaWVudEltcGw6OmRpc3BhdGNoVmlld3BvcnRQcm9wZXJ0aWVzRGlkQ2hhbmdlKGNvbnN0 IFZpZXdwb3J0QXJndW1lbnRzJiBhcmd1bWVudHMpIGNvbnN0CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3NyYy9DaHJvbWVDbGllbnRJbXBsLmggYi9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3NyYy9DaHJvbWVDbGllbnRJbXBsLmgKaW5kZXggNTg5NDE3N2UwMTIxZDE4ZDVlMzc0 OWJiZDI2YjE4ZjI2OWRhOGU1NS4uMDkyYzNhMmE1NjIwNTcxNzYzMWNjODM1NjY1YjEyNGEyMzVm NDlhYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21lQ2xpZW50 SW1wbC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0Nocm9tZUNsaWVudEltcGwu aApAQCAtMjIwLDYgKzIyMCw4IEBAIHByaXZhdGU6CiAgICAgdm9pZCBzZXRDdXJzb3IoY29uc3Qg V2ViQ3Vyc29ySW5mbyYpOwogCiAgICAgV2ViVmlld0ltcGwqIG1fd2ViVmlldzsgIC8vIHdlYWsg cG9pbnRlcgorICAgIFdlYkNvcmU6OkludFJlY3QgbV9sYXN0UmVjdEZvclRvb2x0aXA7CisgICAg Ym9vbCBtX2xhc3RUb29sdGlwSGFkVGV4dDsKICAgICBib29sIG1fdG9vbGJhcnNWaXNpYmxlOwog ICAgIGJvb2wgbV9zdGF0dXNiYXJWaXNpYmxlOwogICAgIGJvb2wgbV9zY3JvbGxiYXJzVmlzaWJs ZTsK