84369 2012-04-19 12:19:05 -0700 Clean up list iteration in MediaQueryExp constructor (avoid unnecessary calls to current()). 2012-04-19 14:57:20 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 macpherson macpherson eric.carlson feature-media-reviews macpherson menard webkit.review.bot oldest_to_newest 605785 0 macpherson 2012-04-19 12:19:05 -0700 Clean up list iteration in MediaQueryExp constructor (avoid unnecessary calls to current()). 605786 1 137948 macpherson 2012-04-19 12:19:58 -0700 Created attachment 137948 Patch 605890 2 137948 eric 2012-04-19 14:22:27 -0700 Comment on attachment 137948 Patch I'm confused. The old code was setting value every time? Making the value = valueList->next() never do anything? 605930 3 macpherson 2012-04-19 14:39:13 -0700 The old code calls value = value->current() for every iteration, which is unnecessary because the value->current() is the same as the previous assignment from value->next(). 605953 4 137948 webkit.review.bot 2012-04-19 14:57:15 -0700 Comment on attachment 137948 Patch Clearing flags on attachment: 137948 Committed r114676: <http://trac.webkit.org/changeset/114676> 605954 5 webkit.review.bot 2012-04-19 14:57:20 -0700 All reviewed patches have been landed. Closing bug. 137948 2012-04-19 12:19:58 -0700 2012-04-19 14:57:15 -0700 Patch bug-84369-20120420051956.patch text/plain 1826 macpherson U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0NjYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODUxNjI1OTJlMWIxYzUx YTdkYTBiYWI5ODc0YzUxNzhhOWE1NmIzMy4uYzYxNzY3ODdiMjY3NGRlNTljYjBlYjE3NDgyODE0 YWE4YjdmMTU3MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA0LTE5ICBMdWtl IE1hY3BoZXJzb24gIDxtYWNwaGVyc29uQGNocm9taXVtLm9yZz4KKworICAgICAgICBDbGVhbiB1 cCBsaXN0IGl0ZXJhdGlvbiBpbiBNZWRpYVF1ZXJ5RXhwIGNvbnN0cnVjdG9yIChhdm9pZCB1bm5l Y2Vzc2FyeSBjYWxscyB0byBjdXJyZW50KCkpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODQzNjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgLyBjb2RlIGNsZWFudXAgb25seS4KKwor ICAgICAgICAqIGNzcy9NZWRpYVF1ZXJ5RXhwLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlh UXVlcnlFeHA6Ok1lZGlhUXVlcnlFeHApOgorCiAyMDEyLTA0LTE5ICB2c2V2aWtAY2hyb21pdW0u b3JnICA8dnNldmlrQGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBObyBy ZXNwb25zZSBib2R5IGF2YWlsYWJsZSBmb3IgY2FjaGVkIHJlc291cmNlIHJlcXVlc3RzIHdpdGgg ZXJyb3Igc3RhdHVzIGNvZGVzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL01lZGlh UXVlcnlFeHAuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL01lZGlhUXVlcnlFeHAuY3BwCmluZGV4 IDFmNTMyMjE4MzIwNThhMTQ2ZjQwODRjMjJiNDY1ODg1NTQxYjZmZGMuLjc3MGQ4ODI3MzZlNzI1 ZDhhOTYwYWI4NjU0NmU3MjJkM2ZiNmUxMGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nz cy9NZWRpYVF1ZXJ5RXhwLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvTWVkaWFRdWVyeUV4 cC5jcHAKQEAgLTU5LDEwICs1OSwxMCBAQCBpbmxpbmUgTWVkaWFRdWVyeUV4cDo6TWVkaWFRdWVy eUV4cChjb25zdCBBdG9taWNTdHJpbmcmIG1lZGlhRmVhdHVyZSwgQ1NTUGFyc2VyVgogICAgICAg ICAgICAgLy8gY3VycmVudGx5IGFjY2VwdHMgb25seSA8aW50ZWdlcj4vPGludGVnZXI+CiAKICAg ICAgICAgICAgIFJlZlB0cjxDU1NWYWx1ZUxpc3Q+IGxpc3QgPSBDU1NWYWx1ZUxpc3Q6OmNyZWF0 ZUNvbW1hU2VwYXJhdGVkKCk7Ci0gICAgICAgICAgICBDU1NQYXJzZXJWYWx1ZSogdmFsdWUgPSAw OworICAgICAgICAgICAgQ1NTUGFyc2VyVmFsdWUqIHZhbHVlID0gdmFsdWVMaXN0LT5jdXJyZW50 KCk7CiAgICAgICAgICAgICBib29sIGlzVmFsaWQgPSB0cnVlOwogCi0gICAgICAgICAgICB3aGls ZSAoKHZhbHVlID0gdmFsdWVMaXN0LT5jdXJyZW50KCkpICYmIGlzVmFsaWQpIHsKKyAgICAgICAg ICAgIHdoaWxlICh2YWx1ZSAmJiBpc1ZhbGlkKSB7CiAgICAgICAgICAgICAgICAgaWYgKHZhbHVl LT51bml0ID09IENTU1BhcnNlclZhbHVlOjpPcGVyYXRvciAmJiB2YWx1ZS0+aVZhbHVlID09ICcv JykKICAgICAgICAgICAgICAgICAgICAgbGlzdC0+YXBwZW5kKENTU1ByaW1pdGl2ZVZhbHVlOjpj cmVhdGUoIi8iLCBDU1NQcmltaXRpdmVWYWx1ZTo6Q1NTX1NUUklORykpOwogICAgICAgICAgICAg ICAgIGVsc2UgaWYgKHZhbHVlLT51bml0ID09IENTU1ByaW1pdGl2ZVZhbHVlOjpDU1NfTlVNQkVS KQo=