84358 2012-04-19 11:06:46 -0700 Web Inspector: exception when hovering object while paused 2012-04-19 11:18:26 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 yurys yurys apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 605695 0 yurys 2012-04-19 11:06:46 -0700 "Protocol Error: Invalid type of argument 'returnByValue' for method 'Debugger.evaluateOnCallFrame' call. It must be 'boolean' but it is 'function'.", source: chrome-devtools://devtools/InspectorBackend.js (113) 605702 1 137924 yurys 2012-04-19 11:09:54 -0700 Created attachment 137924 Patch 605707 2 137924 vsevik 2012-04-19 11:11:39 -0700 Comment on attachment 137924 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=137924&action=review > Source/WebCore/inspector/front-end/JavaScriptSourceFrame.js:283 > + selectedCallFrame.evaluate(this._highlightElement.textContent, objectGroupName, false, false, false, showObjectPopover.bind(this)); It should be true. 605710 3 yurys 2012-04-19 11:13:05 -0700 (In reply to comment #2) > (From update of attachment 137924 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=137924&action=review > > > Source/WebCore/inspector/front-end/JavaScriptSourceFrame.js:283 > > + selectedCallFrame.evaluate(this._highlightElement.textContent, objectGroupName, false, false, false, showObjectPopover.bind(this)); > > It should be true. Done. 605720 4 yurys 2012-04-19 11:18:26 -0700 Committed r114654: <http://trac.webkit.org/changeset/114654> 137924 2012-04-19 11:09:54 -0700 2012-04-19 11:11:38 -0700 Patch bug-84358-20120419220952.patch text/plain 4563 yurys U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0NjUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGUwNTI0MTFkMjQ1NDQ0 ZWVjOTViZjYyYzJlMzliMzAwMWMyNTRjZS4uY2M2OTc1NmE4YWMwYzIyODBhZDM1OTIyNWZhODNm NjNhMzJhZjFlNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA0LTE5ICBZdXJ5 IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IGV4Y2VwdGlvbiB3aGVuIGhvdmVyaW5nIG9iamVjdCB3aGlsZSBwYXVzZWQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg0MzU4CisKKyAgICAgICAg QWRkZWQgbWlzc2luZyBib29sZWFuIHBhcmFtZXRlciB0byB0aGUgY2FsbCBzaXRlIG9mIGV2YWx1 YXRlIG1ldGhvZAorICAgICAgICBvbiBjYWxsIGZyYW1lLgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9BZHZhbmNl ZFNlYXJjaENvbnRyb2xsZXIuanM6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9EZWJ1 Z2dlclByZXNlbnRhdGlvbk1vZGVsLmpzOiBhbm5vdGF0ZWQgc2xlY3RlZENhbGxGcmFtZQorICAg ICAgICBtZXRob2Qgc28gdGhhdCBjbG9zdXJlIGNvbXBpbGVyIGNhdGNoZXMgZXJyb3JzIGxpa2Ug aW4gdGhlIGJ1ZyByZXBvcnQuCisgICAgICAgIChXZWJJbnNwZWN0b3IuRGVidWdnZXJQcmVzZW50 YXRpb25Nb2RlbC5wcm90b3R5cGUuZXZhbHVhdGVJblNlbGVjdGVkQ2FsbEZyYW1lKToKKyAgICAg ICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0phdmFTY3JpcHRTb3VyY2VGcmFtZS5qczoKKyAgICAg ICAgKFdlYkluc3BlY3Rvci5KYXZhU2NyaXB0U291cmNlRnJhbWUucHJvdG90eXBlLl9yZXNvbHZl T2JqZWN0Rm9yUG9wb3Zlcik6CisKIDIwMTItMDQtMTkgIFNhbWkgS3lvc3RpbGEgIDxza3lvc3Rp bEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBBbGxvdyBzY3JvbGxpbmcgbm9u LXJvb3QgbGF5ZXJzIGluIHRoZSBjb21wb3NpdG9yIHRocmVhZApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9BZHZhbmNlZFNlYXJjaENvbnRyb2xsZXIuanMg Yi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0FkdmFuY2VkU2VhcmNoQ29udHJv bGxlci5qcwppbmRleCBkODQ2NDEzY2U5MzYzNTBhZDg4MDc1NGZlOGRhZDFjNTBlZTdjMThjLi5k OTcwOTQzOWQzYzU1NWFlMTk5OGJlMzkwYjJkMjJmNzllZWRhYzdjIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0FkdmFuY2VkU2VhcmNoQ29udHJvbGxlci5q cworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0FkdmFuY2VkU2VhcmNo Q29udHJvbGxlci5qcwpAQCAtNDUwLDcgKzQ1MCw3IEBAIFdlYkluc3BlY3Rvci5TZWFyY2hTY29w ZS5wcm90b3R5cGUgPSB7CiAgICAgCiAgICAgLyoqCiAgICAgICogQHBhcmFtIHtXZWJJbnNwZWN0 b3IuU2VhcmNoQ29uZmlnfSBzZWFyY2hDb25maWcKLSAgICAgKiBAcmV0dXJuIFdlYkluc3BlY3Rv ci5TZWFyY2hSZXN1bHRzUGFuZX0KKyAgICAgKiBAcmV0dXJuIHtXZWJJbnNwZWN0b3IuU2VhcmNo UmVzdWx0c1BhbmV9CiAgICAgICovCiAgICAgY3JlYXRlU2VhcmNoUmVzdWx0c1BhbmU6IGZ1bmN0 aW9uKHNlYXJjaENvbmZpZykgeyB9CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL0RlYnVnZ2VyUHJlc2VudGF0aW9uTW9kZWwuanMgYi9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0RlYnVnZ2VyUHJlc2VudGF0aW9uTW9kZWwuanMKaW5k ZXggZTlhYWIxNTZmYjE4ODFjNzc0Yjc4MjQ0MDYzYmUyZmIxMjg4YTRmYS4uZmRjN2VlY2Y2OWIz ZjE4NjhjMzVjNTk0MWVlZTVmMGExMmE1MDhjOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv aW5zcGVjdG9yL2Zyb250LWVuZC9EZWJ1Z2dlclByZXNlbnRhdGlvbk1vZGVsLmpzCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRGVidWdnZXJQcmVzZW50YXRpb25Nb2Rl bC5qcwpAQCAtNDUzLDYgKzQ1Myw5IEBAIFdlYkluc3BlY3Rvci5EZWJ1Z2dlclByZXNlbnRhdGlv bk1vZGVsLnByb3RvdHlwZSA9IHsKICAgICAgICAgdGhpcy5fZXhlY3V0aW9uTGluZUxpdmVMb2Nh dGlvbi5pbml0KCk7CiAgICAgfSwKIAorICAgIC8qKgorICAgICAqIEByZXR1cm4gez9XZWJJbnNw ZWN0b3IuUHJlc2VudGF0aW9uQ2FsbEZyYW1lfQorICAgICAqLwogICAgIGdldCBzZWxlY3RlZENh bGxGcmFtZSgpCiAgICAgewogICAgICAgICByZXR1cm4gdGhpcy5fc2VsZWN0ZWRDYWxsRnJhbWU7 CkBAIC00NzAsMTQgKzQ3MywxNCBAQCBXZWJJbnNwZWN0b3IuRGVidWdnZXJQcmVzZW50YXRpb25N b2RlbC5wcm90b3R5cGUgPSB7CiAgICAgewogICAgICAgICAvKioKICAgICAgICAgICogQHBhcmFt IHs/UnVudGltZUFnZW50LlJlbW90ZU9iamVjdH0gcmVzdWx0Ci0gICAgICAgICAqIEBwYXJhbSB7 Ym9vbGVhbn0gd2FzVGhyb3duCisgICAgICAgICAqIEBwYXJhbSB7Ym9vbGVhbj19IHdhc1Rocm93 bgogICAgICAgICAgKi8KICAgICAgICAgZnVuY3Rpb24gZGlkRXZhbHVhdGUocmVzdWx0LCB3YXNU aHJvd24pCiAgICAgICAgIHsKICAgICAgICAgICAgIGlmIChyZXR1cm5CeVZhbHVlKQotICAgICAg ICAgICAgICAgIGNhbGxiYWNrKG51bGwsIHdhc1Rocm93biwgd2FzVGhyb3duID8gbnVsbCA6IHJl c3VsdCk7CisgICAgICAgICAgICAgICAgY2FsbGJhY2sobnVsbCwgISF3YXNUaHJvd24sIHdhc1Ro cm93biA/IG51bGwgOiByZXN1bHQpOwogICAgICAgICAgICAgZWxzZQotICAgICAgICAgICAgICAg IGNhbGxiYWNrKFdlYkluc3BlY3Rvci5SZW1vdGVPYmplY3QuZnJvbVBheWxvYWQocmVzdWx0KSwg d2FzVGhyb3duKTsKKyAgICAgICAgICAgICAgICBjYWxsYmFjayhXZWJJbnNwZWN0b3IuUmVtb3Rl T2JqZWN0LmZyb21QYXlsb2FkKHJlc3VsdCksICEhd2FzVGhyb3duKTsKIAogICAgICAgICAgICAg aWYgKG9iamVjdEdyb3VwID09PSAiY29uc29sZSIpCiAgICAgICAgICAgICAgICAgdGhpcy5kaXNw YXRjaEV2ZW50VG9MaXN0ZW5lcnMoV2ViSW5zcGVjdG9yLkRlYnVnZ2VyUHJlc2VudGF0aW9uTW9k ZWwuRXZlbnRzLkNvbnNvbGVDb21tYW5kRXZhbHVhdGVkSW5TZWxlY3RlZENhbGxGcmFtZSk7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0phdmFTY3JpcHRT b3VyY2VGcmFtZS5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSmF2YVNj cmlwdFNvdXJjZUZyYW1lLmpzCmluZGV4IDI5ZGM2NzI4ZTZiMmFjMmFjNDg2NTIzYjBiZDI3NjRi ZWVlYmRjYmIuLjA5M2Q1ZWQ4YWE5NDIzMGJkYWExMzY0NzMwODdhN2ZkM2M3Y2YzMjQgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSmF2YVNjcmlwdFNvdXJj ZUZyYW1lLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSmF2YVNj cmlwdFNvdXJjZUZyYW1lLmpzCkBAIC0yNjMsNiArMjYzLDEwIEBAIFdlYkluc3BlY3Rvci5KYXZh U2NyaXB0U291cmNlRnJhbWUucHJvdG90eXBlID0gewogICAgIHsKICAgICAgICAgdGhpcy5faGln aGxpZ2h0RWxlbWVudCA9IHRoaXMuX2hpZ2hsaWdodEV4cHJlc3Npb24oZWxlbWVudCk7CiAKKyAg ICAgICAgLyoqCisgICAgICAgICAqIEBwYXJhbSB7P1J1bnRpbWVBZ2VudC5SZW1vdGVPYmplY3R9 IHJlc3VsdAorICAgICAgICAgKiBAcGFyYW0ge2Jvb2xlYW49fSB3YXNUaHJvd24KKyAgICAgICAg ICovCiAgICAgICAgIGZ1bmN0aW9uIHNob3dPYmplY3RQb3BvdmVyKHJlc3VsdCwgd2FzVGhyb3du KQogICAgICAgICB7CiAgICAgICAgICAgICBpZiAoIXRoaXMuX21vZGVsLnBhdXNlZCkgewpAQCAt Mjc2LDcgKzI4MCw3IEBAIFdlYkluc3BlY3Rvci5KYXZhU2NyaXB0U291cmNlRnJhbWUucHJvdG90 eXBlID0gewogICAgICAgICB9CiAKICAgICAgICAgdmFyIHNlbGVjdGVkQ2FsbEZyYW1lID0gdGhp cy5fbW9kZWwuc2VsZWN0ZWRDYWxsRnJhbWU7Ci0gICAgICAgIHNlbGVjdGVkQ2FsbEZyYW1lLmV2 YWx1YXRlKHRoaXMuX2hpZ2hsaWdodEVsZW1lbnQudGV4dENvbnRlbnQsIG9iamVjdEdyb3VwTmFt ZSwgZmFsc2UsIGZhbHNlLCBzaG93T2JqZWN0UG9wb3Zlci5iaW5kKHRoaXMpKTsKKyAgICAgICAg c2VsZWN0ZWRDYWxsRnJhbWUuZXZhbHVhdGUodGhpcy5faGlnaGxpZ2h0RWxlbWVudC50ZXh0Q29u dGVudCwgb2JqZWN0R3JvdXBOYW1lLCBmYWxzZSwgZmFsc2UsIGZhbHNlLCBzaG93T2JqZWN0UG9w b3Zlci5iaW5kKHRoaXMpKTsKICAgICB9LAogCiAgICAgX29uSGlkZVBvcG92ZXI6IGZ1bmN0aW9u KCkK